From patchwork Sun Jul 28 23:11:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Matteo Croce X-Patchwork-Id: 11063091 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 891BF112C for ; Sun, 28 Jul 2019 23:11:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7754128710 for ; Sun, 28 Jul 2019 23:11:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6A00428718; Sun, 28 Jul 2019 23:11:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1215B28710 for ; Sun, 28 Jul 2019 23:11:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=OoveTOCeZZ73I3CioyJgOZMeC2iRUxixj2bjgr+Dv8o=; b=mj3ATfR7uXuf7k +tkOjrQdKN+NOLb356+7Qm7r2ODKTLHXvyP6L2qfXg21LT9BKoOgNyQ0dhjIRIshoy0oTaNCPZXBt DgToOiLQqDxpiCnK874UAhwFHc4owTx42/GPESdGDTiwvsuJDja0gmiaZn7NZFSlyclUQoOLX8j8B Sn/8exKN40Mw8xb0EdCrU/R0HyG4TGYJyySMqVPC0gRWbxXpITX//Myexgs7QUMcg0x/ngm0Y/i0Y pXwPwZWUS54X+TZVdLJUXijRdU6t5NiAzQS82DBllMBOW212fruXOGIUaOuwb+deylbw6tUv2Ysct I3yi1gzKCGJf7AYQQZ0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hrsKL-00063R-VJ; Sun, 28 Jul 2019 23:11:41 +0000 Received: from mail-wm1-f67.google.com ([209.85.128.67]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hrsKI-00062m-F5 for linux-arm-kernel@lists.infradead.org; Sun, 28 Jul 2019 23:11:39 +0000 Received: by mail-wm1-f67.google.com with SMTP id h19so41757426wme.0 for ; Sun, 28 Jul 2019 16:11:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=42lghrV63bcshzCGKSHua5vo/hvXi8DHZoy6o0Cat9Y=; b=YWkZMQnmheNgJxsqq/fTv3zORc6SBI+BjokqmZWVh29SktIDWRlnFKT0DgBcxyeLqM 8IS6wvCkSUdS1o5gUjt8NJyta01QPaPdV47FNZ3BBtgyfEv8a2OnKDhmAYFFW8EKlqXr 6t0JSH2nssQLuypUOqCCUFC+4VUrxMHOG1+1+ZbiEkyz3ok6d6YevpQ33fEsC257fIsm 9AdmHpqH8TOdPJqM6m2o0Mb3p7XLJcj6lNPDJ4578+/GtEVqCHeS3G8x4csIciMw0moo 7NjWe90LXJMb2aK3xFB2Wlg9w9D7EqEwTIbXI1LvsyhUhGSrcbzIzDFNK+1YFvIgFEZ6 LUIQ== X-Gm-Message-State: APjAAAX41usAfVKt2GHMeR3aZW4Wmc564MzkBpADzMXVgpq89GuroU3b cNzi4vpSja6WxALjWDGDSD3v+hAnO+M= X-Google-Smtp-Source: APXvYqxPo7htNk7ZRI5iDnM8YMA9X9gv9/VMPzCI4aNrd3OhZP9OppJEggWVfYxwOlqvknmBwBcY6A== X-Received: by 2002:a1c:d10c:: with SMTP id i12mr96083615wmg.152.1564355496144; Sun, 28 Jul 2019 16:11:36 -0700 (PDT) Received: from mcroce-redhat.homenet.telecomitalia.it (host221-208-dynamic.27-79-r.retail.telecomitalia.it. [79.27.208.221]) by smtp.gmail.com with ESMTPSA id 4sm137778934wro.78.2019.07.28.16.11.34 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 28 Jul 2019 16:11:35 -0700 (PDT) From: Matteo Croce To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] arm64: module: mark expected switch fall-through Date: Mon, 29 Jul 2019 01:11:32 +0200 Message-Id: <20190728231132.6367-1-mcroce@redhat.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190728_161138_526433_8EC0A21D X-CRM114-Status: UNSURE ( 7.64 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, Ard Biesheuvel Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Mark switch cases where we are expecting to fall through, fixes the following warning: arch/arm64/kernel/module.c: In function ‘apply_relocate_add’: arch/arm64/kernel/module.c:316:19: warning: this statement may fall through [-Wimplicit-fallthrough=] overflow_check = false; ~~~~~~~~~~~~~~~^~~~~~~ arch/arm64/kernel/module.c:317:3: note: here case R_AARCH64_MOVW_UABS_G0: ^~~~ arch/arm64/kernel/module.c:322:19: warning: this statement may fall through [-Wimplicit-fallthrough=] overflow_check = false; ~~~~~~~~~~~~~~~^~~~~~~ arch/arm64/kernel/module.c:323:3: note: here case R_AARCH64_MOVW_UABS_G1: ^~~~ arch/arm64/kernel/module.c:328:19: warning: this statement may fall through [-Wimplicit-fallthrough=] overflow_check = false; ~~~~~~~~~~~~~~~^~~~~~~ arch/arm64/kernel/module.c:329:3: note: here case R_AARCH64_MOVW_UABS_G2: ^~~~ arch/arm64/kernel/module.c:395:19: warning: this statement may fall through [-Wimplicit-fallthrough=] overflow_check = false; ~~~~~~~~~~~~~~~^~~~~~~ arch/arm64/kernel/module.c:396:3: note: here case R_AARCH64_ADR_PREL_PG_HI21: ^~~~ Signed-off-by: Matteo Croce --- arch/arm64/kernel/module.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c index 46e643e30708..ffd76b291af2 100644 --- a/arch/arm64/kernel/module.c +++ b/arch/arm64/kernel/module.c @@ -314,18 +314,21 @@ int apply_relocate_add(Elf64_Shdr *sechdrs, /* MOVW instruction relocations. */ case R_AARCH64_MOVW_UABS_G0_NC: overflow_check = false; + /* fallthrough */ case R_AARCH64_MOVW_UABS_G0: ovf = reloc_insn_movw(RELOC_OP_ABS, loc, val, 0, AARCH64_INSN_IMM_MOVKZ); break; case R_AARCH64_MOVW_UABS_G1_NC: overflow_check = false; + /* fallthrough */ case R_AARCH64_MOVW_UABS_G1: ovf = reloc_insn_movw(RELOC_OP_ABS, loc, val, 16, AARCH64_INSN_IMM_MOVKZ); break; case R_AARCH64_MOVW_UABS_G2_NC: overflow_check = false; + /* fallthrough */ case R_AARCH64_MOVW_UABS_G2: ovf = reloc_insn_movw(RELOC_OP_ABS, loc, val, 32, AARCH64_INSN_IMM_MOVKZ); @@ -393,6 +396,7 @@ int apply_relocate_add(Elf64_Shdr *sechdrs, break; case R_AARCH64_ADR_PREL_PG_HI21_NC: overflow_check = false; + /* fallthrough */ case R_AARCH64_ADR_PREL_PG_HI21: ovf = reloc_insn_adrp(me, sechdrs, loc, val); if (ovf && ovf != -ERANGE)