From patchwork Mon Jul 29 16:00:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 11064147 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6F66913AC for ; Mon, 29 Jul 2019 16:00:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5D4A828334 for ; Mon, 29 Jul 2019 16:00:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4DD6E285C3; Mon, 29 Jul 2019 16:00:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CD05828334 for ; Mon, 29 Jul 2019 16:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Dv3pB5oNDEZXMck6zfr4r+vL2xRfReWEfQMx5Wvrqjo=; b=QctG/tvc5aOzu1 4CX1fKETpBf+MVqKym2V9qW6IP/G/mfDs7id4cuCEJ5RQ/oRuTzYH7UDJXt4+kPuPGz23X7CAB5Ui 8mk4MPIMegXJG+LrsvAPMZbcXtu0sjgJenIwKC1L6O8bN4QEmXqON99Ac5j9xlIlBi9GWKkFs5WJw DHy5gRF1WxL/E+1R7Xr2W60Fd4kvdwFuyZwuVqdUTGN8/60FycrAzDCrhWwFUd9Sn9EtKoot104PI GUIPdUYBI3xvg5lAKbYhH23J52LjBHiJ49hsn6yYahrF5wk/gv5WgQuogSMCpXQVX6FuVXFa/VorJ G8PcWm5D/sKvF28ml+kQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hs84g-0003Bg-EH; Mon, 29 Jul 2019 16:00:34 +0000 Received: from antares.kleine-koenig.org ([2a01:4f8:c0c:3a97::2]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hs84c-000310-Se for linux-arm-kernel@lists.infradead.org; Mon, 29 Jul 2019 16:00:32 +0000 Received: by antares.kleine-koenig.org (Postfix, from userid 1000) id BED88743106; Mon, 29 Jul 2019 18:00:28 +0200 (CEST) From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Nicolas Ferre , Alexandre Belloni , Ludovic Desroches Subject: [PATCH] ARM: at91sam9x5/dt: enable internal pull-up for i2c-gpio lines Date: Mon, 29 Jul 2019 18:00:22 +0200 Message-Id: <20190729160022.22781-1-uwe@kleine-koenig.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190729_090031_085004_1BB3A1E9 X-CRM114-Status: UNSURE ( 9.44 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This is what I need on my Arietta G25 to be able to just connect an i2c device to the pin headers. Also remove the comment that doesn't tell more than the pin declaration. Signed-off-by: Uwe Kleine-König --- Hello, not sure this is change suitable for the SoC dtsi. I'll leave it to the at91 maintainers to decide. Best regards Uwe arch/arm/boot/dts/at91sam9x5.dtsi | 12 ++++++------ include/dt-bindings/pinctrl/at91.h | 2 ++ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi index ef47c005ef03..5fc38626795e 100644 --- a/arch/arm/boot/dts/at91sam9x5.dtsi +++ b/arch/arm/boot/dts/at91sam9x5.dtsi @@ -437,24 +437,24 @@ i2c_gpio0 { pinctrl_i2c_gpio0: i2c_gpio0-0 { atmel,pins = - ; /* PA31 gpio multidrive I2C0 clock */ + ; }; }; i2c_gpio1 { pinctrl_i2c_gpio1: i2c_gpio1-0 { atmel,pins = - ; /* PC1 gpio multidrive I2C1 clock */ + ; }; }; i2c_gpio2 { pinctrl_i2c_gpio2: i2c_gpio2-0 { atmel,pins = - ; /* PB5 gpio multidrive I2C2 clock */ + ; }; }; diff --git a/include/dt-bindings/pinctrl/at91.h b/include/dt-bindings/pinctrl/at91.h index 3831f91fb3ba..c72d40f50acd 100644 --- a/include/dt-bindings/pinctrl/at91.h +++ b/include/dt-bindings/pinctrl/at91.h @@ -20,6 +20,8 @@ #define AT91_PINCTRL_DEBOUNCE (1 << 16) #define AT91_PINCTRL_DEBOUNCE_VAL(x) (x << 17) +#define AT91_PINCTRL_MULTI_DRIVE_PU (AT91_PINCTRL_MULTI_DRIVE | AT91_PINCTRL_PULL_UP) + #define AT91_PINCTRL_PULL_UP_DEGLITCH (AT91_PINCTRL_PULL_UP | AT91_PINCTRL_DEGLITCH) #define AT91_PINCTRL_DRIVE_STRENGTH_DEFAULT (0x0 << 5)