From patchwork Thu Aug 1 01:00:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Borowski X-Patchwork-Id: 11069857 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 96595912 for ; Thu, 1 Aug 2019 01:01:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8822922B26 for ; Thu, 1 Aug 2019 01:01:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 79363208C2; Thu, 1 Aug 2019 01:01:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BB83A208C2 for ; Thu, 1 Aug 2019 01:01:01 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id E8454212FD41E; Wed, 31 Jul 2019 18:03:31 -0700 (PDT) X-Original-To: linux-nvdimm@lists.01.org Delivered-To: linux-nvdimm@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2001:41d0:602:dbe::8; helo=tartarus.angband.pl; envelope-from=kilobyte@angband.pl; receiver=linux-nvdimm@lists.01.org Received: from tartarus.angband.pl (tartarus.angband.pl [IPv6:2001:41d0:602:dbe::8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2E769212FD41A for ; Wed, 31 Jul 2019 18:03:29 -0700 (PDT) Received: from [2a02:a31c:853f:a300::4] (helo=valinor.angband.pl) by tartarus.angband.pl with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hszSf-0002Pq-Bg; Thu, 01 Aug 2019 03:00:55 +0200 Received: from kilobyte by valinor.angband.pl with local (Exim 4.92) (envelope-from ) id 1hszSf-000Eou-4W; Thu, 01 Aug 2019 03:00:53 +0200 From: Adam Borowski To: linux-nvdimm@lists.01.org Date: Thu, 1 Aug 2019 03:00:44 +0200 Message-Id: <20190801010044.56927-1-kilobyte@angband.pl> X-Mailer: git-send-email 2.23.0.rc0 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a02:a31c:853f:a300::4 X-SA-Exim-Mail-From: kilobyte@angband.pl Subject: [PATCH] daxctl: link against libndctl, in case its use doesn't get pruned X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on tartarus.angband.pl) X-BeenThere: linux-nvdimm@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Linux-nvdimm developer list." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Adam Borowski Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" X-Virus-Scanned: ClamAV using ClamSMTP util/json.c uses libndctl symbols, and is included by daxctl. These functions should then get pruned as unused, but on some platforms the toolchain fails to do so. These platforms are ia64, hppa and 32-bit powerpc. It's generally a waste of our time to build ndctl there, but as the lack of a build-dependency requires annoying workarounds higher in the stack, this has been requested in https://bugs.debian.org/914348 -- and is trivially fixable on the ndctl side. Thanks to -Wl,--as-needed there's no harm to architectures where the pruning works, thus let's not bother with detection. As daxctl and libdaxctl are separate, there's no circular dependency. Signed-off-by: Adam Borowski --- daxctl/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/daxctl/Makefile.am b/daxctl/Makefile.am index 94f73f9..a5487d6 100644 --- a/daxctl/Makefile.am +++ b/daxctl/Makefile.am @@ -21,4 +21,5 @@ daxctl_LDADD =\ lib/libdaxctl.la \ ../libutil.a \ $(UUID_LIBS) \ - $(JSON_LIBS) + $(JSON_LIBS) \ + ../ndctl/lib/libndctl.la