From patchwork Mon Aug 5 22:27:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Gruenbacher X-Patchwork-Id: 11077829 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0717113B1 for ; Mon, 5 Aug 2019 22:27:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EA04A22B39 for ; Mon, 5 Aug 2019 22:27:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DD4052897E; Mon, 5 Aug 2019 22:27:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9251722B39 for ; Mon, 5 Aug 2019 22:27:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729999AbfHEW1m (ORCPT ); Mon, 5 Aug 2019 18:27:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55826 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728483AbfHEW1m (ORCPT ); Mon, 5 Aug 2019 18:27:42 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 033D230655F5 for ; Mon, 5 Aug 2019 22:27:42 +0000 (UTC) Received: from max.com (unknown [10.40.205.105]) by smtp.corp.redhat.com (Postfix) with ESMTP id 393A860603; Mon, 5 Aug 2019 22:27:41 +0000 (UTC) From: Andreas Gruenbacher To: fstests@vger.kernel.org Cc: Andreas Gruenbacher Subject: [PATCH] generic/322: remove bad xfs_io sync_range Date: Tue, 6 Aug 2019 00:27:38 +0200 Message-Id: <20190805222738.21422-1-agruenba@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Mon, 05 Aug 2019 22:27:42 +0000 (UTC) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The xfs_io sync_range command requires offset and length arguments. Those are missing here, so the command fails with: bad argument count 1 to sync_range, expected at least 2 arguments This went unnoticed because xfs_io still exits with status 0 in such cases, which looks like a separate bug. I'm assuming that the test did catch regressions as is and that the sync_range command isn't needed. If this isn't the case, please fix the test. Signed-off-by: Andreas Gruenbacher --- tests/generic/322 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/generic/322 b/tests/generic/322 index 2afd7127..22797c04 100755 --- a/tests/generic/322 +++ b/tests/generic/322 @@ -65,7 +65,7 @@ _write_after_fsync_rename_test() echo "fsync rename test" _mount_flakey $XFS_IO_PROG -f -c "pwrite 0 1M" -c "fsync" -c "pwrite 2M 1M" \ - -c "sync_range -b" $SCRATCH_MNT/foo > $seqres.full 2>&1 || _fail "xfs_io failed" + $SCRATCH_MNT/foo > $seqres.full 2>&1 || _fail "xfs_io failed" mv $SCRATCH_MNT/foo $SCRATCH_MNT/bar $XFS_IO_PROG -c "fsync" $SCRATCH_MNT/bar md5sum $SCRATCH_MNT/bar | _filter_scratch