From patchwork Fri Aug 9 08:06:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 11085625 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0B6C06C5 for ; Fri, 9 Aug 2019 08:06:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F272928C42 for ; Fri, 9 Aug 2019 08:06:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E657D28C37; Fri, 9 Aug 2019 08:06:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6768428C37 for ; Fri, 9 Aug 2019 08:06:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405612AbfHIIGp (ORCPT ); Fri, 9 Aug 2019 04:06:45 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:53870 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405567AbfHIIGp (ORCPT ); Fri, 9 Aug 2019 04:06:45 -0400 Received: by mail-wm1-f66.google.com with SMTP id 10so4761706wmp.3 for ; Fri, 09 Aug 2019 01:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OcRJCWNzuK8DiQkEdzF/yO/qc30Q7ZChtZ7mfMlw4Zw=; b=lpj0+HKvT5JnYHKAkLXs1jxeoYXm9mLNyrMk0wINffBuRw2GqGPxsdqWIJx7TlOpu6 ELMpEeJBRYQcugF3tntbbD06vvzktR03jn8hU/iQ96HdvpgC4G6TPJETZ6sfKk1dlf69 k5/g0hriCXqqjXR+WFGkWTZYsOcYYV/GgvVyMbpFp2SAM/cw5/JWVc2ox5SahVhYPppc 5LA8b07wx3iIYFOmwah5kc7PTZqg9GXMWIPmTxWkGFljD9GO+ltDmeXNEmCpif2XOxU0 S/BX53C5btt0+G2b1fb/CHL6N/dFgd9Q1ktBP2eL1FNV2hwPY4tHUiGA9qR7MjT6J1/G M8kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OcRJCWNzuK8DiQkEdzF/yO/qc30Q7ZChtZ7mfMlw4Zw=; b=ChUdZ76CLE5hysoNJPIgNmlvDrseEeN035babBU+kzedDtWA3HAJYHYUU0Z3sA4ECz 6jn4d5qYCdqbbq5fgqvWAwuhy1UZcSAcNQ7w8Z+TO2D0raC0qcM3p66Pw2XJ0QnHEKlK 0OvCLunD4bXvfuLbX8uH821iD0H4+gexd2JtPhHaQgrO24J2f2j9/416Lm73ZN01rowF rSgN0CbnL7wu1qOG3xanQby7xPMEdrKowKaPaQu+iwWkV2SHpFmP31ic3jRvGAzrKkRc Yfst7hu3+jcE2PZIpeZ9fhrx7D/srwNF7cR7NTGnhGUWSlVfxon2Osp/YPxB+4XmzHoW d+jg== X-Gm-Message-State: APjAAAWQzImi5bXd0wJYCMH7gvq11WIJF2fUb89wiHtqkxMNHvYZ1i4i mlH1+L89f44MNaCyYXRMTe0= X-Google-Smtp-Source: APXvYqwKtwZeMbdaNsi43qZXLsW4/w4263xZJVF7VRMU5HMLDRccqdb3DYG6yNaDw2+vGS4qff0MTg== X-Received: by 2002:a05:600c:2549:: with SMTP id e9mr9343959wma.46.1565338003045; Fri, 09 Aug 2019 01:06:43 -0700 (PDT) Received: from mamba.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id q124sm6964302wma.33.2019.08.09.01.06.42 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 09 Aug 2019 01:06:42 -0700 (PDT) From: "Yordan Karadzhov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, mike.auty@gmail.com, "Yordan Karadzhov (VMware)" Subject: [PATCH 1/3] kernel-shark: Show warning message when running as Root Date: Fri, 9 Aug 2019 11:06:21 +0300 Message-Id: <20190809080623.7548-2-y.karadz@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190809080623.7548-1-y.karadz@gmail.com> References: <20190809080623.7548-1-y.karadz@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Running the KernelShark GUI with Root privileges is not recommended due to security reasons. The user will be allowed to continue on its own risk. Suggested-by: Steven Rostedt (VMware) Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204475 Signed-off-by: Yordan Karadzhov (VMware) --- kernel-shark/src/KsMainWindow.cpp | 28 ++++++++++++++++++++++++++++ kernel-shark/src/KsMainWindow.hpp | 2 ++ 2 files changed, 30 insertions(+) diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp index 6439265..2560bf8 100644 --- a/kernel-shark/src/KsMainWindow.cpp +++ b/kernel-shark/src/KsMainWindow.cpp @@ -76,6 +76,9 @@ KsMainWindow::KsMainWindow(QWidget *parent) _createMenus(); _initCapture(); + if (geteuid() == 0) + _rootWarning(); + _splitter.addWidget(&_graph); _splitter.addWidget(&_view); setCentralWidget(&_splitter); @@ -1271,3 +1274,28 @@ void KsMainWindow::_deselectB() _mState.updateLabels(); _graph.glPtr()->model()->update(); } + +void KsMainWindow::_rootWarning() +{ + QString cbFlag("noRootWorn"); + + if (_settings.value(cbFlag).toBool()) + return; + + QMessageBox warn; + warn.setText("KernelShark will have Root privileges."); + warn.setInformativeText("Continue on your one risk."); + warn.setIcon(QMessageBox::Warning); + warn.setStandardButtons(QMessageBox::Close); + + QCheckBox cb("Don't show this message again."); + + auto lamCbChec = [&] (int state) { + if (state) + _settings.setValue(cbFlag, true); + }; + + connect(&cb, &QCheckBox::stateChanged, lamCbChec); + warn.setCheckBox(&cb); + warn.exec(); +} diff --git a/kernel-shark/src/KsMainWindow.hpp b/kernel-shark/src/KsMainWindow.hpp index 62e66a0..4a7b8ab 100644 --- a/kernel-shark/src/KsMainWindow.hpp +++ b/kernel-shark/src/KsMainWindow.hpp @@ -238,6 +238,8 @@ private: void _deselectB(); + void _rootWarning(); + void _updateFilterMenu(); void _filterSyncCBoxUpdate(kshark_context *kshark_ctx); From patchwork Fri Aug 9 08:06:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 11085627 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E19C913AC for ; Fri, 9 Aug 2019 08:06:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D5A2F28C37 for ; Fri, 9 Aug 2019 08:06:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C93A028C47; Fri, 9 Aug 2019 08:06:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6E09C28C37 for ; Fri, 9 Aug 2019 08:06:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727063AbfHIIGr (ORCPT ); Fri, 9 Aug 2019 04:06:47 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:38770 "EHLO mail-wr1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405567AbfHIIGr (ORCPT ); Fri, 9 Aug 2019 04:06:47 -0400 Received: by mail-wr1-f42.google.com with SMTP id g17so97367338wrr.5 for ; Fri, 09 Aug 2019 01:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GzZW68YpzSYG7VmGJEFcAcop1rM6UBUGQUSzvNjpV+Y=; b=eNbDFdiXQdayBeVcTNyBgVF0NDzhoqQP03nqMmXScf/C3LTX1J55zXnLCeHnYm3DGv eUdlA0ueZB47BYi05n9y5SmkLEIrEW0tGksMtC4oeujpo9LuijpNCXUVLBygViMBojPa MItfXDN6OEEk5SwzrZ9GLJ7BQXV7cfAHnNqdPVehU65a/Mzg98EmUIRYdPbEWeT8wsSd /EvQ0BdA6Wx/Gi80UGBOn9COVhpcBd8e3lXj86Ta0FSRQvsdXbUFMgtAMe71XBfJwzuC E5WfpAX2wjnqd/Fts1erLQXoCpjCowIM8DPUGM0O6A61H1k2RhhNM/6uYZwgYIqpdzjH xU+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GzZW68YpzSYG7VmGJEFcAcop1rM6UBUGQUSzvNjpV+Y=; b=uD0xNNslnOXmhPlkj2NkpaIaQZS7kNzxZmUbrhYI9Exc+TW+ZdNlNxQ4wG5OS+ZoUK OPcoFYzixf+Zk3GuuTfpdbxo8ITOorW0Ip4lZVa2OAnNzP+PLFtHJF9qGuGiB7iJa5WL lTd4S/v8TvZPVXDGBEs7P9ERXfEtbKl5V5kZkhSdzoizSzwD78YX+zyhXo5SB2Iyfq1O k9UO8Bcwxb2xY/mnvzmyBZFJvf9c4HUMwa5NfQ8Go+KB9IC8MuD3589pMpwV1RAUtxZW ZnI+qzySXIUCu3SlMBZEDRQieqw/Z5+noD7xVRUE0B4k0FHOzZtbXPEuc79a2+D3Vax3 zomA== X-Gm-Message-State: APjAAAURTb3Hq/3UJiSmaRrpcKwYjlaOSUAwZeEuYJpqOyNzwgxNA4QB F1tMBgsaP/bqSegtrF2EDhY6C6nbwYA= X-Google-Smtp-Source: APXvYqxcyAJx8zxYy//x7TfX/L2EbmUJc6eaurIKrbv9/oc0Nkq0yWDTP/r5UCQpxtIFeA+3xi6YHA== X-Received: by 2002:adf:f883:: with SMTP id u3mr22113567wrp.0.1565338004908; Fri, 09 Aug 2019 01:06:44 -0700 (PDT) Received: from mamba.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id q124sm6964302wma.33.2019.08.09.01.06.44 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 09 Aug 2019 01:06:44 -0700 (PDT) From: "Yordan Karadzhov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, mike.auty@gmail.com, "Yordan Karadzhov (VMware)" Subject: [PATCH 2/3] kernel-shark: Don't use pkexec when running as Root Date: Fri, 9 Aug 2019 11:06:22 +0300 Message-Id: <20190809080623.7548-3-y.karadz@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190809080623.7548-1-y.karadz@gmail.com> References: <20190809080623.7548-1-y.karadz@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If KernelShark GUI has been started as Root we do not need to use "pkexec" when starting the Record dialog. Note that the actual place where "pkexec" gets used is in the script "kshark-su-record". Signed-off-by: Yordan Karadzhov (VMware) --- kernel-shark/src/KsMainWindow.cpp | 47 +++++++++++++++++++++---------- 1 file changed, 32 insertions(+), 15 deletions(-) diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp index 2560bf8..e9c6d54 100644 --- a/kernel-shark/src/KsMainWindow.cpp +++ b/kernel-shark/src/KsMainWindow.cpp @@ -883,23 +883,26 @@ void KsMainWindow::_pluginAdd() void KsMainWindow::_record() { -#ifndef DO_AS_ROOT + bool canDoAsRoot(false); - QErrorMessage *em = new QErrorMessage(this); - QString message; - - message = "Record is currently not supported."; - message += " Install \"pkexec\" and then do:
"; - message += " cd build
sudo ./cmake_uninstall.sh
"; - message += " ./cmake_clean.sh
cmake ..
make
"; - message += " sudo make install"; +#ifdef DO_AS_ROOT + canDoAsRoot = true; +#endif - em->showMessage(message); - qCritical() << "ERROR: " << message; + if (geteuid() && !canDoAsRoot) { + QErrorMessage *em = new QErrorMessage(this); + QString message; - return; + message = "Record is currently not supported."; + message += " Install \"pkexec\" and then do:
"; + message += " cd build
sudo ./cmake_uninstall.sh
"; + message += " ./cmake_clean.sh
cmake ..
make
"; + message += " sudo make install"; -#endif + em->showMessage(message); + qCritical() << "ERROR: " << message; + return; + } _capture.start(); } @@ -1134,9 +1137,24 @@ void KsMainWindow::loadSession(const QString &fileName) void KsMainWindow::_initCapture() { + bool canDoAsRoot(false); + #ifdef DO_AS_ROOT + canDoAsRoot = true; +#endif + + if (geteuid() && !canDoAsRoot) + return; - _capture.setProgram("kshark-su-record"); + if (geteuid()) { + _capture.setProgram("kshark-su-record"); + } else { + QStringList argv; + + _capture.setProgram("kshark-record"); + argv << QString("-o ") + QDir::homePath(); + _capture.setArguments(argv); + } connect(&_capture, &QProcess::started, this, &KsMainWindow::_captureStarted); @@ -1155,7 +1173,6 @@ void KsMainWindow::_initCapture() connect(&_captureLocalServer, &QLocalServer::newConnection, this, &KsMainWindow::_readSocket); -#endif } void KsMainWindow::_captureStarted() From patchwork Fri Aug 9 08:06:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 11085629 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 192BB13AC for ; Fri, 9 Aug 2019 08:06:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0D40828C37 for ; Fri, 9 Aug 2019 08:06:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0180328C47; Fri, 9 Aug 2019 08:06:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9180A28C37 for ; Fri, 9 Aug 2019 08:06:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405690AbfHIIGt (ORCPT ); Fri, 9 Aug 2019 04:06:49 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:38914 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405567AbfHIIGt (ORCPT ); Fri, 9 Aug 2019 04:06:49 -0400 Received: by mail-wm1-f66.google.com with SMTP id u25so4756711wmc.4 for ; Fri, 09 Aug 2019 01:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VqMOUTuD2s5Dbp59FMHyRSWw9hchSLCbb+LBTKkCOv0=; b=XgPctS15VmVBrbuFUKDCuAqYuD+EsUdOptQ4SSfBKPVIf33XaqS89XChWgoNPpXE/i Pw2TYdtUOJHiUe9lQjapIKAlVAFRUS+Y8q/IZXSVd9G5tXaGuXG4A3uLlWcFK/bAIMnk zMs53olaf9LoQn0yElTC1/s8LgZRuDSiGAsIGvAyacj0lOPAB8vzRw3rgJut1LjRMcT0 enaryLh1fdZJzoJk7ShUiTdUajvNDci74S4+uYBEn6Iuo/qjB2EaHe9+Minksylzldql xqRXlmB7cLC9216Uaq3AUehJujZ9+0RWHPT0pnNSOTR8hFHs0Cguxmg0vMDwXUdq/y0G IYnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VqMOUTuD2s5Dbp59FMHyRSWw9hchSLCbb+LBTKkCOv0=; b=LDE5BWeC1RO1gLRLvxBF069/3LokuxG+6luJR6Nh8U6FNZOio/np5In+5ZxXY3PhSj 0ciK5TKirg7lNiNsqZ9VDK64cuv8LmUbsBw5JLLKnprkkRNobJw4rLrbXCHxIRiVuVpd eaH/dZUHuCkU0IyM20bI/aUuUeKDpTgFmrG1cpYVSA5+ylQR/slclV5D1+9IOsrRGLDS /FdEyDpDDn2OuaXA0CV/vQsu01Tt3ppLnShKSytfmDfDCV+++WA++wNbEkUCxSzgGFPD wgBVWTPmXMZ2NmXLdqz/YS4IlMTILuynolysiV69dyVXgGHclH8/PDC/M7l7hTaYh9zi Fkpg== X-Gm-Message-State: APjAAAWbXYYFBYzhV8y9ReyeD3O4ScIh8smNH0kHpqoWaKHOMRqVz/sJ JYGMmXL6AqlwtdR4yFXuhB0= X-Google-Smtp-Source: APXvYqzGf5d21BPmT9EXM2MCivDs0G0cfbobE7RQjvcRa0EQg8THhO74BZRt6ZcT6DfLOSZmr3qg1Q== X-Received: by 2002:a7b:c149:: with SMTP id z9mr9570761wmi.0.1565338007162; Fri, 09 Aug 2019 01:06:47 -0700 (PDT) Received: from mamba.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id q124sm6964302wma.33.2019.08.09.01.06.46 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 09 Aug 2019 01:06:46 -0700 (PDT) From: "Yordan Karadzhov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, mike.auty@gmail.com, "Yordan Karadzhov (VMware)" Subject: [PATCH 3/3] kernel-shark: Use standart error message in KsMainWindow::_record() Date: Fri, 9 Aug 2019 11:06:23 +0300 Message-Id: <20190809080623.7548-4-y.karadz@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190809080623.7548-1-y.karadz@gmail.com> References: <20190809080623.7548-1-y.karadz@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The error message is printed using the method KsMainWindow::_error(). The message itself remains unchanged. If we want to change the message, this can be done in another patch. Signed-off-by: Yordan Karadzhov (VMware) --- kernel-shark/src/KsMainWindow.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp index e9c6d54..b462ded 100644 --- a/kernel-shark/src/KsMainWindow.cpp +++ b/kernel-shark/src/KsMainWindow.cpp @@ -890,7 +890,6 @@ void KsMainWindow::_record() #endif if (geteuid() && !canDoAsRoot) { - QErrorMessage *em = new QErrorMessage(this); QString message; message = "Record is currently not supported."; @@ -899,8 +898,7 @@ void KsMainWindow::_record() message += " ./cmake_clean.sh
cmake ..
make
"; message += " sudo make install"; - em->showMessage(message); - qCritical() << "ERROR: " << message; + _error(message, "recordCantStart", false, false); return; }