From patchwork Tue Aug 13 07:27:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 11091379 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 13DB514F7 for ; Tue, 13 Aug 2019 07:27:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ED619285C8 for ; Tue, 13 Aug 2019 07:27:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E12E8285CD; Tue, 13 Aug 2019 07:27:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from web01.groups.io (web01.groups.io [66.175.222.12]) (using TLSv1.2 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 742D6285C8 for ; Tue, 13 Aug 2019 07:27:42 +0000 (UTC) X-Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by groups.io with SMTP; Tue, 13 Aug 2019 00:27:37 -0700 X-Received: by mail.kernel.org (Postfix) id 4D18320843; Tue, 13 Aug 2019 07:27:37 +0000 (UTC) X-Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB5A120663 for ; Tue, 13 Aug 2019 07:27:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB5A120663 X-Received: by mail-lj1-f194.google.com with SMTP id r9so100608333ljg.5 for ; Tue, 13 Aug 2019 00:27:36 -0700 (PDT) X-Gm-Message-State: APjAAAVCKgu0Z3VKsAL0Yl+MC0K4GUskUTwn3e/wrC6KwJO18hZ07yT0 43PP5cDKpyBC7KzJywU6i0vRZYexypWLQA== X-Google-Smtp-Source: APXvYqysE1zoOaMXVVrhPhIBzgFCPB3jNNndUZAP7c+tNqs2RgHpaFLlNgeFmS76jP1fiEV3l22XOg== X-Received: by 2002:a05:651c:95:: with SMTP id 21mr2819969ljq.128.1565681255104; Tue, 13 Aug 2019 00:27:35 -0700 (PDT) X-Received: from localhost.bredbandsbolaget (c-2ccd225c.014-348-6c756e10.bbcust.telenor.se. [92.34.205.44]) by smtp.gmail.com with ESMTPSA id r23sm737884lji.3.2019.08.13.00.27.33 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 13 Aug 2019 00:27:34 -0700 (PDT) From: Linus Walleij To: Linuxkernel+Patchwork-Soc via Email Integration Cc: linux-arm-kernel@lists.infradead.org, Linus Walleij Subject: [PATCH] ARM: dts: nomadik: Set up the CS GPIO right Date: Tue, 13 Aug 2019 09:27:31 +0200 Message-Id: <20190813072731.4558-1-linus.walleij@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: patchwork-soc@linux.kernel.org List-Id: Mailing-List: list patchwork-soc@linux.kernel.org; contact patchwork-soc+owner@linux.kernel.org Delivered-To: mailing list patchwork-soc@linux.kernel.org Reply-To: patchwork-soc+owner@linux.kernel.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux.kernel.org; q=dns/txt; s=20140610; t=1565681262; bh=98kEnzeFzPGa5dW63pBkaagigggZ6Iaz3JiSn27+gzI=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=N1Iv2mtnp+i3bk4UNDBkm15QSVCfM0ZcinaAW9L7iaTSDNaZlKB6Tiq2GGYN6xbKOSp j+YdlvEoKUy8/ebgvEnGb9n+n5bGr4gsoRyXYydvyu9yYU/q6pIPxcApYBbNh2Lbq+E/C AoRKB24+O0t2f/pNbb+hIvz9/WisZp5JWZ4= X-Virus-Scanned: ClamAV using ClamSMTP Now that the SPI GPIO driver knows how to handle these chip select GPIOs and we get nasty messages about the core having to enforce active low on the GPIO, fix this up by actually requesting the CS GPIO line as active low. Signed-off-by: Linus Walleij --- ARM SoC folks: please apply this directly for v5.4, I do not plan to send more Nomadik patches this merge window. --- arch/arm/boot/dts/ste-nomadik-nhk15.dts | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/arm/boot/dts/ste-nomadik-nhk15.dts b/arch/arm/boot/dts/ste-nomadik-nhk15.dts index 04066f9cb8a3..41ed21a4fdc1 100644 --- a/arch/arm/boot/dts/ste-nomadik-nhk15.dts +++ b/arch/arm/boot/dts/ste-nomadik-nhk15.dts @@ -212,13 +212,7 @@ */ gpio-sck = <&gpio0 5 GPIO_ACTIVE_HIGH>; gpio-mosi = <&gpio0 4 GPIO_ACTIVE_HIGH>; - /* - * It's not actually active high, but the frameworks assume - * the polarity of the passed-in GPIO is "normal" (active - * high) then actively drives the line low to select the - * chip. - */ - cs-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>; + cs-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>; num-chipselects = <1>; /*