From patchwork Thu Sep 6 14:53:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov X-Patchwork-Id: 10590693 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6C1135A4 for ; Thu, 6 Sep 2018 14:58:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4F2102AA83 for ; Thu, 6 Sep 2018 14:58:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 41F952AB7C; Thu, 6 Sep 2018 14:58:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C476F2AA83 for ; Thu, 6 Sep 2018 14:58:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BAE586E108; Thu, 6 Sep 2018 14:58:13 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 461E26E108 for ; Thu, 6 Sep 2018 14:58:12 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id r1-v6so14602234wmh.0 for ; Thu, 06 Sep 2018 07:58:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=RUIRD3jeLwS/MuVSJKvRDmIQuXcfuI1ZI8Tmh5duJ/c=; b=EMBzE9UAWzwFpwj+Rh4xo9LAZhnFbgltYNqwl+aLzgBYRcXzNtMAA+Tgjd/N9zp+sB koHFjymzBhpMFivJc3+CsB1zMeZD+kTdIxRhhgdu/LRyZgtaekr7v0u4CJImGj0j5iE8 GVZB72MOyjLVKi6j9vChRvJps7Pl0kYEm/tZrUyKkiFv/p+oGRBWoBINFYUGUHr+gmAw ep00TKWqbHDqDHBFc2XdhhcRPDKna042Lex0DFzx7fE2SVZ5FIPmh8qAEeJyxvkMtKGV b7GANlla3xZ9ULwh/607HSlvaIEbey6RD01SlpPm0+eVB5OO4bhmSn1cVAPizICU8Zkl 2lew== X-Gm-Message-State: APzg51CgZNs5TlrNkB33CysnlM1jsRwTEhP4JRj33D+qNL68YnKRKBFQ JFPxOUBMlgnL+db4SINn2REBWqK7 X-Google-Smtp-Source: ANB0VdbcswWxid4p/DRlvCvQD6FAZP/zBpBNvxd0FbsnAZxxUeXo2BjNNbc3Hp63Yk7B47OEoxLbTg== X-Received: by 2002:a1c:7301:: with SMTP id d1-v6mr2359755wmb.34.1536245890644; Thu, 06 Sep 2018 07:58:10 -0700 (PDT) Received: from arch-x1c3.cbg.collabora.co.uk ([2a00:5f00:102:0:9665:9cff:feee:aa4d]) by smtp.gmail.com with ESMTPSA id v46-v6sm5502668wrc.63.2018.09.06.07.58.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Sep 2018 07:58:09 -0700 (PDT) From: Emil Velikov To: dri-devel@lists.freedesktop.org Subject: [PATCH libdrm 1/2] automake: set NM before running the tests Date: Thu, 6 Sep 2018 15:53:33 +0100 Message-Id: <20180906145334.9070-1-emil.l.velikov@gmail.com> X-Mailer: git-send-email 2.18.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Engestrom , emil.l.velikov@gmail.com, Heiko Becker MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Emil Velikov Set/export the NM variable since it may not be set already. Fixes: 4f08bfe96da ("*-symbol-check: Don't hard-code nm executable") Cc: Heiko Becker Cc: Eric Engestrom Signed-off-by: Emil Velikov Reviewed-by: Eric Engestrom --- amdgpu/Makefile.am | 1 + etnaviv/Makefile.am | 1 + exynos/Makefile.am | 1 + freedreno/Makefile.am | 1 + intel/Makefile.am | 1 + libkms/Makefile.am | 1 + nouveau/Makefile.am | 1 + omap/Makefile.am | 1 + radeon/Makefile.am | 1 + tegra/Makefile.am | 1 + 10 files changed, 10 insertions(+) diff --git a/amdgpu/Makefile.am b/amdgpu/Makefile.am index a1b0d05c..1a8538f5 100644 --- a/amdgpu/Makefile.am +++ b/amdgpu/Makefile.am @@ -47,5 +47,6 @@ libdrm_amdgpuinclude_HEADERS = $(LIBDRM_AMDGPU_H_FILES) pkgconfigdir = @pkgconfigdir@ pkgconfig_DATA = libdrm_amdgpu.pc +AM_TESTS_ENVIRONMENT = NM='$(NM)' TESTS = amdgpu-symbol-check EXTRA_DIST = $(TESTS) diff --git a/etnaviv/Makefile.am b/etnaviv/Makefile.am index be96ba86..38ed1717 100644 --- a/etnaviv/Makefile.am +++ b/etnaviv/Makefile.am @@ -22,5 +22,6 @@ libdrm_etnavivinclude_HEADERS = $(LIBDRM_ETNAVIV_H_FILES) pkgconfigdir = @pkgconfigdir@ pkgconfig_DATA = libdrm_etnaviv.pc +AM_TESTS_ENVIRONMENT = NM='$(NM)' TESTS = etnaviv-symbol-check EXTRA_DIST = $(TESTS) diff --git a/exynos/Makefile.am b/exynos/Makefile.am index f99f8981..c1dda663 100644 --- a/exynos/Makefile.am +++ b/exynos/Makefile.am @@ -23,5 +23,6 @@ libdrm_exynosinclude_HEADERS = exynos_drmif.h pkgconfigdir = @pkgconfigdir@ pkgconfig_DATA = libdrm_exynos.pc +AM_TESTS_ENVIRONMENT = NM='$(NM)' TESTS = exynos-symbol-check EXTRA_DIST = $(TESTS) diff --git a/freedreno/Makefile.am b/freedreno/Makefile.am index cbb0d031..f4f0bafe 100644 --- a/freedreno/Makefile.am +++ b/freedreno/Makefile.am @@ -27,5 +27,6 @@ libdrm_freedrenocommoninclude_HEADERS = $(LIBDRM_FREEDRENO_H_FILES) pkgconfigdir = @pkgconfigdir@ pkgconfig_DATA = libdrm_freedreno.pc +AM_TESTS_ENVIRONMENT = NM='$(NM)' TESTS = freedreno-symbol-check EXTRA_DIST = $(TESTS) diff --git a/intel/Makefile.am b/intel/Makefile.am index c52e8c08..acedb795 100644 --- a/intel/Makefile.am +++ b/intel/Makefile.am @@ -56,6 +56,7 @@ BATCHES = \ tests/gen7-2d-copy.batch \ tests/gen7-3d.batch +AM_TESTS_ENVIRONMENT = NM='$(NM)' TESTS = \ $(BATCHES:.batch=.batch.sh) \ intel-symbol-check diff --git a/libkms/Makefile.am b/libkms/Makefile.am index 461fc35b..cd273fa7 100644 --- a/libkms/Makefile.am +++ b/libkms/Makefile.am @@ -39,5 +39,6 @@ libkmsinclude_HEADERS = $(LIBKMS_H_FILES) pkgconfigdir = @pkgconfigdir@ pkgconfig_DATA = libkms.pc +AM_TESTS_ENVIRONMENT = NM='$(NM)' TESTS = kms-symbol-check EXTRA_DIST = $(TESTS) diff --git a/nouveau/Makefile.am b/nouveau/Makefile.am index 344a8445..9f61491b 100644 --- a/nouveau/Makefile.am +++ b/nouveau/Makefile.am @@ -29,5 +29,6 @@ libdrm_nouveaunvifinclude_HEADERS = nvif/class.h \ pkgconfigdir = @pkgconfigdir@ pkgconfig_DATA = libdrm_nouveau.pc +AM_TESTS_ENVIRONMENT = NM='$(NM)' TESTS = nouveau-symbol-check EXTRA_DIST = $(TESTS) diff --git a/omap/Makefile.am b/omap/Makefile.am index 599bb9de..56257c89 100644 --- a/omap/Makefile.am +++ b/omap/Makefile.am @@ -20,5 +20,6 @@ libdrm_omapinclude_HEADERS = omap_drmif.h pkgconfigdir = @pkgconfigdir@ pkgconfig_DATA = libdrm_omap.pc +AM_TESTS_ENVIRONMENT = NM='$(NM)' TESTS = omap-symbol-check EXTRA_DIST = $(TESTS) diff --git a/radeon/Makefile.am b/radeon/Makefile.am index e2415314..0f5f94a1 100644 --- a/radeon/Makefile.am +++ b/radeon/Makefile.am @@ -43,5 +43,6 @@ libdrm_radeoninclude_HEADERS = $(LIBDRM_RADEON_H_FILES) pkgconfigdir = @pkgconfigdir@ pkgconfig_DATA = libdrm_radeon.pc +AM_TESTS_ENVIRONMENT = NM='$(NM)' TESTS = radeon-symbol-check EXTRA_DIST = $(LIBDRM_RADEON_BOF_FILES) $(TESTS) diff --git a/tegra/Makefile.am b/tegra/Makefile.am index fb40be55..92b2ce2a 100644 --- a/tegra/Makefile.am +++ b/tegra/Makefile.am @@ -21,5 +21,6 @@ libdrm_tegrainclude_HEADERS = tegra.h pkgconfigdir = @pkgconfigdir@ pkgconfig_DATA = libdrm_tegra.pc +AM_TESTS_ENVIRONMENT = NM='$(NM)' TESTS = tegra-symbol-check EXTRA_DIST = $(TESTS) From patchwork Thu Sep 6 14:53:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov X-Patchwork-Id: 10590695 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AF82C5A4 for ; Thu, 6 Sep 2018 14:58:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 940DB2AC01 for ; Thu, 6 Sep 2018 14:58:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 87C5B2AB8E; Thu, 6 Sep 2018 14:58:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 282EE2AB7C for ; Thu, 6 Sep 2018 14:58:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 43D266E6CA; Thu, 6 Sep 2018 14:58:15 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5FDF76E6CE for ; Thu, 6 Sep 2018 14:58:14 +0000 (UTC) Received: by mail-wm0-x230.google.com with SMTP id s12-v6so11759901wmc.0 for ; Thu, 06 Sep 2018 07:58:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YPdAUPbyLs4pp9CecGswWqCJcWT2SlfJ+c7tdtnNT+g=; b=Xh8B3+qQGPRrY2TBGvmv4dGvDV5HuicQC8HvhF5SSkL3R1v5b2X+XZndeCjWU14jwp scRqBrg+Iw/VudQbco2SBCc6kTat5FHHw2XednQDoeL1g8NkYJTnWI3K6DERpImvs+Wu 9lYKvsi5VDL/rRUy1cbPEwdQ4IXrmdWYb+uRnnmpvSkZUKLRjz1R9Aps8x0kR/R2ICX8 zib1m9RGGV02QK5j+I44OXA1QY/xRQPHCRGfQ9G7Pp8r+HXytMdFhlkQnQDUpXMkVQZb RZwa6+GlnB16UvZ4WFnbSJx9BH3vj8TeEk5E0JJnyDIH8Joz082Jl+Mr9MLfoHERuOH6 yiDQ== X-Gm-Message-State: APzg51C9f2OmKRxiHYcQEBI96LbjwDn86mDbtpZT/gSq7Hz5P/KZRWoc KuzAhpP5hjcNFokj01Ulbl5FufKq X-Google-Smtp-Source: ANB0VdavltjVa9WJlUQQBuQ5WfatggXRJQ0ixO0ElBL5qOC+bE4Sm3vqIyXWaBp3ZCEEOPudGt0zvA== X-Received: by 2002:a1c:1510:: with SMTP id 16-v6mr2303056wmv.74.1536245891918; Thu, 06 Sep 2018 07:58:11 -0700 (PDT) Received: from arch-x1c3.cbg.collabora.co.uk ([2a00:5f00:102:0:9665:9cff:feee:aa4d]) by smtp.gmail.com with ESMTPSA id v46-v6sm5502668wrc.63.2018.09.06.07.58.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Sep 2018 07:58:10 -0700 (PDT) From: Emil Velikov To: dri-devel@lists.freedesktop.org Subject: [PATCH libdrm 2/2] *-symbols-check: error out when using unset variables Date: Thu, 6 Sep 2018 15:53:34 +0100 Message-Id: <20180906145334.9070-2-emil.l.velikov@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180906145334.9070-1-emil.l.velikov@gmail.com> References: <20180906145334.9070-1-emil.l.velikov@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Engestrom , emil.l.velikov@gmail.com MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Emil Velikov It will make bugs like the one fixed with previous patch dead obvious. Cc: Eric Engestrom Signed-off-by: Emil Velikov --- amdgpu/amdgpu-symbol-check | 2 ++ etnaviv/etnaviv-symbol-check | 2 ++ exynos/exynos-symbol-check | 2 ++ freedreno/freedreno-symbol-check | 2 ++ intel/intel-symbol-check | 2 ++ libkms/kms-symbol-check | 2 ++ nouveau/nouveau-symbol-check | 2 ++ omap/omap-symbol-check | 2 ++ radeon/radeon-symbol-check | 2 ++ tegra/tegra-symbol-check | 2 ++ 10 files changed, 20 insertions(+) diff --git a/amdgpu/amdgpu-symbol-check b/amdgpu/amdgpu-symbol-check index 90b7a1d6..07477243 100755 --- a/amdgpu/amdgpu-symbol-check +++ b/amdgpu/amdgpu-symbol-check @@ -1,5 +1,7 @@ #!/bin/bash +set -u + # The following symbols (past the first five) are taken from the public headers. # A list of the latter should be available Makefile.am/libdrm_amdgpuinclude_HEADERS diff --git a/etnaviv/etnaviv-symbol-check b/etnaviv/etnaviv-symbol-check index bc509615..18910688 100755 --- a/etnaviv/etnaviv-symbol-check +++ b/etnaviv/etnaviv-symbol-check @@ -1,5 +1,7 @@ #!/bin/bash +set -u + # The following symbols (past the first five) are taken from the public headers. # A list of the latter should be available Makefile.sources/LIBDRM_ETNAVIV_H_FILES diff --git a/exynos/exynos-symbol-check b/exynos/exynos-symbol-check index e9f1b04d..49d611e6 100755 --- a/exynos/exynos-symbol-check +++ b/exynos/exynos-symbol-check @@ -1,5 +1,7 @@ #!/bin/bash +set -u + # The following symbols (past the first five) are taken from the public headers. # A list of the latter should be available Makefile.am/libdrm_exynos*_HEADERS diff --git a/freedreno/freedreno-symbol-check b/freedreno/freedreno-symbol-check index e732c995..6da9d667 100755 --- a/freedreno/freedreno-symbol-check +++ b/freedreno/freedreno-symbol-check @@ -1,5 +1,7 @@ #!/bin/bash +set -u + # The following symbols (past the first five) are taken from the public headers. # A list of the latter should be available Makefile.sources/LIBDRM_FREEDRENO_H_FILES diff --git a/intel/intel-symbol-check b/intel/intel-symbol-check index 4d30a4b1..de377bef 100755 --- a/intel/intel-symbol-check +++ b/intel/intel-symbol-check @@ -1,5 +1,7 @@ #!/bin/bash +set -u + # The following symbols (past the first five) are taken from the public headers. # A list of the latter should be available Makefile.sources/LIBDRM_INTEL_H_FILES diff --git a/libkms/kms-symbol-check b/libkms/kms-symbol-check index a5c2120d..30f444f7 100755 --- a/libkms/kms-symbol-check +++ b/libkms/kms-symbol-check @@ -1,5 +1,7 @@ #!/bin/bash +set -u + # The following symbols (past the first five) are taken from the public headers. # A list of the latter should be available Makefile.sources/LIBKMS_H_FILES diff --git a/nouveau/nouveau-symbol-check b/nouveau/nouveau-symbol-check index b3a24101..6296244c 100755 --- a/nouveau/nouveau-symbol-check +++ b/nouveau/nouveau-symbol-check @@ -1,5 +1,7 @@ #!/bin/bash +set -u + # The following symbols (past the first five) are taken from the public headers. # A list of the latter should be available Makefile.sources/LIBDRM_NOUVEAU_H_FILES diff --git a/omap/omap-symbol-check b/omap/omap-symbol-check index 0fb4a0f2..16da3c40 100755 --- a/omap/omap-symbol-check +++ b/omap/omap-symbol-check @@ -1,5 +1,7 @@ #!/bin/bash +set -u + # The following symbols (past the first five) are taken from the public headers. # A list of the latter should be available Makefile.am/libdrm_omap*HEADERS diff --git a/radeon/radeon-symbol-check b/radeon/radeon-symbol-check index 7d79d901..da605bb8 100755 --- a/radeon/radeon-symbol-check +++ b/radeon/radeon-symbol-check @@ -1,5 +1,7 @@ #!/bin/bash +set -u + # The following symbols (past the first five) are taken from the public headers. # A list of the latter should be available Makefile.sources/LIBDRM_RADEON_H_FILES diff --git a/tegra/tegra-symbol-check b/tegra/tegra-symbol-check index 509b678c..8539b95b 100755 --- a/tegra/tegra-symbol-check +++ b/tegra/tegra-symbol-check @@ -1,5 +1,7 @@ #!/bin/bash +set -u + # The following symbols (past the first nine) are taken from tegra.h. FUNCS=$($NM -D --format=bsd --defined-only ${1-.libs/libdrm_tegra.so} | awk '{print $3}'| while read func; do