From patchwork Tue Aug 20 09:40:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda Delgado X-Patchwork-Id: 11103463 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C1026174A for ; Tue, 20 Aug 2019 09:40:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 96A2222DCC for ; Tue, 20 Aug 2019 09:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566294033; bh=uQVsEV87rvpBFU1J/Cofx8lDu0ZRe62qsYfucG0g9uM=; h=From:To:Cc:Subject:Date:List-ID:From; b=I0kq7zLDHWv8G7ViRse2lRsF3iWyRii+GelnrnSBLKPhLqgO3spV6oZ7gMWoRUWsf C9XvDYKsVfC1zKKSXKoeWNMs0Vdf68hsTTl6Eo/5u0AlmQGnlsTdUE74Kyc50cVNM9 UfCNscR0DUH09s0xPFPLvmRZkNlLEmlUqD8kTk0g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729635AbfHTJkc (ORCPT ); Tue, 20 Aug 2019 05:40:32 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:46598 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728414AbfHTJkc (ORCPT ); Tue, 20 Aug 2019 05:40:32 -0400 Received: by mail-ed1-f68.google.com with SMTP id z51so5550983edz.13; Tue, 20 Aug 2019 02:40:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=k8VTLUSMPpJlERrTrCZkEPzdT4RCL143ZsVe+wpx+3E=; b=smjvbONfMCtWrgRO4aRRdOKmD36mprIOh3qF3Mgr+ca4orIth6foYaBrFCCMGPgdhV jJGArt6MP87/qEPx5brOonKqLmUn1ZL1ePJKlLdonSA8avK6gX7afR9qqvF7bIpjAU98 Pwe90Mx9I/w5F+KbZIOhIbNk0N5umRufyT0mF+FQ85El72Bj4Kr/JFK/mGlvitLg6Ir4 /sda3K3z0mkX7BUMKSIpouqoZsFb/VXHYhrLjnc/hB+E4iSgt0QIObIT06Sv+Cz+gsHg LpBzeudeSks+UE8uqUEgwA0FthodXi7wpNqVM1+4HwZB1vZYYdCgHhI0hF+/ewW8Wb3p H8iQ== X-Gm-Message-State: APjAAAUo9nSSomjc/27GZpYU0wpgCAJWjrhL6Rs2TWxkY7N9BgIDogvp 4I1UngZ9ahBs2PFaHlrK2Xo= X-Google-Smtp-Source: APXvYqxQfc1FHosZmGZPEXyfGaCgaDxmTrJrsE15LSyDty9Eyjf412FvnXCL93RcBHCUH4RbDKGF6A== X-Received: by 2002:aa7:c552:: with SMTP id s18mr17429600edr.0.1566294029934; Tue, 20 Aug 2019 02:40:29 -0700 (PDT) Received: from neopili.qtec.com (cpe.xe-3-0-1-778.vbrnqe10.dk.customer.tdc.net. [80.197.57.18]) by smtp.gmail.com with ESMTPSA id j37sm3354259ede.23.2019.08.20.02.40.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2019 02:40:28 -0700 (PDT) From: Ricardo Ribalda Delgado To: Philipp Zabel , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ricardo Ribalda Delgado Subject: [PATCH v2 1/3] media: add V4L2_CID_UNIT_CELL_SIZE control Date: Tue, 20 Aug 2019 11:40:25 +0200 Message-Id: <20190820094027.4144-1-ribalda@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This control returns the unit cell size in nanometres. The struct provides the width and the height in separated fields to take into consideration asymmetric pixels and/or hardware binning. This control is required for automatic calibration of sensors/cameras. Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/v4l2-core/v4l2-ctrls.c | 11 +++++++++++ include/media/v4l2-ctrls.h | 2 ++ include/uapi/linux/v4l2-controls.h | 3 +++ include/uapi/linux/videodev2.h | 11 +++++++++++ 4 files changed, 27 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index cd1ae016706f..ec949453a081 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls.c +++ b/drivers/media/v4l2-core/v4l2-ctrls.c @@ -978,6 +978,7 @@ const char *v4l2_ctrl_get_name(u32 id) case V4L2_CID_AUTO_FOCUS_RANGE: return "Auto Focus, Range"; case V4L2_CID_PAN_SPEED: return "Pan, Speed"; case V4L2_CID_TILT_SPEED: return "Tilt, Speed"; + case V4L2_CID_UNIT_CELL_SIZE: return "Unit Cell Size"; /* FM Radio Modulator controls */ /* Keep the order of the 'case's the same as in v4l2-controls.h! */ @@ -1357,6 +1358,9 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type, case V4L2_CID_MPEG_VIDEO_VP8_FRAME_HEADER: *type = V4L2_CTRL_TYPE_VP8_FRAME_HEADER; break; + case V4L2_CID_UNIT_CELL_SIZE: + *type = V4L2_CTRL_TYPE_AREA; + break; default: *type = V4L2_CTRL_TYPE_INTEGER; break; @@ -1423,6 +1427,7 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type, case V4L2_CID_RDS_RX_TRAFFIC_ANNOUNCEMENT: case V4L2_CID_RDS_RX_TRAFFIC_PROGRAM: case V4L2_CID_RDS_RX_MUSIC_SPEECH: + case V4L2_CID_UNIT_CELL_SIZE: *flags |= V4L2_CTRL_FLAG_READ_ONLY; break; case V4L2_CID_RF_TUNER_PLL_LOCK: @@ -1705,6 +1710,9 @@ static int std_validate_compound(const struct v4l2_ctrl *ctrl, u32 idx, case V4L2_CTRL_TYPE_FWHT_PARAMS: break; + case V4L2_CTRL_TYPE_AREA: + break; + case V4L2_CTRL_TYPE_H264_SPS: case V4L2_CTRL_TYPE_H264_PPS: case V4L2_CTRL_TYPE_H264_SCALING_MATRIX: @@ -2403,6 +2411,9 @@ static struct v4l2_ctrl *v4l2_ctrl_new(struct v4l2_ctrl_handler *hdl, case V4L2_CTRL_TYPE_VP8_FRAME_HEADER: elem_size = sizeof(struct v4l2_ctrl_vp8_frame_header); break; + case V4L2_CTRL_TYPE_AREA: + elem_size = sizeof(struct v4l2_area); + break; default: if (type < V4L2_CTRL_COMPOUND_TYPES) elem_size = sizeof(s32); diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h index 570ff4b0205a..9a3d11350e67 100644 --- a/include/media/v4l2-ctrls.h +++ b/include/media/v4l2-ctrls.h @@ -50,6 +50,7 @@ struct poll_table_struct; * @p_h264_slice_params: Pointer to a struct v4l2_ctrl_h264_slice_params. * @p_h264_decode_params: Pointer to a struct v4l2_ctrl_h264_decode_params. * @p_vp8_frame_header: Pointer to a VP8 frame header structure. + * @p_area: Pointer to an area. * @p: Pointer to a compound value. */ union v4l2_ctrl_ptr { @@ -68,6 +69,7 @@ union v4l2_ctrl_ptr { struct v4l2_ctrl_h264_slice_params *p_h264_slice_params; struct v4l2_ctrl_h264_decode_params *p_h264_decode_params; struct v4l2_ctrl_vp8_frame_header *p_vp8_frame_header; + struct v4l2_area *p_area; void *p; }; diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h index a2669b79b294..1332eabd27b1 100644 --- a/include/uapi/linux/v4l2-controls.h +++ b/include/uapi/linux/v4l2-controls.h @@ -912,6 +912,9 @@ enum v4l2_auto_focus_range { #define V4L2_CID_PAN_SPEED (V4L2_CID_CAMERA_CLASS_BASE+32) #define V4L2_CID_TILT_SPEED (V4L2_CID_CAMERA_CLASS_BASE+33) +#define V4L2_CID_UNIT_CELL_SIZE (V4L2_CID_CAMERA_CLASS_BASE+34) + + /* FM Modulator class control IDs */ #define V4L2_CID_FM_TX_CLASS_BASE (V4L2_CTRL_CLASS_FM_TX | 0x900) diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index 2427bc4d8eba..751e2065ac02 100644 --- a/include/uapi/linux/videodev2.h +++ b/include/uapi/linux/videodev2.h @@ -422,6 +422,11 @@ struct v4l2_fract { __u32 denominator; }; +struct v4l2_area { + __u32 width; + __u32 height; +}; + /** * struct v4l2_capability - Describes V4L2 device caps returned by VIDIOC_QUERYCAP * @@ -1718,6 +1723,12 @@ enum v4l2_ctrl_type { V4L2_CTRL_TYPE_U8 = 0x0100, V4L2_CTRL_TYPE_U16 = 0x0101, V4L2_CTRL_TYPE_U32 = 0x0102, + /* + * V4L2_CTRL_TYPE_MPEG2_SLICE_PARAMS = 0x0103, + * V4L2_CTRL_TYPE_MPEG2_QUANTIZATION = 0x0104, + * V4L2_CTRL_TYPE_FWHT_PARAMS = 0x0105, + */ + V4L2_CTRL_TYPE_AREA = 0x0106, }; /* Used in the VIDIOC_QUERYCTRL ioctl for querying controls */ From patchwork Tue Aug 20 09:40:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda Delgado X-Patchwork-Id: 11103467 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 23B82174A for ; Tue, 20 Aug 2019 09:40:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0246222DD3 for ; Tue, 20 Aug 2019 09:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566294051; bh=i99KwOAygiGJojcIo7pV3IW0ClMi5lnMrChCPAboa5A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=swf7BFOD0KElNUWR3KMnmZNuFivWQAWq+X1VpQ8KIV8ghJQovRrhPiXWf2TceEKie doVhzpg87Gl+MBWaJZ7ZxkOCO3Uov0NLnPtlECDGX6plnaa6Gy0WGLvm/MviBaV5wk /bS5MV0uKU/z48rXK3gft9MQ0dekuMpYJW5RQ6yQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729667AbfHTJkf (ORCPT ); Tue, 20 Aug 2019 05:40:35 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:33336 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729631AbfHTJkd (ORCPT ); Tue, 20 Aug 2019 05:40:33 -0400 Received: by mail-ed1-f65.google.com with SMTP id s15so5568430edx.0; Tue, 20 Aug 2019 02:40:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rMUXCb5+TixoCdCe/Ddi5TGh1mQeTH0yMrCUcqjfwn4=; b=piMRqED2uS4uYJQ6IO5ZBxEwvMqZitaeHWyFvn5k6O690JkO1+NxhrBlPgcBauckAg XZK4jN3v+cqQl9fRkU47ntfmhkFngX1TXwcmi2v4nsMJIc6Dnko0kwGHHZdMAwXJ13Gh M3bm61Jhvv8J6+6fIhBo+lHCu0AJdY441+y5fdwyLAn9MlOqrfggzf5c6aX4PpTK68Va OrZaORPRKdnGRaWs7YNfSuByqZpoPlOwqf+F3ugS03ri7ilkj+57Bx8KEg9znrY3n5nn 5dTcmbvs521rNH7M8XpU/2FwK0GxVcd/urEtcFb2a8Y2h+e8C3jvA59CKkNvVwD3vRc9 nsXQ== X-Gm-Message-State: APjAAAXclE4sOle8IDPvJkYcz6Lgh0/0LEEh3cBfYe7GMpwp/qiv2FDi FlfaDuqDTnv2lkRdvFSPyxo= X-Google-Smtp-Source: APXvYqyEqw/zlmW3qrpIUevhkSUtrQM3Brcy0GT+8gIBrauXNcPT8NadK8e40XErlzeDsC2RrD4bfQ== X-Received: by 2002:a17:906:1303:: with SMTP id w3mr25512694ejb.143.1566294031409; Tue, 20 Aug 2019 02:40:31 -0700 (PDT) Received: from neopili.qtec.com (cpe.xe-3-0-1-778.vbrnqe10.dk.customer.tdc.net. [80.197.57.18]) by smtp.gmail.com with ESMTPSA id j37sm3354259ede.23.2019.08.20.02.40.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2019 02:40:30 -0700 (PDT) From: Ricardo Ribalda Delgado To: Philipp Zabel , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ricardo Ribalda Delgado Subject: [PATCH v2 2/3] Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZE Date: Tue, 20 Aug 2019 11:40:26 +0200 Message-Id: <20190820094027.4144-2-ribalda@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20190820094027.4144-1-ribalda@kernel.org> References: <20190820094027.4144-1-ribalda@kernel.org> MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org New control to pass to userspace the width/height of a pixel. Which is needed for calibration and lens selection. Signed-off-by: Ricardo Ribalda Delgado --- Documentation/media/uapi/v4l/ext-ctrls-camera.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/media/uapi/v4l/ext-ctrls-camera.rst b/Documentation/media/uapi/v4l/ext-ctrls-camera.rst index 51c1d5c9eb00..b43047d4e7a1 100644 --- a/Documentation/media/uapi/v4l/ext-ctrls-camera.rst +++ b/Documentation/media/uapi/v4l/ext-ctrls-camera.rst @@ -510,6 +510,14 @@ enum v4l2_scene_mode - value down. A value of zero stops the motion if one is in progress and has no effect otherwise. +``V4L2_CID_UNIT_CELL_SIZE (struct)`` + This control returns the unit cell size in nanometres. The struct provides + the width and the height in separated fields to take into consideration + asymmetric pixels and/or hardware binning. + The unit cell consist on the whole area of the pixel, sensitive and + non-sensitive. + This control is required for automatic calibration sensors/cameras. + .. [#f1] This control may be changed to a menu control in the future, if more options are required. From patchwork Tue Aug 20 09:40:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda Delgado X-Patchwork-Id: 11103469 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 57843912 for ; Tue, 20 Aug 2019 09:40:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3732D22DD3 for ; Tue, 20 Aug 2019 09:40:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566294053; bh=8F1t8oqfj5gxhAo6yR6MvajYWf9rB2vs+sJzzlrxfZM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JfRE70Xqil5Ys0VAb65ExUEZWn4P4VUZ2AOXPnRPuk6MwbrS4EJ/TolCm6Gowr1sD nNTcSuDJIZYUmdfzapasVKvdd4elqwCfVULHilWVgjZ/zrPERtCRxZqBabAtPxuGAC oTBoM3U5/olST0MgcYVXb+Lk8qi41LJdqEIi0lp4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729658AbfHTJkf (ORCPT ); Tue, 20 Aug 2019 05:40:35 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:34715 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728414AbfHTJke (ORCPT ); Tue, 20 Aug 2019 05:40:34 -0400 Received: by mail-ed1-f67.google.com with SMTP id s49so5573697edb.1; Tue, 20 Aug 2019 02:40:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F4LOpR2+qDGG/nyT8CDQzwfIkNx8dPONyLIfkWrwXb0=; b=pAO8b0enPUDQRcQU6KJWM6w6AMVJewkc3FljenpBBsAm/fcc8fGxid94RcAa5blnTT 7rwCL/6QHjw5aWg7eHp7tjl1GST1GH9m1lYHR6gw20imO3IG48dDe7NOl37b1ZCyBu5v NINgf4c6I+4c7IEbsQ072ot/D/YpHUIEiQWb1r1BzpWI0yeYxg858Yqy93knqkImbipb a6JyF4nVnEc2TjQkXcqEG2kdv4XqGXU1Jlj7s0T9DJw6VKB8VKQlpKgGE3wzGByu8knj VPqQZgkh9PkuLQ1XttC6Jpo5HYDNKPV+UKduMpj0kFJtntxzwAqn00456lBpBxPfDZ0C Yhvg== X-Gm-Message-State: APjAAAV23+IUD+tsBwXO5NG1PPwTQEWVoWAcbofor3yYSfPJq6OfHxdH n/TTAqxkM/L6Uzm6Q/SF1fU= X-Google-Smtp-Source: APXvYqyRecxQxMOPmI8NopXpVU38gqYahmiUiwm3vmKPM5fq7qf5ITTqib2gdF9RQeyAID+0r/k/CA== X-Received: by 2002:a17:906:3604:: with SMTP id q4mr1518387ejb.102.1566294032808; Tue, 20 Aug 2019 02:40:32 -0700 (PDT) Received: from neopili.qtec.com (cpe.xe-3-0-1-778.vbrnqe10.dk.customer.tdc.net. [80.197.57.18]) by smtp.gmail.com with ESMTPSA id j37sm3354259ede.23.2019.08.20.02.40.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2019 02:40:31 -0700 (PDT) From: Ricardo Ribalda Delgado To: Philipp Zabel , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ricardo Ribalda Delgado Subject: [PATCH v2 3/3] media: imx214: Add new control with V4L2_CID_UNIT_CELL_SIZE Date: Tue, 20 Aug 2019 11:40:27 +0200 Message-Id: <20190820094027.4144-3-ribalda@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20190820094027.4144-1-ribalda@kernel.org> References: <20190820094027.4144-1-ribalda@kernel.org> MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org According to the product brief, the unit cell size is 1120 nanometers^2. https://www.sony-semicon.co.jp/products_en/IS/sensor1/img/products/ProductBrief_IMX214_20150428.pdf Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/i2c/imx214.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c index 159a3a604f0e..cc0a013ba7da 100644 --- a/drivers/media/i2c/imx214.c +++ b/drivers/media/i2c/imx214.c @@ -47,6 +47,7 @@ struct imx214 { struct v4l2_ctrl *pixel_rate; struct v4l2_ctrl *link_freq; struct v4l2_ctrl *exposure; + struct v4l2_ctrl *unit_size; struct regulator_bulk_data supplies[IMX214_NUM_SUPPLIES]; @@ -941,6 +942,26 @@ static int __maybe_unused imx214_resume(struct device *dev) return ret; } +static void unit_size_init(const struct v4l2_ctrl *ctrl, u32 idx, + union v4l2_ctrl_ptr ptr) +{ + ptr.p_area->width = 1120; + ptr.p_area->height = 1120; +} + +static const struct v4l2_ctrl_type_ops unit_size_ops = { + .init = unit_size_init, +}; + +static struct v4l2_ctrl *new_unit_size_ctrl(struct v4l2_ctrl_handler *handler) +{ + static struct v4l2_ctrl_config ctrl = { + .id = V4L2_CID_UNIT_CELL_SIZE, + .type_ops = &unit_size_ops, + }; + + return v4l2_ctrl_new_custom(handler, &ctrl, NULL); +} static int imx214_probe(struct i2c_client *client) { struct device *dev = &client->dev; @@ -1029,6 +1050,8 @@ static int imx214_probe(struct i2c_client *client) V4L2_CID_EXPOSURE, 0, 3184, 1, 0x0c70); + imx214->unit_size = new_unit_size_ctrl(&imx214->ctrls); + ret = imx214->ctrls.error; if (ret) { dev_err(&client->dev, "%s control init failed (%d)\n",