From patchwork Fri Sep 7 18:10:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Stoppa X-Patchwork-Id: 10592465 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 694CA921 for ; Fri, 7 Sep 2018 18:10:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 56BC32B865 for ; Fri, 7 Sep 2018 18:10:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4AFCE2B86A; Fri, 7 Sep 2018 18:10:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9DF5C2B865 for ; Fri, 7 Sep 2018 18:10:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 690BA6B7FAD; Fri, 7 Sep 2018 14:10:49 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 5C8336B7FAE; Fri, 7 Sep 2018 14:10:49 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B79C6B7FAF; Fri, 7 Sep 2018 14:10:49 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by kanga.kvack.org (Postfix) with ESMTP id C9D8C6B7FAD for ; Fri, 7 Sep 2018 14:10:48 -0400 (EDT) Received: by mail-lf1-f71.google.com with SMTP id o22-v6so2882853lfk.5 for ; Fri, 07 Sep 2018 11:10:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id; bh=F9DaonvEapl6YnvqzHacv5ImpGQxDeye4uIerD81AMI=; b=U1sG7Cz+O/vsr9PMgS1ajZFQLEFMwc+Nw42OWh5bneE2zOeoxZX/7BM5C1D5JnuL6H Jv3ggD8QLIgoQ75L3cVUPuX12L6nwo64qvAzvSJEXjZf1O6hCaN6oVhsuzdAC06whvC2 iDXCMi5n7Uj6WOtVT2Nr7WHd61/CFOokOhJ2wb8bnx9cS5GaNnqbSTEjQ1k5C9g0Lw7H Ytj8c3o7EwGg5WzL9nclSvH+DLReqdvi0xosXdjV8vqCsaTkpzDRl2VIj3PehgGiDkzU q6AiFkyxE3m/OAk/xkUvGswbJG6ckFWYfqtKj1sFPaXvQp0VyOUpCwJSxwkOjRhpVVjN v48g== X-Gm-Message-State: APzg51BDrvmyC6QVYG1TJBqxIF1oOEELGSYiBQy8+ZJrZOei5ozSqmmo dUs+wThSvQKmSJYJk86JYRoyMeBmECEoAUDS5/2rGu7aK+CYY262iWZI/vlfVEq+kDqdoNeb50f aq0SLuA6qoDZFO+TtZYE72iP/3z1TFa35MUDSgSDHH/uj9gDeTg+bnh9XF10xd6CrfREV93+n/k d5iFSfgKLlib7to6R5873PXZK6NvI76oCyJV33dJhqmv5S6cqt4c7up9RxGOQIF2l3i8tDLQQXa C4NMtaYUVzvQ9zJrZNJjwOUeVVJaAMMKZE0YPZFdHJcNpmShkewzU7K33K7CFe1vLnnYQylAaUZ S4Nqu8XTHqxvQHphPEfTQChg1kS7kDNX09VnS/OD+39WMk+2ImzzXHh19DbABVtPdu8tMzuJ/Y4 K X-Received: by 2002:a2e:800e:: with SMTP id j14-v6mr5598615ljg.114.1536343847873; Fri, 07 Sep 2018 11:10:47 -0700 (PDT) X-Received: by 2002:a2e:800e:: with SMTP id j14-v6mr5598582ljg.114.1536343846753; Fri, 07 Sep 2018 11:10:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536343846; cv=none; d=google.com; s=arc-20160816; b=OQYOT/EQPDlPCLopLXHfMHTOaNoK0bQuXiYvMMWHe7hWjfIMG5JFQ8vPtUGB15Ej+Z yiihMfBuqi+VxifYhp7dwcXYwcnHwgW6ottdJW4HeV2RL30/V3OqzkPn0r7BToxni6VH eRITGRV/paI9wBxjzdBr6IVE4usbNqkl9Nvs52sn6CIqjPxM9gp90VXq7P5CSpd0T0ss i98mos1az4HfYlwRnYs2eg/uqalp5yqKL+hGkLm6KfWrBXvD1QXDkdH5Num2XaYMVHgz nnDvAtKWWlAsj5kU8HaAJ8c6EyZJO1w6yoUdebM2XuMb/THR5H+A+aXGh4bG4Y9GBgGB gFfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature; bh=F9DaonvEapl6YnvqzHacv5ImpGQxDeye4uIerD81AMI=; b=mxGzb5mgev2W1bMwUQkycxmm6NaLzAxpl/lVACyFYqiNF3wws8mWEMobHDUYXSx+Xo qEkjyZqpiBGa5yxx++uAQhXHek4kYxLFIDQHnwTnaM48Jxskp8GNkXgc7Qv4aeDJlaLz 3cUZOKNo4XhveBojtW/1qQqRchx46OUOeAk0mB1ARcNhN+0w3XlaaSpA7UfezCf5CRUx pbGJ6qCCAw4gdZENTMIELqSu4hHdPTwHDX8x3SQFypLx6yc8maU7WEHIu2JIjIfh6iJ4 Ps8VZzL2Hb5jm3R8VSltS3mGyYrxXOL6h0UWx5m/ESu+WHOy+0YWLKYovw0E+7wJ7dtT G9zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Fi+D+/qf"; spf=pass (google.com: domain of igor.stoppa@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=igor.stoppa@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id v18-v6sor4672920ljj.31.2018.09.07.11.10.46 for (Google Transport Security); Fri, 07 Sep 2018 11:10:46 -0700 (PDT) Received-SPF: pass (google.com: domain of igor.stoppa@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Fi+D+/qf"; spf=pass (google.com: domain of igor.stoppa@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=igor.stoppa@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=F9DaonvEapl6YnvqzHacv5ImpGQxDeye4uIerD81AMI=; b=Fi+D+/qfmMWDcgBzAYimV5Y29P0squZ3TNNPZy2QsMLNci/FRfYrCDhS25iD1rYOLa bViX/JnfA1NCa2zKOtmpsDAdRO9veEqjrygac1JVQ6ByDl4ichAIwYvG+fRY3wyx39pG 595nppdmZtLvAGI+NPefoXO6B7vwkhmzKtQ3Y+E+1IulPFa+c8yO7KX+2VAqjL94vGU3 WW9EUiNCMSnQg20ellMt5ALTtDEx2sHEKC7FX4H1vyoFrZDMlLegAW9c5rnaFAF4kCre GOi5+cs8+6d5HybPTTnrXy8aQ4IpwotVzigancqCnUQ44Ccpa/t7ULmwx8O9sFqL8q90 f/ow== X-Google-Smtp-Source: ANB0VdZ30thomy/lrOkzwsn6dgsPFOLavg57KYdfI0QJo3fvY6+StyK4stXnxxL7rPYWheGWgUVypg== X-Received: by 2002:a2e:5719:: with SMTP id l25-v6mr5551804ljb.125.1536343846335; Fri, 07 Sep 2018 11:10:46 -0700 (PDT) Received: from Mort.jumbo.freeair (91-156-179-220.elisa-laajakaista.fi. [91.156.179.220]) by smtp.gmail.com with ESMTPSA id f74-v6sm1396307lfg.61.2018.09.07.11.10.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Sep 2018 11:10:45 -0700 (PDT) From: Igor Stoppa X-Google-Original-From: Igor Stoppa To: Tejun Heo , Christoph Lameter , Dennis Zhou Cc: igor.stoppa@gmail.com, Igor Stoppa , zijun_hu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [RESEND PATCH] mm: percpu: remove unnecessary unlikely() Date: Fri, 7 Sep 2018 21:10:35 +0300 Message-Id: <20180907181035.1662-1-igor.stoppa@huawei.com> X-Mailer: git-send-email 2.17.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP WARN_ON() already contains an unlikely(), so it's not necessary to wrap it into another. Signed-off-by: Igor Stoppa Acked-by: Dennis Zhou Cc: Tejun Heo Cc: zijun_hu Cc: Christoph Lameter Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/percpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/percpu.c b/mm/percpu.c index a749d4d96e3e..f5c2796fe63e 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -2588,7 +2588,7 @@ int __init pcpu_page_first_chunk(size_t reserved_size, BUG_ON(ai->nr_groups != 1); upa = ai->alloc_size/ai->unit_size; nr_g0_units = roundup(num_possible_cpus(), upa); - if (unlikely(WARN_ON(ai->groups[0].nr_units != nr_g0_units))) { + if (WARN_ON(ai->groups[0].nr_units != nr_g0_units)) { pcpu_free_alloc_info(ai); return -EINVAL; }