From patchwork Wed Aug 28 07:10:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Steinhardt X-Patchwork-Id: 11117925 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DF57213B1 for ; Wed, 28 Aug 2019 07:10:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B3064217F5 for ; Wed, 28 Aug 2019 07:10:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b="ebk9prBp"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="xamANkOE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726441AbfH1HKh (ORCPT ); Wed, 28 Aug 2019 03:10:37 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60569 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726292AbfH1HKh (ORCPT ); Wed, 28 Aug 2019 03:10:37 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5E96621B0E for ; Wed, 28 Aug 2019 03:10:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 28 Aug 2019 03:10:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=1d54FNDRbTuME hWLgxs6sn6X+kyM4FlE9PwhjBe0F6Y=; b=ebk9prBpjcpiH+QyA2UCWLoW+SzEK C2En8sCiQvEj+p8LmpGOC3nfelMBJe0B2aLaqRk1Rw64XpdK4WlGKcmpkYuKnrzR 2gzoLA02tXHu+76oiWl15HFpZsaL9yy3WEBfaO8wnKaWKmamlKFZ5nNU/XTTrFbR ncPLTfBALtJglLWze0i0VRKSuwTncTQUOjVtwoHzyjVRb3e4V1VWy/9z2TTzduxv W1PHLC5s5RdIJDZJidQFaaxiRPMaKKFeOY7bA3OiOpzBjFLPAJglRzNx6hciyT3m jftOGKzcp0m5FMI4/PaEGUlDkqu4M6QgF/xI0NhYfgUsIKwsepzLZDw1w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=1d54FNDRbTuMEhWLgxs6sn6X+kyM4FlE9PwhjBe0F6Y=; b=xamANkOE LLQUyKPUna34hvKUoL8kVT6fDBB0TIuIybQWz9sAlEfxxmpdT+60FGPkdX0MGJeb toA9s/3uWBeTMlf0CL1FqBnO2z+N3eE6jBOSljYCoVTQqK1Xgu3zy/fcIjrh0orR eaPPh+AOY/K7zVO10eAKHHai1UbsPJ29qtM2/fbOZFi3VCoalGLlkjnIM/kS1pB3 /F14D0gAwmZ4+6JpkM1t/ieo0hps9VULZci87zXT9K8BSpCM64t4+uTvAVv+Uw6f m5bYU4Makmn/UWpaNulUGL0bI0WNwfmsxPtnsNVtxD2pFwHdglhiyo41paJp+Vg5 Dau2lL9hwNEvbQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudehledgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefrrghtrhhitghkucfuthgvihhnhhgrrhguthcuoehpshes phhkshdrihhmqeenucfkphepjeejrdduuddrudehhedrvdehheenucfrrghrrghmpehmrg hilhhfrhhomhepphhssehpkhhsrdhimhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from NSJAIL (x4d0b9bff.dyn.telefonica.de [77.11.155.255]) by mail.messagingengine.com (Postfix) with ESMTPA id CCF7ED6005F for ; Wed, 28 Aug 2019 03:10:35 -0400 (EDT) Received: from localhost (10.192.0.11 [10.192.0.11]) by NSJAIL (OpenSMTPD) with ESMTPSA id e21ee48a (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Wed, 28 Aug 2019 07:10:33 +0000 (UTC) From: Patrick Steinhardt To: linux-nfs@vger.kernel.org Cc: Patrick Steinhardt Subject: [PATCH 1/6] Annotate unused fields with UNUSED Date: Wed, 28 Aug 2019 09:10:12 +0200 Message-Id: <724274b0bf9340bc11f6741759ce1e43b82de7be.1566976047.git.ps@pks.im> X-Mailer: git-send-email 2.23.0 In-Reply-To: References: MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org There are some parameters that may be potentially unused. Add the UNUSED macro to avoid any warnings. Signed-off-by: Patrick Steinhardt --- support/misc/xstat.c | 3 ++- support/nfs/rpc_socket.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/support/misc/xstat.c b/support/misc/xstat.c index 4c997eea..661e29e4 100644 --- a/support/misc/xstat.c +++ b/support/misc/xstat.c @@ -9,6 +9,7 @@ #include #include +#include "nfslib.h" #include "xstat.h" #ifdef HAVE_FSTATAT @@ -66,7 +67,7 @@ statx_stat_nosync(int fd, const char *pathname, struct stat *statbuf, int flags) #else static int -statx_stat_nosync(int fd, const char *pathname, struct stat *statbuf, int flags) +statx_stat_nosync(int UNUSED(fd), const char *UNUSED(pathname), struct stat *UNUSED(statbuf), int UNUSED(flags)) { errno = ENOSYS; return -1; diff --git a/support/nfs/rpc_socket.c b/support/nfs/rpc_socket.c index bdf6d2f6..03048feb 100644 --- a/support/nfs/rpc_socket.c +++ b/support/nfs/rpc_socket.c @@ -41,6 +41,7 @@ #include #include "sockaddr.h" +#include "nfslib.h" #include "nfsrpc.h" #ifdef HAVE_LIBTIRPC @@ -519,7 +520,7 @@ CLIENT *nfs_get_priv_rpcclient(const struct sockaddr *sap, * Returns program number of first name to be successfully looked * up, or the default program number if all lookups fail. */ -rpcprog_t nfs_getrpcbyname(const rpcprog_t program, const char *table[]) +rpcprog_t nfs_getrpcbyname(const rpcprog_t program, const char *UNUSED(table[])) { #ifdef HAVE_GETRPCBYNAME struct rpcent *entry; From patchwork Wed Aug 28 07:10:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Steinhardt X-Patchwork-Id: 11117931 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 840B61800 for ; Wed, 28 Aug 2019 07:10:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6364A22DA7 for ; Wed, 28 Aug 2019 07:10:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b="irHN+61c"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="JV5bHNIn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726258AbfH1HKi (ORCPT ); Wed, 28 Aug 2019 03:10:38 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:52107 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726368AbfH1HKi (ORCPT ); Wed, 28 Aug 2019 03:10:38 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EA4A922305 for ; Wed, 28 Aug 2019 03:10:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 28 Aug 2019 03:10:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=0wc7Gau0xii4k Jxb8zXQS3Ds82T+ZIi0Mk5LiRoOcLE=; b=irHN+61c+nPvOs9Drmws7KhUSfqys pma7TlMDLq2X29WnA/JtiN4Zgj9oqjRjoEerVa+Y+GzNPfmlI6BV0I7RfgP4Fdpi PAqpjtI8G0mgEr1Xf5OLH1zfNYhT1Ou8X1fr/3kNdUF61E4TMf45t19FjqG5u+B6 Pbt5pTABtNjlp4WOQ6z65clEw4Uk6Usv13+l7KxsdSSqDyROugYXzeHkQU5v/Ue/ RoPoMg4QH6mE+PtKZbfNhINWd+gFrRQZzUy1m4VVRua3zj/VLjBywtfWO93ao+fO DH6I2fCrTH6HfCQjWbRGSlJUV7pMflzEyzVQCZNpP4ubSPE7ZOqbRd+cA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=0wc7Gau0xii4kJxb8zXQS3Ds82T+ZIi0Mk5LiRoOcLE=; b=JV5bHNIn oWsbfYF9lADngZ4HPIbo1CCd9+8eKWgVN9obxgA1x9KvkCErJDlbILxJY7c1gd9s K5aV/iDzR3argKEKdFjI99rHxKEdBzDJL9PX9GGJU9AbJ8C7T4scwQyCspy+SBga 1WEFAtpaqhzl5cDafEMzdXnEPZ6HzpQh3lm3NP6rf9QaDZrb8NdA1uqXBWD8eVb4 V9UWR3ANkSAziOVzdFvLua3PmqlubkNwKKAFD58u1Jai/wN7WqRfgzL7Q4ZClNbg sNHUBqUgJH5xKlFJUxl3diVQS6NUKROJwhpq/kpUoJ4AoOdke3q2dT1XW2xkGxJF 2Cde9JEhPUfQnA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudehledgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefrrghtrhhitghkucfuthgvihhnhhgrrhguthcuoehpshes phhkshdrihhmqeenucfkphepjeejrdduuddrudehhedrvdehheenucfrrghrrghmpehmrg hilhhfrhhomhepphhssehpkhhsrdhimhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from NSJAIL (x4d0b9bff.dyn.telefonica.de [77.11.155.255]) by mail.messagingengine.com (Postfix) with ESMTPA id 4B70880059 for ; Wed, 28 Aug 2019 03:10:36 -0400 (EDT) Received: from localhost (10.192.0.11 [10.192.0.11]) by NSJAIL (OpenSMTPD) with ESMTPSA id d38a8fcf (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Wed, 28 Aug 2019 07:10:33 +0000 (UTC) From: Patrick Steinhardt To: linux-nfs@vger.kernel.org Cc: Patrick Steinhardt Subject: [PATCH 2/6] Use header instead of Date: Wed, 28 Aug 2019 09:10:13 +0200 Message-Id: <7c8b5df691c0b12c656e0dd8d350f260308dc115.1566976047.git.ps@pks.im> X-Mailer: git-send-email 2.23.0 In-Reply-To: References: MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org While most source files already use the standard header instead of , some do not, causing warnings on musl libc systems. Fix the remaining ones to use . As we already use the header unconditionally in a lot of places, this change should not cause any problems for other platforms. Signed-off-by: Patrick Steinhardt --- support/export/xtab.c | 2 +- support/nfs/rmtab.c | 2 +- support/nfs/svc_socket.c | 2 +- support/nfs/xio.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/support/export/xtab.c b/support/export/xtab.c index 1e1d679e..00b25eaa 100644 --- a/support/export/xtab.c +++ b/support/export/xtab.c @@ -10,7 +10,7 @@ #include #endif -#include +#include #include #include #include diff --git a/support/nfs/rmtab.c b/support/nfs/rmtab.c index 2ecb2cc9..9f03167d 100644 --- a/support/nfs/rmtab.c +++ b/support/nfs/rmtab.c @@ -10,7 +10,7 @@ #include #endif -#include +#include #include #include #include diff --git a/support/nfs/svc_socket.c b/support/nfs/svc_socket.c index 5afc6aa5..2e8fe1af 100644 --- a/support/nfs/svc_socket.c +++ b/support/nfs/svc_socket.c @@ -22,7 +22,7 @@ #include #include #include -#include +#include #include #include "xlog.h" #include "rpcmisc.h" diff --git a/support/nfs/xio.c b/support/nfs/xio.c index e3d27d2f..6962751d 100644 --- a/support/nfs/xio.c +++ b/support/nfs/xio.c @@ -10,7 +10,7 @@ #include #endif -#include +#include #include #include #include From patchwork Wed Aug 28 07:10:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Steinhardt X-Patchwork-Id: 11117927 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1F8EE16B1 for ; Wed, 28 Aug 2019 07:10:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3DAD217F5 for ; Wed, 28 Aug 2019 07:10:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b="Peiew2Vb"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="pgAR5TXx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726292AbfH1HKi (ORCPT ); Wed, 28 Aug 2019 03:10:38 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:47249 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726340AbfH1HKi (ORCPT ); Wed, 28 Aug 2019 03:10:38 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DE0972221C for ; Wed, 28 Aug 2019 03:10:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 28 Aug 2019 03:10:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=8/j+2Y1dbHjza 5Pt5iDd4OimapmgmKN+bPWjskjWaqY=; b=Peiew2VbGGDc0mC5CXn0FranRbf6p HfbgS8XcT3Fz+V7v/gF9986+74ZFQ3OIrfpsVoOh+SZEomXwdziopr/6Y8HH2ooo DqbT8Tmg1/wJK52eD9HGAsGMFfY3QH+/J8SvfHEX7BaepthnjpTvsklUxHOuNuOt OuK69ZPK24fxN3OxYrg3AAra221XPgrIqZYfEzr1tzCXqhKCOvf8rKKZOPArl9ua ZTm0h6MfZCFU+EwJ9NjFj1jsPsDHUpkTGgLX7uw0+23iG4Z1Vh9cUkuWM9NtJzAP kxxZZjoiqqC0xqvoQXlHM8S2f+1ukCAJ8jMC6ikMxCgHuvUnwkfgPmNMw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=8/j+2Y1dbHjza5Pt5iDd4OimapmgmKN+bPWjskjWaqY=; b=pgAR5TXx LsS/ltVSovP/rC6cATg+GstfoBWeG4M3Aus3wYu96J4T5itTRHrqnUqIyPXAE2yX 64xSVvEIoQis9bfmuUXmBmjJqRRnzPvh7D0WNGukeU9BzKR9bVS1BDxDYKVDsSV6 Xy1f13ybmm0a4pZ8mm/loamBwJiap9drpH3ZK3pE4dgdkMM2WrkTDzfVX6G03grM Df/GtHMQU6TLclLH8SPX+QRT8cf3657IyvkkB2QdsyYcE23SyUkVIuKkZOdqRboZ wDTCfGm03I8HerZPA2JqXE4M2LB9avkkiVOYKm1l6k8lkN/mXjQ5Bnq/24r5Vyb9 qJ1gA1Kj63L3Fg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudehledgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefrrghtrhhitghkucfuthgvihhnhhgrrhguthcuoehpshes phhkshdrihhmqeenucfkphepjeejrdduuddrudehhedrvdehheenucfrrghrrghmpehmrg hilhhfrhhomhepphhssehpkhhsrdhimhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from NSJAIL (x4d0b9bff.dyn.telefonica.de [77.11.155.255]) by mail.messagingengine.com (Postfix) with ESMTPA id 54FA8D60062 for ; Wed, 28 Aug 2019 03:10:36 -0400 (EDT) Received: from localhost (10.192.0.11 [10.192.0.11]) by NSJAIL (OpenSMTPD) with ESMTPSA id 7f3c31de (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Wed, 28 Aug 2019 07:10:34 +0000 (UTC) From: Patrick Steinhardt To: linux-nfs@vger.kernel.org Cc: Patrick Steinhardt Subject: [PATCH 3/6] Use header instead of Date: Wed, 28 Aug 2019 09:10:14 +0200 Message-Id: <736b1f0b3f59286150bf6b1eddcc0789c97bd9a9.1566976047.git.ps@pks.im> X-Mailer: git-send-email 2.23.0 In-Reply-To: References: MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org The POSIX standard specifies that poll(3P) should be declared in the header instead of . While there is one location where we use the correct header, two others do not, causing warnings on musl libc systems. Fix the warning by switching from to . As we're already using the latter one already, this change should not cause any problems for other platforms. Signed-off-by: Patrick Steinhardt --- utils/gssd/svcgssd_main_loop.c | 2 +- utils/statd/sm-notify.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/gssd/svcgssd_main_loop.c b/utils/gssd/svcgssd_main_loop.c index b5681ce1..920520d0 100644 --- a/utils/gssd/svcgssd_main_loop.c +++ b/utils/gssd/svcgssd_main_loop.c @@ -34,7 +34,7 @@ #include #include -#include +#include #include #include #include diff --git a/utils/statd/sm-notify.c b/utils/statd/sm-notify.c index abfb8bc7..739731f5 100644 --- a/utils/statd/sm-notify.c +++ b/utils/statd/sm-notify.c @@ -12,7 +12,7 @@ #include #include #include -#include +#include #include #include #include From patchwork Wed Aug 28 07:10:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Steinhardt X-Patchwork-Id: 11117933 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2C2A716B1 for ; Wed, 28 Aug 2019 07:10:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BB3220828 for ; Wed, 28 Aug 2019 07:10:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b="id7RU7DG"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="fIUBwwfs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726340AbfH1HKj (ORCPT ); Wed, 28 Aug 2019 03:10:39 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:58131 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726444AbfH1HKi (ORCPT ); Wed, 28 Aug 2019 03:10:38 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7B8242230F for ; Wed, 28 Aug 2019 03:10:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 28 Aug 2019 03:10:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=ESxHxEDzwGVav JtbQlSYJR8/RFA2T/9kB/XUMsaQgII=; b=id7RU7DGS4ssgUFO/i0CLnTiOdl8g L5suLdZoPAlkLBjZtuNprGtsCgcMXvV8knZcZqPBKCxnhBAs6BLRo4c64C6cx0qi bppNOzgJtL/7Ax6oVvQPkTmvqqJfsuHWdiZdQKEs1KfXc+vFPS/E4lrKZ9goqamt 7uMViGBkltRYiuLOh3UJduAWK+tMV4nf1mOY73t8jg/uADOUwiB9LgIk4j8d+YOC roQ3i5FoOw0FK+jPMfQp6JwqzqzvMUFIZAYg2hxPr2JIlCpi3LxEB6CRDux3eEwo y6yj/L2VN6DCQoCql/KGyvH8+7pCmhqIuSVw/VSNpZm6qm3oVeCnXs54w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=ESxHxEDzwGVavJtbQlSYJR8/RFA2T/9kB/XUMsaQgII=; b=fIUBwwfs +/pqbK3mW3ct/zNU6eHx0bI80uZi65GD19ckfk5W6Lkb7wOsWdD+j0Vi31PL7gIq F8IJslgdU55nSAMk8aaRfWlMgpST7OTmocoGws5o0C/40jmWeiUmdfAA/ZD3b0HK kfBzIueIcUdJ5ijwkdRJHNqNT3kRBLaIeYXAhnCpI/1PxXgyiaPbLpZbx+0Ez7K4 FX7O5YfjyEP9USVSF5A//ex2knLCkic1oqb0V8Dcms3yljT3hVeU4mjLPr282Ox9 ThWTG6wx+Uzyz0fwEikWcB+7JrNRRz+ubpC3gVhtsTuLiCv56/eC31ZMZlqsTEgl 5wNSJhXnjbivCg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudehledgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefrrghtrhhitghkucfuthgvihhnhhgrrhguthcuoehpshes phhkshdrihhmqeenucfkphepjeejrdduuddrudehhedrvdehheenucfrrghrrghmpehmrg hilhhfrhhomhepphhssehpkhhsrdhimhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from NSJAIL (x4d0b9bff.dyn.telefonica.de [77.11.155.255]) by mail.messagingengine.com (Postfix) with ESMTPA id CEE7280060 for ; Wed, 28 Aug 2019 03:10:36 -0400 (EDT) Received: from localhost (10.192.0.11 [10.192.0.11]) by NSJAIL (OpenSMTPD) with ESMTPSA id 5aa33a69 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Wed, 28 Aug 2019 07:10:34 +0000 (UTC) From: Patrick Steinhardt To: linux-nfs@vger.kernel.org Cc: Patrick Steinhardt Subject: [PATCH 4/6] configure.ac: Add header when checking sizeof(socklen_t) Date: Wed, 28 Aug 2019 09:10:15 +0200 Message-Id: <42879dea46c255025fb579dcf7b15335fd77291c.1566976047.git.ps@pks.im> X-Mailer: git-send-email 2.23.0 In-Reply-To: References: MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org We're checking for various sizes in configure.ac, among them the size of the socklen_t type. If socklen_t's size is not found and thus reported to be zero, we will typedef our own socklen_t as "unsigned int". The check for socklen_t is insufficient, though. While the type is declared via , we only search AC_INCLUDES_DEFAULT for its declaration, which doesn't include . On musl libc, this causes us to not find the declaration and redeclare it with an incompatible type. Fix the issue by searching both the default includes as well as . Signed-off-by: Patrick Steinhardt --- configure.ac | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 50002b4a..37096944 100644 --- a/configure.ac +++ b/configure.ac @@ -545,7 +545,10 @@ AC_CHECK_SIZEOF(short) AC_CHECK_SIZEOF(int) AC_CHECK_SIZEOF(long) AC_CHECK_SIZEOF(size_t) -AC_CHECK_SIZEOF(socklen_t) +AC_CHECK_SIZEOF(socklen_t,, [AC_INCLUDES_DEFAULT + #ifdef HAVE_SYS_SOCKET_H + # include + #endif]) dnl ************************************************************* From patchwork Wed Aug 28 07:10:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Steinhardt X-Patchwork-Id: 11117935 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0C6B313B1 for ; Wed, 28 Aug 2019 07:10:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E0FB9217F5 for ; Wed, 28 Aug 2019 07:10:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b="eGyMzw1g"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="MsoIXtvt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726449AbfH1HKn (ORCPT ); Wed, 28 Aug 2019 03:10:43 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:48371 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726446AbfH1HKn (ORCPT ); Wed, 28 Aug 2019 03:10:43 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 76F7822138 for ; Wed, 28 Aug 2019 03:10:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 28 Aug 2019 03:10:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=KlSKOXKRHQHQw +s21VcvqJBsmiq3FmwE2ig1q9YZLCs=; b=eGyMzw1gtb0Wj/78kVXqnBwKPa+WO SO2sbKMGdG6ORMH8e6l9fr+27+aFAXdNEN8wPLUjTdtSu4KShJ0hCXwqNrA7pJ8E HIWuUvZ92+TgWHKKx/TVXPlVw2I7QrwfrbBzXH3LmJwVmNEOOmB55yKx2lVAcQ0k m/egJnoGmDc+V5cHEghaj70dvuuk7oIqhWgirqBmIWTWqY8+QjFQPzUNX7VHlHzU 89aArYye9atzmBswzlMB28Kg0MA5YvyrqKy45Z1Gq+fpySEgeTpjokzzL2psNXTo Q+PO+Ypb7IDVpesn0pNcO15DLXAjx99tGheOn/UJWcLAQzx3eN49BTZaw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=KlSKOXKRHQHQw+s21VcvqJBsmiq3FmwE2ig1q9YZLCs=; b=MsoIXtvt 4uT1v/TIOCjL/FPMwPftXffVwiSm2mD+y2VDhGg00jiyxF5XmTFhR5chV70j6IBr UVDsTXrPByOkP0hhlH+m05CnDqiMaoMY3ORdIXPUfH3unF8OpkypXbfOjBL76PlI vk9XGj/z8GcZFG0RdLT1UdWFbu904f+ketBesVC/xAo4Xv4o9ptiS6twrcs1cDDr nM71omhRBcDu6/kuz2bVoUcqQL8ekde7aC1FPfFX2JnuiptD63A9g7Ksc5K0u8Ik nb/LNRBCauT4p6secgp/faMwBa4eMafBfu6sWqIWngkSvtPIbugFcrnfDndr2jfN K3EVfgA7mCy2DQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudehledgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefrrghtrhhitghkucfuthgvihhnhhgrrhguthcuoehpshes phhkshdrihhmqeenucfkphepjeejrdduuddrudehhedrvdehheenucfrrghrrghmpehmrg hilhhfrhhomhepphhssehpkhhsrdhimhenucevlhhushhtvghrufhiiigvpeeg X-ME-Proxy: Received: from NSJAIL (x4d0b9bff.dyn.telefonica.de [77.11.155.255]) by mail.messagingengine.com (Postfix) with ESMTPA id BFFC380059 for ; Wed, 28 Aug 2019 03:10:41 -0400 (EDT) Received: from localhost (10.192.0.11 [10.192.0.11]) by NSJAIL (OpenSMTPD) with ESMTPSA id a17a34ec (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Wed, 28 Aug 2019 07:10:41 +0000 (UTC) From: Patrick Steinhardt To: linux-nfs@vger.kernel.org Cc: Patrick Steinhardt Subject: [PATCH 5/6] nfsd_path: Include missing header for `struct stat` Date: Wed, 28 Aug 2019 09:10:16 +0200 Message-Id: X-Mailer: git-send-email 2.23.0 In-Reply-To: References: MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org The header "nfsd_path.h" uses `struct stat` in its function signatures, but doesn't include the header. This may cause compiler warnings if a compilation unit includes "nfsd_path.h" while not transitively including . Fix the potential warning by including in the header. Signed-off-by: Patrick Steinhardt --- support/include/nfsd_path.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/support/include/nfsd_path.h b/support/include/nfsd_path.h index ca2570a9..b42416bb 100644 --- a/support/include/nfsd_path.h +++ b/support/include/nfsd_path.h @@ -4,6 +4,8 @@ #ifndef NFSD_PATH_H #define NFSD_PATH_H +#include + void nfsd_path_init(void); const char * nfsd_path_nfsd_rootdir(void); From patchwork Wed Aug 28 07:10:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Steinhardt X-Patchwork-Id: 11117937 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7820616B1 for ; Wed, 28 Aug 2019 07:10:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5839F217F5 for ; Wed, 28 Aug 2019 07:10:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b="QcY9zZnA"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="IUIIfc77" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726450AbfH1HKv (ORCPT ); Wed, 28 Aug 2019 03:10:51 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:57701 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726446AbfH1HKv (ORCPT ); Wed, 28 Aug 2019 03:10:51 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 863E62232A for ; Wed, 28 Aug 2019 03:10:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 28 Aug 2019 03:10:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=kB7M3jDMSMxJZ qvcCqIBAjbh3jTGK0mCRBhq2OIwRCo=; b=QcY9zZnAAYTv9W22kk/Knjvp+6Dmh AUMDnWul+hK/f0crF9Hec6l/2BPIWtf5coerdOcQiFWYnuvu5kWaSiMgHXXEPZy2 2iiCyZJb0JteVgKAlvKm3Aq9VQoX5I//r7mQnhKihqrjA2hwi6pJxK+WuMiYpF37 vg9W55GR+LIYco+eYFPIEEohhqLSKLWINTKRExxIDPWfbRiBVqwpK/hkRPN9KJ4e JwbM9T6xskh/ik+yBU1TQmYDJxh8Y6SDyr9sTInSrQKF0XDqRaV5QDDM+ypQ8dni A3wwhhOIoShQTBwn7pHJHHjFnl1VIXZi0/3BXxlBr2tjiKXgDAGbFQv1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=kB7M3jDMSMxJZqvcCqIBAjbh3jTGK0mCRBhq2OIwRCo=; b=IUIIfc77 0ZpMl4lEUPaCQ1KAzWdi17LRhue1VJaTy4xqUqxIxjqfkjht/IRXqDV1YVgrr1zO pZHZe/IztEGKW4SkBb9YUGJQI5M9d6hxsbT9LFb2szuhYRLDAwVZMVelzhPHoZyf HZDtkIOYMv7tgKGga6T58P4OAXgA3kC8iMTwmTa0y55wmASVrPOKUmEzDkVSNcGn nLIw9oBV/TtjCZ2QiPkhEa/MGzgqxiLwvP1EvxQ19XCWxM0qSljv2hXNq9V3eePt Zz9jZrxdpG90D6oXdHId+n+A2kHUjjutltDBn3r7C+UxdBI1RC6uLe/YzofbTKoQ GuyPp2nphwV/vQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudehledgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefrrghtrhhitghkucfuthgvihhnhhgrrhguthcuoehpshes phhkshdrihhmqeenucfkphepjeejrdduuddrudehhedrvdehheenucfrrghrrghmpehmrg hilhhfrhhomhepphhssehpkhhsrdhimhenucevlhhushhtvghrufhiiigvpeeh X-ME-Proxy: Received: from NSJAIL (x4d0b9bff.dyn.telefonica.de [77.11.155.255]) by mail.messagingengine.com (Postfix) with ESMTPA id D50658005C for ; Wed, 28 Aug 2019 03:10:49 -0400 (EDT) Received: from localhost (10.192.0.11 [10.192.0.11]) by NSJAIL (OpenSMTPD) with ESMTPSA id b81197bb (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Wed, 28 Aug 2019 07:10:49 +0000 (UTC) From: Patrick Steinhardt To: linux-nfs@vger.kernel.org Cc: Patrick Steinhardt Subject: [PATCH 6/6] mountd: Use unsigned for filesystem type magic constants Date: Wed, 28 Aug 2019 09:10:17 +0200 Message-Id: <6ca3eb041a455eb0d37ee359e9831fe5a8605a2f.1566976047.git.ps@pks.im> X-Mailer: git-send-email 2.23.0 In-Reply-To: References: MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org The filesystem type magic constants are all unsigned integers, but we declare them as signed ones. This may cause a compiler warning when comparing our own signed magic constants with the unsigned ones return by statfs64(3). Fix the issue by uniformly usign unsigned types. Signed-off-by: Patrick Steinhardt --- utils/mountd/cache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c index ecda18c7..6cfa0549 100644 --- a/utils/mountd/cache.c +++ b/utils/mountd/cache.c @@ -302,7 +302,7 @@ static int get_uuid(const char *val, size_t uuidlen, char *u) * we generate the identifier from statfs->f_fsid. The rest are network or * pseudo filesystems. (See for the basic IDs.) */ -static const long int nonblkid_filesystems[] = { +static const unsigned long nonblkid_filesystems[] = { 0x2fc12fc1, /* ZFS_SUPER_MAGIC */ 0x9123683E, /* BTRFS_SUPER_MAGIC */ 0xFF534D42, /* CIFS_MAGIC_NUMBER */ @@ -355,7 +355,7 @@ static int uuid_by_path(char *path, int type, size_t uuidlen, char *uuid) rc = statfs64(path, &st); if (type == 0 && rc == 0) { - const long int *bad; + const unsigned long *bad; for (bad = nonblkid_filesystems; *bad; bad++) { if (*bad == st.f_type) break;