From patchwork Mon Sep 2 12:33:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Richter X-Patchwork-Id: 11126553 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9BA1E1398 for ; Mon, 2 Sep 2019 12:34:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69C8520820 for ; Mon, 2 Sep 2019 12:34:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="scS0ZnFG"; dkim=pass (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="jRKbkhBF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731653AbfIBMd6 (ORCPT ); Mon, 2 Sep 2019 08:33:58 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:60692 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729999AbfIBMd5 (ORCPT ); Mon, 2 Sep 2019 08:33:57 -0400 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x82CVK3X025478; Mon, 2 Sep 2019 05:33:44 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=tRVRI0/pFRdhX0JXwAZAaofoYmWAvzqvKh/DaExNszc=; b=scS0ZnFGwuSJMP4lgDYlBOrcVrbdOCcHHp6pEOIuPW5g81t9lsbgSpTgk1ceH6jf3eEE d0r6dzoBcfAZVM7s8qNqoBs3h9j33MWSNLz4Hdx4m3DEuuEn5651qyO4RjQbAVYl25Qp d9+seRKDjSGAFvBuUGUfk9TVkj7sj5cFxXeyxc+oJosjT9y/pVKHe+sYaKoLzwIk1ML3 6zgrTxyOPcoz1x5ukqobF6UKPnrcR38NX1+cGGeZ+F37LYvGVhUkCknc5gCLzOdELQbz zqE++gjqEjUcs/5b0mhJMYe72uTDpH43ShG5aqRruCuknQRoLlxiRAsAdlTr8MEVvmSd Ww== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2uqp8p6jh8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 02 Sep 2019 05:33:44 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 2 Sep 2019 05:33:42 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.52) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 2 Sep 2019 05:33:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oPcsxi0Thq9iGxL9L+B+tDFY9aHYSm2JLZU0ooPxmFN4MoH7anDRB6Jv/QVu/dfue3pugaHpNa4lgeZ3Wk7fMjDPHr9DpcFh1ZYQQCvNsICAFHfZW1z91eoZmU8J+BUyUMZON/nHhvYVBKxPCh71MeG2oWUEE98OqJngPCxxwcJIai95LgTDZxSOZ7JMiIoxkRQUezo/kfI4bbv8jUoXafC3EEadM8vyfzjHG53RvASkYewG+6uWo83iVaVJ7zeOfHgHVMpVIwi25Y+GvexySPL0nI/7pxFVqnzl5WMDcCLtuUoEubI7utHUaohGb+JX+vPzFAH610SZwp6yRTGODw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tRVRI0/pFRdhX0JXwAZAaofoYmWAvzqvKh/DaExNszc=; b=a/beXXcFKhE7f8fPcT08hA05BfU3pq2Orxu/9VNMG6MU2Wbsnr+AFuFnV1WgJmxoWs7DnWSI6yZgUSlN1oJR9N4tpgt6D9yca8OSXpyNSW6BNtbEHMswjwCvCuaKj4/dwX+6d0sh4q1c57av4WoSH7Q9ky3zPHOn0pkTg78JKL5bJMyYJcJzjYuttMQN7XCKbsDNfbdANRZAWAiOXfU7xQttzHqP986hvAf4bJSqfpn7AemSRdJranE2ru9bp5/L8/OOIxuk7i3f5ILIZSiPDg919nY9RPqhWORKCQdOSU7qrwePFSWpeDaRDBufQ4YjJ8EiqGvajOuxL6jMfUzmPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tRVRI0/pFRdhX0JXwAZAaofoYmWAvzqvKh/DaExNszc=; b=jRKbkhBFsUD7bzm3pAR9rI2S+1DNz2CDCbIqZwifLtv+DlwldlxMOTvv1OFHUthXz0W0G7GXo1GTFFS+0Ss8AY6tejaZwdozjwMYW6XB0d5JF+/YJkKLNXajRFRPaPFXIbguU+XNs8549+DaSFxO3vUEcMnnZnwZMHOQZg2x6Ss= Received: from MN2PR18MB3408.namprd18.prod.outlook.com (10.255.238.217) by MN2PR18MB2480.namprd18.prod.outlook.com (20.179.82.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.20; Mon, 2 Sep 2019 12:33:41 +0000 Received: from MN2PR18MB3408.namprd18.prod.outlook.com ([fe80::8162:62e8:aeeb:ec7b]) by MN2PR18MB3408.namprd18.prod.outlook.com ([fe80::8162:62e8:aeeb:ec7b%3]) with mapi id 15.20.2220.013; Mon, 2 Sep 2019 12:33:41 +0000 From: Robert Richter To: Borislav Petkov , Mauro Carvalho Chehab , Tony Luck CC: Robert Richter , James Morse , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH 1/5] EDAC: Prefer 'unsigned int' to bare use of 'unsigned' Thread-Topic: [PATCH 1/5] EDAC: Prefer 'unsigned int' to bare use of 'unsigned' Thread-Index: AQHVYYqm1RQO00AiRUWPRAcGKd4KJA== Date: Mon, 2 Sep 2019 12:33:41 +0000 Message-ID: <20190902123216.9809-2-rrichter@marvell.com> References: <20190902123216.9809-1-rrichter@marvell.com> In-Reply-To: <20190902123216.9809-1-rrichter@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1PR07CA0027.eurprd07.prod.outlook.com (2603:10a6:7:66::13) To MN2PR18MB3408.namprd18.prod.outlook.com (2603:10b6:208:16c::25) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [31.208.96.227] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2934de7e-0404-45de-7b5e-08d72fa1c93b x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:MN2PR18MB2480; x-ms-traffictypediagnostic: MN2PR18MB2480: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-forefront-prvs: 01480965DA x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(346002)(376002)(39850400004)(396003)(136003)(366004)(199004)(189003)(6486002)(8676002)(186003)(110136005)(81166006)(81156014)(71190400001)(66066001)(6506007)(386003)(1076003)(71200400001)(26005)(6512007)(53936002)(256004)(478600001)(50226002)(54906003)(86362001)(36756003)(8936002)(14444005)(52116002)(66556008)(66476007)(486006)(5660300002)(64756008)(66446008)(11346002)(2616005)(4326008)(316002)(476003)(2906002)(7736002)(76176011)(6436002)(305945005)(6116002)(3846002)(99286004)(102836004)(14454004)(446003)(66946007)(25786009);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB2480;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: WoyrlOI1nIdh/0ZbKZJwnEstJ9INJ0t1TpxO/RxLGg3zhx7++2XqsRhhrWVTR7LT9nMWHo22cbRJlBBRg80LDtJbQJecanpXmy2JqwcsVeyJNQDyIAdVsnGCcDcVRLhIAgGGD5vpetN2v9/D1ghWWVudBdJeikWLUJG+Gi0QToV/5wUwjhl/7UY8DfqdxRfGMfeK47yosQeQDKfECwsbzWy1ObefjtxLP4UBqkzFQ0u31Y3MXYxnUUNpqgJYn6vl6zi0CCKx+qUiEinN13A6YMm/oWaXTrHtejEneQizEZFRMjjXMOjHKQnWpoMZmXxK1h6G0kfzOfOYbOmZEWS3xbk2kJLDr11E1cC2Ca1tOdB8f5bGe7hLq6E9dFppaM5d4epw3+H8H+7LZ7sgWP0EOp0lClWnOXvFDR+/HRwnVJU= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2934de7e-0404-45de-7b5e-08d72fa1c93b X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2019 12:33:41.2541 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xNKwfGS5tDrlhq3I9Z+FyuLU9QfecY78FVYietclZ/03tgP5ZEoOSJvPqG9OFG6yhLX1B1aifXgDxvBnvO8FpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2480 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-02_04:2019-08-29,2019-09-02 signatures=0 Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org Use of 'unsigned int' instead of bare use of 'unsigned'. Fix this for edac_mc*, ghes and the i5100 driver. Depending on the compiler's warning level it can throw messages like this: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #235: FILE: drivers/edac/i5100_edac.c:854: + const unsigned chan = i5100_csrow_to_chan(mci, dimm->idx); Signed-off-by: Robert Richter --- drivers/edac/edac_mc.c | 20 ++++++++++---------- drivers/edac/edac_mc.h | 6 +++--- drivers/edac/edac_mc_sysfs.c | 6 +++--- drivers/edac/ghes_edac.c | 2 +- drivers/edac/i5100_edac.c | 16 +++++++++------- include/linux/edac.h | 10 +++++----- 6 files changed, 31 insertions(+), 29 deletions(-) diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c index c68f62ab54b0..2f1e3ec8e1cc 100644 --- a/drivers/edac/edac_mc.c +++ b/drivers/edac/edac_mc.c @@ -114,8 +114,8 @@ static const struct kernel_param_ops edac_report_ops = { module_param_cb(edac_report, &edac_report_ops, &edac_report, 0644); -unsigned edac_dimm_info_location(struct dimm_info *dimm, char *buf, - unsigned len) +unsigned int edac_dimm_info_location(struct dimm_info *dimm, char *buf, + unsigned int len) { struct mem_ctl_info *mci = dimm->mci; int i, n, count = 0; @@ -236,9 +236,9 @@ EXPORT_SYMBOL_GPL(edac_mem_types); * At return, the pointer 'p' will be incremented to be used on a next call * to this function. */ -void *edac_align_ptr(void **p, unsigned size, int n_elems) +void *edac_align_ptr(void **p, unsigned int size, int n_elems) { - unsigned align, r; + unsigned int align, r; void *ptr = *p; *p += size * n_elems; @@ -302,10 +302,10 @@ static void _edac_mc_free(struct mem_ctl_info *mci) kfree(mci); } -struct mem_ctl_info *edac_mc_alloc(unsigned mc_num, - unsigned n_layers, +struct mem_ctl_info *edac_mc_alloc(unsigned int mc_num, + unsigned int n_layers, struct edac_mc_layer *layers, - unsigned sz_pvt) + unsigned int sz_pvt) { struct mem_ctl_info *mci; struct edac_mc_layer *layer; @@ -313,9 +313,9 @@ struct mem_ctl_info *edac_mc_alloc(unsigned mc_num, struct rank_info *chan; struct dimm_info *dimm; u32 *ce_per_layer[EDAC_MAX_LAYERS], *ue_per_layer[EDAC_MAX_LAYERS]; - unsigned pos[EDAC_MAX_LAYERS]; - unsigned size, tot_dimms = 1, count = 1; - unsigned tot_csrows = 1, tot_channels = 1, tot_errcount = 0; + unsigned int pos[EDAC_MAX_LAYERS]; + unsigned int size, tot_dimms = 1, count = 1; + unsigned int tot_csrows = 1, tot_channels = 1, tot_errcount = 0; void *pvt, *p, *ptr = NULL; int i, j, row, chn, n, len, off; bool per_rank = false; diff --git a/drivers/edac/edac_mc.h b/drivers/edac/edac_mc.h index 4165e15995ad..02aac5c61d00 100644 --- a/drivers/edac/edac_mc.h +++ b/drivers/edac/edac_mc.h @@ -122,10 +122,10 @@ do { \ * On success, return a pointer to struct mem_ctl_info pointer; * %NULL otherwise */ -struct mem_ctl_info *edac_mc_alloc(unsigned mc_num, - unsigned n_layers, +struct mem_ctl_info *edac_mc_alloc(unsigned int mc_num, + unsigned int n_layers, struct edac_mc_layer *layers, - unsigned sz_pvt); + unsigned int sz_pvt); /** * edac_get_owner - Return the owner's mod_name of EDAC MC diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 4386ea4b9b5a..640b9419623e 100644 --- a/drivers/edac/edac_mc_sysfs.c +++ b/drivers/edac/edac_mc_sysfs.c @@ -200,7 +200,7 @@ static ssize_t channel_dimm_label_show(struct device *dev, char *data) { struct csrow_info *csrow = to_csrow(dev); - unsigned chan = to_channel(mattr); + unsigned int chan = to_channel(mattr); struct rank_info *rank = csrow->channels[chan]; /* if field has not been initialized, there is nothing to send */ @@ -216,7 +216,7 @@ static ssize_t channel_dimm_label_store(struct device *dev, const char *data, size_t count) { struct csrow_info *csrow = to_csrow(dev); - unsigned chan = to_channel(mattr); + unsigned int chan = to_channel(mattr); struct rank_info *rank = csrow->channels[chan]; size_t copy_count = count; @@ -240,7 +240,7 @@ static ssize_t channel_ce_count_show(struct device *dev, struct device_attribute *mattr, char *data) { struct csrow_info *csrow = to_csrow(dev); - unsigned chan = to_channel(mattr); + unsigned int chan = to_channel(mattr); struct rank_info *rank = csrow->channels[chan]; return sprintf(data, "%u\n", rank->ce_count); diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c index 7f19f1c672c3..d413a0bdc9ad 100644 --- a/drivers/edac/ghes_edac.c +++ b/drivers/edac/ghes_edac.c @@ -68,7 +68,7 @@ struct memdev_dmi_entry { struct ghes_edac_dimm_fill { struct mem_ctl_info *mci; - unsigned count; + unsigned int count; }; static void ghes_edac_count_dimms(const struct dmi_header *dh, void *arg) diff --git a/drivers/edac/i5100_edac.c b/drivers/edac/i5100_edac.c index b506eef6b146..251f2b692785 100644 --- a/drivers/edac/i5100_edac.c +++ b/drivers/edac/i5100_edac.c @@ -417,7 +417,8 @@ static const char *i5100_err_msg(unsigned err) } /* convert csrow index into a rank (per channel -- 0..5) */ -static int i5100_csrow_to_rank(const struct mem_ctl_info *mci, int csrow) +static unsigned int i5100_csrow_to_rank(const struct mem_ctl_info *mci, + unsigned int csrow) { const struct i5100_priv *priv = mci->pvt_info; @@ -425,7 +426,8 @@ static int i5100_csrow_to_rank(const struct mem_ctl_info *mci, int csrow) } /* convert csrow index into a channel (0..1) */ -static int i5100_csrow_to_chan(const struct mem_ctl_info *mci, int csrow) +static unsigned int i5100_csrow_to_chan(const struct mem_ctl_info *mci, + unsigned int csrow) { const struct i5100_priv *priv = mci->pvt_info; @@ -653,11 +655,11 @@ static struct pci_dev *pci_get_device_func(unsigned vendor, return ret; } -static unsigned long i5100_npages(struct mem_ctl_info *mci, int csrow) +static unsigned long i5100_npages(struct mem_ctl_info *mci, unsigned int csrow) { struct i5100_priv *priv = mci->pvt_info; - const unsigned chan_rank = i5100_csrow_to_rank(mci, csrow); - const unsigned chan = i5100_csrow_to_chan(mci, csrow); + const unsigned int chan_rank = i5100_csrow_to_rank(mci, csrow); + const unsigned int chan = i5100_csrow_to_chan(mci, csrow); unsigned addr_lines; /* dimm present? */ @@ -852,8 +854,8 @@ static void i5100_init_csrows(struct mem_ctl_info *mci) for (i = 0; i < mci->tot_dimms; i++) { struct dimm_info *dimm; const unsigned long npages = i5100_npages(mci, i); - const unsigned chan = i5100_csrow_to_chan(mci, i); - const unsigned rank = i5100_csrow_to_rank(mci, i); + const unsigned int chan = i5100_csrow_to_chan(mci, i); + const unsigned int rank = i5100_csrow_to_rank(mci, i); if (!npages) continue; diff --git a/include/linux/edac.h b/include/linux/edac.h index 342dabda9c7e..c19483b90079 100644 --- a/include/linux/edac.h +++ b/include/linux/edac.h @@ -440,7 +440,7 @@ struct dimm_info { char label[EDAC_MC_LABEL_LEN + 1]; /* DIMM label on motherboard */ /* Memory location data */ - unsigned location[EDAC_MAX_LAYERS]; + unsigned int location[EDAC_MAX_LAYERS]; struct mem_ctl_info *mci; /* the parent */ @@ -451,7 +451,7 @@ struct dimm_info { u32 nr_pages; /* number of pages on this dimm */ - unsigned csrow, cschannel; /* Points to the old API data */ + unsigned int csrow, cschannel; /* Points to the old API data */ u16 smbios_handle; /* Handle for SMBIOS type 17 */ }; @@ -597,7 +597,7 @@ struct mem_ctl_info { unsigned long page); int mc_idx; struct csrow_info **csrows; - unsigned nr_csrows, num_cschannel; + unsigned int nr_csrows, num_cschannel; /* * Memory Controller hierarchy @@ -608,14 +608,14 @@ struct mem_ctl_info { * of the recent drivers enumerate memories per DIMM, instead. * When the memory controller is per rank, csbased is true. */ - unsigned n_layers; + unsigned int n_layers; struct edac_mc_layer *layers; bool csbased; /* * DIMM info. Will eventually remove the entire csrows_info some day */ - unsigned tot_dimms; + unsigned int tot_dimms; struct dimm_info **dimms; /* From patchwork Mon Sep 2 12:33:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Richter X-Patchwork-Id: 11126555 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A98ED1398 for ; Mon, 2 Sep 2019 12:34:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 806D121881 for ; Mon, 2 Sep 2019 12:34:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="y4oVkVxZ"; dkim=pass (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="TPPJWO+K" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731239AbfIBMd5 (ORCPT ); Mon, 2 Sep 2019 08:33:57 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:40270 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731634AbfIBMd5 (ORCPT ); Mon, 2 Sep 2019 08:33:57 -0400 Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x82CUiGn029652; Mon, 2 Sep 2019 05:33:47 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=b4H7jvs/togG3+26Ds/1XqTEtiHB5CxN8IOMuJN/PBo=; b=y4oVkVxZ7+oIYj9pcUjoDOHfaTkDqf4EEVIscH1ET3KyFxXSR3MXtiO1TDhV+8rRi3gg N4U/cjYRWq9wgv5eXD3T3F9DuohOfSxwkMYjqn6oTJLjs4cOu3umUihTgu7d1oGBNnvQ +Rb80mZjWkFTk5PZQpdbNxo4z0eYPX9gJt0hZSWk2WHqzMucUkE7ZkvuyIbz/kvUtkhG B0JbcCbtRGkyIFKwryeIVfyMJ/c/UBENG0/WhKRYdoWMIV+BEwvlONsP2kJV+56udZBg zRhTtuRT42LXPp8ICoWDz3Q8kElUxtMcp2Ll3T6NZNTZbBMkUbLNXOFYCIptqJHKN3o8 7Q== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2uqrdm6038-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 02 Sep 2019 05:33:46 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 2 Sep 2019 05:33:44 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.57) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 2 Sep 2019 05:33:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FJ8IK76AaNDEDq0bdPHC0MdZtXZc17mBTsSxs2GifHP2xYFXdLPE+SLFl5HtaRsc0U5hlePYv92vf0Y+Jp0/RP9pLma9UGLcYXHJ4xaTTNAZWUcnnQGCMFnI0PGq8CGI3JZbZ+D5GFsdEjOxqIPRHTv9WS34ib85/k24Vc8emafBae3V0OV/x9fxPIvU88elbuGLzb1YlTVwyeBB9jQU4wTRJ7TRMQljUXmy8V9NlTQxgMW2u2Ezfp88N0qncUx5JgKmsN1LOrewZYqsS0KZKErJ6hYGap3Ejfk2OS8Lo5symVM2HroIUHPkxJsm9x0oOpvBc+NKl1IrF8wSrnb8ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b4H7jvs/togG3+26Ds/1XqTEtiHB5CxN8IOMuJN/PBo=; b=FaIGAQy+J2lg8/v89bqdc6pFUnN26At9W+tGOnrNdo161GvGPdi8uFboMXv+LRvRFtzkX5derVOfyLwA/wqJtg0XjisUJArIBioAF/rXQDZesZjN1STtuI70wWNemfenHPeln8VVSstIj4pkdO4nYtQRy6R547X/fAU68NinykHrMzZyTNSoXZDz349x5KrgAAAkp/8lT5mv/P3MaAMHSRw/rb+1Ktvfnd/5GVM8cXCRgqPO8xeFte69HM7auj+h9vvYFdKSDiQrBsa1ntonR5bOcjuYvm3PzlSWmds86Vi0C8g5ZOXcAnf502EIm9R+HYex/z4EviNSJHDVTPq0qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b4H7jvs/togG3+26Ds/1XqTEtiHB5CxN8IOMuJN/PBo=; b=TPPJWO+K2YmJuXIQySizy7VWquG9YLBK5tB3mUF2dGfSaeDg0oUrnhrtyRK6PwQiyYaoNP2xsPWaQheJGuto4EdKhjyI+DEIxBNBCtDgyMfqdbvNGWfufSG19OA0h4PNxpA+1iLPNBfXRtYs8OGss5Bt6/vA1N7ut3Of1el7aU4= Received: from MN2PR18MB3408.namprd18.prod.outlook.com (10.255.238.217) by MN2PR18MB2480.namprd18.prod.outlook.com (20.179.82.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.20; Mon, 2 Sep 2019 12:33:43 +0000 Received: from MN2PR18MB3408.namprd18.prod.outlook.com ([fe80::8162:62e8:aeeb:ec7b]) by MN2PR18MB3408.namprd18.prod.outlook.com ([fe80::8162:62e8:aeeb:ec7b%3]) with mapi id 15.20.2220.013; Mon, 2 Sep 2019 12:33:43 +0000 From: Robert Richter To: Borislav Petkov , Mauro Carvalho Chehab , Tony Luck CC: Robert Richter , James Morse , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH 2/5] EDAC, mc_sysfs: Change dev_ch_attribute->channel to unsigned int Thread-Topic: [PATCH 2/5] EDAC, mc_sysfs: Change dev_ch_attribute->channel to unsigned int Thread-Index: AQHVYYqoelFrxSu3pkCoThr/UzCw6g== Date: Mon, 2 Sep 2019 12:33:43 +0000 Message-ID: <20190902123216.9809-3-rrichter@marvell.com> References: <20190902123216.9809-1-rrichter@marvell.com> In-Reply-To: <20190902123216.9809-1-rrichter@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1PR07CA0027.eurprd07.prod.outlook.com (2603:10a6:7:66::13) To MN2PR18MB3408.namprd18.prod.outlook.com (2603:10b6:208:16c::25) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [31.208.96.227] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8a5a06b4-4ed7-40ff-16ce-08d72fa1ca7f x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:MN2PR18MB2480; x-ms-traffictypediagnostic: MN2PR18MB2480: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:510; x-forefront-prvs: 01480965DA x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(346002)(376002)(39850400004)(396003)(136003)(366004)(199004)(189003)(6486002)(8676002)(186003)(110136005)(81166006)(81156014)(71190400001)(66066001)(6506007)(386003)(1076003)(71200400001)(26005)(6512007)(4744005)(53936002)(256004)(478600001)(50226002)(54906003)(86362001)(36756003)(8936002)(14444005)(52116002)(66556008)(66476007)(486006)(5660300002)(64756008)(66446008)(11346002)(2616005)(4326008)(316002)(476003)(2906002)(7736002)(76176011)(6436002)(305945005)(6116002)(3846002)(99286004)(102836004)(14454004)(446003)(66946007)(25786009);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB2480;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: f++YGtZrtZ4HxfzSd5PROVdEKToYtqaTMw8FN+q16eolOZq/cgsLZzXg7J5WNDC5mZo18muXFEJBHW7OR/qP4VTN1b2qWctn1skCzob+iazGVcageAlaj6bxRcYPvD8jYIIJTmbdBDtyO//V44HnErrGUo0iPTSiNqhzCb7CgKXcvC8WcOWm46H2Y5K+dY8Ljh0jPbuvryTswnSAlukDofQ0kP+sUZ+1PUE43i8mFnAYctd7gsgaOhjAvTULhg2JOCfZT12EhlDi6XtoogLJdDF/3ZTfS+iWl/1WYRNFYgU3L8ClxA6qvy0K7wE16eiFLfkbzNaJa5ePlNDUYzPvyDJgXBqvDDOQvdhLwNUsaCffeIF/E4h0KAOiKV8pTKyU6yAyfrDlogUMvvTiQcyrj4S8uq/gDth10xvTd9EZN7I= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8a5a06b4-4ed7-40ff-16ce-08d72fa1ca7f X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2019 12:33:43.2779 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8m3m5jI2bbcRrzPMReQm7dSj4F3T+/onN0iLquWe7PKhKjk3uiZN5WoRatQ7IFREbBgTxt6T3X0+m8+8Fekigg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2480 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-02_04:2019-08-29,2019-09-02 signatures=0 Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org Struct member dev_ch_attribute->channel is always used as unsigned int. Change type to unsigned int to avoid type casts. Signed-off-by: Robert Richter --- drivers/edac/edac_mc_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 640b9419623e..4eb8c5ceb973 100644 --- a/drivers/edac/edac_mc_sysfs.c +++ b/drivers/edac/edac_mc_sysfs.c @@ -131,7 +131,7 @@ static const char * const edac_caps[] = { struct dev_ch_attribute { struct device_attribute attr; - int channel; + unsigned int channel; }; #define DEVICE_CHANNEL(_name, _mode, _show, _store, _var) \ From patchwork Mon Sep 2 12:33:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Richter X-Patchwork-Id: 11126557 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B7FE614F7 for ; Mon, 2 Sep 2019 12:34:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9025C20820 for ; Mon, 2 Sep 2019 12:34:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="uH7TfZw9"; dkim=pass (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="KD6arz5p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731639AbfIBMd5 (ORCPT ); Mon, 2 Sep 2019 08:33:57 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:4330 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730628AbfIBMd5 (ORCPT ); Mon, 2 Sep 2019 08:33:57 -0400 Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x82CUiGp029652; Mon, 2 Sep 2019 05:33:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=q+UcsD8AVJ2yD4QdTpH5jA/xu0OUWHpb/y8uAIk8s68=; b=uH7TfZw9MChh4IMaSpbFwDUsQ6Pfj4/W87Yws3/du9h4oXPl48Dd/mSckexyi9curGGe z0gbHQ9tXSzrL8UHXW33uEwy2fxK+lL0Th2jVTMkACxox5G3cdH058t6UvDAP2SdkQ2f m+WxD2d8V7MRv/8WvZux6HQRuJXsjxBJPELo6yzAVZ8057VBIKIsXZoNT2a3du1TheE8 L+z9LSRfR19dK0FAVjlva2KJYnhjiiXFCLVCYbdaD1c+tTxknRqN5Yysy3YTARerRhdM u2gdkuWhVoUdhV1YHufUYuKIdgQp9KI1kuOJqnjO4RmSnpYjNImXRkDUz+tlQW6mt1Zl GA== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2uqrdm603b-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 02 Sep 2019 05:33:49 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 2 Sep 2019 05:33:46 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.51) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 2 Sep 2019 05:33:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fh4Bxq5c2UexNaPKIZCCyFLH7Y1aifXekWglF0cOOCVdDZ3zf5l5+14zvzXSCtvBMLDzSf28+yFYezN+evc9nXYH78btJ1QD1TqdI3Ox2MpnCl+Ycgrzm7sEobgoW1pLiXPdBFSKvlxSv3zXNjahGfm79G0mR+Oq8EaV2caL9TXwETd/JXjW85xt3gtSuK+WRJVCN+3XcxCUtp/ede+r37jO4G7MeTvGxC2kXun3kXUnGwrhu723BjhH1BpFDIGbSzChjdpFPnSSQEWyt9I6wRk/9blRGKNJfNGOyrlpxCrodGT9Uwl3HGerlKeS6MjC0G6BbSpCs8QPVATqPkDT1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q+UcsD8AVJ2yD4QdTpH5jA/xu0OUWHpb/y8uAIk8s68=; b=HeZCymd4TksqxOQtVoRdObWYtq3TGHvedO6WZKVuoY4+nPvHjs8aY0KmgYEUrz76xL46NhvE5cbCAgcTm6nGIetUH4iIXxgRHAGTgLphNqIgzZlh+gZAYqRZMsgg6xzR8K76I2Gc/S+mA/vbIzbKoQuprl56vC57uWOESu3rhC28/woh4SndsWb2+wAOSqc+/CKqIKbQKMucUhQ76je8AA8y3pxAaW9k7GCYXfV6BcN4vnBmhUpS13ycoAeEVEZbpGYAzwzYzFVFkY4a1KAAk3FtHEyXgMFkuiuqdT7sUzpJtkcffmVtgdIM7Z47+K3ZkR7ds0k7pBJw0m2Ciq55Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q+UcsD8AVJ2yD4QdTpH5jA/xu0OUWHpb/y8uAIk8s68=; b=KD6arz5pfDr7GufXAhRVRz3Nns3QhODeZjHxv9UF8HJPE5IFQPTI6Of34Pvoh6kDL7m4LksjlFCkIeUEMOEDrk+OuLXcz6de+SKo1j2kE2Ny7Tjar45Z4PWpgdIN90WO3mbPQS3DE7i4akwY5rOFBNHmXZGwO2e66SPIWV+QaeQ= Received: from MN2PR18MB3408.namprd18.prod.outlook.com (10.255.238.217) by MN2PR18MB2480.namprd18.prod.outlook.com (20.179.82.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.20; Mon, 2 Sep 2019 12:33:45 +0000 Received: from MN2PR18MB3408.namprd18.prod.outlook.com ([fe80::8162:62e8:aeeb:ec7b]) by MN2PR18MB3408.namprd18.prod.outlook.com ([fe80::8162:62e8:aeeb:ec7b%3]) with mapi id 15.20.2220.013; Mon, 2 Sep 2019 12:33:45 +0000 From: Robert Richter To: Borislav Petkov , Mauro Carvalho Chehab , Tony Luck CC: Robert Richter , James Morse , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH 3/5] EDAC, mc_sysfs: Remove pointless gotos Thread-Topic: [PATCH 3/5] EDAC, mc_sysfs: Remove pointless gotos Thread-Index: AQHVYYqpgvER4zlKe0KU5vpskR3bNg== Date: Mon, 2 Sep 2019 12:33:45 +0000 Message-ID: <20190902123216.9809-4-rrichter@marvell.com> References: <20190902123216.9809-1-rrichter@marvell.com> In-Reply-To: <20190902123216.9809-1-rrichter@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1PR07CA0027.eurprd07.prod.outlook.com (2603:10a6:7:66::13) To MN2PR18MB3408.namprd18.prod.outlook.com (2603:10b6:208:16c::25) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [31.208.96.227] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7b02db0a-334c-4ac2-f2df-08d72fa1cbc8 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:MN2PR18MB2480; x-ms-traffictypediagnostic: MN2PR18MB2480: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:82; x-forefront-prvs: 01480965DA x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(346002)(376002)(39850400004)(396003)(136003)(366004)(199004)(189003)(6486002)(8676002)(186003)(110136005)(81166006)(81156014)(71190400001)(66066001)(6506007)(386003)(1076003)(71200400001)(26005)(6512007)(53936002)(256004)(478600001)(50226002)(54906003)(86362001)(36756003)(8936002)(14444005)(52116002)(66556008)(66476007)(486006)(5660300002)(64756008)(66446008)(11346002)(2616005)(4326008)(316002)(476003)(2906002)(7736002)(76176011)(6436002)(305945005)(6116002)(3846002)(99286004)(102836004)(14454004)(446003)(66946007)(25786009);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB2480;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: uAkVfy0j3B7glonPo475z/1JTiVwMj+bgixN5I7PkMC27Cy666Jt9Ls4w666hobHigYaZeaYC3tYq+sKQkck+Io/o/TdUdHhYMC1aJLTJeDfz8p3UAp7XHBVntTh95qLdSK7L74Xu7eJBgquLI+J10ValZXlRphXpT3dgVYP5Z7ktd3rtisEnIo6DnorWzznLL6KOH2PW9VvsgiQIz8zWiXTE/lWDlUhEd48lkPJ/wLgHURdBv4l2wOXbaRtBQa/TxTlvG62Oaym1S+ogW5TAmRz3iLxopZQAWVwrgYsHEEPBPreUD9TZpYy11d5+p8PSZMILlB/0SIVFDRB1yFcohGIozDawkkYUgyUPgMtCfjonVsuDWvXEyEf7fCeJik8yFE/Bfzua/HCoz85krkCtIRe2GUbq2xKN/D+mo5noq4= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7b02db0a-334c-4ac2-f2df-08d72fa1cbc8 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2019 12:33:45.3057 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nj3Fu1uBejGQhu55V+cItKvFWM8s25QR16qgbYnNXvTlxzi23yJmrWcmTdWEZGIuF5b5HRa7x9Z5x3rqbTua9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2480 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-02_04:2019-08-29,2019-09-02 signatures=0 Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org Use direct returns instead of gotos. Error handling code becomes smaller and better readable. Signed-off-by: Robert Richter --- drivers/edac/edac_mc_sysfs.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 4eb8c5ceb973..309fc24339b0 100644 --- a/drivers/edac/edac_mc_sysfs.c +++ b/drivers/edac/edac_mc_sysfs.c @@ -938,7 +938,7 @@ int edac_create_sysfs_mci_device(struct mem_ctl_info *mci, if (err < 0) { edac_dbg(1, "failure: create device %s\n", dev_name(&mci->dev)); put_device(&mci->dev); - goto out; + return err; } /* @@ -987,7 +987,6 @@ int edac_create_sysfs_mci_device(struct mem_ctl_info *mci, } device_unregister(&mci->dev); -out: return err; } @@ -1044,10 +1043,8 @@ int __init edac_mc_sysfs_init(void) int err; mci_pdev = kzalloc(sizeof(*mci_pdev), GFP_KERNEL); - if (!mci_pdev) { - err = -ENOMEM; - goto out; - } + if (!mci_pdev) + return -ENOMEM; mci_pdev->bus = edac_get_sysfs_subsys(); mci_pdev->type = &mc_attr_type; @@ -1055,17 +1052,14 @@ int __init edac_mc_sysfs_init(void) dev_set_name(mci_pdev, "mc"); err = device_add(mci_pdev); - if (err < 0) - goto out_put_device; + if (err < 0) { + put_device(mci_pdev); + return err; + } edac_dbg(0, "device %s created\n", dev_name(mci_pdev)); return 0; - - out_put_device: - put_device(mci_pdev); - out: - return err; } void edac_mc_sysfs_exit(void) From patchwork Mon Sep 2 12:33:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Richter X-Patchwork-Id: 11126551 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AC8A41398 for ; Mon, 2 Sep 2019 12:34:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B79F21883 for ; Mon, 2 Sep 2019 12:34:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="Qm6ocUp0"; dkim=pass (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="S5mlK+He" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730599AbfIBMeI (ORCPT ); Mon, 2 Sep 2019 08:34:08 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:47024 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731650AbfIBMd6 (ORCPT ); Mon, 2 Sep 2019 08:33:58 -0400 Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x82CUjqa029663; Mon, 2 Sep 2019 05:33:51 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=p8D0+yn2GU0s+KGko5wJ4F5JGoNvubsQ8oGhq8GWBbI=; b=Qm6ocUp0m3o4htXx7cZSsYWK/FD0Ct0y1HVRQ8Tcjs8LrO3R66OD/ykvaXmL9laf1aQ8 nqp7dUvcuESI4md56CIHRH/YM2O7A0suaghwqLtYOfazcLUNni1zbuDYZJ3qYXya1r5H X92XtbBvVWYjss9/dEssZf8RvGxlZt72lLuKoWIMIlYotL2AcX4Or1nE1zstjZTadBLK EuCpkG9OZs4hOmxfc1kOZ6ym4EVzJ27TIZkg938HCk/VlWZXuVbVq4hY8oQ+IEmJJeZ0 h95rrWQwPmLXLOm74VIah4WZv2D4ftuAnGmk0x/c0KFc+Kn1b81wqxA3CP5tWYVAXsfg Iw== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2uqrdm603h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 02 Sep 2019 05:33:51 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 2 Sep 2019 05:33:48 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.55) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 2 Sep 2019 05:33:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fMAzWu02y3apWDvqPsXANamSFvgEFkTxxUla9aQIJWqOsuYmKBDnz8Gxno+DpXFWfgrMp3IifZwIFtAESd4dSLofHdn/rGMTLAWnjz4500zVMn82e6HYPrGyT7srZWNLM6oU1FVBMK6b0UXL/EerMvkHlvqOa82B5wd+tP9olr6mB/p8BbU1uPb003u0TY+I0GXOfnT3E8VrQeffHqkUq0Fg5FTvmdOiVk83c4eVM0mFPi2KArGPzv9wADiBwd801SIw5FnuqfLX3RCGPE5KKwugjWXVGO7bhWZR+K6CD6vYSNFgwSsPMYD78CdbDtxSsr6FFKfFXsBZGHTmh9/OKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p8D0+yn2GU0s+KGko5wJ4F5JGoNvubsQ8oGhq8GWBbI=; b=fOZ716BQZZssZy1aL8ftW2Hf1sz8/2Z7oiAMsTsQY6ghvvl6/keqFAHHSGaTiLprrEbTCWCvRfUSGd6+1+OugOW2nvjqem2zTfXhUpUPCS8hzbLG6weAHx+iVnJ9nJrw23mUIUsFJMLoEPBU/JtgTM/FAw/Wnb0/Zyb5sTdrSJmS9rn7ccLnCGh/DN1tRJ+crz7e5ifi3XJ6LY20PYhE+WGUlKN4SkATRkpzWyFSCTznkWXKWwuTYfcHoSlE2tqr10vfdwPdaEtiyoe0Wh7fEYNktirKx9eRWhKGWOpzxFjHV+m34eWqZQETFfRJZB/aktB2bMIQvj16V0xgujG+PA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p8D0+yn2GU0s+KGko5wJ4F5JGoNvubsQ8oGhq8GWBbI=; b=S5mlK+HepaY1GfLpzsCTcgxTZWljGwqha5PhCck5OurrnpZt59iLnIWfDuoHGCeBe1myi/lU14ndzTu2DMCqeSAbIDnbSvRkCYo5HuzciZ5cy0PiUkSMIFJ4xPzwX+HfjCHzCGufkMQ72q8gtxMR527XLSAFoBN2oTfVV8ruY+o= Received: from MN2PR18MB3408.namprd18.prod.outlook.com (10.255.238.217) by MN2PR18MB2480.namprd18.prod.outlook.com (20.179.82.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.20; Mon, 2 Sep 2019 12:33:47 +0000 Received: from MN2PR18MB3408.namprd18.prod.outlook.com ([fe80::8162:62e8:aeeb:ec7b]) by MN2PR18MB3408.namprd18.prod.outlook.com ([fe80::8162:62e8:aeeb:ec7b%3]) with mapi id 15.20.2220.013; Mon, 2 Sep 2019 12:33:47 +0000 From: Robert Richter To: Borislav Petkov , Mauro Carvalho Chehab , Tony Luck CC: Robert Richter , James Morse , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH 4/5] EDAC, mc_sysfs: Make debug messages consistent Thread-Topic: [PATCH 4/5] EDAC, mc_sysfs: Make debug messages consistent Thread-Index: AQHVYYqq19hRVbKeJkGLaGszT0mThw== Date: Mon, 2 Sep 2019 12:33:47 +0000 Message-ID: <20190902123216.9809-5-rrichter@marvell.com> References: <20190902123216.9809-1-rrichter@marvell.com> In-Reply-To: <20190902123216.9809-1-rrichter@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1PR07CA0027.eurprd07.prod.outlook.com (2603:10a6:7:66::13) To MN2PR18MB3408.namprd18.prod.outlook.com (2603:10b6:208:16c::25) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [31.208.96.227] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 97b7612c-2c7f-4d14-75f3-08d72fa1ccf4 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:MN2PR18MB2480; x-ms-traffictypediagnostic: MN2PR18MB2480: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:619; x-forefront-prvs: 01480965DA x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(346002)(376002)(39850400004)(396003)(136003)(366004)(199004)(189003)(6486002)(8676002)(186003)(110136005)(81166006)(81156014)(71190400001)(66066001)(6506007)(386003)(1076003)(71200400001)(26005)(6512007)(53936002)(256004)(478600001)(50226002)(54906003)(86362001)(36756003)(8936002)(14444005)(52116002)(66556008)(66476007)(486006)(5660300002)(64756008)(66446008)(11346002)(2616005)(4326008)(316002)(476003)(2906002)(7736002)(76176011)(6436002)(305945005)(6116002)(3846002)(99286004)(102836004)(14454004)(446003)(66946007)(25786009)(15650500001);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB2480;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: toAODxe6CyUXRsIE9/oMcAhDO/oyJHzUbKJDlbKYPzic5lyaBDBspCcNa0EZhFa5TbJwF3pocCvotSe3lClEnFUY1J533+BAmyqYmtkzitQ9EdzbXmTbwv4eb1wfgtOV3sapGohPdf3trgyDkAp3XDGWvnbUUSuHUGqfZuW42IdRA0T15C12fCqZFn/ulkSO/p1uU65P8wysF8C37vU+Jzd7qrfSug3N9uQU7ZLQ0sFtYm7Rpb1WHiV6NN64cLq47eA458qQUsfzcwpV/BHcCD8ohjv+y9SZQUKBPOrtkNMp52+1xqR8xx3PSzcskdESV9MBKrZL4JkHwGKq+lAMunDOGqAevhTun5valZB6U1yixmXi5cQDcUj4GmyMtSn64i3w2ubRW67dfEmPBboFIO39QBvdM0hk62k12wU9jic= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 97b7612c-2c7f-4d14-75f3-08d72fa1ccf4 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2019 12:33:47.2706 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IomEikX3ELtg3+Epm7uZoEiyAq0Q3o8X0WcYKWM2YCTw3oJVgqdEHJfotS+aDzAy5B8InFrM4deymDn7W/QFdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2480 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-02_04:2019-08-29,2019-09-02 signatures=0 Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org Debug messages are inconsistently used in the error handlers. Some lack an error message, some are called regardless the return status, messages for the same error are at different locations in the code depending on the error code. This happens esp. near put_device() calls. Make those debug messages more consistent. Additionally, unify the error messages to have the same terms for the same operations of the device. Signed-off-by: Robert Richter --- drivers/edac/edac_mc_sysfs.c | 63 +++++++++++++++++------------------- 1 file changed, 29 insertions(+), 34 deletions(-) diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 309fc24339b0..eaccde3fc1b8 100644 --- a/drivers/edac/edac_mc_sysfs.c +++ b/drivers/edac/edac_mc_sysfs.c @@ -278,7 +278,7 @@ static void csrow_attr_release(struct device *dev) { struct csrow_info *csrow = container_of(dev, struct csrow_info, dev); - edac_dbg(1, "Releasing csrow device %s\n", dev_name(dev)); + edac_dbg(1, "device %s released\n", dev_name(dev)); kfree(csrow); } @@ -414,14 +414,16 @@ static int edac_create_csrow_object(struct mem_ctl_info *mci, dev_set_name(&csrow->dev, "csrow%d", index); dev_set_drvdata(&csrow->dev, csrow); - edac_dbg(0, "creating (virtual) csrow node %s\n", - dev_name(&csrow->dev)); - err = device_add(&csrow->dev); - if (err) + if (err) { + edac_dbg(1, "failure: create device %s\n", dev_name(&csrow->dev)); put_device(&csrow->dev); + return err; + } - return err; + edac_dbg(0, "device %s created\n", dev_name(&csrow->dev)); + + return 0; } /* Create a CSROW object under specifed edac_mc_device */ @@ -435,12 +437,8 @@ static int edac_create_csrow_objects(struct mem_ctl_info *mci) if (!nr_pages_per_csrow(csrow)) continue; err = edac_create_csrow_object(mci, mci->csrows[i], i); - if (err < 0) { - edac_dbg(1, - "failure: create csrow objects for csrow %d\n", - i); + if (err < 0) goto error; - } } return 0; @@ -624,7 +622,7 @@ static void dimm_attr_release(struct device *dev) { struct dimm_info *dimm = container_of(dev, struct dimm_info, dev); - edac_dbg(1, "Releasing dimm device %s\n", dev_name(dev)); + edac_dbg(1, "device %s released\n", dev_name(dev)); kfree(dimm); } @@ -653,12 +651,20 @@ static int edac_create_dimm_object(struct mem_ctl_info *mci, pm_runtime_forbid(&mci->dev); err = device_add(&dimm->dev); - if (err) + if (err) { + edac_dbg(1, "failure: create device %s\n", dev_name(&dimm->dev)); put_device(&dimm->dev); + return err; + } - edac_dbg(0, "created rank/dimm device %s\n", dev_name(&dimm->dev)); + if (IS_ENABLED(CONFIG_EDAC_DEBUG)) { + char location[80]; + edac_dimm_info_location(dimm, location, sizeof(location)); + edac_dbg(0, "device %s created at location %s\n", + dev_name(&dimm->dev), location); + } - return err; + return 0; } /* @@ -901,7 +907,7 @@ static void mci_attr_release(struct device *dev) { struct mem_ctl_info *mci = container_of(dev, struct mem_ctl_info, dev); - edac_dbg(1, "Releasing csrow device %s\n", dev_name(dev)); + edac_dbg(1, "device %s released\n", dev_name(dev)); kfree(mci); } @@ -933,7 +939,6 @@ int edac_create_sysfs_mci_device(struct mem_ctl_info *mci, dev_set_drvdata(&mci->dev, mci); pm_runtime_forbid(&mci->dev); - edac_dbg(0, "creating device %s\n", dev_name(&mci->dev)); err = device_add(&mci->dev); if (err < 0) { edac_dbg(1, "failure: create device %s\n", dev_name(&mci->dev)); @@ -941,6 +946,8 @@ int edac_create_sysfs_mci_device(struct mem_ctl_info *mci, return err; } + edac_dbg(0, "device %s created\n", dev_name(&mci->dev)); + /* * Create the dimm/rank devices */ @@ -950,22 +957,9 @@ int edac_create_sysfs_mci_device(struct mem_ctl_info *mci, if (!dimm->nr_pages) continue; -#ifdef CONFIG_EDAC_DEBUG - edac_dbg(1, "creating dimm%d, located at ", i); - if (edac_debug_level >= 1) { - int lay; - for (lay = 0; lay < mci->n_layers; lay++) - printk(KERN_CONT "%s %d ", - edac_layer_name[mci->layers[lay].type], - dimm->location[lay]); - printk(KERN_CONT "\n"); - } -#endif err = edac_create_dimm_object(mci, dimm, i); - if (err) { - edac_dbg(1, "failure: create dimm %d obj\n", i); + if (err) goto fail_unregister_dimm; - } } #ifdef CONFIG_EDAC_LEGACY_SYSFS @@ -1010,14 +1004,14 @@ void edac_remove_sysfs_mci_device(struct mem_ctl_info *mci) struct dimm_info *dimm = mci->dimms[i]; if (dimm->nr_pages == 0) continue; - edac_dbg(0, "removing device %s\n", dev_name(&dimm->dev)); + edac_dbg(1, "unregistering device %s\n", dev_name(&dimm->dev)); device_unregister(&dimm->dev); } } void edac_unregister_sysfs(struct mem_ctl_info *mci) { - edac_dbg(1, "Unregistering device %s\n", dev_name(&mci->dev)); + edac_dbg(1, "unregistering device %s\n", dev_name(&mci->dev)); device_unregister(&mci->dev); } @@ -1028,7 +1022,7 @@ static void mc_attr_release(struct device *dev) * parent device, used to create the /sys/devices/mc sysfs node. * So, there are no attributes on it. */ - edac_dbg(1, "Releasing device %s\n", dev_name(dev)); + edac_dbg(1, "device %s released\n", dev_name(dev)); kfree(dev); } @@ -1053,6 +1047,7 @@ int __init edac_mc_sysfs_init(void) err = device_add(mci_pdev); if (err < 0) { + edac_dbg(1, "failure: create device %s\n", dev_name(mci_pdev)); put_device(mci_pdev); return err; } From patchwork Mon Sep 2 12:33:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Richter X-Patchwork-Id: 11126549 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 003941398 for ; Mon, 2 Sep 2019 12:34:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB28120820 for ; Mon, 2 Sep 2019 12:34:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="dy+t1ysN"; dkim=pass (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="YWqPfaY7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729999AbfIBMeA (ORCPT ); Mon, 2 Sep 2019 08:34:00 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:28348 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731670AbfIBMeA (ORCPT ); Mon, 2 Sep 2019 08:34:00 -0400 Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x82CUjqb029663; Mon, 2 Sep 2019 05:33:53 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=eT5ARylE0PPIGqS6JRb8G0U3D3rvi556maazBgeCjFU=; b=dy+t1ysNoJ5vO4Bq30yGrWi3AmKAxxbI3SvOhgj2b8msbsP/CkxcCIEKtLS50HSIRYqG nXXESwWmxB1Rf2fCoy3brF226+MBe5BMUULD4xpeA4Ts2wMTBtungbG43R0KJv89Z9Wn uTwZk8OPuVoz71kyHbvEXNz/pa5DkQYA/H4wM7/Tbh05g6Ol3KwhBZ4AXPEDg5HpSqW/ ts1jyzuj2AT9HY3Wvszo5Yh2MTBu+z49gybBGtGck7AaqFZribivOEq2o9x4sM/c7nFQ zaIqHyy10cUsIqUBH9IUDhNiRRnBbtkYWe2XraDswwE5VA0CqJ7XVcq4uZxzS6OiNGzq Xw== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2uqrdm603k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 02 Sep 2019 05:33:53 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 2 Sep 2019 05:33:51 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.55) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 2 Sep 2019 05:33:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eNyw7VF3iW87LXF8cmAE5O4PWhvxTAHksEVpk5LijtkkGP0ZdgQEB5ceNbNCDr1ZAjwJjO3E0GM7xNEHPcKgW5A2oRygSuiucqK47iHV67Ypz7uq1Ocs1cYijucqrjYhW/X7O8MhxuHn5kD9gQ8RVmLa2Fdf9dJMoISjBOD2K2wulEfPBHi6yyxA4VpIPIbyU4nKo/TpvvRueYEHx8zbAb22iLtOaFWy1/htKeFp1jeXQT/BWKjOGzNKDg2ub0hBM+l/IeglPEtqsq/yNIAodZ/VPJFFmCScfUUb53zUj+lrztX4Y020mhUbeMq53RfMJ7B0LFYJj3JedHisMec1/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eT5ARylE0PPIGqS6JRb8G0U3D3rvi556maazBgeCjFU=; b=Oht0Dw9e5iBZ5+USPp1k8qkTwprCYgDksq7YBaLZ38uzCBy+633alCsFnGZqlHkHjn3fRPimvYRUD6d7gEEI8eZc7dnAmOLRam+os0z+UxjTQnnvFRJFfUt/j4U3Cm2kL1QqXRxpYf1y3XQucbWyKinMhDSlvfH5LDgG7jWq1pIpJ8uifUt8ofZLerRvSUINCILbj1MNCNmgFLxXqy30B/t4yi7eP6CplHPPOFsoiWF0rKgnBVV5YrG5gZP88O8xP5gaF1LA2j//ZigUyi5yBwG4WKnfIE6jx9RZImaQKiWrhHyBlEFGSaTs8t9VjVezs84DELs20P4gfsp90nejUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eT5ARylE0PPIGqS6JRb8G0U3D3rvi556maazBgeCjFU=; b=YWqPfaY7qmSlCqnQKCHpXJJjrWOAtu4VpnGiwvXZqyoDwNMM7l2sHRWiu9gnovBBxtqGZabTF7xvsAokLHLz3rJPan5gOOyvMxogYYnJWNmBEPR9gQtwpvikJ4ZHR/cUak732FkshfU2TRA6fsgQXN9hn55Etw/l07tK8X0JqCk= Received: from MN2PR18MB3408.namprd18.prod.outlook.com (10.255.238.217) by MN2PR18MB2480.namprd18.prod.outlook.com (20.179.82.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.20; Mon, 2 Sep 2019 12:33:49 +0000 Received: from MN2PR18MB3408.namprd18.prod.outlook.com ([fe80::8162:62e8:aeeb:ec7b]) by MN2PR18MB3408.namprd18.prod.outlook.com ([fe80::8162:62e8:aeeb:ec7b%3]) with mapi id 15.20.2220.013; Mon, 2 Sep 2019 12:33:49 +0000 From: Robert Richter To: Borislav Petkov , Mauro Carvalho Chehab , Tony Luck CC: Robert Richter , James Morse , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH 5/5] MAINTAINERS: update EDAC's reviewer entry Thread-Topic: [PATCH 5/5] MAINTAINERS: update EDAC's reviewer entry Thread-Index: AQHVYYqr018fZ7kvpEWL1+5AuK3XQg== Date: Mon, 2 Sep 2019 12:33:49 +0000 Message-ID: <20190902123216.9809-6-rrichter@marvell.com> References: <20190902123216.9809-1-rrichter@marvell.com> In-Reply-To: <20190902123216.9809-1-rrichter@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1PR07CA0027.eurprd07.prod.outlook.com (2603:10a6:7:66::13) To MN2PR18MB3408.namprd18.prod.outlook.com (2603:10b6:208:16c::25) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [31.208.96.227] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 083237a3-3f95-4960-daf2-08d72fa1ce1b x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:MN2PR18MB2480; x-ms-traffictypediagnostic: MN2PR18MB2480: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1824; x-forefront-prvs: 01480965DA x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(346002)(376002)(39850400004)(396003)(136003)(366004)(199004)(189003)(6486002)(8676002)(186003)(110136005)(81166006)(81156014)(71190400001)(66066001)(6506007)(386003)(1076003)(71200400001)(26005)(6512007)(4744005)(53936002)(256004)(478600001)(50226002)(54906003)(86362001)(36756003)(8936002)(52116002)(66556008)(66476007)(486006)(5660300002)(64756008)(66446008)(11346002)(2616005)(4326008)(316002)(476003)(2906002)(7736002)(76176011)(6436002)(305945005)(6116002)(3846002)(99286004)(102836004)(14454004)(446003)(66946007)(25786009);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB2480;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 3AZIqllSYG6pa60ZulnBu4qjdUcsliLuRb5iUXpRcO/YXZbqyGJvmBzTMmaOlBpiW7bsKjFExzAmJfIAY1e5rjF6YDGfIl/cQpSHEHPCZ+33ZXLXKCCD5caWde891HAcdJn5wZ1dYTZGkImSvKp5gq28m0B23lKCASvF26v+sK4lU57GOeODO1zAkLeHZ9Z4ws/Rml/e2fv522WaafdsNwd0vV+aRZpReS3Z3GFJUDCvh/jHKPlroVCRwLzZnTQrCOx7+Z+4KfQxdVcH8YicIhV6UL74tr2wNWNPJaT7ROTCXkk5YfYoplMr9hdlMf/RhHNFbtfUfBldKhzYPdB24m4/7EvtVDMiQ19mPN82KCdb1GolFauLegLbvSB0IiUP1p4PYf1G2X5UkQYXbVfJLfhUpmo4tHPZjkseo3q8P4g= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 083237a3-3f95-4960-daf2-08d72fa1ce1b X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2019 12:33:49.3494 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: muPGUNjntKO2LUn76FgmwDk6ufPJgRnsTZlz9lNdMQfHZYZeSwi2Cbu2+tOkNMatpl6+c7iJ/MJVyjq9fAPU3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2480 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-02_04:2019-08-29,2019-09-02 signatures=0 Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org I did some significant work with code in edac_mc.c and ghes_edac.c already, so I guess I can probably helping out a bit as code reviewer here. Signed-off-by: Robert Richter --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 97912d8333a9..79d2ae8519e3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5788,6 +5788,7 @@ M: Borislav Petkov M: Mauro Carvalho Chehab M: Tony Luck R: James Morse +R: Robert Richter L: linux-edac@vger.kernel.org T: git git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git edac-for-next S: Supported