From patchwork Tue Sep 3 15:36:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 11128251 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 12DAD13B1 for ; Tue, 3 Sep 2019 15:18:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7CD7233A1 for ; Tue, 3 Sep 2019 15:18:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729117AbfICPSh (ORCPT ); Tue, 3 Sep 2019 11:18:37 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:5735 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727107AbfICPSh (ORCPT ); Tue, 3 Sep 2019 11:18:37 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 5B8CD39A87045D9D68BD; Tue, 3 Sep 2019 23:18:35 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.439.0; Tue, 3 Sep 2019 23:18:25 +0800 From: Wei Yongjun To: Greg Kroah-Hartman , Felipe Balbi , Pawel Laszczak CC: Wei Yongjun , , Subject: [PATCH -next] usb: cdns3: Remove redundant dev_err call in cdns3_probe() Date: Tue, 3 Sep 2019 15:36:25 +0000 Message-ID: <20190903153625.85691-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/usb/cdns3/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c index 300df58a190b..9b1d8fed4e5a 100644 --- a/drivers/usb/cdns3/core.c +++ b/drivers/usb/cdns3/core.c @@ -462,10 +462,8 @@ static int cdns3_probe(struct platform_device *pdev) res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dev"); regs = devm_ioremap_resource(dev, res); - if (IS_ERR(regs)) { - dev_err(dev, "couldn't iomap dev resource\n"); + if (IS_ERR(regs)) return PTR_ERR(regs); - } cdns->dev_regs = regs; cdns->otg_irq = platform_get_irq_byname(pdev, "otg");