From patchwork Fri Sep 6 16:52:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Elfring X-Patchwork-Id: 11137333 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 18F4716C1 for ; Mon, 9 Sep 2019 07:23:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0137121D81 for ; Mon, 9 Sep 2019 07:23:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0137121D81 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=web.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D82989856; Mon, 9 Sep 2019 07:23:17 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.web.de (mout.web.de [212.227.17.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7157C6E32F for ; Fri, 6 Sep 2019 16:58:49 +0000 (UTC) X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.135.58.4]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LshSX-1iHVpu1po9-012E1h; Fri, 06 Sep 2019 18:52:31 +0200 To: dri-devel@lists.freedesktop.org, Alexios Zavras , Allison Randal , Daniel Vetter , David Airlie , Enrico Weigelt , Greg Kroah-Hartman , Laurent Pinchart , Matteo Croce , Sebastian Reichel , Thomas Gleixner , Tomi Valkeinen From: Markus Elfring Subject: [PATCH] omapdrm/dss: Use PTR_ERR_OR_ZERO() in four functions Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <66cd9e01-1f86-efb2-56c0-29a80dc47596@web.de> Date: Fri, 6 Sep 2019 18:52:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 Content-Language: en-US X-Provags-ID: V03:K1:zoVdOeaJSGaW++jfJyhGx6/hqxUplFpCG+bhKbYCVhpZQd7WXu0 eYoj4d5J2w3xHsvROBo5Fo6LF43LGbhGWKZ+j7ik/z4uJ45jOKcZRHnbJvgcKh7OxNr+plu KpKxA3CKaMLbHa+DEGMIJgP0p6GFfZPVN6WScvZOg4jVBUlsDdgKq3ZOeuTliSzjoumNIqx h0wbPP36tiWguRAyO7mwg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:gvnA/aXE4gQ=:Krnn2emmB7fYw8WcSNJY62 Yh2GsBIjZLMuUbwB1AiBExlvY/AuaWy+8NC2MpezH5enBv6ye7sMLc6fBpQTrcVc7VlmFwPcf VEvhmCCoUDoMMMc2AjQIZl8EkAkzsiRZosNnd1jfdcUcGrhM8c5N3TCtEXYfl4xVueFOvpT/2 IV56AdnjWZn95EJtJyJ39+OD1wcpPO2rGLmXghwNvD/hjh8RzfG7ZMFD9VGMRh5qEKJnolfNl aKQZTOW67vjcilFGKEXiCKIdmo4lowEGRasD0PUrjVSJlVwrOvuQ+DA9QZu2UcpWrT1OAQ75o 5ebOXe0vFr8gofyC5JWBUeMYLMNbeOuCBwLLyO+CBULs5OwtOn+9Kjsx0YtcPgZCUDng8dWEu tUG8k1qRVn9Bd96QDnaZF4/ayd0b6TJUrQDRONs8QKKfgK120Yeen49ZAp038vIR77/8xPuOS wScn4BzI/TSkewokCvQMoMHTmnKxi5QnOhJwsdrmMtDopnXJt711TyFbe+fXbsV4Rp7eVjp4d W4NAWylQzZO51NKkkU6tdOngZvo+DERyBIKTN2LEMCN4dBns7/mXn0UPHwdVdWxkpls74lmxW SjO5kRlElogNDJE0ga77wX2z/yRAxVOpgViNkEejkbae4PwyTSqOv/J2gr05AewIya3CV0rj2 ghxUW5b9ncZheLdEhBdmU92xaxvDzWBvlBqWHrCmmH0uOtJN1YgKVmNLXZk+fX69TdFVO29OJ G6cKuMekpgxW3qAtTG2MjVkXDLj97MgRU4ghhLyI7xW8d+FFlYJWuN8hnts+I9863GGwOAlWZ 8NJHX2144RN8g4Y2XV9b8XNEiZI8jUIJWZrAUombfEikPIr2BCIOrXXdv4DZ5uhAJkIfiNjfl WJPhw3Sr12z7rWYHQ/GQdoeBYfXYKoi0tQtjrvRS0DTxOO1Keqr+eYYRl38xyrf2CrQ0vj6lv tHPMaGpSFOH6xF7jtEiVyB5BhvmRk9XvP0tZL4bhpdnYGdnQQaqvCbK6GX3uaggnXkLi8ksN9 ffiQGdNdd6cX5h8FxF0pTa3IaB7eJgXQNP78WVhYh0BPMY9RDoBq/VSeKeAeZxBRWOOyMvxVa Wz+eMGnNBls0WlWNMyLbaXjf4GrDwUnqMrzXfo71ObCmCZ4hJGsrGFxrWuI8U3/KjxQmBZtTX gOL3+czRMDMLWt0zO1kP8WN+hCRlQSZlzUwmWZCJVfuokhWqDlPYv6k2nIs8OEIxxNBG7umNk BYZ/sBN7H0vaZ+C+w X-Mailman-Approved-At: Mon, 09 Sep 2019 07:23:02 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1567789126; bh=mhqeZ+7z5Q7wNBVobBZgdDABit9PMa8Nwp21IFODusQ=; h=X-UI-Sender-Class:To:From:Subject:Cc:Date; b=GrZmiF8t+PhlPmSFs9+zUlDPqR6KKqxWyhZZqbXbhvq0+HO2vhHcJQyrxF6pa4DnD 0p9SXMrAUYpQf5n6dZ+o7+SpMXIA2e68igsKQSHGDDh8OB3Vb+Hjdu5/GFFo4GyGzM v7IxyA1qYN4HALE8XPRWaedq6qgf8mznKITka42M= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhong jiang , LKML Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Markus Elfring Date: Fri, 6 Sep 2019 18:40:48 +0200 Simplify these function implementations by using a known function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 6 +----- drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 4 +--- drivers/gpu/drm/omapdrm/dss/hdmi5_core.c | 4 +--- drivers/gpu/drm/omapdrm/dss/hdmi_phy.c | 4 +--- 4 files changed, 4 insertions(+), 14 deletions(-) -- 2.23.0 diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c b/drivers/gpu/drm/omapdrm/dss/hdmi4.c index 0f557fad4513..b1a8d4bfbe48 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c @@ -586,11 +586,7 @@ static int hdmi_audio_register(struct omap_hdmi *hdmi) hdmi->audio_pdev = platform_device_register_data( &hdmi->pdev->dev, "omap-hdmi-audio", PLATFORM_DEVID_AUTO, &pdata, sizeof(pdata)); - - if (IS_ERR(hdmi->audio_pdev)) - return PTR_ERR(hdmi->audio_pdev); - - return 0; + return PTR_ERR_OR_ZERO(hdmi->audio_pdev); } /* ----------------------------------------------------------------------------- diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c index 5d5d5588ebc1..0775109133b5 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c @@ -923,8 +923,6 @@ int hdmi4_core_init(struct platform_device *pdev, struct hdmi_core_data *core) res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "core"); core->base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(core->base)) - return PTR_ERR(core->base); - return 0; + return PTR_ERR_OR_ZERO(core->base); } diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c index 7400fb99d453..655cf2048809 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c @@ -899,8 +899,6 @@ int hdmi5_core_init(struct platform_device *pdev, struct hdmi_core_data *core) res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "core"); core->base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(core->base)) - return PTR_ERR(core->base); - return 0; + return PTR_ERR_OR_ZERO(core->base); } diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c b/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c index 00bbf24488c1..bbc02d5aa8fb 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c @@ -191,8 +191,6 @@ int hdmi_phy_init(struct platform_device *pdev, struct hdmi_phy_data *phy, res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy"); phy->base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(phy->base)) - return PTR_ERR(phy->base); - return 0; + return PTR_ERR_OR_ZERO(phy->base); }