From patchwork Mon Sep 9 15:55:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew Cooper X-Patchwork-Id: 11138219 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E21B914DB for ; Mon, 9 Sep 2019 15:57:26 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCAE42086D for ; Mon, 9 Sep 2019 15:57:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="YUPfXTkS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCAE42086D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i7M0y-0001Nr-9H; Mon, 09 Sep 2019 15:55:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i7M0x-0001Nm-Cw for xen-devel@lists.xenproject.org; Mon, 09 Sep 2019 15:55:39 +0000 X-Inumbo-ID: 442642ac-d31a-11e9-b76c-bc764e2007e4 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 442642ac-d31a-11e9-b76c-bc764e2007e4; Mon, 09 Sep 2019 15:55:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1568044538; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=zf6bNC9HU8cOyuKaCv1fwvKGH2K+HP7QAO6wpn3xE0I=; b=YUPfXTkSzJkA/mtKy+TpRPG2N0cL0QCDpl/puvR6vpz69Asw4dZitOxZ GruybnMJKcILdcvg/mlMk4Kx4M72x3Ab5MayWWs6vfWvxm2uqFj0Ndv1k MT5hvG+Bn+9OHWDgyrGJeBflF47cewh+E4QHlhgqyG9RNRlyacoaNjUvZ o=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa5.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: XK32eGNbzMhb1Xui/LdmvXORhw74UWjG6qtoLOj6a9U0xiFHDiDW72rowx7SLv++KuncGpihc7 19TT9Cg0o7UK3LyFr6GAk88CbqQdVg2KTZ91DjbxAMy3TKz8dHcDf4y99CgIHXZyYdOUKoAMSp NT5K3jZEnZI4n02A3RhOvV2jH3hJZKrxBjy0rv8UHHpVP42kSYnniHzNqDvJxBFbow4rwfJDEa gU2iilsX9tAr17hbjVshI0AvCaXswViBK01uYR2mwMKRfijecXtQ75fuN4y3bT0NmMHCG8QnMI wOo= X-SBRS: 2.7 X-MesageID: 5513400 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,486,1559534400"; d="scan'208";a="5513400" From: Andrew Cooper To: Xen-devel Date: Mon, 9 Sep 2019 16:55:34 +0100 Message-ID: <20190909155534.20514-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] x86/cpuid: Fix build with CentOS 6 following c/s 7479151106 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , =?utf-8?q?Roger_Pau_Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" GCC of a CentOS 6 vintage complains: cpuid.c: In function 'parse_xen_cpuid': cpuid.c:32: error: 'mid' may be used uninitialized in this function This can't occur in practice because the while() loop is guarenteed to be entered, but initialise mid to work around the issues. Spotted by Gitlab CI. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- xen/arch/x86/cpuid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index 36b1e2ce4c..acba0f7583 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -29,7 +29,7 @@ static int __init parse_xen_cpuid(const char *s) const char *name; unsigned int bit; } features[] __initconstrel = INIT_FEATURE_NAMES; - const struct feature *lhs, *mid, *rhs; + const struct feature *lhs, *rhs, *mid = NULL /* GCC... */; const char *feat; ss = strchr(s, ',');