From patchwork Tue Sep 10 07:46:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajay Singh X-Patchwork-Id: 11138883 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B6C1F13BD for ; Tue, 10 Sep 2019 07:46:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 801112084D for ; Tue, 10 Sep 2019 07:46:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="fLJAudKm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393567AbfIJHqI (ORCPT ); Tue, 10 Sep 2019 03:46:08 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:15041 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728157AbfIJHqI (ORCPT ); Tue, 10 Sep 2019 03:46:08 -0400 Received-SPF: Pass (esa5.microchip.iphmx.com: domain of Ajay.Kathat@microchip.com designates 198.175.253.82 as permitted sender) identity=mailfrom; client-ip=198.175.253.82; receiver=esa5.microchip.iphmx.com; envelope-from="Ajay.Kathat@microchip.com"; x-sender="Ajay.Kathat@microchip.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 mx a:ushub1.microchip.com a:smtpout.microchip.com a:mx1.microchip.iphmx.com a:mx2.microchip.iphmx.com include:servers.mcsv.net include:mktomail.com include:spf.protection.outlook.com ~all" Received-SPF: None (esa5.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@email.microchip.com) identity=helo; client-ip=198.175.253.82; receiver=esa5.microchip.iphmx.com; envelope-from="Ajay.Kathat@microchip.com"; x-sender="postmaster@email.microchip.com"; x-conformance=spf_only Authentication-Results: esa5.microchip.iphmx.com; spf=Pass smtp.mailfrom=Ajay.Kathat@microchip.com; spf=None smtp.helo=postmaster@email.microchip.com; dkim=pass (signature verified) header.i=@microchiptechnology.onmicrosoft.com; dmarc=pass (p=none dis=none) d=microchip.com IronPort-SDR: KBLrEDd4NihuoDaLFp10Gg5WQT/rZWxxQ2bJZwnvN9yaTs5yU0nUeWdm66QCTlKHi/UfYYYNbE ur32h7xTU42dFsu00rs5j35XNyXGOcdmUA2Lttszs/tT1p/VGei6NelIjoFSyRoXSt+bXlT44o dBMjVT7nVtIHujbkqVqT25+4yHrkp57Yx4dRdSKZhV01Jxh8XicFucQ25BRao90bA+4Cm3UPbm Kj8rk/rPwef3JOTBOGUVhMy1sXdBSaHDBTrnq75Us3sMRlepb+pJQ3LRn2buD8JvPF3oiODjwF ci0= X-IronPort-AV: E=Sophos;i="5.64,487,1559545200"; d="scan'208";a="46867018" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 10 Sep 2019 00:46:07 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 10 Sep 2019 00:46:06 -0700 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 10 Sep 2019 00:46:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IsQVRW0sFnxVEmqfUYYFwWpCthMGcke4lIx1oYYNqrDp4/HMNZLcy4Tz/2fdNlz7RiEnaCsf9W3fcX+w3a8iVVdLnCFEXMZOZQAKOAJ8BV602dNEhyeosAu3/XtE/uN31aLCaPnv7RRrv43sTrOSxhw8dXC4Iv/pCwDxWgsAJX/9IKMl8BonAUbw6pPaoHiY1/QkyuZ6Sj0OFncVcImkYqIGIiTasNSuhapJivMUQc7qEMF00ZOdTTpwUPIPrPW2uwCjL+1GXjjJYiBk6hHS477jAwR1HlnISnPAosZ9yAjoo/m/bfdEuIwVt+F6l/+0Wn7uuw66OlyNNTH5jshsig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8ANFPoGNQGzKup1MLOP76wohv2h6FEkfMHrsonsw4Mg=; b=Y1yuQCKcqTwAv2A3uAFQJKuKXopB1jBgUgNh/YoFs1ydadExOyifKkkI3C5lobpQST39tQi2p/CxnokuTyctulcHLDqzevxcmKTWcBFIHGox7V8itX7sdXfBBM24rZQAuf/KnGIl6ytNJo3+tIQk6LiUPwy3yXDuf3l3nzkDcsyhtgI3GFhZzLYr9G9AODO6fCkN9Dc2GoP4+rA0wofg7eO9vhSyLFXokssJ3AYjFIYX9bS4COwHMWV1UFwg7NVpiVXrsDw/CZh/UqtR8M8xzBa2gF3kGWXt5u64AMgDigtxil6KQnQwmPKNZdvh/S3P+Wing/txLyr8xu+fprqyNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8ANFPoGNQGzKup1MLOP76wohv2h6FEkfMHrsonsw4Mg=; b=fLJAudKmPxD/M1+Vh5GCP+YsBRnvONw96Y3qtnwtCZ2OUPTb6VjW9yY/1UZxxwUFEaxbhbtG9b24z2qPo+WZ8SKNM1JhzmY1WrKX98J88U5uZNaUydcb9mEdAbK4mxm45rfpqwvsfpOVrHmSZCuR+yhtDSWqr/A1W3PAMFSdiBc= Received: from BN6PR11MB3985.namprd11.prod.outlook.com (10.255.129.78) by BN6PR11MB1985.namprd11.prod.outlook.com (10.173.31.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.15; Tue, 10 Sep 2019 07:46:04 +0000 Received: from BN6PR11MB3985.namprd11.prod.outlook.com ([fe80::5864:dae1:9b7e:ff83]) by BN6PR11MB3985.namprd11.prod.outlook.com ([fe80::5864:dae1:9b7e:ff83%4]) with mapi id 15.20.2241.018; Tue, 10 Sep 2019 07:46:04 +0000 From: To: CC: , , , , Subject: [PATCH 1/2] staging: wilc1000: remove unused interrupt status handling code Thread-Topic: [PATCH 1/2] staging: wilc1000: remove unused interrupt status handling code Thread-Index: AQHVZ6vMJxNkB4UPSE+yElL8DxZzpw== Date: Tue, 10 Sep 2019 07:46:04 +0000 Message-ID: <20190910074514.3073-1-ajay.kathat@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MAXPR0101CA0002.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:c::12) To BN6PR11MB3985.namprd11.prod.outlook.com (2603:10b6:405:7b::14) x-mailer: git-send-email 2.22.0 x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [27.59.41.188] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 961d2cef-aa9d-474f-01fa-08d735c2eeaf x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:BN6PR11MB1985; x-ms-traffictypediagnostic: BN6PR11MB1985: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 01565FED4C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(366004)(396003)(136003)(346002)(39860400002)(189003)(199004)(3846002)(6506007)(6486002)(25786009)(476003)(7736002)(1076003)(71190400001)(71200400001)(6116002)(2501003)(2616005)(305945005)(5660300002)(486006)(52116002)(2351001)(2906002)(14454004)(99286004)(26005)(186003)(478600001)(256004)(14444005)(50226002)(102836004)(66946007)(66476007)(66556008)(64756008)(66446008)(5640700003)(6916009)(81156014)(81166006)(86362001)(8676002)(8936002)(316002)(36756003)(66066001)(53936002)(107886003)(6436002)(54906003)(4326008)(386003)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR11MB1985;H:BN6PR11MB3985.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: GoGmPLCoCBKJ9ALGcBE0uj5yEHZZ4kYVBgrwjohTvjQHeSKUvHRuAYtUZOvni5kbWY+43RyXp9SGy5mqlzX0ZfOJ7iU52i+N3RwR5SLylb2vFtVWTsEzWCn6UVBKzG+dsaKckHa+iHk5++BHbPqjoWXf2Lu7LWUIjS+C+otHOElMacMlxgh0X3ZDYWWkqQh65jR1CQ8E4R0Plqgn41cl79eymHY4hOcEzmpwlL4n6enSGCMYe6OuUX6pfujuYXnTqfNtOgO9NDmTCxBYlLkQorCmhq3Yt35orclSwXKqx+EuUqEqfJa9b8LY3bIZF62LC5JhhttYlcfr5dQ+ZLlJZzRvXYNauUWuW19Z6ZOAj6rSO+euUSxMOP34wOYFV907/Thy21GJjPlif0iw1yv/NvS7gbrSn2OqowVTmKsiZwM= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 961d2cef-aa9d-474f-01fa-08d735c2eeaf X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Sep 2019 07:46:04.5316 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1ahRJROMkPMUxnxboLdXiFlInmxNyNne/o5op7cT7KozCfTg8y5CeYKEJn1u8a38/J9GvJRklBHn30sJdbAqHBRrdZYIajK00ueeeMqG++o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1985 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Ajay Singh Remove interrupt handling for unused interrupt status(PLL update and Sleep). The firmware only initiates the interrupt for the data transfer to host and rest are not used anymore. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c | 26 -------------------------- drivers/staging/wilc1000/wilc_wlan.h | 10 ++-------- 2 files changed, 2 insertions(+), 34 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index 2bbb359d2119..771d8cb68dc1 100644 --- a/drivers/staging/wilc1000/wilc_wlan.c +++ b/drivers/staging/wilc1000/wilc_wlan.c @@ -758,26 +758,6 @@ static void wilc_unknown_isr_ext(struct wilc *wilc) wilc->hif_func->hif_clear_int_ext(wilc, 0); } -static void wilc_pllupdate_isr_ext(struct wilc *wilc, u32 int_stats) -{ - int trials = 10; - - wilc->hif_func->hif_clear_int_ext(wilc, PLL_INT_CLR); - - if (wilc->io_type == WILC_HIF_SDIO) - mdelay(WILC_PLL_TO_SDIO); - else - mdelay(WILC_PLL_TO_SPI); - - while (!(is_wilc1000(wilc_get_chipid(wilc, true)) && --trials)) - mdelay(1); -} - -static void wilc_sleeptimer_isr_ext(struct wilc *wilc, u32 int_stats1) -{ - wilc->hif_func->hif_clear_int_ext(wilc, SLEEP_INT_CLR); -} - static void wilc_wlan_handle_isr_ext(struct wilc *wilc, u32 int_status) { u32 offset = wilc->rx_buffer_offset; @@ -827,15 +807,9 @@ void wilc_handle_isr(struct wilc *wilc) acquire_bus(wilc, WILC_BUS_ACQUIRE_AND_WAKEUP); wilc->hif_func->hif_read_int(wilc, &int_status); - if (int_status & PLL_INT_EXT) - wilc_pllupdate_isr_ext(wilc, int_status); - if (int_status & DATA_INT_EXT) wilc_wlan_handle_isr_ext(wilc, int_status); - if (int_status & SLEEP_INT_EXT) - wilc_sleeptimer_isr_ext(wilc, int_status); - if (!(int_status & (ALL_INT_EXT))) wilc_unknown_isr_ext(wilc); diff --git a/drivers/staging/wilc1000/wilc_wlan.h b/drivers/staging/wilc1000/wilc_wlan.h index f566d040bb72..7469fa47d588 100644 --- a/drivers/staging/wilc1000/wilc_wlan.h +++ b/drivers/staging/wilc1000/wilc_wlan.h @@ -128,8 +128,6 @@ #define WILC_CFG_RSP_STATUS 2 #define WILC_CFG_RSP_SCAN 3 -#define WILC_PLL_TO_SDIO 4 -#define WILC_PLL_TO_SPI 2 #define WILC_ABORT_REQ_BIT BIT(31) #define WILC_RX_BUFF_SIZE (96 * 1024) @@ -185,14 +183,10 @@ #define EN_VMM BIT(8) #define DATA_INT_EXT INT_0 -#define PLL_INT_EXT INT_1 -#define SLEEP_INT_EXT INT_2 -#define ALL_INT_EXT (DATA_INT_EXT | PLL_INT_EXT | SLEEP_INT_EXT) -#define NUM_INT_EXT 3 +#define ALL_INT_EXT DATA_INT_EXT +#define NUM_INT_EXT 1 #define DATA_INT_CLR CLR_INT0 -#define PLL_INT_CLR CLR_INT1 -#define SLEEP_INT_CLR CLR_INT2 #define ENABLE_RX_VMM (SEL_VMM_TBL1 | EN_VMM) #define ENABLE_TX_VMM (SEL_VMM_TBL0 | EN_VMM) From patchwork Tue Sep 10 07:46:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ajay Singh X-Patchwork-Id: 11138885 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6C65014DB for ; Tue, 10 Sep 2019 07:46:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40AAB21479 for ; Tue, 10 Sep 2019 07:46:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="Rmbjdixa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404603AbfIJHqN (ORCPT ); Tue, 10 Sep 2019 03:46:13 -0400 Received: from esa1.microchip.iphmx.com ([68.232.147.91]:6666 "EHLO esa1.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728157AbfIJHqM (ORCPT ); Tue, 10 Sep 2019 03:46:12 -0400 Received-SPF: Pass (esa1.microchip.iphmx.com: domain of Ajay.Kathat@microchip.com designates 198.175.253.82 as permitted sender) identity=mailfrom; client-ip=198.175.253.82; receiver=esa1.microchip.iphmx.com; envelope-from="Ajay.Kathat@microchip.com"; x-sender="Ajay.Kathat@microchip.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 mx a:ushub1.microchip.com a:smtpout.microchip.com a:mx1.microchip.iphmx.com a:mx2.microchip.iphmx.com include:servers.mcsv.net include:mktomail.com include:spf.protection.outlook.com ~all" Received-SPF: None (esa1.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@email.microchip.com) identity=helo; client-ip=198.175.253.82; receiver=esa1.microchip.iphmx.com; envelope-from="Ajay.Kathat@microchip.com"; x-sender="postmaster@email.microchip.com"; x-conformance=spf_only Authentication-Results: esa1.microchip.iphmx.com; spf=Pass smtp.mailfrom=Ajay.Kathat@microchip.com; spf=None smtp.helo=postmaster@email.microchip.com; dkim=pass (signature verified) header.i=@microchiptechnology.onmicrosoft.com; dmarc=pass (p=none dis=none) d=microchip.com IronPort-SDR: EY2HDGgTI7tpHJoJ7NzGC8RMehU2Eu5foxmbkpuJWRJuFrIJnJphhjz3uv0H8zbJUh+sTGTm36 RQX0a4mDAC++vAAbQuTkzvSQGk1qKhd/BsbS0SiNoNnoHXFGjfsvT8FwO7UeJQHVrmb1B4sxnG FHwGBoMRcRp77LJKKKAGbVeLBiAO4VGOcOVa2As7iSvgiOsFx0XfezSoq6bqv+hrNYBKbqyAsz yYRzqkW8A9+m3vNTCaJveETNEYCDmcUuGkI4yA900LgWFIFxh9h7vtQuXp8swiiURr0dNFHItq S40= X-IronPort-AV: E=Sophos;i="5.64,487,1559545200"; d="scan'208";a="49856980" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 10 Sep 2019 00:46:09 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 10 Sep 2019 00:46:09 -0700 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 10 Sep 2019 00:46:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MYPrUMk7Hki4TTVi2SWhvtFWZ3UlelO/p+xO81GAG/r67MCyZ65HxOP1Hrnt5GJA3lDqg6kOxlU02rKYdDPYUxvhlo6S6bkpLO2YRKJquWJdT9q0lWzDzyBPWuo1MzJTVP5fiK75H68jjnf/xkD5KEFNnfXf2u7DiQmT9j0qAIJp7N/DtDf9E9PhwCvdj0RabKmTcZMcXVeOVBF0IDPAWgkULUCf+BLGB4aM0GS8d3ABSObc4JxM63OOB2mYiHoaQuMULQ1cSN0LL4kVmW/ukz7gs6hJuRgxhCaewajZpbZkJ05ND5qDNhlnL4BXQQdoXLOfGW8jz2htuDmG4085Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZitsTgT7/DVZDIBDg0XpL7bClgr9eqjd4AiNqpzHhAY=; b=VEHpRGXxmiJVm7L2uuT/zPPEeMy4ymz1qqVUZgbWjHn6NEF8cUCTh3G7gsq/A4Jg836zrm2VcqastqAA+hEI0Q7BWhQNBQystHbYu0hEwixLVwoRxEGDGWqjquZGGX3Ghn1RxDIkyCM2eCLfoGApbsNdgE4ULdIRdTKs3MLbQPX4ljCigMQdxdo8K2SWzSMQvLBzfCFALMRp/YfV9Id11D53efFTMeIzjZEK1LY0lbwAP6eJz/PIeI3s7/MPxFfp6Qrq9qayPO89Isr7YCSgJQXAR9+jqV/u9WUWX57ekb3qySJBlaAQ/mplkWWmUVBJd4kfO9pvZxhjKxvLhkVlGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZitsTgT7/DVZDIBDg0XpL7bClgr9eqjd4AiNqpzHhAY=; b=RmbjdixaEly90GdYL6EQAZIQrIHaEqnCdOoP3fbM/nvS72vlpd01lxCNpf9rTYPE4gpYSKwRTAdTTwptG8VXlN5Aibi8bDzg7s9Qxn7LZkLq3es2muHA3AxsBGBnUKz++HPFpoB124k/iDffSIzpwqCym9FQx8U0cGl60n4PgAI= Received: from BN6PR11MB3985.namprd11.prod.outlook.com (10.255.129.78) by BN6PR11MB1985.namprd11.prod.outlook.com (10.173.31.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.15; Tue, 10 Sep 2019 07:46:08 +0000 Received: from BN6PR11MB3985.namprd11.prod.outlook.com ([fe80::5864:dae1:9b7e:ff83]) by BN6PR11MB3985.namprd11.prod.outlook.com ([fe80::5864:dae1:9b7e:ff83%4]) with mapi id 15.20.2241.018; Tue, 10 Sep 2019 07:46:08 +0000 From: To: CC: , , , , Subject: [PATCH 2/2] staging: wilc1000: avoid twice IRQ handler execution for each single interrupt Thread-Topic: [PATCH 2/2] staging: wilc1000: avoid twice IRQ handler execution for each single interrupt Thread-Index: AQHVZ6vOQhEXwUqqEECS+kD89ZsUxA== Date: Tue, 10 Sep 2019 07:46:07 +0000 Message-ID: <20190910074514.3073-2-ajay.kathat@microchip.com> References: <20190910074514.3073-1-ajay.kathat@microchip.com> In-Reply-To: <20190910074514.3073-1-ajay.kathat@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MAXPR0101CA0002.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:c::12) To BN6PR11MB3985.namprd11.prod.outlook.com (2603:10b6:405:7b::14) x-mailer: git-send-email 2.22.0 x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [27.59.41.188] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 610f095f-60f0-4e2a-b0c1-08d735c2f0ba x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:BN6PR11MB1985; x-ms-traffictypediagnostic: BN6PR11MB1985: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 01565FED4C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(366004)(396003)(136003)(346002)(39860400002)(189003)(199004)(3846002)(6506007)(11346002)(6486002)(25786009)(476003)(7736002)(1076003)(71190400001)(71200400001)(446003)(6116002)(2501003)(2616005)(305945005)(5660300002)(486006)(52116002)(2351001)(4744005)(2906002)(14454004)(99286004)(26005)(186003)(478600001)(256004)(14444005)(50226002)(102836004)(66946007)(66476007)(66556008)(64756008)(66446008)(5640700003)(6916009)(76176011)(81156014)(81166006)(86362001)(8676002)(8936002)(316002)(36756003)(66066001)(53936002)(107886003)(6436002)(54906003)(4326008)(386003)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR11MB1985;H:BN6PR11MB3985.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: jmqg+jN3T4bT5oBkI2iXZ5uAaI86cvyO5JEnasERXxMVsjDoXNUoodjrhxH9y1msLp8AJw9UwfuHchglxxuA1RJkg8guRSFi/Lx4EV4k0mSV0Qvr9smnL4l48GpeucUXfaQvgqR3jfKm+fNV7SJ8yGFVZFR+msi2ugSauipR6mS30PorIT3C4v+Lx4r4xVGqSBQykGBb194HhkH0d938RTVDKxm6DvmFzuW2Tamw0NNmLt07OA8aTo5+3Yu8CL8EX5fyR3ahUg7u5RGax9HJKU9rjUmtb+kTlsfvxHZU1F2XyowXuwaE2DsXR/RhkmwOxrRx1RfUqH6CSh8oYop6U22egaSWElbGWyvo7wAaN8+j7G0aG99cWUZWc9wCj8DFCVG4Qy+jijQOA/880FAO+yD6hgRAayCyIb6/AgQ7lDA= Content-ID: <305B38B0D662BF4F97BCD7AE005AB44C@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 610f095f-60f0-4e2a-b0c1-08d735c2f0ba X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Sep 2019 07:46:07.8436 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: e1eLjeja8mgmiy4Gl0eLCzEE8y34jSpH6YDJi/82u0FD4cK4QQOltSj8OnCk3E1bLhBE8pVygPih0sDH6NkoP4xobi3aK2rjSja7PjeYtqY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1985 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Ajay Singh The IRQ handler(isr_bh_routine()) was called twice for each interrupt from firmware. The data was read completely during the first call and the second call was doing nothing. Now changed the IRQ flag from ‘level’ to ‘edge’ trigger i.e IRQF_TRIGGER_LOW to IRQF_TRIGGER_FALLING to avoid extra interrupt trigger. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_netdev.c b/drivers/staging/wilc1000/wilc_netdev.c index cd11c35adcfe..508acb8bb089 100644 --- a/drivers/staging/wilc1000/wilc_netdev.c +++ b/drivers/staging/wilc1000/wilc_netdev.c @@ -60,7 +60,7 @@ static int init_irq(struct net_device *dev) ret = request_threaded_irq(wl->dev_irq_num, isr_uh_routine, isr_bh_routine, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "WILC_IRQ", dev); if (ret < 0) netdev_err(dev, "Failed to request IRQ\n");