From patchwork Tue Sep 10 14:43:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Popa X-Patchwork-Id: 11139695 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 51F27924 for ; Tue, 10 Sep 2019 14:44:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2526C208E4 for ; Tue, 10 Sep 2019 14:44:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=analog.onmicrosoft.com header.i=@analog.onmicrosoft.com header.b="8Tiu8Mx6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727925AbfIJOoT (ORCPT ); Tue, 10 Sep 2019 10:44:19 -0400 Received: from mx0a-00128a01.pphosted.com ([148.163.135.77]:16522 "EHLO mx0a-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725935AbfIJOoT (ORCPT ); Tue, 10 Sep 2019 10:44:19 -0400 Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8AEhacq014269; Tue, 10 Sep 2019 10:43:48 -0400 Received: from nam02-cy1-obe.outbound.protection.outlook.com (mail-cys01nam02lp2059.outbound.protection.outlook.com [104.47.37.59]) by mx0a-00128a01.pphosted.com with ESMTP id 2uv9f6ahtv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Sep 2019 10:43:48 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KFMg5Y6fwsGvkVrVLIKV+rJJCGn9J9ZmI19fgryFuTXMT7DnL69FzZqC1pptsJ+uYGpNbFn+w8yI24fieUwkhAYyDbRQYuyFtQc5eiAIXDOYfC4jCdVyZnExW6tDh3VyIyZuAqV0LX8GUBaq0rCCHboVmecVs+YSbo/XoJpzJsdtyMQYW+WAl61F0tDfg+aBHTbdtZGqA8zQPlza323ajKaZ2LsW/K1S4za+Rm28QairPbhypgOQkXnD91YkR9XOhXFjxUjyI9x00vh6MtlTsiFXAaXSY7t6yAEKdrR/0gQSKuc7eSRSfHw/1e4vYbrwTZupX/91uLPRAnVyBym4MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=POajf/KlRCSSRHjI0CEDVfbADDg05/wbdDPcrno9tt8=; b=YZqldz6hh5kfCeBb4gZuP5H+OCf+Yfpr8LZaZqj2KBYk7s+c0ZENaXM+D2Dpf8vbaTtyNLQg9GWN/dDP1kkvW0bJCCuZ2or10VcCLyBmPUSBBjip0csVnkguIqTgEQWpDU+OXMdyUPtHNBtsENJHrr3EN/LdUg0V4QwxXxId6G31nZW8tei5LncI/AhEkwZQzFHK99SvvOSYM3YRgSGULsULbrIKK/0yOT4pRg2SKP9c/mVfRY8BoYsiJWtJFMjyVvd+07mMJj0+gRdu8UWxXCyG7b+9XvckAJ2R7Ybo9qWl7OwzLTbdBeiDR1qbEMi1TOQEMcjOyCPb/6EtyG3tGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 137.71.25.55) smtp.rcpttodomain=gmx.de smtp.mailfrom=analog.com; dmarc=bestguesspass action=none header.from=analog.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.onmicrosoft.com; s=selector2-analog-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=POajf/KlRCSSRHjI0CEDVfbADDg05/wbdDPcrno9tt8=; b=8Tiu8Mx61Hv7ZQElX5fe+n/qnS3TRbGGRa4fUM8YjDixaZwcMP8sJ4VpRr82qb5ck7PJQ3jh5D9gWjWuzbmOIOs8uGJ6YIdqwOyvjJNDZHnRen5R5yHXAS0wBvBcSVtFuHJB3qyTuHxAz1g8MZL2sgJiwUoKSnernap3CIDjVog= Received: from BN6PR03CA0076.namprd03.prod.outlook.com (2603:10b6:405:6f::14) by CH2PR03MB5189.namprd03.prod.outlook.com (2603:10b6:610:a1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.13; Tue, 10 Sep 2019 14:43:46 +0000 Received: from CY1NAM02FT031.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::207) by BN6PR03CA0076.outlook.office365.com (2603:10b6:405:6f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.15 via Frontend Transport; Tue, 10 Sep 2019 14:43:46 +0000 Received-SPF: Pass (protection.outlook.com: domain of analog.com designates 137.71.25.55 as permitted sender) receiver=protection.outlook.com; client-ip=137.71.25.55; helo=nwd2mta1.analog.com; Received: from nwd2mta1.analog.com (137.71.25.55) by CY1NAM02FT031.mail.protection.outlook.com (10.152.75.180) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2241.14 via Frontend Transport; Tue, 10 Sep 2019 14:43:46 +0000 Received: from NWD2HUBCAS7.ad.analog.com (nwd2hubcas7.ad.analog.com [10.64.69.107]) by nwd2mta1.analog.com (8.13.8/8.13.8) with ESMTP id x8AEhidD030172 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK); Tue, 10 Sep 2019 07:43:44 -0700 Received: from linux.ad.analog.com (10.32.226.41) by NWD2HUBCAS7.ad.analog.com (10.64.69.107) with Microsoft SMTP Server id 14.3.408.0; Tue, 10 Sep 2019 10:43:44 -0400 From: Stefan Popa To: CC: , , , , , , Subject: [PATCH v2 1/3] iio: accel: adxl372: Fix/remove limitation for FIFO samples Date: Tue, 10 Sep 2019 17:43:32 +0300 Message-ID: <1568126612-13134-1-git-send-email-stefan.popa@analog.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-ADIRoutedOnPrem: True X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.55;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(376002)(346002)(396003)(136003)(39860400002)(2980300002)(189003)(199004)(36756003)(48376002)(50466002)(44832011)(47776003)(8676002)(356004)(6666004)(336012)(7696005)(486006)(50226002)(426003)(478600001)(70206006)(106002)(70586007)(8936002)(4326008)(5660300002)(186003)(476003)(2616005)(107886003)(126002)(305945005)(26005)(7636002)(51416003)(2906002)(246002)(2351001)(54906003)(316002)(16586007)(6916009);DIR:OUT;SFP:1101;SCL:1;SRVR:CH2PR03MB5189;H:nwd2mta1.analog.com;FPR:;SPF:Pass;LANG:en;PTR:nwd2mail10.analog.com;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 816862ab-9db1-4c7c-52c2-08d735fd490a X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(4709080)(1401327)(4618075)(2017052603328);SRVR:CH2PR03MB5189; X-MS-TrafficTypeDiagnostic: CH2PR03MB5189: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-Forefront-PRVS: 01565FED4C X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: vOzVsSaeQ++k3q0Ity8flje/Yif1i3Iux/GWhVm1zA1q/7mJfv0iHJXj4z5hxYuPNAH0pLXzMnAodO0b1A+qt53ptdean2NitSwWhelTWz5qf9nYJ+gq+fLfa9+gLo+d9EIh8CGCR+2hzmOiA3jMtUgs4O3QDDCeIJy1yBry2LKNYQ9U7jM/2JJ0SUSKadSgfHye8wrSTUeFDnWGSg/HpRH7P8uGacFzBzz28YNAdVMtba57Qmb98h4dba6pikvWPUkLAZi/WfxpSoqcWKtRVynksyE7CBftHplaHPGEO6REY0g6Jlw0qjyYoPPD3G+rQ478dHVELW2M4rdijVDgV0RkFawyOAs8u/Aj+vcE0ETk8KrJ5TJ0vQ9FJbhbQR6Bxo4HENXWvmvNIGAbYZnFz83qEP1eiAA0MUX9WDuQBlQ= X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2019 14:43:46.0303 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 816862ab-9db1-4c7c-52c2-08d735fd490a X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.55];Helo=[nwd2mta1.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5189 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-10_10:2019-09-10,2019-09-10 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=1 spamscore=0 adultscore=0 phishscore=0 mlxscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 mlxlogscore=801 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1906280000 definitions=main-1909100142 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Currently, the driver sets the FIFO_SAMPLES register with the number of sample sets (maximum of 170 for 3 axis data, 256 for 2-axis and 512 for single axis). However, the FIFO_SAMPLES register should store the number of samples, regardless of how the FIFO format is configured. Signed-off-by: Stefan Popa --- Changes in v2: - st->watermark needs to store the number of sample sets, the total number of samples is computed in adxl372_configure_fifo() func. drivers/iio/accel/adxl372.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/iio/accel/adxl372.c b/drivers/iio/accel/adxl372.c index 055227cb..7de5e1b 100644 --- a/drivers/iio/accel/adxl372.c +++ b/drivers/iio/accel/adxl372.c @@ -474,12 +474,17 @@ static int adxl372_configure_fifo(struct adxl372_state *st) if (ret < 0) return ret; - fifo_samples = st->watermark & 0xFF; + /* + * watermak stores the number of sets; we need to write the FIFO + * registers with the number of samples + */ + fifo_samples = (st->watermark * st->fifo_set_size); fifo_ctl = ADXL372_FIFO_CTL_FORMAT_MODE(st->fifo_format) | ADXL372_FIFO_CTL_MODE_MODE(st->fifo_mode) | - ADXL372_FIFO_CTL_SAMPLES_MODE(st->watermark); + ADXL372_FIFO_CTL_SAMPLES_MODE(fifo_samples); - ret = regmap_write(st->regmap, ADXL372_FIFO_SAMPLES, fifo_samples); + ret = regmap_write(st->regmap, + ADXL372_FIFO_SAMPLES, fifo_samples & 0xFF); if (ret < 0) return ret; From patchwork Tue Sep 10 14:44:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Popa X-Patchwork-Id: 11139697 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 831A91599 for ; Tue, 10 Sep 2019 14:45:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5632A21019 for ; Tue, 10 Sep 2019 14:45:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=analog.onmicrosoft.com header.i=@analog.onmicrosoft.com header.b="5CFd2kOx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393064AbfIJOpC (ORCPT ); Tue, 10 Sep 2019 10:45:02 -0400 Received: from mx0b-00128a01.pphosted.com ([148.163.139.77]:42432 "EHLO mx0b-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387874AbfIJOpC (ORCPT ); Tue, 10 Sep 2019 10:45:02 -0400 Received: from pps.filterd (m0167090.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8AEhWq6011562; Tue, 10 Sep 2019 10:44:34 -0400 Received: from nam04-co1-obe.outbound.protection.outlook.com (mail-co1nam04lp2053.outbound.protection.outlook.com [104.47.45.53]) by mx0b-00128a01.pphosted.com with ESMTP id 2uv967k39m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 10 Sep 2019 10:44:34 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bZVHQBLh/vtKfMTdzIn4xC+CXSgpUwxK/mYpkV92xKobERAa0zJNfoBr2qeIPoounO7Y6EAWN0Ist7SWDWAEluKKUPKTZofAoAHkcQuBtvB8sZ94RRW3JEVq59paeAD7+USiGXyFvfVaD25pvuQfpYQ0naOCGZC37px6TPejpF81/d1Qsz7Rxi/ZYYCgpQigMUOVqKHAvtynLOeZ29zCZ+NcPtgRPGxZzdYHRv7cPbBPntHBxXj1NNUnfOEyIwZMrh7arD68oZLlsfArzrS3XWWTmTcQtC5tbhw/t2PSg+jYmfruOrWgXZoZCvkyNdgXPmQymDsQbUMwc/fWhuEhfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1cZde7Eyvzsex2pybL4VyV5NycHjyiO9Uk+r61xbFx4=; b=SYsQDlUykLh9980pLLjDszqQbUaHwwDspDoqIL8CJr/gZY74KMw+eJ9R5ChJBje63UqQDz6/UoDeo0mB3KKC01FRyA9gsJWDsgLnTXy+QnbCRtaWURGTodEVd1eg1XuMGaKbkIgUsxgcmi9mOULWo3ZosvEEo9P0SotnJs0ZPVc/Lxp45F1yolO+oUjX7dt4e/lu69tU+ObZjGy5FwAP7/UhqXsMn9wmLpKaIy8ZB/i8eUGKhnw7ZraF/2dOx0EzEMq+jau8ZMg03ne3MV60V+Ncbf/uTWo61mkPE80OjIfQNKCLM6UCk/wKmHpdGr6Oe5vcVzdqZ8MwsIyGLE/oHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 137.71.25.55) smtp.rcpttodomain=gmx.de smtp.mailfrom=analog.com; dmarc=bestguesspass action=none header.from=analog.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.onmicrosoft.com; s=selector2-analog-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1cZde7Eyvzsex2pybL4VyV5NycHjyiO9Uk+r61xbFx4=; b=5CFd2kOxdCHMmCNtgE25q2HODCZaTgRqbVosBYX7M1Rocw6md+3ghujt3vErZWmKuW2Bv6I+Olf5d1AL/GjwSYnT/RSiX/e/2VQA/w7vC5UJNgVUi0bwT5cBXBlnmuCrGwgfzZwR2cEd6qa4eGbJD/x9rVSdPS6rsWsNstSNqkM= Received: from BN3PR03CA0097.namprd03.prod.outlook.com (2603:10b6:400:4::15) by MWHPR03MB3087.namprd03.prod.outlook.com (2603:10b6:301:3c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.15; Tue, 10 Sep 2019 14:44:31 +0000 Received: from SN1NAM02FT003.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::207) by BN3PR03CA0097.outlook.office365.com (2603:10b6:400:4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.15 via Frontend Transport; Tue, 10 Sep 2019 14:44:30 +0000 Received-SPF: Pass (protection.outlook.com: domain of analog.com designates 137.71.25.55 as permitted sender) receiver=protection.outlook.com; client-ip=137.71.25.55; helo=nwd2mta1.analog.com; Received: from nwd2mta1.analog.com (137.71.25.55) by SN1NAM02FT003.mail.protection.outlook.com (10.152.73.29) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2241.14 via Frontend Transport; Tue, 10 Sep 2019 14:44:30 +0000 Received: from NWD2HUBCAS7.ad.analog.com (nwd2hubcas7.ad.analog.com [10.64.69.107]) by nwd2mta1.analog.com (8.13.8/8.13.8) with ESMTP id x8AEiTLa030493 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK); Tue, 10 Sep 2019 07:44:29 -0700 Received: from linux.ad.analog.com (10.32.226.41) by NWD2HUBCAS7.ad.analog.com (10.64.69.107) with Microsoft SMTP Server id 14.3.408.0; Tue, 10 Sep 2019 10:44:28 -0400 From: Stefan Popa To: CC: , , , , , , Subject: [PATCH v2 2/3] iio: accel: adxl372: Fix push to buffers lost samples Date: Tue, 10 Sep 2019 17:44:21 +0300 Message-ID: <1568126661-13318-1-git-send-email-stefan.popa@analog.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-ADIRoutedOnPrem: True X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.55;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(396003)(136003)(346002)(376002)(39860400002)(2980300002)(199004)(189003)(44832011)(47776003)(36756003)(26005)(4744005)(2616005)(476003)(486006)(126002)(336012)(8936002)(426003)(48376002)(51416003)(186003)(478600001)(107886003)(4326008)(6916009)(50466002)(7696005)(246002)(5660300002)(54906003)(16586007)(316002)(8676002)(7636002)(106002)(50226002)(2906002)(70206006)(2351001)(70586007)(6666004)(356004)(305945005);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR03MB3087;H:nwd2mta1.analog.com;FPR:;SPF:Pass;LANG:en;PTR:nwd2mail10.analog.com;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d5378f88-2be7-4390-66b7-08d735fd6336 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(4709080)(1401327)(4618075)(2017052603328);SRVR:MWHPR03MB3087; X-MS-TrafficTypeDiagnostic: MWHPR03MB3087: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-Forefront-PRVS: 01565FED4C X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: FeyKUR905cG7YxKwz9HS3xvX1sTiVhT6IpavnRUOrI8vfsNtqOphV9e/8bF9zbXxQhxhhsuknFwG5zSRcy3PAgHge2ObyKvP+ON7kJtgT4ql02UGpA7Dvh9c/oQnoak72YFmWTWyMvB0jIPGJ4YHaTqfi3o7Kycqo0SjXfimlA0z+tW7IiFe+HpBMM9Lo981a+hAJUwSAeMFPOFx7TF4+dWSCkoPZbBGgiC65WbXnmNSQxJ1cCuWzkYhNxuUYpU8hQgxau4WJL/Ni9nf/rBiyplfi1dVmHpdmwcB2Gfd5jMxsKIQIRJTCsr5XejBPj8MKK/TzC2RfgnrqWZfCNiE9/Am7lM3ezDgJBxNmxJVy7u5IDYCdkzYxmDn6/DKvfoB6CemHCq+FJ3D+CWfnKkZj5hKgFIC1g/CwWTV1bqCdJQ= X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2019 14:44:30.0089 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d5378f88-2be7-4390-66b7-08d735fd6336 X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.55];Helo=[nwd2mta1.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3087 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-10_10:2019-09-10,2019-09-10 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=1 bulkscore=0 clxscore=1015 mlxscore=0 phishscore=0 mlxlogscore=980 impostorscore=0 adultscore=0 malwarescore=0 spamscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1906280000 definitions=main-1909100142 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org One in two sample sets was lost by multiplying fifo_set_size with sizeof(u16). Also, the double number of available samples were pushed to the iio buffers. Signed-off-by: Stefan Popa --- Changes in v2: - Nothing changed. drivers/iio/accel/adxl372.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/accel/adxl372.c b/drivers/iio/accel/adxl372.c index 7de5e1b..33edca8 100644 --- a/drivers/iio/accel/adxl372.c +++ b/drivers/iio/accel/adxl372.c @@ -553,8 +553,7 @@ static irqreturn_t adxl372_trigger_handler(int irq, void *p) goto err; /* Each sample is 2 bytes */ - for (i = 0; i < fifo_entries * sizeof(u16); - i += st->fifo_set_size * sizeof(u16)) + for (i = 0; i < fifo_entries; i += st->fifo_set_size) iio_push_to_buffers(indio_dev, &st->fifo_buf[i]); } err: From patchwork Tue Sep 10 14:44:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Popa X-Patchwork-Id: 11139699 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 22E501599 for ; Tue, 10 Sep 2019 14:45:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9D8D208E4 for ; Tue, 10 Sep 2019 14:45:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=analog.onmicrosoft.com header.i=@analog.onmicrosoft.com header.b="M8uxGuvK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387914AbfIJOpW (ORCPT ); Tue, 10 Sep 2019 10:45:22 -0400 Received: from mx0a-00128a01.pphosted.com ([148.163.135.77]:35736 "EHLO mx0a-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387874AbfIJOpW (ORCPT ); Tue, 10 Sep 2019 10:45:22 -0400 Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8AEhg11026561; Tue, 10 Sep 2019 10:44:57 -0400 Received: from nam01-sn1-obe.outbound.protection.outlook.com (mail-sn1nam01lp2054.outbound.protection.outlook.com [104.47.32.54]) by mx0a-00128a01.pphosted.com with ESMTP id 2uv6d9bhwe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 10 Sep 2019 10:44:57 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K+4c+g8MwW8faLW0gAIpfeK6D9vpFOXYOSGDF6xTZG/Xo7CeVX6IocZ4fYWncDRwjyfSPCncC8Y/Jps97qb8uoBv6Rw3bsGGSTaIXYeqObHNBGXjhMp2XuhylQkeg4qF1XGnu7D9iJW9248xChxgL5O0yI06jqg3TQ2LHbBVhL0qS/yAr3yK+yf9gpeahz2QMCepENms2gXCysr3EDPjNdQFe8apFbAlr88kue+T3JAiZWzqHmiNiJggW/4L6jyS9XJENrKCQJGnHXaZ+c8qxGw2gFjjG2WtglH8rvW0WgOWPjKNbQT90ctg1oglT8swve/fM19lq459qseL2jan4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b3C76eXJO7Tj1DPucNSzH1bRt22WA6j0mmBHGF6ioxA=; b=kW6rcTSwOFSSkxFHEuCVqm/9Z49tHMn/y0ktZGw4O4ag5qH0lp9QA+KyiaTWv2HLRx8+cAgM3Q6fuTYNH0+HKNHpOB8MKMZPw0cxQ2HvqDjN+Nm4ghwhWQCsTAeOevny8Ozp52NRhQF0P3RE9+EMBsWKriTvITdyUEXHf6IW3DoIbMHR5wvK93BfkTpLkz5/5Dy4UpXRLc1y6K1YMQ1ovwvpXKpvQfEJa0B2bs54SsPJRtJ4D0KZfZnQMYi4Keu0XtvgCaaL6ZTCgH6ZourFUBOZvoyXaRkhEqzpBrFndJwMOXhr3Reazyq0NVLIDD4qbqraLkYbY9Pq+dmm+u4kaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 137.71.25.55) smtp.rcpttodomain=gmx.de smtp.mailfrom=analog.com; dmarc=bestguesspass action=none header.from=analog.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.onmicrosoft.com; s=selector2-analog-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b3C76eXJO7Tj1DPucNSzH1bRt22WA6j0mmBHGF6ioxA=; b=M8uxGuvKd74NCJG/g1160+TWPsiOnd1GhFbCcNHOw/G9pnjAMAwH/pkkmVn6Zs4Y9MMZUjr295hm85bwT/+JWfRzrfqBoCfXrq7mUygp7j3UYn9ztxsGFOl4Y4uegRJjTSWObHkvILgQIFmjfh4gXKlJ41gJ0HVN2/W32vT/fDk= Received: from BN6PR03CA0024.namprd03.prod.outlook.com (2603:10b6:404:23::34) by MN2PR03MB4845.namprd03.prod.outlook.com (2603:10b6:208:104::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.20; Tue, 10 Sep 2019 14:44:54 +0000 Received: from BL2NAM02FT047.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::200) by BN6PR03CA0024.outlook.office365.com (2603:10b6:404:23::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.14 via Frontend Transport; Tue, 10 Sep 2019 14:44:54 +0000 Received-SPF: Pass (protection.outlook.com: domain of analog.com designates 137.71.25.55 as permitted sender) receiver=protection.outlook.com; client-ip=137.71.25.55; helo=nwd2mta1.analog.com; Received: from nwd2mta1.analog.com (137.71.25.55) by BL2NAM02FT047.mail.protection.outlook.com (10.152.77.9) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2241.14 via Frontend Transport; Tue, 10 Sep 2019 14:44:54 +0000 Received: from NWD2HUBCAS7.ad.analog.com (nwd2hubcas7.ad.analog.com [10.64.69.107]) by nwd2mta1.analog.com (8.13.8/8.13.8) with ESMTP id x8AEis7p030641 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK); Tue, 10 Sep 2019 07:44:54 -0700 Received: from linux.ad.analog.com (10.32.226.41) by NWD2HUBCAS7.ad.analog.com (10.64.69.107) with Microsoft SMTP Server id 14.3.408.0; Tue, 10 Sep 2019 10:44:53 -0400 From: Stefan Popa To: CC: , , , , , , Subject: [PATCH v2 3/3] iio: accel: adxl372: Perform a reset at start up Date: Tue, 10 Sep 2019 17:44:46 +0300 Message-ID: <1568126686-13436-1-git-send-email-stefan.popa@analog.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-ADIRoutedOnPrem: True X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.55;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(39860400002)(346002)(376002)(136003)(396003)(2980300002)(199004)(189003)(7696005)(4326008)(336012)(486006)(54906003)(70206006)(44832011)(70586007)(2616005)(316002)(106002)(8676002)(5660300002)(426003)(476003)(126002)(6666004)(356004)(2351001)(47776003)(36756003)(478600001)(8936002)(50226002)(26005)(50466002)(16586007)(48376002)(186003)(107886003)(246002)(7636002)(305945005)(51416003)(2906002)(6916009);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR03MB4845;H:nwd2mta1.analog.com;FPR:;SPF:Pass;LANG:en;PTR:nwd2mail10.analog.com;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 00958c21-d07a-4c40-723f-08d735fd71a4 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(4709080)(1401327)(4618075)(2017052603328);SRVR:MN2PR03MB4845; X-MS-TrafficTypeDiagnostic: MN2PR03MB4845: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-Forefront-PRVS: 01565FED4C X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: Om57bHmbkJ5os5phqVNBNkYod6z2WgRrMHhd7o8ea0I2EIdXgpEu7tpAiccnMW6azqsFGgqy8RZ4SXcmq36Gg6UeIwlL9Yn0nJUIIA2ifqwaZXicI3oCaa+0L0TtNTNO9hvMIYmpEArvX0yryXWQAAitEt85/PZX98fVkJpUhbsucrzBzbrdArhv0l+2Ig8LhkOxTs/XHy6yMWcTT9R+ExrCCnua6WZX3u+LRy6jchGy6nGMQX4NTh/F99A+PjTxlFgeWe9O5wS7nirdsxb8r+T/couLaOBTllmSztpKs3VAOLiwWGZgNNHkqE6g2Cl4hzk0yzZh5uy20myHRjST+3/9l+nRnVSNGJs4t7Oz56NauhB4q+8wbXJu3fYG4IIe1TIp4pOIDOiHtUk3CVRcSKw6uhppMp7zu5RYB7Isr+0= X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2019 14:44:54.3843 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 00958c21-d07a-4c40-723f-08d735fd71a4 X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.55];Helo=[nwd2mta1.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4845 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-10_10:2019-09-10,2019-09-10 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 malwarescore=0 suspectscore=1 priorityscore=1501 lowpriorityscore=0 bulkscore=0 spamscore=0 mlxlogscore=720 adultscore=0 clxscore=1015 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1906280000 definitions=main-1909100142 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org We need to perform a reset a start up to make sure that the chip is in a consistent state. This reset also disables all the interrupts which should only be enabled together with the iio buffer. Not doing this, was sometimes causing unwanted interrupts to trigger. Signed-off-by: Stefan Popa --- Changes in v2: - Instead of disabling the interrupts, now this patch performs a software reset. drivers/iio/accel/adxl372.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/iio/accel/adxl372.c b/drivers/iio/accel/adxl372.c index 33edca8..8a00528 100644 --- a/drivers/iio/accel/adxl372.c +++ b/drivers/iio/accel/adxl372.c @@ -575,6 +575,14 @@ static int adxl372_setup(struct adxl372_state *st) return -ENODEV; } + /* + * Perform a software reset to make sure the device is in a consistent + * state after start up. + */ + ret = regmap_write(st->regmap, ADXL372_RESET, ADXL372_RESET_CODE); + if (ret < 0) + return ret; + ret = adxl372_set_op_mode(st, ADXL372_STANDBY); if (ret < 0) return ret;