From patchwork Mon Sep 10 18:01:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Limonciello, Mario" X-Patchwork-Id: 10594683 X-Patchwork-Delegate: dvhart@infradead.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6C8856CB for ; Mon, 10 Sep 2018 18:02:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5DC73291E2 for ; Mon, 10 Sep 2018 18:02:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5211329369; Mon, 10 Sep 2018 18:02:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ECAE7291E2 for ; Mon, 10 Sep 2018 18:02:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727998AbeIJW51 (ORCPT ); Mon, 10 Sep 2018 18:57:27 -0400 Received: from esa5.dell-outbound.iphmx.com ([68.232.153.95]:44351 "EHLO esa5.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726709AbeIJW51 (ORCPT ); Mon, 10 Sep 2018 18:57:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dell.com; i=@dell.com; q=dns/txt; s=smtpout; t=1536602474; x=1568138474; h=from:to:cc:subject:date:message-id; bh=z3TIGbAa2zYB36YOsBqfvxGSNJnCeTk8tXR6O9WdllY=; b=LIQKXLcOPc99xPIsEVoq9HG0ykQxkLVkPoiyVKudNrabrlSeJGApzkcZ ffdROP1NligFir5rDPJm8KZguYKw369zbEZOA4jO9d0EgihbSLp04l6mc 7PYU4Sbtze/O3vcDuQYozrpTOpQaApfCtwDEsYiedPsHtczCQCNIh+sSe g=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2HfAQB/sJZbhyWd50NcHgEGDIUyKIxki0CYQYF6C4Rsg30hNRcBAgEBAgEBAgEBAhABAQEKCwkIKS+CNSQBgmIWFVJPbwESIoJ/ggKaWIlXAQEBgWgzigGGT4QWgVg/gRKNaAKONI1UBwKCBASNegIVjnCTZgIEAgQFAhSBQwGCDHCDPIIzjj5RjhYBAQ X-IPAS-Result: A2HfAQB/sJZbhyWd50NcHgEGDIUyKIxki0CYQYF6C4Rsg30hNRcBAgEBAgEBAgEBAhABAQEKCwkIKS+CNSQBgmIWFVJPbwESIoJ/ggKaWIlXAQEBgWgzigGGT4QWgVg/gRKNaAKONI1UBwKCBASNegIVjnCTZgIEAgQFAhSBQwGCDHCDPIIzjj5RjhYBAQ Received: from mx0b-00154901.pphosted.com ([67.231.157.37]) by esa5.dell-outbound.iphmx.com with ESMTP/TLS/AES256-SHA256; 10 Sep 2018 13:01:13 -0500 Received: from pps.filterd (m0144104.ppops.net [127.0.0.1]) by mx0b-00154901.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8AHwmEh107550; Mon, 10 Sep 2018 14:02:09 -0400 Received: from esa2.dell-outbound2.iphmx.com (esa2.dell-outbound2.iphmx.com [68.232.153.202]) by mx0b-00154901.pphosted.com with ESMTP id 2mdsbj1pky-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 10 Sep 2018 14:02:08 -0400 Received: from ausc60pc101.us.dell.com ([143.166.85.206]) by esa2.dell-outbound2.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA256; 11 Sep 2018 00:02:06 +0600 X-LoopCount0: from 10.173.37.27 X-IronPort-AV: E=Sophos;i="5.53,356,1531803600"; d="scan'208";a="1298566026" From: Mario Limonciello To: dvhart@infradead.org, Andy Shevchenko Cc: LKML , platform-driver-x86@vger.kernel.org, Mario Limonciello , stable@vger.kernel.org Subject: [PATCH 1/2] platform/x86: dell-smbios-wmi: Correct a memory leak Date: Mon, 10 Sep 2018 13:01:52 -0500 Message-Id: <1536602513-13861-1-git-send-email-mario.limonciello@dell.com> X-Mailer: git-send-email 2.7.4 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-09-10_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=974 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809100178 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP ACPI buffers were being allocated but never freed. Reported-by: Pinzhen Xu Signed-off-by: Mario Limonciello Cc: stable@vger.kernel.org --- drivers/platform/x86/dell-smbios-wmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/dell-smbios-wmi.c b/drivers/platform/x86/dell-smbios-wmi.c index 88afe56..cf2229e 100644 --- a/drivers/platform/x86/dell-smbios-wmi.c +++ b/drivers/platform/x86/dell-smbios-wmi.c @@ -78,6 +78,7 @@ static int run_smbios_call(struct wmi_device *wdev) dev_dbg(&wdev->dev, "result: [%08x,%08x,%08x,%08x]\n", priv->buf->std.output[0], priv->buf->std.output[1], priv->buf->std.output[2], priv->buf->std.output[3]); + kfree(output.pointer); return 0; } From patchwork Mon Sep 10 18:01:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Limonciello, Mario" X-Patchwork-Id: 10594681 X-Patchwork-Delegate: dvhart@infradead.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D07C913B8 for ; Mon, 10 Sep 2018 18:02:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C027F291E2 for ; Mon, 10 Sep 2018 18:02:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B403C29369; Mon, 10 Sep 2018 18:02:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5E08E291E2 for ; Mon, 10 Sep 2018 18:02:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727031AbeIJW52 (ORCPT ); Mon, 10 Sep 2018 18:57:28 -0400 Received: from esa6.dell-outbound.iphmx.com ([68.232.149.229]:64654 "EHLO esa6.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726709AbeIJW52 (ORCPT ); Mon, 10 Sep 2018 18:57:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dell.com; i=@dell.com; q=dns/txt; s=smtpout; t=1536602532; x=1568138532; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=g7d3HqtijHvSG1qn2XepmMw02he+0ZSar6vu1PYZCmc=; b=fXaqM1dBvLD5krD9+xrvN7p9Ks2rFatyZnD5oXBoQImZJYanIG/rlArK Ub/P/843zyXQKTSc50kWP/c63rKcwbtvETdxrtGrdJbthPon0PebJtn3R NDc41Qc6kUqehbiirXuh5OSKcppHlELKjm/a103G5O5u1ILdk4X95rA7I c=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2GqAADusJZbhyWd50NcHQEBBQELAYUyKIwFX4tAmEGBeguEbAKDeyE0GAECAQECAQECAQECEAEBAQoLCQgpL4I1JAGCYAIBAxIVUhA/ElcGARIign+CAppaiVcBAQGBaDOKAYZPhBaBWD+BEo1oAo40jVQHAoIEBI16AhWOcJNmAgQCBAUCFIFCgg5wgzyCM44+UY4WAQE X-IPAS-Result: A2GqAADusJZbhyWd50NcHQEBBQELAYUyKIwFX4tAmEGBeguEbAKDeyE0GAECAQECAQECAQECEAEBAQoLCQgpL4I1JAGCYAIBAxIVUhA/ElcGARIign+CAppaiVcBAQGBaDOKAYZPhBaBWD+BEo1oAo40jVQHAoIEBI16AhWOcJNmAgQCBAUCFIFCgg5wgzyCM44+UY4WAQE Received: from mx0b-00154901.pphosted.com ([67.231.157.37]) by esa6.dell-outbound.iphmx.com with ESMTP/TLS/AES256-SHA256; 10 Sep 2018 13:02:11 -0500 Received: from pps.filterd (m0144104.ppops.net [127.0.0.1]) by mx0b-00154901.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8AHwmEi107550; Mon, 10 Sep 2018 14:02:10 -0400 Received: from esa2.dell-outbound2.iphmx.com (esa2.dell-outbound2.iphmx.com [68.232.153.202]) by mx0b-00154901.pphosted.com with ESMTP id 2mdsbj1pky-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 10 Sep 2018 14:02:09 -0400 Received: from ausc60pc101.us.dell.com ([143.166.85.206]) by esa2.dell-outbound2.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA256; 11 Sep 2018 00:02:07 +0600 X-LoopCount0: from 10.173.37.27 X-IronPort-AV: E=Sophos;i="5.53,356,1531803600"; d="scan'208";a="1298566027" From: Mario Limonciello To: dvhart@infradead.org, Andy Shevchenko Cc: LKML , platform-driver-x86@vger.kernel.org, Mario Limonciello , stable@vger.kernel.org Subject: [PATCH 2/2] platform/x86: alienware-wmi: Correct a memory leak Date: Mon, 10 Sep 2018 13:01:53 -0500 Message-Id: <1536602513-13861-2-git-send-email-mario.limonciello@dell.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536602513-13861-1-git-send-email-mario.limonciello@dell.com> References: <1536602513-13861-1-git-send-email-mario.limonciello@dell.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-09-10_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=994 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809100178 Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP An ACPI buffer that was allocated was not being freed after use. Signed-off-by: Mario Limonciello Cc: stable@vger.kernel.org --- drivers/platform/x86/alienware-wmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/alienware-wmi.c b/drivers/platform/x86/alienware-wmi.c index d975462..f10af5c 100644 --- a/drivers/platform/x86/alienware-wmi.c +++ b/drivers/platform/x86/alienware-wmi.c @@ -536,6 +536,7 @@ static acpi_status alienware_wmax_command(struct wmax_basic_args *in_args, if (obj && obj->type == ACPI_TYPE_INTEGER) *out_data = (u32) obj->integer.value; } + kfree(output.pointer); return status; }