From patchwork Fri Sep 13 14:50:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 11144837 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 206AF1599 for ; Fri, 13 Sep 2019 14:50:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3B9F214D8 for ; Fri, 13 Sep 2019 14:50:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568386238; bh=WV54R9SAWNCwgT4JV9vnWV2FEozZ1/JL/HN3Hp+AaZc=; h=From:Cc:Subject:Date:In-Reply-To:References:To:List-ID:From; b=MrQaGP5xMHzDJMna5wUmFF5t2pXZu473KHjW7lFr53VkhDRM+S85dHbelHrxZdgZl Io1nKt2Z4ymRzwRjIdLQEZMID1Vwdnaa0nlB+VTCO0TmJYId631tzbAunhhTiVzqEh DCAakCPyLIx+2xxOTLRpboBCrkSLKcfASg9qvEzU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389016AbfIMOuh (ORCPT ); Fri, 13 Sep 2019 10:50:37 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40790 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388993AbfIMOuh (ORCPT ); Fri, 13 Sep 2019 10:50:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Elp+uTImoCrNP71fv1uYeYHL/XQdxRr3L3U43a7bv/k=; b=qWoED4FLjqaj+cGPvaKEj26/3J iKnUjDpu4cPWq4d8LZoBCFQoZ2U/5GL5SRXI34Bfq82etwIHZzOuWP2rY95eusxmYm3Co+/p68mf5 Vx7VFzMGKj/xl+3FYTHx7R0gNvAQfYtTWHR8TwZRjbwyLsyS0ncIwJvQeS3Rgme6K3cRz2mdc2OAM +qthSj31SWg9MvJDzLuz5EsWr/LrX/azFdrEDMZ2QwCoX2y6IXSJhXgaXsII/MSV7zOm4cDqv1j5/ 1nQZFSiGbgNOKoM6PLKsGI+H0m/JwM+ZYyN0W6jxyUd1j6T9nKJxx6VDGYtaqqbja09Nn9H2xsvJH DGC4QLxQ==; Received: from 177.96.232.144.dynamic.adsl.gvt.net.br ([177.96.232.144] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8muC-0002Mv-Mr; Fri, 13 Sep 2019 14:50:36 +0000 Received: from mchehab by bombadil.infradead.org with local (Exim 4.92.2) (envelope-from ) id 1i8mu9-00042q-ES; Fri, 13 Sep 2019 11:50:33 -0300 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Linux Edac Mailing List , Linux Kernel Mailing List , Borislav Petkov , Tony Luck , James Morse , Robert Richter Subject: [PATCH 1/7] EDAC: i5100_edac: get rid of an unused var Date: Fri, 13 Sep 2019 11:50:26 -0300 Message-Id: <0f79a3d3684dc6484e48cfce66ff2b560a1054c8.1568385816.git.mchehab+samsung@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: References: MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org As reported by GCC with W=1: drivers/edac/i5100_edac.c:714:16: warning: variable ‘et’ set but not used [-Wunused-but-set-variable] 714 | unsigned long et; | ^~ It sounds some left over from some code before the addition of an udelay(). Signed-off-by: Mauro Carvalho Chehab --- drivers/edac/i5100_edac.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/edac/i5100_edac.c b/drivers/edac/i5100_edac.c index 251f2b692785..12bebecb203b 100644 --- a/drivers/edac/i5100_edac.c +++ b/drivers/edac/i5100_edac.c @@ -713,7 +713,6 @@ static int i5100_read_spd_byte(const struct mem_ctl_info *mci, { struct i5100_priv *priv = mci->pvt_info; u16 w; - unsigned long et; pci_read_config_word(priv->mc, I5100_SPDDATA, &w); if (i5100_spddata_busy(w)) @@ -724,7 +723,6 @@ static int i5100_read_spd_byte(const struct mem_ctl_info *mci, 0, 0)); /* wait up to 100ms */ - et = jiffies + HZ / 10; udelay(100); while (1) { pci_read_config_word(priv->mc, I5100_SPDDATA, &w); From patchwork Fri Sep 13 14:50:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 11144843 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C65E714E5 for ; Fri, 13 Sep 2019 14:51:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A584D20678 for ; Fri, 13 Sep 2019 14:51:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568386262; bh=awIKl6wXEpUIunhpW9BHubkdswoJbu+Ogk0uPmCLees=; h=From:Cc:Subject:Date:In-Reply-To:References:To:List-ID:From; b=r3YieIuyqf5r2dKXAO30e0mrn2gwRbawoEskkSj/wffL3pJbNduIjxbFAtDV6ZxXh iTLLjHrV2tAApSUQP1zNFD3mavoGGnQ3D3TSZRrmW5ShZdNlozV7H9SEp7NBuA4ynA N+KtuyXLvxbu06YyIhqFBHiOQi5nz1VRzv0xLIz8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389244AbfIMOui (ORCPT ); Fri, 13 Sep 2019 10:50:38 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40796 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388999AbfIMOuh (ORCPT ); Fri, 13 Sep 2019 10:50:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=FGpf56cINC9+BFVgh8DBy4ECBvi8JOhFNHTcv1IE2rc=; b=PeIwWbLeagxov6jGgE1NwNTvP2 cSb+20Zl6/j3VQYGueMYU5UeG/Upe62YVbX1ddhSKvsBMLmsyp9PwLSvcpoCR2E7hKghoTgUDOdNv I5Xr2vdIzipHsrY21PQXJUUeoRMaFSUfQi8Ca/JmI/PsaCQWG2RkkzS53+SN22RoLeibWEFHeEzXz KtTPVrB2xMb70ileVk9Z9jOfg3eMPB2Ub0mbxAs+bZJf+d2kZceuWAd84bS7izUsosaerYeo+nWmz GqcWd+/ROJerZJTStIaslz96V9X0Do7Z9n89tMWCKVM7Oe6+4apc4dOe6o4JieZuc0gwxjcqL7d+k 6KvLPfqA==; Received: from 177.96.232.144.dynamic.adsl.gvt.net.br ([177.96.232.144] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8muC-0002Mw-N1; Fri, 13 Sep 2019 14:50:36 +0000 Received: from mchehab by bombadil.infradead.org with local (Exim 4.92.2) (envelope-from ) id 1i8mu9-00042u-FD; Fri, 13 Sep 2019 11:50:33 -0300 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Linux Edac Mailing List , Linux Kernel Mailing List , Borislav Petkov , Tony Luck , James Morse , Robert Richter Subject: [PATCH 2/7] EDAC: i7300_edac: rename a kernel-doc var description Date: Fri, 13 Sep 2019 11:50:27 -0300 Message-Id: X-Mailer: git-send-email 2.21.0 In-Reply-To: References: MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org One var was renamed, but the associated kernel-doc markup still points to the old name. Signed-off-by: Mauro Carvalho Chehab --- drivers/edac/i7300_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/i7300_edac.c b/drivers/edac/i7300_edac.c index 7bf910d54d11..3d4bd3bf317c 100644 --- a/drivers/edac/i7300_edac.c +++ b/drivers/edac/i7300_edac.c @@ -580,7 +580,7 @@ static void i7300_enable_error_reporting(struct mem_ctl_info *mci) * @ch: Channel number within the branch (0 or 1) * @branch: Branch number (0 or 1) * @dinfo: Pointer to DIMM info where dimm size is stored - * @p_csrow: Pointer to the struct csrow_info that corresponds to that element + * @dimm: Pointer to the struct dimm_info that corresponds to that element */ static int decode_mtr(struct i7300_pvt *pvt, int slot, int ch, int branch, From patchwork Fri Sep 13 14:50:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 11144853 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D7527184E for ; Fri, 13 Sep 2019 14:51:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD04320678 for ; Fri, 13 Sep 2019 14:51:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568386266; bh=cJZqzY3pj94BXyOMX29zqVZIu6C63G1M5woQ5am7HV0=; h=From:Cc:Subject:Date:In-Reply-To:References:To:List-ID:From; b=uTWadCZ8iMCUAUNKCCaMZJPwMRbjoo8+Vs8EHTUSeK3/FOZTlSjOfBzwf2iWCzt5W tn6DHDa6LNF5CHJNKRjd6KoF70b09Lmugat/SA78ANqoOIa0lLqkF6UK2sOg4L9ysS xyFmYYjYD9B2KvU6a2ppCQVjgkHTAfptL4ZCC2Q0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389042AbfIMOuh (ORCPT ); Fri, 13 Sep 2019 10:50:37 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40772 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388704AbfIMOuh (ORCPT ); Fri, 13 Sep 2019 10:50:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ox3AyXAcafO8D8+TJ5Imd59NC6Ph1eV4BYAGmGgunRw=; b=hZcZqtzT1E1Zs0aj6lxiFEvual ol6D80z+z0yxwkk5IW5d+4kuoYrvAqHIc0LHpFb0TzNodsxUowRFqkpOAI2/gMDcBhVjKmyHaplGK amK+ftuShg19jnuB91uvr7Emo27R8LzKzQ5t7aa0D+1XKRqFcaD70YnWc7G///AbnQSSUoLM5XsZX WHQBqiwFUr3HESD4kEz/6BwhBoJDfifTMiDzJeIIPhGpqv14dcMHA4oZDG2K3Wgs1TFdN3P9+gsm5 fYlcrRNDS42o0ZKWXYpIHxaK3KXTc+h3kuKtBbkQcz1onzaeil5e27Jk9SMUAJoKdFMZN40CSb5Fl 0EG3Vw9A==; Received: from 177.96.232.144.dynamic.adsl.gvt.net.br ([177.96.232.144] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8muB-0002Mo-V2; Fri, 13 Sep 2019 14:50:35 +0000 Received: from mchehab by bombadil.infradead.org with local (Exim 4.92.2) (envelope-from ) id 1i8mu9-00042y-G0; Fri, 13 Sep 2019 11:50:33 -0300 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Linux Edac Mailing List , Linux Kernel Mailing List , Borislav Petkov , Tony Luck , James Morse , Robert Richter Subject: [PATCH 3/7] EDAC: i7300_edac: fix a kernel-doc syntax Date: Fri, 13 Sep 2019 11:50:28 -0300 Message-Id: <659775074c522b030a0178e7662079662ee7ee95.1568385816.git.mchehab+samsung@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: References: MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org The declaration of the kerneldoc entry is wrong, causing this warning: drivers/edac/i7300_edac.c:824: warning: Function parameter or member 'mir_no' not described in 'decode_mir' Signed-off-by: Mauro Carvalho Chehab --- drivers/edac/i7300_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/i7300_edac.c b/drivers/edac/i7300_edac.c index 3d4bd3bf317c..447d357c7a67 100644 --- a/drivers/edac/i7300_edac.c +++ b/drivers/edac/i7300_edac.c @@ -817,7 +817,7 @@ static int i7300_init_csrows(struct mem_ctl_info *mci) /** * decode_mir() - Decodes Memory Interleave Register (MIR) info - * @int mir_no: number of the MIR register to decode + * @mir_no: number of the MIR register to decode * @mir: array with the MIR data cached on the driver */ static void decode_mir(int mir_no, u16 mir[MAX_MIR]) From patchwork Fri Sep 13 14:50:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 11144845 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5D37114E5 for ; Fri, 13 Sep 2019 14:51:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3BD7320678 for ; Fri, 13 Sep 2019 14:51:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568386264; bh=3O2EFyMvl4FydsIhvt/igmGTAWUXY533WsMeM5QFj0w=; h=From:Cc:Subject:Date:In-Reply-To:References:To:List-ID:From; b=dUcoP4hEIWyPbv29Neu0PfDHkvnJJPZmVu1DSz+fUin6kQq9ldRfYrOh8FMnf0RGg Jf2/22Hw7t97cweDrYeD6JgrdjieZNY+RluLJgd1A+Vnpm3iqeuODGgf0oBed1D2AY uagUb7JdFdd9SvnqM1rEibaaLHmmRMqmOTU3ixVo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389180AbfIMOui (ORCPT ); Fri, 13 Sep 2019 10:50:38 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40792 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388997AbfIMOuh (ORCPT ); Fri, 13 Sep 2019 10:50:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=WHvF2CG3hSL6Apn9kwopSnBjSdtlbe1zgSHAEIpSxc8=; b=q6l1RWGrXGSXR5d/aXatJKo44b goPcIt2gp4yQEBUgERRBuc6sNqqBSSFqK+aUbJpTTAGxleKKkj1n+OhDCTP7MVIgvdaBr1cbfBReo hqqj4nxCaMeEkopchd0J3W17ukwLpNnVaq38VxEWryNhh/JWDQxDfE9/udqlUe3NRbGhx8iMwoc1d ky9GVS6orXqkZMiTaVQp8y340QswvVepLcrJmhg2YUSGNXtTRVbehrY42n4fw6k2a22ng/fi/m0xZ ed20VIe41AFaGWfsVryggFPlK3ZuIqHzQYTp8KlE5EjQuGwtyEuM65lkDhU1CILuyMM0d5xpnaapK 7N311Bhg==; Received: from 177.96.232.144.dynamic.adsl.gvt.net.br ([177.96.232.144] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8muC-0002Mt-5b; Fri, 13 Sep 2019 14:50:36 +0000 Received: from mchehab by bombadil.infradead.org with local (Exim 4.92.2) (envelope-from ) id 1i8mu9-000432-Gl; Fri, 13 Sep 2019 11:50:33 -0300 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Linux Edac Mailing List , Linux Kernel Mailing List , Borislav Petkov , Tony Luck , James Morse , Robert Richter Subject: [PATCH 4/7] EDAC: i5400_edac: print type at debug message Date: Fri, 13 Sep 2019 11:50:29 -0300 Message-Id: <426c979d7ed44f23eeeda69bcdbc91609d2d3bb7.1568385816.git.mchehab+samsung@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: References: MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org There are 3 types of non-recoverable errors that the MC reports: - Fatal; - Non-fatal uncorrected - Non-fatal correctable While we don't add it to the log itself, it could be useful to have this at least for debug messages. This shuts up this warning: drivers/edac/i5400_edac.c: In function ‘i5400_proccess_non_recoverable_info’: drivers/edac/i5400_edac.c:524:8: warning: variable ‘type’ set but not used [-Wunused-but-set-variable] 524 | char *type = NULL; | ^~~~ Signed-off-by: Mauro Carvalho Chehab --- drivers/edac/i5400_edac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/edac/i5400_edac.c b/drivers/edac/i5400_edac.c index 6f8bcdb9256a..52783b9bd0df 100644 --- a/drivers/edac/i5400_edac.c +++ b/drivers/edac/i5400_edac.c @@ -548,8 +548,8 @@ static void i5400_proccess_non_recoverable_info(struct mem_ctl_info *mci, ras = nrec_ras(info); cas = nrec_cas(info); - edac_dbg(0, "\t\tDIMM= %d Channels= %d,%d (Branch= %d DRAM Bank= %d Buffer ID = %d rdwr= %s ras= %d cas= %d)\n", - rank, channel, channel + 1, branch >> 1, bank, + edac_dbg(0, "\t\t%s DIMM= %d Channels= %d,%d (Branch= %d DRAM Bank= %d Buffer ID = %d rdwr= %s ras= %d cas= %d)\n", + type, rank, channel, channel + 1, branch >> 1, bank, buf_id, rdwr_str(rdwr), ras, cas); /* Only 1 bit will be on */ From patchwork Fri Sep 13 14:50:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 11144849 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B1DE81599 for ; Fri, 13 Sep 2019 14:51:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91F9420678 for ; Fri, 13 Sep 2019 14:51:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568386264; bh=reIl4vuIbLFvd4jhdOdG4pW/EI5dHhtOaJRcewrk+pg=; h=From:Cc:Subject:Date:In-Reply-To:References:To:List-ID:From; b=fPX3s9fJM1cp/xO/Aj/RDVYr8jAUEE2jYNzOwgzlTZ/hoqZ7lAfTiTN28PfZI++Ki s6X4iE4EULnNUYa9S5Zm4ziZe9TeRSJDtPPXiQRgpJhK/ZgdQrYZCYN5QFuef5vVBt ozKO2lSJ9UAbUDN7ZbHIHJJhaK6hgnfaZRlVMM5g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389132AbfIMOuh (ORCPT ); Fri, 13 Sep 2019 10:50:37 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40798 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389009AbfIMOuh (ORCPT ); Fri, 13 Sep 2019 10:50:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=y8V4ISNeIYTh4emFUodtoey9/9XrUBx5fhl2V/vuW5M=; b=O2+wOBRBZoeq+bb+gZoK3LKCA3 q2FfeYxoGnQgZEB7FdS7hHyZOxvlJ21AiXAYkUD2g/hBq7X3AHlEPfoVsEk9S+AN3ByKWJoNamGLt GutEXhhlV12Ketj/xzm6A/sYDV3IPYkQgfRtTH1IesIDIw8OFcX2q4iVajvLaT3GXIHPI5VhcJoiY rUcB0OjmV/kUC7/GW82MiWRl5yJioq7UNcezc6WMe/FWWKNgKac9NBA8bxHLaxxGYVl1AI7j0XzEX YCSCHuT8qrlpSgqbjpfahH7h3xxGPKQsxQbpa1p5+gVpZa2ZcOQC7AIEIv18+NQ4xyusd6hfkBF7h 4NfaDj7g==; Received: from 177.96.232.144.dynamic.adsl.gvt.net.br ([177.96.232.144] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8muC-0002Mr-2z; Fri, 13 Sep 2019 14:50:36 +0000 Received: from mchehab by bombadil.infradead.org with local (Exim 4.92.2) (envelope-from ) id 1i8mu9-000436-HZ; Fri, 13 Sep 2019 11:50:33 -0300 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Linux Edac Mailing List , Linux Kernel Mailing List , Borislav Petkov , Tony Luck , James Morse , Robert Richter Subject: [PATCH 5/7] EDAC: i5400_edac: get rid of some unused vars Date: Fri, 13 Sep 2019 11:50:30 -0300 Message-Id: X-Mailer: git-send-email 2.21.0 In-Reply-To: References: MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org There are several temporary unused vars: drivers/edac/i5400_edac.c: In function ‘i5400_get_mc_regs’: drivers/edac/i5400_edac.c:1058:6: warning: variable ‘maxdimmperch’ set but not used [-Wunused-but-set-variable] 1058 | int maxdimmperch; | ^~~~~~~~~~~~ drivers/edac/i5400_edac.c:1057:6: warning: variable ‘maxch’ set but not used [-Wunused-but-set-variable] 1057 | int maxch; | ^~~~~ drivers/edac/i5400_edac.c: In function ‘i5400_init_dimms’: drivers/edac/i5400_edac.c:1174:6: warning: variable ‘max_dimms’ set but not used [-Wunused-but-set-variable] 1174 | int max_dimms; | ^~~~~~~~~ drivers/edac/i5400_edac.c:1173:14: warning: variable ‘channel_count’ set but not used [-Wunused-but-set-variable] 1173 | int ndimms, channel_count; | ^~~~~~~~~~~~~ Get rid of them. Signed-off-by: Mauro Carvalho Chehab --- drivers/edac/i5400_edac.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/edac/i5400_edac.c b/drivers/edac/i5400_edac.c index 52783b9bd0df..8c86c6fd7da7 100644 --- a/drivers/edac/i5400_edac.c +++ b/drivers/edac/i5400_edac.c @@ -1054,8 +1054,6 @@ static void i5400_get_mc_regs(struct mem_ctl_info *mci) u32 actual_tolm; u16 limit; int slot_row; - int maxch; - int maxdimmperch; int way0, way1; pvt = mci->pvt_info; @@ -1065,9 +1063,6 @@ static void i5400_get_mc_regs(struct mem_ctl_info *mci) pci_read_config_dword(pvt->system_address, AMBASE + sizeof(u32), &pvt->u.ambase_top); - maxdimmperch = pvt->maxdimmperch; - maxch = pvt->maxch; - edac_dbg(2, "AMBASE= 0x%lx MAXCH= %d MAX-DIMM-Per-CH= %d\n", (long unsigned int)pvt->ambase, pvt->maxch, pvt->maxdimmperch); @@ -1170,17 +1165,13 @@ static int i5400_init_dimms(struct mem_ctl_info *mci) { struct i5400_pvt *pvt; struct dimm_info *dimm; - int ndimms, channel_count; - int max_dimms; + int ndimms; int mtr; int size_mb; int channel, slot; pvt = mci->pvt_info; - channel_count = pvt->maxch; - max_dimms = pvt->maxdimmperch; - ndimms = 0; /* From patchwork Fri Sep 13 14:50:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 11144839 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C40D71599 for ; Fri, 13 Sep 2019 14:50:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3EE42171F for ; Fri, 13 Sep 2019 14:50:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568386239; bh=LGe+VFX8841EqXylZLdA9Z4cxrtLb3ZU41TIJPjD5MQ=; h=From:Cc:Subject:Date:In-Reply-To:References:To:List-ID:From; b=2Lbcl3vkeymrnvAUFrSs0hCsK1INBYyGOxgE9P4VCf3WXgd+Cb60h25OsBojOiWHy SIRWQGxBnOnsOHDlCUua8EWybNpV0Y62Fyl0Oa5+iiDMjxVMVse4Zbvbq0EeMxU7Zv 0T2P9LglbSiQurbU3C7jZAZaY50vBfUZieV3vJQ4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388704AbfIMOui (ORCPT ); Fri, 13 Sep 2019 10:50:38 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40788 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388958AbfIMOuh (ORCPT ); Fri, 13 Sep 2019 10:50:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=y7A2GHw6cbpQyTsa/8f0KcgivnQo4Wrc1Cu3FDUvrdQ=; b=m0zY9Mu8Cl6UHzRkEAsFLPL/LA Wv3f2SdG5DoMaMsVlGpYbXGUKYiM4PKs3YbjgCoZOtXi7mTb4QJbp+tjIJUUsBwsdEpesRjyKshWg kFScSxXluBiT8Ziuv4Rt93IHa1pfDOerKtLHh8RxQ/9+G3vOPCnj8mn3uj15f9QTT2gVb0K9hvK0o iQ05s8q+0asXF5OaLqGn4HMBUqgx9Nz/lcc72OIxlBExg/Uq124K3/v8RvUgbkzx+xjRkyD+jX87Q /xi/l64jJl2QS+I43BNQlpUCD4Y2lBmw9nBt7n6AvLAbpvR0GS7oULF+phVc8gmQin8vp7xqorG54 4Bl8eMZg==; Received: from 177.96.232.144.dynamic.adsl.gvt.net.br ([177.96.232.144] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8muC-0002Ms-4Z; Fri, 13 Sep 2019 14:50:36 +0000 Received: from mchehab by bombadil.infradead.org with local (Exim 4.92.2) (envelope-from ) id 1i8mu9-00043B-IL; Fri, 13 Sep 2019 11:50:33 -0300 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Linux Edac Mailing List , Linux Kernel Mailing List , Tony Luck , Qiuxu Zhuo , Borislav Petkov , James Morse , Robert Richter Subject: [PATCH 6/7] EDAC: sb_edac: get rid of unused vars Date: Fri, 13 Sep 2019 11:50:31 -0300 Message-Id: X-Mailer: git-send-email 2.21.0 In-Reply-To: References: MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org There are several vars unused on this driver, probably because it was a modified copy of another driver. Get rid of them. drivers/edac/sb_edac.c: In function ‘knl_get_dimm_capacity’: drivers/edac/sb_edac.c:1343:16: warning: variable ‘sad_size’ set but not used [-Wunused-but-set-variable] 1343 | u64 sad_base, sad_size, sad_limit = 0; | ^~~~~~~~ drivers/edac/sb_edac.c: In function ‘sbridge_mce_output_error’: drivers/edac/sb_edac.c:2955:8: warning: variable ‘type’ set but not used [-Wunused-but-set-variable] 2955 | char *type, *optype, msg[256]; | ^~~~ drivers/edac/sb_edac.c: In function ‘sbridge_unregister_mci’: drivers/edac/sb_edac.c:3203:22: warning: variable ‘pvt’ set but not used [-Wunused-but-set-variable] 3203 | struct sbridge_pvt *pvt; | ^~~ At top level: drivers/edac/sb_edac.c:266:18: warning: ‘correrrthrsld’ defined but not used [-Wunused-const-variable=] 266 | static const u32 correrrthrsld[] = { | ^~~~~~~~~~~~~ drivers/edac/sb_edac.c:257:18: warning: ‘correrrcnt’ defined but not used [-Wunused-const-variable=] 257 | static const u32 correrrcnt[] = { | ^~~~~~~~~~ Signed-off-by: Mauro Carvalho Chehab --- drivers/edac/sb_edac.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c index 37746b045e18..813f66ffc09a 100644 --- a/drivers/edac/sb_edac.c +++ b/drivers/edac/sb_edac.c @@ -254,18 +254,20 @@ static const u32 rir_offset[MAX_RIR_RANGES][MAX_RIR_WAY] = { * FIXME: Implement the error count reads directly */ -static const u32 correrrcnt[] = { - 0x104, 0x108, 0x10c, 0x110, -}; - #define RANK_ODD_OV(reg) GET_BITFIELD(reg, 31, 31) #define RANK_ODD_ERR_CNT(reg) GET_BITFIELD(reg, 16, 30) #define RANK_EVEN_OV(reg) GET_BITFIELD(reg, 15, 15) #define RANK_EVEN_ERR_CNT(reg) GET_BITFIELD(reg, 0, 14) +#if 0 /* Currently unused*/ +static const u32 correrrcnt[] = { + 0x104, 0x108, 0x10c, 0x110, +}; + static const u32 correrrthrsld[] = { 0x11c, 0x120, 0x124, 0x128, }; +#endif #define RANK_ODD_ERR_THRSLD(reg) GET_BITFIELD(reg, 16, 30) #define RANK_EVEN_ERR_THRSLD(reg) GET_BITFIELD(reg, 0, 14) @@ -1340,7 +1342,7 @@ static void knl_show_mc_route(u32 reg, char *s) */ static int knl_get_dimm_capacity(struct sbridge_pvt *pvt, u64 *mc_sizes) { - u64 sad_base, sad_size, sad_limit = 0; + u64 sad_base, sad_limit = 0; u64 tad_base, tad_size, tad_limit, tad_deadspace, tad_livespace; int sad_rule = 0; int tad_rule = 0; @@ -1427,7 +1429,6 @@ static int knl_get_dimm_capacity(struct sbridge_pvt *pvt, u64 *mc_sizes) edram_only = KNL_EDRAM_ONLY(dram_rule); sad_limit = pvt->info.sad_limit(dram_rule)+1; - sad_size = sad_limit - sad_base; pci_read_config_dword(pvt->pci_sad0, pvt->info.interleave_list[sad_rule], &interleave_reg); @@ -2952,7 +2953,7 @@ static void sbridge_mce_output_error(struct mem_ctl_info *mci, struct mem_ctl_info *new_mci; struct sbridge_pvt *pvt = mci->pvt_info; enum hw_event_mc_err_type tp_event; - char *type, *optype, msg[256]; + char *optype, msg[256]; bool ripv = GET_BITFIELD(m->mcgstatus, 0, 0); bool overflow = GET_BITFIELD(m->status, 62, 62); bool uncorrected_error = GET_BITFIELD(m->status, 61, 61); @@ -2981,14 +2982,11 @@ static void sbridge_mce_output_error(struct mem_ctl_info *mci, if (uncorrected_error) { core_err_cnt = 1; if (ripv) { - type = "FATAL"; tp_event = HW_EVENT_ERR_FATAL; } else { - type = "NON_FATAL"; tp_event = HW_EVENT_ERR_UNCORRECTED; } } else { - type = "CORRECTED"; tp_event = HW_EVENT_ERR_CORRECTED; } @@ -3200,7 +3198,6 @@ static struct notifier_block sbridge_mce_dec = { static void sbridge_unregister_mci(struct sbridge_dev *sbridge_dev) { struct mem_ctl_info *mci = sbridge_dev->mci; - struct sbridge_pvt *pvt; if (unlikely(!mci || !mci->pvt_info)) { edac_dbg(0, "MC: dev = %p\n", &sbridge_dev->pdev[0]->dev); @@ -3209,8 +3206,6 @@ static void sbridge_unregister_mci(struct sbridge_dev *sbridge_dev) return; } - pvt = mci->pvt_info; - edac_dbg(0, "MC: mci = %p, dev = %p\n", mci, &sbridge_dev->pdev[0]->dev); From patchwork Fri Sep 13 14:50:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 11144851 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 909A91599 for ; Fri, 13 Sep 2019 14:51:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6FB912089F for ; Fri, 13 Sep 2019 14:51:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568386266; bh=V7pz+g6EwvqCLSge8pZVf8VcrJ6JuX+75cngrO4lIFI=; h=From:Cc:Subject:Date:In-Reply-To:References:To:List-ID:From; b=of0U5fKz7wW8YCMDBBh9u/gzKuoWjmXu2DvaUWuNAWRvI0d2KLFkdZpAn4lf1byXv IIoy9d9XolLdDWe4M9XN871+Byugy/pZ/rnM+CWIJK0FlHsqwUxC7mifaPf+ETSPSJ MMbtbRKLv4zRnw3dxaskHZxEG+rOjizb1uzyoV9k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389090AbfIMOuh (ORCPT ); Fri, 13 Sep 2019 10:50:37 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40794 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388998AbfIMOuh (ORCPT ); Fri, 13 Sep 2019 10:50:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=L2WuVgEWJ1S/DCcbljfrkSPlJ+BBqepA9EJiiwR270o=; b=YRmqjDAz7qLZqG5DjnEH4tIdzC rQVoG/5shJSaY19hAestUS175lC/MF+EkaOPxnav1pO6w7jUwBEm6wa0Zj86HN+Ge5GQ7E7I9YHrt yy1iSKs6kKvTkzziNfevgUU5sTDvngfoLcK5A7itgiT1tyK9z7Xdu05k8Nnwl7vrvj3EO8Hfk64Nq lw4jgFH2iwf5HxTVjbN1Y4mUI9VtOfCWUljd3dobLadwAKygbLz4DaoyAC3NDcIlwnYfE0HcZjfAF 5hxJqw6JYjt1hpzALS4IC7gYRREm9uvggerN6gOqq7FhNiZbMHFZaVZS0l0Pi5cEupJufBoDaaXZh LeGJAT8A==; Received: from 177.96.232.144.dynamic.adsl.gvt.net.br ([177.96.232.144] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8muB-0002Mn-Qm; Fri, 13 Sep 2019 14:50:35 +0000 Received: from mchehab by bombadil.infradead.org with local (Exim 4.92.2) (envelope-from ) id 1i8mu9-00043F-JG; Fri, 13 Sep 2019 11:50:33 -0300 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Linux Edac Mailing List , Linux Kernel Mailing List , Tony Luck , Borislav Petkov , James Morse , Robert Richter Subject: [PATCH 7/7] EDAC: skx_common: get rid of unused type var Date: Fri, 13 Sep 2019 11:50:32 -0300 Message-Id: <3bbd66908f60d43c2f60c8a16570994cce21a853.1568385816.git.mchehab+samsung@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: References: MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-edac-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org drivers/edac/skx_common.c: In function ‘skx_mce_output_error’: drivers/edac/skx_common.c:478:8: warning: variable ‘type’ set but not used [-Wunused-but-set-variable] 478 | char *type, *optype; | ^~~~ Signed-off-by: Mauro Carvalho Chehab --- drivers/edac/skx_common.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c index d8ff63d91b86..83dd5da67a28 100644 --- a/drivers/edac/skx_common.c +++ b/drivers/edac/skx_common.c @@ -475,7 +475,7 @@ static void skx_mce_output_error(struct mem_ctl_info *mci, struct decoded_addr *res) { enum hw_event_mc_err_type tp_event; - char *type, *optype; + char *optype; bool ripv = GET_BITFIELD(m->mcgstatus, 0, 0); bool overflow = GET_BITFIELD(m->status, 62, 62); bool uncorrected_error = GET_BITFIELD(m->status, 61, 61); @@ -490,14 +490,11 @@ static void skx_mce_output_error(struct mem_ctl_info *mci, if (uncorrected_error) { core_err_cnt = 1; if (ripv) { - type = "FATAL"; tp_event = HW_EVENT_ERR_FATAL; } else { - type = "NON_FATAL"; tp_event = HW_EVENT_ERR_UNCORRECTED; } } else { - type = "CORRECTED"; tp_event = HW_EVENT_ERR_CORRECTED; }