From patchwork Fri Sep 13 16:04:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew Cooper X-Patchwork-Id: 11144985 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 80F5313BD for ; Fri, 13 Sep 2019 16:06:21 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C6F9206BB for ; Fri, 13 Sep 2019 16:06:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="A1QGtSNG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C6F9206BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i8o3O-0005yQ-4Y; Fri, 13 Sep 2019 16:04:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i8o3M-0005xt-Vl for xen-devel@lists.xenproject.org; Fri, 13 Sep 2019 16:04:09 +0000 X-Inumbo-ID: 1d94522d-d640-11e9-95af-12813bfff9fa Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1d94522d-d640-11e9-95af-12813bfff9fa; Fri, 13 Sep 2019 16:04:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1568390648; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=4A+HNagdjd7C0ZlLWbR1RH4Zgt8TyZmLUxawx7aRHvs=; b=A1QGtSNGK2M3WqZSj9TqNaVAbi6oxlinMXUxwX2+1ntfJYRjD0Lkb7Hm 0EFP6Z6r8VNjMHlm/AA/pM3dLoJTnUEiav8N2u97u4AzfqBizMGkHG0rV eyRs9XQ5xocw24eUEKOoQAO6QnNImiGlSKR1KGLK1thCVdbQQnpMBrgK5 c=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: V8Whq4PwxjvsCrLNDs8VxqU7qjD2HXxW7xxsEiliYP73ekiJNCDLZ3QxVOa4O5UsRgRj+yV0Cv EtxzorddutFpBzwV8J3SOTBK996SDKD9iqZ0PSOh6glk4BeDXguSVg6XUx99p9rPdqezEwVR6V RDSSTHwSXnxJS3dhqqMSq8prXfNHTbrOoY1oMINalFP+MayNCi7RPnhMFa6PmICL2SWGzkz2Dl W3T+jluWsjZpa925KLmqmASpd0S8bAl64061Ni5NvfZwM/vKp6To3FQ1XJDc+4ygd+WuN5XFNF cfs= X-SBRS: 2.7 X-MesageID: 5543709 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,501,1559534400"; d="scan'208";a="5543709" From: Andrew Cooper To: Xen-devel Date: Fri, 13 Sep 2019 17:04:04 +0100 Message-ID: <20190913160404.495-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Paul Durrant , Wei Liu , Jan Beulich , =?utf-8?q?Roger_Pau_Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Message such as: (XEN) d3v0 VIRIDIAN CRASH: 51 1 ffff9700e146b000 1000 204 have confused many people into thinking the the problem is a bug in the viridian code. The prefix was intended to signify the use of the viridian crash-reporting interface. Replace the VIRIDIAN prefix with 'reported' to reduce the confusion to non-xen-developers trying to interpret the message. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné CC: Paul Durrant This wants backporting to every stable tree which has viridian crash interface support. --- xen/arch/x86/hvm/viridian/viridian.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/viridian/viridian.c b/xen/arch/x86/hvm/viridian/viridian.c index 4b06b78a27..f98c8e7753 100644 --- a/xen/arch/x86/hvm/viridian/viridian.c +++ b/xen/arch/x86/hvm/viridian/viridian.c @@ -357,7 +357,7 @@ int guest_wrmsr_viridian(struct vcpu *v, uint32_t idx, uint64_t val) d->shutdown_code = SHUTDOWN_crash; spin_unlock(&d->shutdown_lock); - gprintk(XENLOG_WARNING, "VIRIDIAN CRASH: %lx %lx %lx %lx %lx\n", + gprintk(XENLOG_WARNING, "reported CRASH: %lx %lx %lx %lx %lx\n", vv->crash_param[0], vv->crash_param[1], vv->crash_param[2], vv->crash_param[3], vv->crash_param[4]); break;