From patchwork Mon Sep 16 20:22:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 11147745 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D7E3114E5 for ; Mon, 16 Sep 2019 20:22:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE84D20830 for ; Mon, 16 Sep 2019 20:22:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391339AbfIPUWp (ORCPT ); Mon, 16 Sep 2019 16:22:45 -0400 Received: from smtp11.smtpout.orange.fr ([80.12.242.133]:48783 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727770AbfIPUWp (ORCPT ); Mon, 16 Sep 2019 16:22:45 -0400 Received: from localhost.localdomain ([90.126.97.183]) by mwinf5d90 with ME id 2LNi2100K3xPcdm03LNisP; Mon, 16 Sep 2019 22:22:43 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Mon, 16 Sep 2019 22:22:43 +0200 X-ME-IP: 90.126.97.183 From: Christophe JAILLET To: kwankhede@nvidia.com Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] sample: vfio mdev display - Fix a missing error code in an error handling path Date: Mon, 16 Sep 2019 22:22:40 +0200 Message-Id: <20190916202240.30189-1-christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org 'ret' is known to be 0 at this point. So explicitly set it to -ENOMEM if 'framebuffer_alloc()' fails. Signed-off-by: Christophe JAILLET --- samples/vfio-mdev/mdpy-fb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c index 2719bb259653..6fe0187f47a2 100644 --- a/samples/vfio-mdev/mdpy-fb.c +++ b/samples/vfio-mdev/mdpy-fb.c @@ -131,8 +131,10 @@ static int mdpy_fb_probe(struct pci_dev *pdev, width, height); info = framebuffer_alloc(sizeof(struct mdpy_fb_par), &pdev->dev); - if (!info) + if (!info) { + ret = -ENOMEM; goto err_release_regions; + } pci_set_drvdata(pdev, info); par = info->par;