From patchwork Tue Sep 17 03:20:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Navid Emamdoost X-Patchwork-Id: 11148147 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6C4AC14F7 for ; Tue, 17 Sep 2019 07:17:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54A12206C2 for ; Tue, 17 Sep 2019 07:17:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54A12206C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0FAA26E9D6; Tue, 17 Sep 2019 07:17:13 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C0376EAC4; Tue, 17 Sep 2019 03:21:41 +0000 (UTC) Received: by mail-io1-xd43.google.com with SMTP id k5so4121689iol.5; Mon, 16 Sep 2019 20:21:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=uMCwEHQvtNjk+/l7SPshcA4CM/OKg67DuvF3ouBwv+s=; b=sV2YLVIyXRgoKtJI9e3qk+Fa5WS9DZONALtYwiqEVWFw3CPXyReOA37+k1ygySRmyL sr+mhccVfXChr4tbpUyI22SYSfVx9un7NqVeqis8yJnAvocl4PDRlTCxmAjKfuncRBcr nENKfOk61G+uohNk8yn8zP47Q2E5kyS+upwih+sTnq3JUrrLhnX9KY+IUxColxKynXC5 ZyDn6GQkgdcyn6AS7/lbD398cmCZ9H+FSJhTZhciycfIbcP9mrEvrfb/9M4iGXtQoR7h 3HA9SAXwE36Rw9XACJJiO1RpU/yLY1KBMWjzGXRH11fecZOR/Ur9d0GdJOQ2iydFzV6A UjMw== X-Gm-Message-State: APjAAAWA9WwxZVK7NcBqiJhX0GwgNtt97Uuyq/C11rP2WawD6NPgIYFy gq45x6sKrId98qS9bUTGDu8= X-Google-Smtp-Source: APXvYqwUAbHzObmxlcKTs7Sr7rY0DuCnBsDeDL5086A+CmYlktYdRFHclzi8wQ5tlTQQ0uKm5fZfWw== X-Received: by 2002:a6b:9109:: with SMTP id t9mr1456924iod.16.1568690500448; Mon, 16 Sep 2019 20:21:40 -0700 (PDT) Received: from cs-dulles.cs.umn.edu (cs-dulles.cs.umn.edu. [128.101.35.54]) by smtp.googlemail.com with ESMTPSA id c25sm651242iod.47.2019.09.16.20.21.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2019 20:21:39 -0700 (PDT) From: Navid Emamdoost To: Subject: [PATCH] drm/amd/display: memory leak Date: Mon, 16 Sep 2019 22:20:44 -0500 Message-Id: <20190917032106.32342-1-navid.emamdoost@gmail.com> X-Mailer: git-send-email 2.17.1 X-Mailman-Approved-At: Tue, 17 Sep 2019 07:17:12 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=uMCwEHQvtNjk+/l7SPshcA4CM/OKg67DuvF3ouBwv+s=; b=i+yWSNJc3bZlvKnVhSjjMRCBCwtmu5ooFGKZkGLKMAjHkZ7wqLgf5B1Ge8VWsOMQ9D 0ZMxcBL3/Bw+tbjePdVCiMNDzLZHb8OHz3KHL3rFah0+a7jG+3jHM2w1M7QldzzrKWlA AOuDVcblakTGqdGh8O7qeTty9pg7dh6lCZFFQ7+qa3Zfo/sMsFoOLD7/RnmqQceRlD7A 9Js0M9EBevwVt+gWJWV4Gv3MpUwABCxFFkqCEi/S5fHiitflplxWobhvKnBCJqFJVOvj Rgl0PSBqUMSwjqhK+gmIrrFp1lJQJyMDWK1p9Ind6kM83mnW5SatKmWATZfrs7p5Qk2A Sc8w== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jun Lei , Wang Hai , Tony Cheng , David Francis , amd-gfx@lists.freedesktop.org, emamd001@umn.edu, Eric Bernstein , Su Sung Chung , smccaman@umn.edu, Charlene Liu , Leo Li , kjlu@umn.edu, Nikola Cornij , Aidan Wood , hersen wu , Bhawanpreet Lakha , Ken Chalmers , Navid Emamdoost , Thomas Lim , Eric Yang , Wesley Chalmers , Roman Li , =?utf-8?q?Christian_K=C3=B6nig?= , Dmytro Laktyushkin , Alex Deucher , Nicholas Kazlauskas MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In dcn*_clock_source_create when dcn20_clk_src_construct fails allocated clk_src needs release. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 3 ++- drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 1 + drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 1 + 7 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c index 6248c8455314..21de230b303a 100644 --- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c @@ -667,7 +667,8 @@ struct clock_source *dce100_clock_source_create( clk_src->base.dp_clk_src = dp_clk_src; return &clk_src->base; } - + + kfree(clk_src); BREAK_TO_DEBUGGER(); return NULL; } diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c index 764329264c3b..0cb83b0e0e1e 100644 --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c @@ -714,6 +714,7 @@ struct clock_source *dce110_clock_source_create( return &clk_src->base; } + kfree(clk_src); BREAK_TO_DEBUGGER(); return NULL; } diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c index c6136e0ed1a4..147d77173e2b 100644 --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c @@ -687,6 +687,7 @@ struct clock_source *dce112_clock_source_create( return &clk_src->base; } + kfree(clk_src); BREAK_TO_DEBUGGER(); return NULL; } diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c index 4a6ba3173a5a..0b5eeff17d00 100644 --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c @@ -500,6 +500,7 @@ static struct clock_source *dce120_clock_source_create( return &clk_src->base; } + kfree(clk_src); BREAK_TO_DEBUGGER(); return NULL; } diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c index 860a524ebcfa..952440893fbb 100644 --- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c @@ -701,6 +701,7 @@ struct clock_source *dce80_clock_source_create( return &clk_src->base; } + kfree(clk_src); BREAK_TO_DEBUGGER(); return NULL; } diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c index a12530a3ab9c..3f25e8da5396 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c @@ -786,6 +786,7 @@ struct clock_source *dcn10_clock_source_create( return &clk_src->base; } + kfree(clk_src); BREAK_TO_DEBUGGER(); return NULL; } diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c index b949e202d6cb..418fdcf1f492 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c @@ -955,6 +955,7 @@ struct clock_source *dcn20_clock_source_create( return &clk_src->base; } + kfree(clk_src) BREAK_TO_DEBUGGER(); return NULL; }