From patchwork Tue Sep 17 16:12:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 11149147 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3145F14DB for ; Tue, 17 Sep 2019 16:12:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1985B206C2 for ; Tue, 17 Sep 2019 16:12:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1985B206C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5059E6ECF8; Tue, 17 Sep 2019 16:12:31 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by gabe.freedesktop.org (Postfix) with ESMTPS id D264C6ECF8 for ; Tue, 17 Sep 2019 16:12:29 +0000 (UTC) Received: by mail-io1-xd42.google.com with SMTP id b19so8983310iob.4 for ; Tue, 17 Sep 2019 09:12:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=MeCcoXMCEze80Bl3xggqeDeE3aKjlz0D7xrnRXvSz50=; b=L+UX/VRGfUC754IK/Lzz8aA8mRnf6OXPppZWHCULt5cJpDly4AuNnFOo0QX/mTFvEM 1wea/i8ObyORaXn5lnsaHJWk1T/BKD0rWhKk2HiNZAo9zXxfgiD9kQ7jWtgaZswjURB/ djmTaas7KrmcnCeEUd/gX3og9AjHW63pQIHEYQ8T0Hep3qmF5RutsL5O1pzO9WP2L6Eg tFxxEd9qNA9E0Ukijl7Tn/LQfxw0W2vHuVxWxaYijyLP+iA479W/EAOcxbpF9jGUn3t8 P8Ze/rbKC4nJ+toJjIXLZ5XUB72HzPuwVTYHLIGgYl9+TE+CQhEopfVFhSZ2+6IeQnE6 kw1A== X-Gm-Message-State: APjAAAV+n8/kiZiM7rAN6HTHIxZGYqjoonqJla9jiGBZ3wPeiXck4HuZ 1DB/olbrW1kTm3Kxs7FLVdcBcEk7ypa0oA== X-Google-Smtp-Source: APXvYqy18s+Gh6RSCdBqHLdIA20bXqdc0iO0ZL76QMlGSl93FwBpVFflu0PIfUb3+kuezZYYc95Iiw== X-Received: by 2002:a5d:9956:: with SMTP id v22mr4304351ios.27.1568736748634; Tue, 17 Sep 2019 09:12:28 -0700 (PDT) Received: from aford-OptiPlex-7050.logicpd.com ([174.46.170.158]) by smtp.gmail.com with ESMTPSA id p25sm2090487ioo.35.2019.09.17.09.12.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2019 09:12:27 -0700 (PDT) From: Adam Ford To: dri-devel@lists.freedesktop.org Subject: [PATCH 1/3] drm/panel: simple: Add Logic PD Type 28 display support Date: Tue, 17 Sep 2019 11:12:11 -0500 Message-Id: <20190917161214.2913-1-aford173@gmail.com> X-Mailer: git-send-email 2.17.1 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=MeCcoXMCEze80Bl3xggqeDeE3aKjlz0D7xrnRXvSz50=; b=tdxiAs3nS/HFbj/DnmJeqprShjlCUPDO/gKB3EjOJ0I68afG8KHwKw5RDFiCNDld2d 1jxQ6jGrcC/yklXj6kEa70e85VPQoP4Kj/ndgRJEwUloLOz6XC7Qm325QBl2KlmUGB0U 8A6myYwT0/IjL/2oiVzNLhBrZFN+xToynXQdAuo+m2MWqEVDjBQPSs596Mw+Noy+YeLT LpEJAPE8sPhh8IK9Jw4NEmeDyE07xhCLoqlur1cbNtqaQD2W7DCs5dtB63L7lTN6vxE1 KzSjJ539vD+auBG3Ig5Jk/uTszD+oFbJ2tjG2e5/fax5mSQOzbK9QXmnRbVSumDiWZtU u5aA== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Sam Ravnborg , David Airlie , adam.ford@logicpd.com, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , linux-omap@vger.kernel.org, Adam Ford MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Previously, there was an omap panel-dpi driver that would read generic timings from the device tree and set the display timing accordingly. This driver was removed so the screen no longer functions. This patch modifies the panel-simple file to setup the timings to the same values previously used. Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Reviewed-by: Sam Ravnborg diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 5a93c4edf1e4..c86c30f3a8a1 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1900,6 +1900,40 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = { .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, }; +static const struct drm_display_mode logicpd_type_28_mode = { + .clock = 9000, + .hdisplay = 480, + .hsync_start = 480 + 3, + .hsync_end = 480 + 3 + 42, + .htotal = 480 + 3 + 42 + 2, + + .vdisplay = 272, + .vsync_start = 272 + 2, + .vsync_end = 272 + 2 + 11, + .vtotal = 272 + 2 + 11 + 3, + .vrefresh = 60, + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC, +}; + +static const struct panel_desc logicpd_type_28 = { + .modes = &logicpd_type_28_mode, + .num_modes = 1, + .bpc = 8, + .size = { + .width = 105, + .height = 67, + }, + .delay = { + .prepare = 200, + .enable = 200, + .unprepare = 200, + .disable = 200, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | + DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE, +}; + static const struct panel_desc mitsubishi_aa070mc01 = { .modes = &mitsubishi_aa070mc01_mode, .num_modes = 1, @@ -2948,6 +2982,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "lg,lp129qe", .data = &lg_lp129qe, + }, { + .compatible = "logicpd,type28", + .data = &logicpd_type_28, }, { .compatible = "mitsubishi,aa070mc01-ca1", .data = &mitsubishi_aa070mc01, From patchwork Tue Sep 17 16:12:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 11149149 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B36501747 for ; Tue, 17 Sep 2019 16:12:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99C0A206C2 for ; Tue, 17 Sep 2019 16:12:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99C0A206C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1B136ECF9; Tue, 17 Sep 2019 16:12:36 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 43D5C6ECF9 for ; Tue, 17 Sep 2019 16:12:35 +0000 (UTC) Received: by mail-io1-xd42.google.com with SMTP id a1so8961678ioc.6 for ; Tue, 17 Sep 2019 09:12:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DnOWZfH0hOJW+dI1w1NtgRKHb/FFjMuNFZYKGDHEM+E=; b=or23G4vnnmPKqkaL7M8bBqZ7CLwJCHkw+0niSAp0fzykf/syhInWxD1HnOqtmjLeE0 kyzUDZcvh0YNWtkcHo0E/UeJQ+qBAU6bTEVBGwY9ju1yBSdV3Y0OiGc2NpLMfOc6kjFe MRqri9nW9JaTc3cENOFdLUPyvV2xBmDuNv5mgXAsMSyv9jdxehrnMGx1mdBqzrf03vhR 9kKGL7szG3bBffA8FH3S3Gt/Dnb3Gos2msR36MVnqjH9rid4N/C34i5UAevzZW0AITrl AdqK+OLTvOji7+9kcoCegDDZ374N2rSYQwWf7/HjeiyBeiS4RDsfu7TJn+qsPABgyFz2 Cumw== X-Gm-Message-State: APjAAAUAHnQOILdBGnQBvn/OA0xaeAv2AskrI7otsPCxCvei0w55iFjM xLsMp3kACRy4yDenEmJOeDWqaOyYIGD/ww== X-Google-Smtp-Source: APXvYqxKwe5NGUh8qHgGmEb1qYzQYcMoUgcdSrs/VA407oH7iuMzBffD3hKkrywOQuGjJWnPF7yIyg== X-Received: by 2002:a5d:8f02:: with SMTP id f2mr220335iof.272.1568736754145; Tue, 17 Sep 2019 09:12:34 -0700 (PDT) Received: from aford-OptiPlex-7050.logicpd.com ([174.46.170.158]) by smtp.gmail.com with ESMTPSA id p25sm2090487ioo.35.2019.09.17.09.12.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2019 09:12:29 -0700 (PDT) From: Adam Ford To: dri-devel@lists.freedesktop.org Subject: [PATCH 2/3] dt-bindings: Add Logic PD Type 28 display panel Date: Tue, 17 Sep 2019 11:12:12 -0500 Message-Id: <20190917161214.2913-2-aford173@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190917161214.2913-1-aford173@gmail.com> References: <20190917161214.2913-1-aford173@gmail.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DnOWZfH0hOJW+dI1w1NtgRKHb/FFjMuNFZYKGDHEM+E=; b=DdhP0J19s0F897KOlRUOyWuJ79Fe27lc+QeqrI5mKAKZWfIyaqt58mnKR0aFCiDJBA kU4QtLqfUglUq6yoPa3ZqZfVDCfw63tvQ8h9KZ6goqBY1SyKCSMX0HBdvGb8CofEfTsQ PScUllzeXrIBnDfOIMegWYmcvwWLMhHe9kDuq7HnxzkkFvDMS1tAUQMC3YgCwt9KGn6v 13shSdNd7LOwBozcd0IfIkAa4+kskIJ0W2tNIOYBjGNTUI51IVqcSP3TP6HjJm2Qcowd FqC31PZZ0N1X8IPzaPAAR0P9aVDGW17N9A/VN6r0yiYC4icFKI9SY2tU73AsdRwdiUNx DGmg== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Sam Ravnborg , David Airlie , adam.ford@logicpd.com, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , linux-omap@vger.kernel.org, Adam Ford MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display. Signed-off-by: Adam Ford diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt b/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt new file mode 100644 index 000000000000..829fc5210e06 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt @@ -0,0 +1,26 @@ +Logic PD Type 28 4.3" WQVGA TFT LCD panel + +This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory. + +Required properties: +- compatible: should be "logicpd,type28" + +Optional properties: +- power-supply: regulator to provide the supply voltage +- enable-gpios: GPIO pin to enable or disable the panel +- backlight: phandle of the backlight device attached to the panel + +Optional nodes: +- Video port for RGB input. + +Example: + lcd0: display { + compatible = "logicpd,type28"; + enable-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>; + port { + lcd_in: endpoint { + remote-endpoint = <&dpi_out>; + }; + }; + }; From patchwork Tue Sep 17 16:12:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 11149151 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B784A14F7 for ; Tue, 17 Sep 2019 16:12:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FCB5218AC for ; Tue, 17 Sep 2019 16:12:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FCB5218AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BBF846ECFB; Tue, 17 Sep 2019 16:12:39 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by gabe.freedesktop.org (Postfix) with ESMTPS id C63556ECFB for ; Tue, 17 Sep 2019 16:12:37 +0000 (UTC) Received: by mail-io1-xd42.google.com with SMTP id h144so8925021iof.7 for ; Tue, 17 Sep 2019 09:12:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=WEnd6CA2jothE5bzqT12cUNUGcNA3mMbmNkUCnktma0=; b=ZsHKzJkYbUM7ZJA8jLTydWC5+FIUzwcUJZcBZk18X+TP5Y3awongiScBowTdq5qIP2 yNXkD/dwq4UmfppVX807Uth73cvGruAS3rVdqO9siLX/0ClsOf+0jzAxmeJTy/gPfrzc cFR/DW52UMKhX8vBmNswTgdUwBumu6601B2XH9te5pfMXPAxwAnjPmArj+ryCC192kUg /jxdKuqVfghj4eRqElTTRiwQVjziHknnzXrojmb5fH/KIgvRki+u6JeKul+hv7CaJkwn TtTYOaJX0Rs5SFkUBO4NvkqYnINoVsYAUMp/63gYqAQlB5pKHlwkFoWSrouDLEmWWBR0 dW/Q== X-Gm-Message-State: APjAAAUECEisJxhG+HzaAaAmp8gVmowwwVSBgef+mOrINs9e4L9r/XIs 8th+xZkL6516gL64UCGJJlxbhVz9VnT6dg== X-Google-Smtp-Source: APXvYqw82gd41rtWEeRFIHmEkIZ2K8Aglv1g8Yt6qRLTT0Ioa2nHqoN00Z0QQU7dccgXgV/FSJ8H7w== X-Received: by 2002:a05:6602:10a:: with SMTP id s10mr1068356iot.171.1568736756502; Tue, 17 Sep 2019 09:12:36 -0700 (PDT) Received: from aford-OptiPlex-7050.logicpd.com ([174.46.170.158]) by smtp.gmail.com with ESMTPSA id p25sm2090487ioo.35.2019.09.17.09.12.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2019 09:12:35 -0700 (PDT) From: Adam Ford To: dri-devel@lists.freedesktop.org Subject: [PATCH 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel Date: Tue, 17 Sep 2019 11:12:13 -0500 Message-Id: <20190917161214.2913-3-aford173@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190917161214.2913-1-aford173@gmail.com> References: <20190917161214.2913-1-aford173@gmail.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=WEnd6CA2jothE5bzqT12cUNUGcNA3mMbmNkUCnktma0=; b=Y8QIhZ+mpfw2Dc8DUoh3Vg0RCtS632bvaOxR2MyzC/t+T7ADNqaVqoaU59sFo6EcCn llAGQDzMGgUdcvVlwxXT935otNrZba7U65A4hxjdwfA5zI43ge2E3pO7JPHfnL5WXYuz W2Nqtwlw8N6PBypphkowTlhNqj5ZWq56psxAhywwtfmGKmfJNE2pmTf20PPNT0WCJ1dR z65m8X2gv9iQnTDbUXFVtR9e60bCXVgNel0cjqPVH+ygAFWc2szpH7Wl9yYgWJWmw5Fd Wcjm41n3p4jKVUO+Pf88Bd+ZJvmLe+Krk4EkJOfcOTwcQu3dtI8N0lEoYF0oKQ8SAwwv KHOg== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Sam Ravnborg , David Airlie , adam.ford@logicpd.com, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , linux-omap@vger.kernel.org, Adam Ford MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" With the removal of the panel-dpi from the omap drivers, the LCD no longer works. This patch points the device tree to a newly created panel named "logicpd,type28" Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Acked-by: Sam Ravnborg diff --git a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts index 07ac99b9cda6..00c426bd51a0 100644 --- a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts +++ b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts @@ -11,22 +11,8 @@ #include "logicpd-torpedo-37xx-devkit.dts" &lcd0 { - + /* This isn't the exact LCD, but the timings meet spec */ + /* To make it work, set CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK=4 */ + compatible = "logicpd,type28"; label = "28"; - - panel-timing { - clock-frequency = <9000000>; - hactive = <480>; - vactive = <272>; - hfront-porch = <3>; - hback-porch = <2>; - hsync-len = <42>; - vback-porch = <3>; - vfront-porch = <2>; - vsync-len = <11>; - hsync-active = <1>; - vsync-active = <1>; - de-active = <1>; - pixelclk-active = <0>; - }; };