From patchwork Tue Sep 17 18:34:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Cooper X-Patchwork-Id: 11149281 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D578614DB for ; Tue, 17 Sep 2019 18:36:29 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B026A21848 for ; Tue, 17 Sep 2019 18:36:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="AArn/cXq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B026A21848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iAIJ4-0003yx-GB; Tue, 17 Sep 2019 18:34:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iAIJ3-0003yf-J2 for xen-devel@lists.xenproject.org; Tue, 17 Sep 2019 18:34:29 +0000 X-Inumbo-ID: c83514fa-d979-11e9-b299-bc764e2007e4 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c83514fa-d979-11e9-b299-bc764e2007e4; Tue, 17 Sep 2019 18:34:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1568745269; h=from:to:cc:subject:date:message-id:mime-version; bh=ICIjZBbG+5HGUGm8TPCUcOelLUDVgToDTueke91dGTc=; b=AArn/cXqegeTHMy+lEPh9tWXXytBg5PUeuimNEkF8OEKI2Ew2lVouwdt ESXtxNJm5c7Z4P5kLKNe3C2R+OrdhUhKxrJQawQSLfZLKYVXDee10fcUJ mjloK2utInLhVdwQAvbIfQCRVpAf8BE8+mf2C+WC+5bU6zVXk1SaVioXx A=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: lbV6QUqFbhR53UQcXsvb93XMU3CDI5+5XKBWxZYOn63QLU78p+viXQfXFeqna1uUb2yLAwv2EE HzdZdFzOiM0z2WVc5M6l14qjiUDlQnEXggLwGGrSS1LjeNjrZN2bf649l+rRXISksS46OvkqQY 0ralKugU3EOR2hg7fzsV2kIq/DFlW0yOV4NclnN/diGDVLKAeLfRd+78R4msDTNcHnXa4lNHnK 8cxlorS3h70gseeTRhKkWTQWObnyxu7g7Nvn11JAsOioIaZXoYbK3lTKvIPxmcIXA+ZyP5rgh3 a78= X-SBRS: 2.7 X-MesageID: 5689757 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,517,1559534400"; d="scan'208";a="5689757" From: Andrew Cooper To: Xen-devel Date: Tue, 17 Sep 2019 19:34:25 +0100 Message-ID: <20190917183425.4826-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] tools/libs: Fix build following c/s 56dccee3f, take 2 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Andrew Cooper , Wei Liu , Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The fix for c/s 01ba8f62b618 was speculative given no local repro. It turns out that it didn't fix the problem. The $(AUTOINCS) variable needs to be visible before libs.mk is included, to have any effect. Signed-off-by: Andrew Cooper Acked-by: Ian Jackson --- CC: Ian Jackson CC: Wei Liu CC: Juergen Gross --- tools/libs/toolcore/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/libs/toolcore/Makefile b/tools/libs/toolcore/Makefile index edce61dca4..9c5a92d93f 100644 --- a/tools/libs/toolcore/Makefile +++ b/tools/libs/toolcore/Makefile @@ -4,6 +4,7 @@ include $(XEN_ROOT)/tools/Rules.mk MAJOR = 1 MINOR = 0 LIBNAME := toolcore +AUTOINCS := include/_xentoolcore_list.h SRCS-y += handlereg.c @@ -11,8 +12,6 @@ include $(XEN_ROOT)/tools/libs/libs.mk $(PKG_CONFIG_LOCAL): PKG_CONFIG_INCDIR = $(XEN_LIBXENTOOLCORE)/include -AUTOINCS=include/_xentoolcore_list.h - $(LIB_OBJS): $(AUTOINCS) $(PIC_OBJS): $(AUTOINCS)