From patchwork Sun Sep 22 11:00:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Elfring X-Patchwork-Id: 11155789 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 03BE11599 for ; Sun, 22 Sep 2019 11:00:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D595520820 for ; Sun, 22 Sep 2019 11:00:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h93+bpHU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=web.de header.i=@web.de header.b="JgUbv4dg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D595520820 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=web.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Date:Message-ID:Subject: From:To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=JWNE5oA4CmATg73uVrSNMWeH2hs3wIbTsJDG2ckGxkk=; b=h93+bpHUWNXjSz 9GS80NY1ccdVOtvOTPxZUMRcpInzCi+ADz5zhaxswt6kn9FgZRe+JwsDIrF7Flli3VeQI0o1SeCOJ qoe2zVnzkSSvK8eGl307oGU55SYEnW8w6K50LwwIG0onbYbT1voo2fvsNKiF2bLvGium51GHebglr nM2aH+A/q230Qe1AgDsY33I3ZxHd6n9HGBnmuCc88WhKZAbvZECHZZ5HN1Dkyq4ElgyLzs4ug3Dao dW+dcMSxGivWdH0CCR1ZvFvA5i6AGnsdA1MAvb96vNfvSBgabRLojJn7b4IkUSEGiOrSItF+4AORD 9UnH/jfot52dFel59qTg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iBzbi-0007sq-De; Sun, 22 Sep 2019 11:00:46 +0000 Received: from mout.web.de ([212.227.17.12]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iBzbY-0007i3-I8 for linux-mediatek@lists.infradead.org; Sun, 22 Sep 2019 11:00:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1569150012; bh=31q+m6nv3NSTbrLlF0GK7cMZgO8xqs0OAU+VDW2WZe8=; h=X-UI-Sender-Class:To:Cc:From:Subject:Date; b=JgUbv4dgXxeHxMoiW0EbcII+BzWxAT4v3nzlJfC55P8pgNVfAjRibaWnj7EtKlKht D0CzORZdZ2+5Fow2eUDV0OeoPbE2+ReeQPa8u/aGFfKsC3ea6xsxIFymRvrVa2Xfe8 v8FWdn7I9v8K/1aHNcrUuDwLdu3rr5iWzJljRHzg= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([2.244.8.78]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0Lhvpu-1hpbKb3yOA-00n9AT; Sun, 22 Sep 2019 13:00:12 +0200 To: dmaengine@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Dan Williams , Matthias Brugger , Sean Wang , Shun-Chih Yu , Vinod Koul From: Markus Elfring Subject: [PATCH] dmaengine: mediatek: Use devm_platform_ioremap_resource() in mtk_cqdma_probe() Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: Date: Sun, 22 Sep 2019 13:00:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 Content-Language: en-US X-Provags-ID: V03:K1:hAXADknAtGNYATmVWj93rnsc4+dPRkCq4IiYKz204pSpN0HWOTp F2WSVct/qhgaupn0VeWpSXbddaIZpOS0m0Re0Mpr3+6JT+pHpLle7a6JlH4BcidWm6TT+vF 7jGdM1RKg9wj+lBNnSVMIqbFpyQzAQFJn2ViR0nr32JoSP5GASQouJidE0HhTjD6MFaAXFQ pSX0HKZlLnyVZdaBdJq+Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Z4RCimlTYfI=:z0KqTyPUk4pIEwxeayyqmr oJwkWUI2bGwQkePKBV58Ou6gEuTmsRCHq1m2eSKhc6yiq4MEbUp/LQigcFehU+76MbigXcFS3 5CKgGA/sf/mWWuHbX/2KV1qdFOD6lhiHO0J88SYtnicNW0JjTkQbTsPwxQjnMuGtUOdJe+TB9 NXLF3P1r4tyFv1/qj56vOEqQoETUC/cC9+dbdXdNbG4sQtUJ1IR/C+a+6BQOLbauvWrbEMjS6 HVuZtF5gjv3a70ZKxTReHDf+LBJ045A550XQhB/FT7oC0ps/d+M4lA7E9xUq1J6ZbOkSfNrgo RlEazPIgA3ju6UR9oystpcpdyr5U+NGKTTY/WLqxW3LkyTm7lADgv/shqu6Ai/tR8eAH7JbM/ 3mqPIbN8ikiWLztOQM1PfubJdJ3BFv68OGa9B7uV9mncJrjd8BOYfHnFiqetZNnTILmQgdJdB JWktWIVKVDAqAb9Fe+4aLz2sqx7i9kQiSlgD4gkDvMXfUXt+ds2Z2lMMVFRwO04Qb9GL7ZQ5W /uqkKlb4ac4cFru7ByLKJVKQ7v8H1EZFWN1TNqPzUF3IynmDVjwW71K0RTU7sr6EGXNS3a/HB D+G1vjYXV2C1iaES+/6jaO4wdsPem3WsAZRQ4rGRPo0H5as0Bu851vExcr8+zhUvP9avO3lip XguEvRPbZG2b5o5J9aEUL8sXQGmDjLFkBz5lnEj/HgG5Sgv/GdIB1suVEl1vfkUc8/zbbYno4 89ocPjmsg86ct3HE4MLRK7/x89xYa7F6AVq/jDHcRMiN7EyR/+/z1876lPdaC870IN882txWc WnkQ0Db9E9U71fKwkWvDiPXGc7+Te/a7lIJJSMa8MWiUVexXWbD2dK4/k4LBlo+yteBYd5cSp szR9eLF8wvkAU7uXocPkKt3CdvAluffiENFW3ep1VdqsDaATmYnH1VGSthkZa5zrywln6wE2A 0LQBB2OZcGEKQ7gYJurvS2UvVdnnkaXxiXB6D34GwayKeH27EvqH+jPV0y1Iwmkk3GfWTdWNi FHYP65eRP9g2y/afJoYc/H/EgfiTgME6v2HYmUa9hBXt14UBLvLZvaw5BdlkO3fpA3A/uk2S4 dFErNAIGY3YvcLYkyUvrvUZey9WVTeZplNc5oAcBCT9uoxbvfs6IhZXqtY0/pCbW/KEv9Xp8D jx3+/yjt3gWyKIPTxsSLhlaApLTjtxo6Nc0JLn1op4W7sh8ff4O5W1OsYl6CImLf3nV9uvao7 q9H4j1pGentPgA3UvsAkECEybVfob2eWSlNYBMLDud03q9fAacoItdUh7NgA= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190922_040036_893999_5F6E0C86 X-CRM114-Status: UNSURE ( 9.29 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.9 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.12 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (markus.elfring[at]web.de) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org From: Markus Elfring Date: Sun, 22 Sep 2019 12:52:25 +0200 Simplify this function implementation a bit by using a known wrapper function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/dma/mediatek/mtk-cqdma.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) -- 2.23.0 diff --git a/drivers/dma/mediatek/mtk-cqdma.c b/drivers/dma/mediatek/mtk-cqdma.c index 723b11c190b3..6bf838e63be1 100644 --- a/drivers/dma/mediatek/mtk-cqdma.c +++ b/drivers/dma/mediatek/mtk-cqdma.c @@ -819,15 +819,7 @@ static int mtk_cqdma_probe(struct platform_device *pdev) INIT_LIST_HEAD(&cqdma->pc[i]->queue); spin_lock_init(&cqdma->pc[i]->lock); refcount_set(&cqdma->pc[i]->refcnt, 0); - - res = platform_get_resource(pdev, IORESOURCE_MEM, i); - if (!res) { - dev_err(&pdev->dev, "No mem resource for %s\n", - dev_name(&pdev->dev)); - return -EINVAL; - } - - cqdma->pc[i]->base = devm_ioremap_resource(&pdev->dev, res); + cqdma->pc[i]->base = devm_platform_ioremap_resource(pdev, i); if (IS_ERR(cqdma->pc[i]->base)) return PTR_ERR(cqdma->pc[i]->base);