From patchwork Mon Sep 23 13:44:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 11156957 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 95A6B76 for ; Mon, 23 Sep 2019 13:45:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DE0B20665 for ; Mon, 23 Sep 2019 13:45:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DE0B20665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9877B6E90F; Mon, 23 Sep 2019 13:45:08 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 93E726E90F for ; Mon, 23 Sep 2019 13:45:07 +0000 (UTC) Received: by mail-io1-xd43.google.com with SMTP id r26so33441587ioh.8 for ; Mon, 23 Sep 2019 06:45:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=8gJJO39rFvRPC27Eg6HXHKJTgns+bBIO2jkPaH1hgc4=; b=eYOXyXktDWdG/uD0RETrKTfOCGaZQ2iA3ifR3FLIeSJsaWfQJ2Q085vYouVONYdGXK eUHRQnQBzegJe/lK1Y/8uVgllD1FNJwb5CdEfg90UogW81iz9rMt+YBeGiPiKrwlJx/f zSq6Xq6PJCvuXV6wM/yvXUy8nsyoxe6nBA0wSsKQGxffXOJErRaGYxTEWR/23apfyt3c SkUqpfRn9Bu8DlqR9cC7wcq3F5JWnHdcwt8Zeroqf1EvHazVuB1V+b5xHAo/lfwjQL7/ vbjwsGLfpTj22f1h1tJlh8kq+27ani34uG7iyDongccUPO7wHAo1vHaKcpebfOOHsdpm kL1Q== X-Gm-Message-State: APjAAAWGS9EszUsom7mfrMPWZOwgbjKb7XiNbDFbxOzIV6XXdKiX8czj jqKeaoVO3FIRu2Uda63rZKr81Su2jek= X-Google-Smtp-Source: APXvYqzJ5o3V+xw8Vo6YavSbpE/G0mrA+1QvHonDZaHomPezsl9Rg4ZVusHEe89mStO7TrQUS+BgXA== X-Received: by 2002:a6b:c895:: with SMTP id y143mr14632059iof.271.1569246305617; Mon, 23 Sep 2019 06:45:05 -0700 (PDT) Received: from aford-OptiPlex-7050.logicpd.com ([174.46.170.158]) by smtp.gmail.com with ESMTPSA id x2sm8844474iob.74.2019.09.23.06.44.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2019 06:44:59 -0700 (PDT) From: Adam Ford To: dri-devel@lists.freedesktop.org Subject: [PATCH V2 1/3] drm/panel: simple: Add Logic PD Type 28 display support Date: Mon, 23 Sep 2019 08:44:47 -0500 Message-Id: <20190923134449.22326-1-aford173@gmail.com> X-Mailer: git-send-email 2.17.1 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=8gJJO39rFvRPC27Eg6HXHKJTgns+bBIO2jkPaH1hgc4=; b=gYnxWxDzYUW5wn60fhXJrrdD/bHxTVKwpKATR5CRZEQcYGvXyNPjvq4hzHLvfaf5Qn HLcQUGjw/5+RhsF9F2VVpXwAiTSkvIWCGnJo+3s8xZjyaV9ZfeUxBFlwP7KzOZAiIPTC T6j7b4NdQ//XRSTLKNKUQrQtMi5hhBgDwKp0tt0msVN9MHViDBJTcaUFdlXxZR90ujcH 4PYYFitroKR3Jc9v8E9sNobSwr3+LrMmKvS3jUjbM2Tt3xXNwVsdeb7M+QmK+83NBXfS LzBnzOTk9WrX+w3N0JyHc/MPaPt0Ej4YzZq5CAGpOPoSrTgEdQwTidx0M4upHPwcTPxH 3IJA== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Sam Ravnborg , David Airlie , adam.ford@logicpd.com, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , linux-omap@vger.kernel.org, Adam Ford MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Previously, there was an omap panel-dpi driver that would read generic timings from the device tree and set the display timing accordingly. This driver was removed so the screen no longer functions. This patch modifies the panel-simple file to setup the timings to the same values previously used. Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Reviewed-by: Sam Ravnborg --- V2: No change diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 5a93c4edf1e4..c86c30f3a8a1 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1900,6 +1900,40 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = { .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, }; +static const struct drm_display_mode logicpd_type_28_mode = { + .clock = 9000, + .hdisplay = 480, + .hsync_start = 480 + 3, + .hsync_end = 480 + 3 + 42, + .htotal = 480 + 3 + 42 + 2, + + .vdisplay = 272, + .vsync_start = 272 + 2, + .vsync_end = 272 + 2 + 11, + .vtotal = 272 + 2 + 11 + 3, + .vrefresh = 60, + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC, +}; + +static const struct panel_desc logicpd_type_28 = { + .modes = &logicpd_type_28_mode, + .num_modes = 1, + .bpc = 8, + .size = { + .width = 105, + .height = 67, + }, + .delay = { + .prepare = 200, + .enable = 200, + .unprepare = 200, + .disable = 200, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | + DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE, +}; + static const struct panel_desc mitsubishi_aa070mc01 = { .modes = &mitsubishi_aa070mc01_mode, .num_modes = 1, @@ -2948,6 +2982,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "lg,lp129qe", .data = &lg_lp129qe, + }, { + .compatible = "logicpd,type28", + .data = &logicpd_type_28, }, { .compatible = "mitsubishi,aa070mc01-ca1", .data = &mitsubishi_aa070mc01, From patchwork Mon Sep 23 13:44:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 11156963 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 74D5B76 for ; Mon, 23 Sep 2019 13:45:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D14520820 for ; Mon, 23 Sep 2019 13:45:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D14520820 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 677546E910; Mon, 23 Sep 2019 13:45:17 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by gabe.freedesktop.org (Postfix) with ESMTPS id E822E6E910 for ; Mon, 23 Sep 2019 13:45:15 +0000 (UTC) Received: by mail-io1-xd42.google.com with SMTP id b136so33524585iof.3 for ; Mon, 23 Sep 2019 06:45:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6KEVbOMgmT7rRfn/GiQXZyuHVfsA7+ZXr3TLsE1ZKxg=; b=azv7k8osWfeEiO++AHi9OYNWkIQe94Ocb6rI+YXqMimucRBD1Gc6Sm6PZy09tsGTxq +928tIfalQtj4mmBzyKuq8DvQa8hDYfHCxbY6tJQXOarNra4izsavkHB+8U+zk7VhHT3 /Gb6cdjYe2k7skXYpr8zl1Xj9IcqLM+YbaLKFS71JbsBkZjAls0IJK2a+1JMtsCBIDm7 lfTHyLAcoCxgFP4IABAuQkeZ4eCCfdeY0lioDnKHsn7qFe8emvJ1EHs6znZ8LwTNre53 Z+3F1Ik67HyvpAz0VWq44pc/79kVIb7bT5xOOvEoYgLXqC7q3SECIIAYxJDixSEoDbzx 5ZIA== X-Gm-Message-State: APjAAAUNunhFO1C/7Xs/S8oOwkUqauw3buM28uym/AYPLBv5ieIguUKP FlJdXdYxaIBP67lrCNI6Cr9n2qtgJSM= X-Google-Smtp-Source: APXvYqyRhc1UYpQc17s5gFWSBKWFMsHMrfOoJgvXh4s0LmVVLySIdfue6aQFT09HebdqP+/6iH4Gzw== X-Received: by 2002:a6b:e302:: with SMTP id u2mr2267525ioc.135.1569246313939; Mon, 23 Sep 2019 06:45:13 -0700 (PDT) Received: from aford-OptiPlex-7050.logicpd.com ([174.46.170.158]) by smtp.gmail.com with ESMTPSA id x2sm8844474iob.74.2019.09.23.06.45.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2019 06:45:08 -0700 (PDT) From: Adam Ford To: dri-devel@lists.freedesktop.org Subject: [PATCH V2 2/3] dt-bindings: Add Logic PD Type 28 display panel Date: Mon, 23 Sep 2019 08:44:48 -0500 Message-Id: <20190923134449.22326-2-aford173@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190923134449.22326-1-aford173@gmail.com> References: <20190923134449.22326-1-aford173@gmail.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6KEVbOMgmT7rRfn/GiQXZyuHVfsA7+ZXr3TLsE1ZKxg=; b=apaI9MYT4uF2EnxCrwNl6kE1+1obRxTSGNBCmUc1fv82RV20hwMgb0DelnRGQBg/0r /eUkkz48X0hfIPKZ2N2DmbN5oKZobno+nbjeT4eeskVcepR8ap4NOLPh5/jA0JggX023 xvJlUduAlc51f9v/RV2Bus8bcJJDY9yzItUSL7KWtJoJ/CObfC3BXBagk07kE4SAp7lX oU1df9YcLYKKdlWkMv+q5oms96DMigH/BvWFYs4/vFBV65Fq4vJ42EPFpG6DLEPcXP2L pRleMG7p84G+AXDbphrjFJl4MKLA9TSjeWjZu8plF4AKoet8cbrxTyq459qEcWKEXVH4 FE1g== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Sam Ravnborg , David Airlie , adam.ford@logicpd.com, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , linux-omap@vger.kernel.org, Adam Ford MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display. Signed-off-by: Adam Ford --- V2: Use YAML instead of TXT for binding diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml new file mode 100644 index 000000000000..707e2a17c8c2 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml @@ -0,0 +1,39 @@ +# SPDX-License-Identifier: (GPL-2.0+ OR X11) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/ronbo,rb070d30.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Logic PD Type 28 4.3" WQVGA TFT LCD panel + +properties: + compatible: + const: logicpd,type28 + + power-supply: + description: Regulator to provide the supply voltage + maxItems: 1 + + enable-gpios: + description: GPIO pin to enable or disable the panel + maxItems: 1 + + backlight: + description: Backlight used by the panel + $ref: "/schemas/types.yaml#/definitions/phandle" + +required: + - compatible + +additionalProperties: false + +examples: + lcd0: display { + compatible = "logicpd,type28"; + enable-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>; + port { + lcd_in: endpoint { + remote-endpoint = <&dpi_out>; + }; + }; + }; From patchwork Mon Sep 23 13:44:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 11156967 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6EBC076 for ; Mon, 23 Sep 2019 13:45:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 567AB20665 for ; Mon, 23 Sep 2019 13:45:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 567AB20665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E9FE6E914; Mon, 23 Sep 2019 13:45:21 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by gabe.freedesktop.org (Postfix) with ESMTPS id CA3246E913 for ; Mon, 23 Sep 2019 13:45:19 +0000 (UTC) Received: by mail-io1-xd42.google.com with SMTP id q1so33584880ion.1 for ; Mon, 23 Sep 2019 06:45:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=II3Z/ePw+kluHJAh79jkfAHhBKN0+PEn+7sKnI4/9O4=; b=LRABbZJo74OmEPchvD+M7+XDN+adsufCYmhC4CoXFx314DASZJ4s82dyUsUYX7WLbq NJJKvAcjFEa22zWRI4UnW9dbsJvp56MliRsx2jf8VW98/fPWEM7/RuW7gI/oU95v9NNE kH5106jnfRLXNckto1WZtz3GARVGM0zW8EVkuuMOA1bD1HARSf/0/dnU5KlOHfEvWqFg KyArxRbBZQJ/ior/pWOsEh+sYbon0Hr4F+8PkBzheTEOXeNK43BlbT2p0mktf85YHU22 svBpnmqWKQ3UWlfPDfxhZrR5jgFcwonIxhP5gLvk8WRbmsEJCWETOithdq+qH49YmcTW Eu2w== X-Gm-Message-State: APjAAAX3KwL98U+GpZ7zdrKbdrnwWfmopPV9jpB7Hk9gvyGG5J0OfINb jli2BYS4xMYnwm8cJnfxsQRoVFonQSA= X-Google-Smtp-Source: APXvYqyL7wQoJ473oflZEdH5F1MQH5u5UVaHY3bRwruszPd0fFxVNFp6Y7enr88bqIkoM2DZxCPn8Q== X-Received: by 2002:a6b:7509:: with SMTP id l9mr127293ioh.34.1569246317680; Mon, 23 Sep 2019 06:45:17 -0700 (PDT) Received: from aford-OptiPlex-7050.logicpd.com ([174.46.170.158]) by smtp.gmail.com with ESMTPSA id x2sm8844474iob.74.2019.09.23.06.45.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2019 06:45:15 -0700 (PDT) From: Adam Ford To: dri-devel@lists.freedesktop.org Subject: [PATCH V2 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel Date: Mon, 23 Sep 2019 08:44:49 -0500 Message-Id: <20190923134449.22326-3-aford173@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190923134449.22326-1-aford173@gmail.com> References: <20190923134449.22326-1-aford173@gmail.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=II3Z/ePw+kluHJAh79jkfAHhBKN0+PEn+7sKnI4/9O4=; b=LRIxgemCeo1xWi9guI7emc3IqoiMCWFHvsGEbD3szsHx+S8v43Ax2NGNrtoREyn2Bz vhnkmPK37M8KzQsgFNpeQ+BcY5h/4VC72ASTQkmKZFETngnZgV1M86XBfzG60leuCeYs 563KI6gOtg2Ce7d1NMNGrrAYJiU2WaB9WV23rE+x6LA9JhY1eytJKSG14aTC/KvjYA1n gjRa5pf0opTGYsQOJAhOHxgr15AJXj9sfeSKMd5XroMv52TCQgRkb0VoaDoZ7IBXq97v aw8aj0jbzaySkiFHq/CcsyQl8tAs8gEdCDPa3DgVSik6vPjiWbrz6fWg/2rzp9h/8uh8 vXNQ== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Sam Ravnborg , David Airlie , adam.ford@logicpd.com, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , linux-omap@vger.kernel.org, Adam Ford MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" With the removal of the panel-dpi from the omap drivers, the LCD no longer works. This patch points the device tree to a newly created panel named "logicpd,type28" Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Acked-by: Sam Ravnborg --- V2: Remove legacy 'label' from binding diff --git a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts index 07ac99b9cda6..cdb89b3e2a9b 100644 --- a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts +++ b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts @@ -11,22 +11,6 @@ #include "logicpd-torpedo-37xx-devkit.dts" &lcd0 { - - label = "28"; - - panel-timing { - clock-frequency = <9000000>; - hactive = <480>; - vactive = <272>; - hfront-porch = <3>; - hback-porch = <2>; - hsync-len = <42>; - vback-porch = <3>; - vfront-porch = <2>; - vsync-len = <11>; - hsync-active = <1>; - vsync-active = <1>; - de-active = <1>; - pixelclk-active = <0>; - }; + /* To make it work, set CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK=4 */ + compatible = "logicpd,type28"; };