From patchwork Wed Sep 25 15:27:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 11160963 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CB07A14DB for ; Wed, 25 Sep 2019 15:29:20 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AFC62205F4 for ; Wed, 25 Sep 2019 15:29:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFC62205F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iD9Cv-0006eD-3v; Wed, 25 Sep 2019 15:27:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iD9Ct-0006dy-UE for xen-devel@lists.xenproject.org; Wed, 25 Sep 2019 15:27:55 +0000 X-Inumbo-ID: 0ba00b34-dfa9-11e9-8628-bc764e2007e4 Received: from mx1.suse.de (unknown [195.135.220.15]) by localhost (Halon) with ESMTPS id 0ba00b34-dfa9-11e9-8628-bc764e2007e4; Wed, 25 Sep 2019 15:27:55 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A12ECAC52; Wed, 25 Sep 2019 15:27:54 +0000 (UTC) To: "xen-devel@lists.xenproject.org" From: Jan Beulich Message-ID: <052b6003-53a7-0563-72ac-48fe558ac549@suse.com> Date: Wed, 25 Sep 2019 17:27:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 Content-Language: en-US Subject: [Xen-devel] [PATCH] x86/CPUID: RSTR_FP_ERR_PTRS depends on FPU X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Andrew Cooper , Wei Liu , =?utf-8?q?Roger_Pau_Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" There's nothing to restore here if there's no FPU in the first place. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- To be considered for 4.13 since RSTR_FP_ERR_PTRS support was introduced just recently. --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -168,8 +168,9 @@ def crunch_numbers(state): deps = { # FPU is taken to mean support for the x87 regisers as well as the # instructions. MMX is documented to alias the %MM registers over the - # x87 %ST registers in hardware. - FPU: [MMX], + # x87 %ST registers in hardware. Correct restoring of error pointers + # of course makes no sense without there being anything to restore. + FPU: [MMX, RSTR_FP_ERR_PTRS], # The PSE36 feature indicates that reserved bits in a PSE superpage # may be used as extra physical address bits.