From patchwork Wed Sep 25 18:42:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 11161209 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1441514E5 for ; Wed, 25 Sep 2019 18:42:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7D0B21D7C for ; Wed, 25 Sep 2019 18:42:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7D0B21D7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 13A926EEED; Wed, 25 Sep 2019 18:42:53 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD6DA6EEF2 for ; Wed, 25 Sep 2019 18:42:51 +0000 (UTC) Received: by mail-io1-xd41.google.com with SMTP id j4so1356422iog.11 for ; Wed, 25 Sep 2019 11:42:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=TlBz3qIS+SsSa9e31MzD37WA3jnWQII7/YaRfP4QoxA=; b=Q1Eyc3gb5pMTla9XPRQcEP1ineATI77dOhvRew+VUaHOF8evxd9rORtiUjnt9Sea0f UYaa4n1aJgcoN0JFlIgKDKyYafTUuK98N6CtPcp4/Bm1o7unkqWFb8C/5XVJL61Y52wA jG1qfE2sXiMKSD2gWjwG//DKhtuo/p0c4ByZo9Mg0SZMFqFdTiwQo7jFxJVk07nF0eQF pTC3O0XIoaoS2RfawxzONHsI+g576A8FecUqHLBCDJHF3rligdV0iNoZMjm+yaTAVVBl vz6oXQwxRpVLUkMMlYQGzUvSRRH7JTaTBaCptGqlPRGk2id9uT2JVIUMRlH8sIZ8Dmnd Lxvg== X-Gm-Message-State: APjAAAViJtmxN//2Fl6gyr1JqnhpjS06dFPLT/Yd/IXxPFQ0QtGtj3g8 3DIYKMuKqEShNn37HcqKLEC6Gau2EdM= X-Google-Smtp-Source: APXvYqyWcbpkHZhyO2HSgyh99GMG9XDCNmg1b/77oJptfWakBsJXv7WLdgEZwob3RcTKaT6HbwJRhQ== X-Received: by 2002:a05:6602:1ce:: with SMTP id w14mr915623iot.137.1569436970815; Wed, 25 Sep 2019 11:42:50 -0700 (PDT) Received: from localhost.localdomain (c-73-37-219-234.hsd1.mn.comcast.net. [73.37.219.234]) by smtp.gmail.com with ESMTPSA id q17sm337511ile.5.2019.09.25.11.42.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2019 11:42:49 -0700 (PDT) From: Adam Ford To: dri-devel@lists.freedesktop.org Subject: [PATCH V3 1/3] drm/panel: simple: Add Logic PD Type 28 display support Date: Wed, 25 Sep 2019 13:42:36 -0500 Message-Id: <20190925184239.22330-1-aford173@gmail.com> X-Mailer: git-send-email 2.17.1 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=TlBz3qIS+SsSa9e31MzD37WA3jnWQII7/YaRfP4QoxA=; b=kZ+Ybj30bvqckN6rb/SACnDIb4xG59DbEkq3eHDObPzpjFkXjVVFMUQBwYc1kAbkeE Kgh0+IxBjigbjgM6B7AbBXRE6oy7WhHs36DHJYR99VCaHljp3LGe5eFyAi7GTLRQPdvd L0u0XMSneeu6M3IU9vQQbLcwTh/ZL/gPTpUtVn+XY+OPZixePvJ0aGgYWiN3iIKWeU8o jwytacPXg2gu7mC2rzxiY/QieHd4BPakPmpRhNy+KAb4ufMWSjcUj+ujEBPA/MfepyFV hcPG4+pjU2nc1aJBZI31/DaoIo2WbWC1zOOQH0SiQA5100AhuJ8QaLpAYhz11rvYZ0dO x2ug== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Sam Ravnborg , David Airlie , adam.ford@logicpd.com, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , Adam Ford MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Previously, there was an omap panel-dpi driver that would read generic timings from the device tree and set the display timing accordingly. This driver was removed so the screen no longer functions. This patch modifies the panel-simple file to setup the timings to the same values previously used. Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Reviewed-by: Sam Ravnborg --- V3: No change V2: No change diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 28fa6ba7b767..8abb31f83ffc 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -2048,6 +2048,40 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = { .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, }; +static const struct drm_display_mode logicpd_type_28_mode = { + .clock = 9000, + .hdisplay = 480, + .hsync_start = 480 + 3, + .hsync_end = 480 + 3 + 42, + .htotal = 480 + 3 + 42 + 2, + + .vdisplay = 272, + .vsync_start = 272 + 2, + .vsync_end = 272 + 2 + 11, + .vtotal = 272 + 2 + 11 + 3, + .vrefresh = 60, + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC, +}; + +static const struct panel_desc logicpd_type_28 = { + .modes = &logicpd_type_28_mode, + .num_modes = 1, + .bpc = 8, + .size = { + .width = 105, + .height = 67, + }, + .delay = { + .prepare = 200, + .enable = 200, + .unprepare = 200, + .disable = 200, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | + DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE, +}; + static const struct panel_desc mitsubishi_aa070mc01 = { .modes = &mitsubishi_aa070mc01_mode, .num_modes = 1, @@ -3264,6 +3298,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "lg,lp129qe", .data = &lg_lp129qe, + }, { + .compatible = "logicpd,type28", + .data = &logicpd_type_28, }, { .compatible = "mitsubishi,aa070mc01-ca1", .data = &mitsubishi_aa070mc01, From patchwork Wed Sep 25 18:42:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 11161213 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9E5381709 for ; Wed, 25 Sep 2019 18:43:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85C8C21655 for ; Wed, 25 Sep 2019 18:43:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85C8C21655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5340C6EF00; Wed, 25 Sep 2019 18:43:02 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by gabe.freedesktop.org (Postfix) with ESMTPS id D4B4F6EEF6 for ; Wed, 25 Sep 2019 18:42:54 +0000 (UTC) Received: by mail-io1-xd44.google.com with SMTP id c6so1324252ioo.13 for ; Wed, 25 Sep 2019 11:42:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7TqSWERPDP6dY8lexk4L6mhRR8imTrM3/l99588sDqo=; b=Wxt2Yte4fgYWchpaCip7GuwuNkgrAI+lmP6+VvoW2Io/s3rrjDBG++BqWE0HZ2qVah Pi/pF8jRcVpEcLr2RLrUnsx/ZC4xZIp91UH9KOuMINLmvQ4AwgeA4Ln0b9lVUFxIpEHm qqpCSX3gaJML5gM9GLjbbKVq94rQ+zcU82Y3AnPUPY1r7nUhyLyX1PJWbi5KZLTnEQM8 XngrD7O8/JxNmVpNu/cpqPeCjzbjr9D1Uh2vTEGR92HPi8wC8m1FfHM/hMnlQ9GC/xRB TSLwysp7GCkNo3kPjGq4J//fxKpSZVIt8tpipCVBjnB8sVMngZGxgSr3yQNnxK/GDi5l nyAA== X-Gm-Message-State: APjAAAXehsTT3cY2bjIAV9K1KOf3Poz2dMtTH6phHoNjHpGmEbtIxp4r 6GHk2wAn5nwRPtvNLoRMtYduHVIyNME= X-Google-Smtp-Source: APXvYqwwrDy8W/AtYbORQyLWMA9NN2CDdud93Tg9fQpFlGiWbambEjDSW7EoczUuk/UioCsYM2LQuQ== X-Received: by 2002:a6b:3e55:: with SMTP id l82mr877956ioa.216.1569436972896; Wed, 25 Sep 2019 11:42:52 -0700 (PDT) Received: from localhost.localdomain (c-73-37-219-234.hsd1.mn.comcast.net. [73.37.219.234]) by smtp.gmail.com with ESMTPSA id q17sm337511ile.5.2019.09.25.11.42.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2019 11:42:52 -0700 (PDT) From: Adam Ford To: dri-devel@lists.freedesktop.org Subject: [PATCH V3 2/3] dt-bindings: Add Logic PD Type 28 display panel Date: Wed, 25 Sep 2019 13:42:37 -0500 Message-Id: <20190925184239.22330-2-aford173@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190925184239.22330-1-aford173@gmail.com> References: <20190925184239.22330-1-aford173@gmail.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7TqSWERPDP6dY8lexk4L6mhRR8imTrM3/l99588sDqo=; b=FqmZgGUBYxcX6ZXTvgF1ZCGrqCQk4byoZONJBWX/y2WJE1WFxXZy/a/FjD26O420kK FxIDzsvAtqvHmKAYSZaqFkUxG57+n9YbAw6NzXffmaE5miqSzRbgKlBOkq2qM0ov5C90 mX0sV8PP9TGvYnH+e+0pwJqj6vipdHKVWkQFS8/SzjzsMdSSX8aVgkHuepyIB+CJm0yc bdmpz6vLOEpQ5Iis1pI4zxssvDaAwPycCtxq9kWhX4q6i8xS7edBxEgMXOXMdmqwUyWn +yFrgyQDxWpXUbsy5Acr+k8aLkXAdy9rm1WPZGM0vFjGNNSVue/6B+axo7tFHDgYzyYz emyA== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Sam Ravnborg , David Airlie , adam.ford@logicpd.com, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , Adam Ford MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This patch adds documentation of device tree bindings for the WVGA panel Logic PD Type 28 display. Signed-off-by: Adam Ford --- V3: Correct build errors from 'make dt_binding_check' V2: Use YAML instead of TXT for binding diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml new file mode 100644 index 000000000000..74ba650ea7a0 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml @@ -0,0 +1,31 @@ +# SPDX-License-Identifier: (GPL-2.0+ OR X11) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/logicpd,type28.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Logic PD Type 28 4.3" WQVGA TFT LCD panel + +maintainers: + - Adam Ford + +properties: + compatible: + const: logicpd,type28 + + power-supply: + description: Regulator to provide the supply voltage + maxItems: 1 + + enable-gpios: + description: GPIO pin to enable or disable the panel + maxItems: 1 + + backlight: + description: Backlight used by the panel + $ref: "/schemas/types.yaml#/definitions/phandle" + +required: + - compatible + +additionalProperties: false From patchwork Wed Sep 25 18:42:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 11161211 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6E02B14E5 for ; Wed, 25 Sep 2019 18:42:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56DED21655 for ; Wed, 25 Sep 2019 18:42:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56DED21655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C47F86EEFC; Wed, 25 Sep 2019 18:42:57 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4531B6EEF2 for ; Wed, 25 Sep 2019 18:42:56 +0000 (UTC) Received: by mail-io1-xd42.google.com with SMTP id h144so1429906iof.7 for ; Wed, 25 Sep 2019 11:42:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Nfx7JTVu0PRWrPasNmIdEHuXDgbsCjZv1S3XWQFYKYg=; b=YcP05peDRmKO1Wo6QfUxWGMZm08oQbfNawoystUTaqtWx41FDs5CPHLd80XGOfd0tc 51nh96AWqOUKXuIGJaUVH9/gkvF3EcBX6pfBCJGKE7i4GB9YTXwnK2qV1nNSCLqm1CIQ VlPXDUNulDtsX3v+XYPdpbj7l4B1yUQP1cWMzwQbplIYVaQuDypquYMPzNrSy0TKsBqP JGFY50DNy1FRYWSy7XgewEoN67rQziOg+pW93rOp3bJ9WkeFQLMfvKLMYN2HyPu0xYre eI06D4NaiP6MfIP4KNWZQsu5KnI2UXxllituJEk2Uc+tq8T7SPRGZ89jIro/Od8I8nba MHtQ== X-Gm-Message-State: APjAAAX3YEjMuqhv1tV3Az5B4R+AC3nCT26e8p5nBCP3yysHnkY167pC qI8ahwo5O0sxQVH11SpyO54wSYuvDY4= X-Google-Smtp-Source: APXvYqw8uBxXc+QlppeT9+fI+zXI803fXFhEr3c58w/+SY0fM0bf5aP9ub5Nm77ENx5/dzszjPUriQ== X-Received: by 2002:a05:6602:c9:: with SMTP id z9mr929490ioe.28.1569436974866; Wed, 25 Sep 2019 11:42:54 -0700 (PDT) Received: from localhost.localdomain (c-73-37-219-234.hsd1.mn.comcast.net. [73.37.219.234]) by smtp.gmail.com with ESMTPSA id q17sm337511ile.5.2019.09.25.11.42.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2019 11:42:54 -0700 (PDT) From: Adam Ford To: dri-devel@lists.freedesktop.org Subject: [PATCH V3 3/3] ARM: logicpd-torpedo-37xx-devkit-28: Reference new DRM panel Date: Wed, 25 Sep 2019 13:42:38 -0500 Message-Id: <20190925184239.22330-3-aford173@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190925184239.22330-1-aford173@gmail.com> References: <20190925184239.22330-1-aford173@gmail.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Nfx7JTVu0PRWrPasNmIdEHuXDgbsCjZv1S3XWQFYKYg=; b=Ne1IyYexGmWAl3Gmd6YygaFJ+CaOKP/8+69myulVINwwdcCJmpXrSiqxVSvcGnVipp 8597xWEGPKa+zJsDNcrkMnaTDzaPLbKFHI2P4GTQcd3mQg2kHI1kfJ6hx7w13iI4MJEX y7JN6wCC7yW7DUksLkOc8lTnL7d3fnwa5lKQlIM0NoL6wqGFQntcjW7vebHkDGuO2scA QlJfBI6ABPucYHGzd+a/1qsfsFXNZdVWMp99RBkx/Q1VrPyOumAPN/uG7CG4EvseBlZX 1lNkYO2e+gaRXWIla01vlV2Oe1vE6pjnfOYPsw4x77JICtQkoADXLXVcwnFqLMrrfpy2 QBog== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Sam Ravnborg , David Airlie , adam.ford@logicpd.com, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , Adam Ford MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" With the removal of the panel-dpi from the omap drivers, the LCD no longer works. This patch points the device tree to a newly created panel named "logicpd,type28" Fixes: 8bf4b1621178 ("drm/omap: Remove panel-dpi driver") Signed-off-by: Adam Ford Acked-by: Sam Ravnborg --- V3: No change V2: Remove legacy 'label' from binding diff --git a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts index 07ac99b9cda6..cdb89b3e2a9b 100644 --- a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts +++ b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit-28.dts @@ -11,22 +11,6 @@ #include "logicpd-torpedo-37xx-devkit.dts" &lcd0 { - - label = "28"; - - panel-timing { - clock-frequency = <9000000>; - hactive = <480>; - vactive = <272>; - hfront-porch = <3>; - hback-porch = <2>; - hsync-len = <42>; - vback-porch = <3>; - vfront-porch = <2>; - vsync-len = <11>; - hsync-active = <1>; - vsync-active = <1>; - de-active = <1>; - pixelclk-active = <0>; - }; + /* To make it work, set CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK=4 */ + compatible = "logicpd,type28"; };