From patchwork Mon Sep 30 11:45:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 11166547 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3594D112B for ; Mon, 30 Sep 2019 11:45:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0591E21855 for ; Mon, 30 Sep 2019 11:45:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LiWfsGiK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0SYpXQ7z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0591E21855 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=56x4/By25DV0K4ei7y9Dr5sPYvmrYtNkuq9bz5vQEIs=; b=LiW fsGiKUBrj84oI6x31xDP8J50tPWL/l7lokpa327RVEIBDgoKi8e4arzrClx9DuQpM6RJDovgfWogc wkENBsoX7QeSEHzO7yjGLac6sQk9qOVjz/s7jcqy/wB+SR1exjK7fWFjWxCt2kBFafhuUj6++SvNI HJHHrkXwx+8PLpnDFnUr5Y1uzNpWrZfMF9Cw0K+HlR1GeMn8kC6jX50QlpUogINXQ0XFGVthaj2qk 5YuL3fH7SXTBRANIIEbDikEzqsnoZqUJcg18ez/Q3Fs/GhKXEo6LUeikIenOyYFRwUzn5nW4jsisz FMhQDMCLGITUQmDUNkPdou0jR8rUeRQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iEu7i-0002GV-Do; Mon, 30 Sep 2019 11:45:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iEu7e-0002DM-P9 for linux-arm-kernel@lists.infradead.org; Mon, 30 Sep 2019 11:45:48 +0000 Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 97087216F4; Mon, 30 Sep 2019 11:45:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569843946; bh=iv/Dtkavbg/c29QLGURU+cPsjlv6mILK2Etm2RWqlsg=; h=From:To:Cc:Subject:Date:From; b=0SYpXQ7z0QqoDRun4j/lbd+Nx36/8rnMBqY1n7l6Y4BBOg6z5T4r6JtXfDJGLvQQr dcVxK9jQDZFTsjWZbuJCCNAP+8uqw3xcoyqeX9kSfNfU9Th0kgCph02Y2BHC1OSk3F da3X7DvTVSE0cKe9gbaWg3qLY9bKfNv/RYIiA1FE= From: Will Deacon To: torvalds@linux-foundation.org, yamada.masahiro@socionext.com Subject: [PATCH] Partially revert "compiler: enable CONFIG_OPTIMIZE_INLINING forcibly" Date: Mon, 30 Sep 2019 12:45:40 +0100 Message-Id: <20190930114540.27498-1-will@kernel.org> X-Mailer: git-send-email 2.11.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190930_044546_847331_6856946A X-CRM114-Status: GOOD ( 12.53 ) X-Spam-Score: -5.2 (-----) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-5.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [198.145.29.99 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Catalin Marinas , Russell King , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will Deacon , Nicolas Saenz Julienne MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This reverts commit ac7c3e4ff401b304489a031938dbeaab585bfe0a for ARM and arm64. Building an arm64 kernel with CONFIG_OPTIMIZE_INLINING=y has been shown to violate fixed register allocations of local variables passed to inline assembly with GCC prior to version 9 which can lead to subtle failures at runtime: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91111 A very similar has been reported for 32-bit ARM as well: https://lkml.kernel.org/r/f5c221f5749e5768c9f0d909175a14910d349456.camel@suse.de Although GCC 9.1 appears to work for the specific case in the bugzilla above, the exact issue has not been root-caused so play safe and disable the option for now on these architectures. Cc: Nicolas Saenz Julienne Cc: Linus Torvalds Cc: Catalin Marinas Cc: Russell King Cc: Masahiro Yamada , Cc: Arnd Bergmann Signed-off-by: Will Deacon --- lib/Kconfig.debug | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 93d97f9b0157..c37c72adaeff 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -312,6 +312,7 @@ config HEADERS_CHECK config OPTIMIZE_INLINING def_bool y + depends on !(ARM || ARM64) # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91111 help This option determines if the kernel forces gcc to inline the functions developers have marked 'inline'. Doing so takes away freedom from gcc to