From patchwork Fri Oct 11 15:02:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew Cooper X-Patchwork-Id: 11185689 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 46D2618B7 for ; Fri, 11 Oct 2019 15:04:19 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 221E1206CD for ; Fri, 11 Oct 2019 15:04:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="R6vRsctI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 221E1206CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iIwRY-0002go-Hn; Fri, 11 Oct 2019 15:03:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iIwRW-0002gj-Ne for xen-devel@lists.xenproject.org; Fri, 11 Oct 2019 15:02:58 +0000 X-Inumbo-ID: 3563e0a8-ec38-11e9-933b-12813bfff9fa Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3563e0a8-ec38-11e9-933b-12813bfff9fa; Fri, 11 Oct 2019 15:02:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1570806177; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=hnNOStA6qcYhE562odRCC01tuIlteEXw84G1woRvxAs=; b=R6vRsctIKqDhPkKDcy/6AVDHYVX7k14cL+7S4xLJkP3jbTX7EsuL7EhA b67rs2OfPCnrAsUM3Ssuu/lCvgRQogXHzlcQ/mnLqm3Z+SDflrBO7WKLH SdrT6zuH1EuUTi650/VRDwVi5fMYjI+6ELi+ZfzT0fQKekufJwCWN0jvM U=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: UHLjV1Rk2D0ISCadyO5k4BAxOdpvdcVzRqTrDQfV5FMrbI8MsgJOrJofjvalb2bmIg6rP8Q2mL epeHAvp42hjs8CSSsZZP9fQZ3qTvKSg5wVgXtfM3AGgZRNOBboVMIWPzmBEYl+S5odpJA9unvW x4R2BY9+e/jfRFnWeI3t4IrMmlbh3xnsN0VSzgrn6TYBFmksLm6uqwqB7P+nktTKamU6rhVf4v ipAWrg+zq1dSbhAnEoUQkaFOcy9BIGOIk0rjY3lm5R8P+UqAzCzn6PYtTUjxW9tFC7dv9heDkZ dog= X-SBRS: 2.7 X-MesageID: 6772780 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.67,284,1566878400"; d="scan'208";a="6772780" From: Andrew Cooper To: Xen-devel Date: Fri, 11 Oct 2019 16:02:53 +0100 Message-ID: <20191011150253.29457-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH for-4.13] x86/VT-d: Drop unhelpful information in diagnostics X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Kevin Tian , Jan Beulich , Wei Liu , Andrew Cooper , Jun Nakajima , =?utf-8?q?Roger_Pau_Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The virtual address of the base of the IOMMU's regsters is not useful for diagnostic purposes, and is quite voluminous. The PCI coordinates is by far the most useful piece of identifying information. Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Acked-by: Jan Beulich --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné CC: Jun Nakajima CC: Kevin Tian CC: Juergen Gross Surrounding printk()s also identify the IOMMU by Xen's internal ID, but that is also pretty useless information when diagnosing problems. RFC for-4.13. This is a nice to have stylistic improvement. --- xen/drivers/passthrough/vtd/iommu.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index f08eec070d..0522ecd3bc 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -842,26 +842,26 @@ static int iommu_page_fault_do_one(struct vtd_iommu *iommu, int type, case DMA_REMAP: printk(XENLOG_G_WARNING VTDPREFIX "DMAR:[%s] Request device [%04x:%02x:%02x.%u] " - "fault addr %"PRIx64", iommu reg = %p\n", + "fault addr %"PRIx64"\n", (type ? "DMA Read" : "DMA Write"), seg, PCI_BUS(source_id), PCI_SLOT(source_id), - PCI_FUNC(source_id), addr, iommu->reg); + PCI_FUNC(source_id), addr); kind = "DMAR"; break; case INTR_REMAP: printk(XENLOG_G_WARNING VTDPREFIX "INTR-REMAP: Request device [%04x:%02x:%02x.%u] " - "fault index %"PRIx64", iommu reg = %p\n", + "fault index %"PRIx64"\n", seg, PCI_BUS(source_id), PCI_SLOT(source_id), - PCI_FUNC(source_id), addr >> 48, iommu->reg); + PCI_FUNC(source_id), addr >> 48); kind = "INTR-REMAP"; break; default: printk(XENLOG_G_WARNING VTDPREFIX "UNKNOWN: Request device [%04x:%02x:%02x.%u] " - "fault addr %"PRIx64", iommu reg = %p\n", + "fault addr %"PRIx64"\n", seg, PCI_BUS(source_id), PCI_SLOT(source_id), - PCI_FUNC(source_id), addr, iommu->reg); + PCI_FUNC(source_id), addr); kind = "UNKNOWN"; break; }