From patchwork Tue Oct 15 04:38:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naohiro Aota X-Patchwork-Id: 11189703 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5E678912 for ; Tue, 15 Oct 2019 04:38:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2B31321835 for ; Tue, 15 Oct 2019 04:38:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=wdc.com header.i=@wdc.com header.b="Bn4skdOB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B31321835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 36B178E0005; Tue, 15 Oct 2019 00:38:46 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 31B638E0001; Tue, 15 Oct 2019 00:38:46 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 232308E0005; Tue, 15 Oct 2019 00:38:46 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 027568E0001 for ; Tue, 15 Oct 2019 00:38:45 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 9B965180189FD for ; Tue, 15 Oct 2019 04:38:45 +0000 (UTC) X-FDA: 76044763410.15.wren70_2f33ff1cbd91b X-Spam-Summary: 1,0,0,,d41d8cd98f00b204,prvs=18467e7c9=naohiro.aota@wdc.com,::linux-fsdevel@vger.kernel.org:linux-block@vger.kernel.org:akpm@linux-foundation.org:naohiro.aota@wdc.com,RULES_HIT:30034:30054,0,RBL:68.232.141.245:@wdc.com:.lbl8.mailshell.net-62.18.0.100 64.10.201.10,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:ft,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:279,LUA_SUMMARY:none X-HE-Tag: wren70_2f33ff1cbd91b X-Filterd-Recvd-Size: 3842 Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Oct 2019 04:38:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1571114324; x=1602650324; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=gDSqX501OhSu6g48JSoPoR2a3uxDz2ElT9166R/rHPM=; b=Bn4skdOB4jqmqgvUHkT1BQgY48teU52QnxlYbMezYP7vtw08LBC0sd1k +nels5t7gaybP0rBL11ez0zw/uIRiOeTqQwPnHpqcxYmfVfJgRw6l611y HUHMY3IOQ35/NMHnRCb54lLk/I16Sm+GobxzY9UnkFkSGPIQwkL9Dp+56 ImXC5qzX32kyqrGgI2gLT4kfxo989xIP5n+KYriPlL3tZ03psbCqSxRC5 4x5TVcIU3AazATfkj1IkyMnuiKVYft2bUBN0PHBC0dx/IcQdGiUAtkYzQ /bSlYsgzG0DRhqjdQAVywWFj1b2NO3m/Hwhm5BO2+QKPIIj26xgE+jn33 w==; IronPort-SDR: Rrb7Ap8Fh2QfpyOo++MKUmbN9X752K8O81m+Rjw+eqSIyjZHXWYlg5jaC03ollRY6l/FBGbptD K8zBKS0eeX3H5SUJ37KblA7oelUAskhTrtkmyvpO3HTVAA1gHq3g5pp+CyAJ5ayp8pJmcP2c5S H/huSTDmYv8RQWHpwU0x/dpumF5WPXhMUpcLG3FXYFdGFPW2+OuajMoHiLpB7TDt19usq6u4Si q7rdD4Hz0fUNw6fiIZFgT6Mxa5noRIFrDIb/WSGhst25otzohGFjjDm8FbylhQg8sxFenE5hjg rks= X-IronPort-AV: E=Sophos;i="5.67,297,1566835200"; d="scan'208";a="227591552" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 15 Oct 2019 12:38:30 +0800 IronPort-SDR: eF9fUZnuy3/NS72IFCACiVM36DH+E83xqIDfSgAjh1ylE/DMO3J2WdICaT5nNKuDkFteRTE2Ta 4QgZbl2e8vAmCXPXPyi36i3psxzdIjitw+FLk6CGp0HJSJLBcU43an8V7uoXRPn2/V9vavkNim 1IuqhCerzJD6LD+x+Q+mk+jbs/HS+phD3m8nJExG/tc/TGVr/UHuW4PJMNGsEabkzgPn28vipV M5HHXXm/uqvdIHGcfPuDTjPlHu81DAG/xEshW1Z3PSg5g9nIjZuMI4DDvM4Wo1wmrhtUTtAask qq7YROuXtwhciqly8GeifhwD Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2019 21:34:14 -0700 IronPort-SDR: UPN8Ssg25fhiIzxy+9ii1rkN3BxsQUiAyhRmmcuvGmruxDrp84oOI6HkHNrtP0frtOOQCxWhqH qPclCmfow5hbTFflQLX18xFlwbzGPK2sFrjQcs2oED2DR4ymAdbcTUZOXcwNsQtWgS7NgVmE1D x7EfqdKqTQI4ckLOlHqV7IgUgZ34UrjXyH++Ln5yugT/cdnHnjULcwQ3GcnUiZszFmJCxqbEJX b7WLFdSV5m/VYTjmHYkzBBD33WDn1oJcB4XiBN9GHM8GR18uQuM+D3gIu1F6ZPanAYHRw4OhIU 9EE= WDCIronportException: Internal Received: from naota.dhcp.fujisawa.hgst.com (HELO naota.fujisawa.hgst.com) ([10.149.53.115]) by uls-op-cesaip02.wdc.com with ESMTP; 14 Oct 2019 21:38:30 -0700 From: Naohiro Aota To: linux-mm@kvack.org Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, Andrew Morton , Naohiro Aota Subject: [PATCH] mm, swap: disallow swapon() on zoned block devices Date: Tue, 15 Oct 2019 13:38:27 +0900 Message-Id: <20191015043827.160444-1-naohiro.aota@wdc.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: A zoned block device consists of a number of zones. Zones are eitherconventional and accepting random writes or sequential and requiringthat writes be issued in LBA order from each zone write pointerposition. For the write restriction, zoned block devices are notsuitable for a swap device. Disallow swapon on them. Signed-off-by: Naohiro Aota --- mm/swapfile.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/swapfile.c b/mm/swapfile.c index dab43523afdd..a9da20739017 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -2887,6 +2887,8 @@ static int claim_swapfile(struct swap_info_struct *p, struct inode *inode) error = set_blocksize(p->bdev, PAGE_SIZE); if (error < 0) return error; + if (blk_queue_is_zoned(p->bdev->bd_queue)) + return -EINVAL; p->flags |= SWP_BLKDEV; } else if (S_ISREG(inode->i_mode)) { p->bdev = inode->i_sb->s_bdev;