From patchwork Wed Oct 16 07:22:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 11192485 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E6BE913BD for ; Wed, 16 Oct 2019 07:22:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7A7420873 for ; Wed, 16 Oct 2019 07:22:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QE2Uo2aI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726802AbfJPHW6 (ORCPT ); Wed, 16 Oct 2019 03:22:58 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:37174 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726875AbfJPHW6 (ORCPT ); Wed, 16 Oct 2019 03:22:58 -0400 Received: by mail-wm1-f68.google.com with SMTP id f22so1527169wmc.2 for ; Wed, 16 Oct 2019 00:22:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PviuyabPKIUKvylhvFSX9SEcIFgxFxjDOcPMsr4oBCs=; b=QE2Uo2aIkmIAKeej+740TwKIcJJptMtwc2e7v3UdxYccx/lDvtxqeLpk6lIzfeu0QO Yrca1h92zkQ8tD2DbbIE2lvzdAEfU8rPUohXdHLr2korlgdXIcP5Cxx+E5e4QZ0G+T3X SCa8dBABtLPCAEOI6M9wicIOCcbdoj1jcUWJ60oQ+LnN5N/hX3Vt+IrYXMLCpCzgbft/ 58NivtxVqcHJdVheiMmrgS2u7+eqTX/8JcOVLtaX37z0ocO/T/JKlosYlfQasQMJlxan I3iZu4W6cLRSIZ61Yumfsyf2l9jro5LtSZwUCblB4OKJm0p/X8hEdeNDCayq+Fbes0q6 wBmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PviuyabPKIUKvylhvFSX9SEcIFgxFxjDOcPMsr4oBCs=; b=bJaJym7Owkis7pn6BMxVlCyhRu5+0dKHIcMdH36jLTYm3uuX5I9tepweog6YgY226Y DFNbgH+vjd2M9pY8i5M1k/A0zes/VG6NWitEEvqN8ThScp5RtNJU+tu1BFiwaJ+1kFFD +a3nIqOerkHO4Vx7BreysTPhBvS2tEVjqPz1AclQXxI/z8lhjCByszuyuPIgY9z96I8x Sm6f+KE3RA7/moUTdiHrHg1rZuoXmzEQOnl402q8mvNKOYP7Qa4Ln0jgUVjwj95PD3lM CBhGif74hqyZ8uO7ftHlgoLgyNeP0rTiAC+Tcfkt+Vy8EDX3JbODICzxxDrCne96iV2m PBhw== X-Gm-Message-State: APjAAAUcwD/bsHuZ90Zv/jKNLHE61djlPJ6jmgHRnYgjiE5IEpKs+Lw1 Km8dh7WwtFOgOEJmNlfgHLC9opnq X-Google-Smtp-Source: APXvYqyQ6relfssaKI9GtHnIG68HPRimhB+NUHXpEwsyeSg/AaYESwRx5uxJgwNeQgSe5lc0FeyLCA== X-Received: by 2002:a1c:f011:: with SMTP id a17mr2016439wmb.18.1571210575952; Wed, 16 Oct 2019 00:22:55 -0700 (PDT) Received: from kheib-workstation.redhat.com (bzq-79-179-0-252.red.bezeqint.net. [79.179.0.252]) by smtp.gmail.com with ESMTPSA id r140sm1687046wme.47.2019.10.16.00.22.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2019 00:22:55 -0700 (PDT) From: Kamal Heib To: linux-rdma@vger.kernel.org Cc: Doug Ledford , Jason Gunthorpe , Lijun Ou , Selvin Xavier , Michal Kalderon , Kamal Heib Subject: [PATCH for-next v2 1/4] RDMA/core: Fix return code when modify_port isn't supported Date: Wed, 16 Oct 2019 10:22:31 +0300 Message-Id: <20191016072234.28442-2-kamalheib1@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191016072234.28442-1-kamalheib1@gmail.com> References: <20191016072234.28442-1-kamalheib1@gmail.com> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org The proper return code is "-EOPNOTSUPP" when modify_port callback is not supported. Fixes: 61e0962d5221 ("IB: Avoid ib_modify_port() failure for RoCE devices") Signed-off-by: Kamal Heib --- drivers/infiniband/core/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c index a667636f74bf..98a01caf7850 100644 --- a/drivers/infiniband/core/device.c +++ b/drivers/infiniband/core/device.c @@ -2397,7 +2397,7 @@ int ib_modify_port(struct ib_device *device, port_modify_mask, port_modify); else - rc = rdma_protocol_roce(device, port_num) ? 0 : -ENOSYS; + rc = rdma_protocol_roce(device, port_num) ? 0 : -EOPNOTSUPP; return rc; } EXPORT_SYMBOL(ib_modify_port); From patchwork Wed Oct 16 07:22:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 11192487 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 87B9113BD for ; Wed, 16 Oct 2019 07:23:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68B0520873 for ; Wed, 16 Oct 2019 07:23:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LRoYd8su" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727791AbfJPHW7 (ORCPT ); Wed, 16 Oct 2019 03:22:59 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:41672 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726875AbfJPHW7 (ORCPT ); Wed, 16 Oct 2019 03:22:59 -0400 Received: by mail-wr1-f67.google.com with SMTP id p4so10828724wrm.8 for ; Wed, 16 Oct 2019 00:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hAZ2TrIIVcLEbxIdOVbHEBWi4WBUQuacFKnyYRaMGgU=; b=LRoYd8su0OKNWCuZu6EaDj4g4SiQTR78JrYL27rstQSGprPXEud8FvUfzDOYKe/SZE ngM5MKfh1bG87Xco/aEpCvZwt0tOP7XjwJOvT5ftbCZs69X7nnOdpwQf0wSzNR46KleC dXjLny9qNZyHnkEz3JwMkN5c7oye2I5DdSQrcXvbtEtdIHtKMir+lnnJbR92prI+lUbg AeH7J3ircMzb1BfI1j6e9hfAFwHUqJRhqMvQkEkrcMrWOac/c5C9KpN758VmcmqNdHYc PcVZA/PWbc/98Zo/01M+qlvDR35DJJvdQd/NTH3sQGdj3gjUvscxWKGjhH+aEhF5T0CO Z1oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hAZ2TrIIVcLEbxIdOVbHEBWi4WBUQuacFKnyYRaMGgU=; b=FH06u6A8CHIyHVeMq7mWnTLmLUkr/ochCqyiXPJzNdccWb37p4PZaJ7zyCGpXYyXeG 0J+VdkxOl5eHl1rNyT+Ggot5SvohbYw2H2zgA915CSIiCn1XG/JaXWohQE5kWdKL8IWw AQkqN6NXTrYCQcmApSyttllwOZ0Hj3oqP575e7zM3uUBGLG04vHqYuy38wiULDGrbTXf rPqcVVlM7PnDfFRuwbxqwHZD4slfSdnmTRFZjHy1WMJad3yMcpAhhE2jGg//egO8HsYw mVyiFpEHAKGCSxGHHK2jZT5Plsvray1+YHq/HZCkCET05Zmj5WtWXos04PZ656xRu2Gq 1tQw== X-Gm-Message-State: APjAAAWqcWc6rJQjiNcygPpU+Cp9Kl7Z4NHheAsOwUgKwGPlQVIbxOlp Z9Owb2wN2Vf7ZM3AiGdKC7OkpK79 X-Google-Smtp-Source: APXvYqwO9BDndMKz/JOZFExJfmsq2QfA/1e2z0LAloxtyknKHxPwyGG2FgjDoTxYrQ8mjfSJxzjKBw== X-Received: by 2002:a05:6000:92:: with SMTP id m18mr1374990wrx.105.1571210577430; Wed, 16 Oct 2019 00:22:57 -0700 (PDT) Received: from kheib-workstation.redhat.com (bzq-79-179-0-252.red.bezeqint.net. [79.179.0.252]) by smtp.gmail.com with ESMTPSA id r140sm1687046wme.47.2019.10.16.00.22.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2019 00:22:57 -0700 (PDT) From: Kamal Heib To: linux-rdma@vger.kernel.org Cc: Doug Ledford , Jason Gunthorpe , Lijun Ou , Selvin Xavier , Michal Kalderon , Kamal Heib Subject: [PATCH for-next v2 2/4] RDMA/hns: Remove unsupported modify_port callback Date: Wed, 16 Oct 2019 10:22:32 +0300 Message-Id: <20191016072234.28442-3-kamalheib1@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191016072234.28442-1-kamalheib1@gmail.com> References: <20191016072234.28442-1-kamalheib1@gmail.com> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org There is no need to return always zero for function which is not supported. Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver") Signed-off-by: Kamal Heib --- drivers/infiniband/hw/hns/hns_roce_main.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c index b5d196c119ee..b241f74a7e3b 100644 --- a/drivers/infiniband/hw/hns/hns_roce_main.c +++ b/drivers/infiniband/hw/hns/hns_roce_main.c @@ -301,12 +301,6 @@ static int hns_roce_modify_device(struct ib_device *ib_dev, int mask, return 0; } -static int hns_roce_modify_port(struct ib_device *ib_dev, u8 port_num, int mask, - struct ib_port_modify *props) -{ - return 0; -} - static int hns_roce_alloc_ucontext(struct ib_ucontext *uctx, struct ib_udata *udata) { @@ -438,7 +432,6 @@ static const struct ib_device_ops hns_roce_dev_ops = { .get_port_immutable = hns_roce_port_immutable, .mmap = hns_roce_mmap, .modify_device = hns_roce_modify_device, - .modify_port = hns_roce_modify_port, .modify_qp = hns_roce_modify_qp, .query_ah = hns_roce_query_ah, .query_device = hns_roce_query_device, From patchwork Wed Oct 16 07:22:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 11192489 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 917B413BD for ; Wed, 16 Oct 2019 07:23:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7136020872 for ; Wed, 16 Oct 2019 07:23:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fh1m6/aK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726875AbfJPHXA (ORCPT ); Wed, 16 Oct 2019 03:23:00 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:33875 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727447AbfJPHXA (ORCPT ); Wed, 16 Oct 2019 03:23:00 -0400 Received: by mail-wm1-f65.google.com with SMTP id y135so3982465wmc.1 for ; Wed, 16 Oct 2019 00:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/nLBDNnI2ytUN/R+LaCECQ51HAzPdQVxI7fwxKBAxkk=; b=fh1m6/aK7UZaTL2ZvmcUBF4qsHh9/mZ4IrZ+3XQE5l7dDECw+lF6HlH+UFcXuYBBv3 76Uty9LDcCTsTbIqdZqt7UIuz5GXSDpa3+hx1z4o0KwpiZjnmpQFeTWfzsjUXSOomXzj 2w/fvbkyWZq6kCXrXWLROr+EsbNp4q5YznKTFqSHXZd+724mQVr9FEKsUl/jM3HgqAmC /EsrQKnC8lw1leu0a2nQ4FBL7jtY8r5PFE4aLiR9iA4u19O+zMDeHkXJdjwZBX79mtdz PXXdoYuF3DHPdQCvcFDfPDA83BbZCUDPQqlA6aXSh5tvsqZMDlUudBMqAt5O9l/ZtDoD HQcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/nLBDNnI2ytUN/R+LaCECQ51HAzPdQVxI7fwxKBAxkk=; b=gIIsVr8Qp1qBx89Ukes57wrfEvrW6CM/xe2uAHl2dcy1QgIKtQJwsacOz9QIsnpkej WkXQmUqhpcntjnEPdzwQywJ7lTCbIpqu41s4wxUMtZMbA/zf+VsG/r0qDP4xckn5Yh80 htdLNNEtSYNnJAnPRQSYHTylU4PL2omNtsmWgtx7JQKiU9B98yBXF1a/WdSBcx7XrmXw ksC4ZrYQmOjvpuECUT7HwJD0AD/CFa8DUXFLJJvhg7atEeljoVqsS0eCKEUHd1zlz7ci l4QXDEZSH4YHT07oAvjC0iCerR66+cE0bFPMpW4b9Xb61m2g1pH3/iaJImJVXMKniJyK 6d2A== X-Gm-Message-State: APjAAAUrOuSgHwlNehH+gIW8c/kcLVfbW+UdCeuIN+Dyx5GdNPNcf0jT aqifOrpqoboSjDcpYbWiCR3w6B4X X-Google-Smtp-Source: APXvYqwnlBr5BolU+0Nx+3cqBKBKkJbXYnNMkEuqhy77+xUnhqNKa0maTaBja/LgAt0yvtcFLoYeEA== X-Received: by 2002:a1c:9d4c:: with SMTP id g73mr2205259wme.92.1571210578801; Wed, 16 Oct 2019 00:22:58 -0700 (PDT) Received: from kheib-workstation.redhat.com (bzq-79-179-0-252.red.bezeqint.net. [79.179.0.252]) by smtp.gmail.com with ESMTPSA id r140sm1687046wme.47.2019.10.16.00.22.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2019 00:22:58 -0700 (PDT) From: Kamal Heib To: linux-rdma@vger.kernel.org Cc: Doug Ledford , Jason Gunthorpe , Lijun Ou , Selvin Xavier , Michal Kalderon , Kamal Heib Subject: [PATCH for-next v2 3/4] RDMA/ocrdma: Remove unsupported modify_port callback Date: Wed, 16 Oct 2019 10:22:33 +0300 Message-Id: <20191016072234.28442-4-kamalheib1@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191016072234.28442-1-kamalheib1@gmail.com> References: <20191016072234.28442-1-kamalheib1@gmail.com> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org There is no need to return always zero for function which is not supported. Fixes: fe2caefcdf58 ("RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMAadapter") Signed-off-by: Kamal Heib --- drivers/infiniband/hw/ocrdma/ocrdma_main.c | 1 - drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 6 ------ drivers/infiniband/hw/ocrdma/ocrdma_verbs.h | 2 -- 3 files changed, 9 deletions(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_main.c b/drivers/infiniband/hw/ocrdma/ocrdma_main.c index c15cfc6cef81..d8c47d24d6d6 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_main.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_main.c @@ -166,7 +166,6 @@ static const struct ib_device_ops ocrdma_dev_ops = { .get_port_immutable = ocrdma_port_immutable, .map_mr_sg = ocrdma_map_mr_sg, .mmap = ocrdma_mmap, - .modify_port = ocrdma_modify_port, .modify_qp = ocrdma_modify_qp, .poll_cq = ocrdma_poll_cq, .post_recv = ocrdma_post_recv, diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c index e8267e590772..e72050de5734 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c @@ -190,12 +190,6 @@ int ocrdma_query_port(struct ib_device *ibdev, return 0; } -int ocrdma_modify_port(struct ib_device *ibdev, u8 port, int mask, - struct ib_port_modify *props) -{ - return 0; -} - static int ocrdma_add_mmap(struct ocrdma_ucontext *uctx, u64 phy_addr, unsigned long len) { diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.h b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.h index 32488da1b752..3a5010881be5 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.h +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.h @@ -54,8 +54,6 @@ int ocrdma_arm_cq(struct ib_cq *, enum ib_cq_notify_flags flags); int ocrdma_query_device(struct ib_device *, struct ib_device_attr *props, struct ib_udata *uhw); int ocrdma_query_port(struct ib_device *, u8 port, struct ib_port_attr *props); -int ocrdma_modify_port(struct ib_device *, u8 port, int mask, - struct ib_port_modify *props); enum rdma_protocol_type ocrdma_query_protocol(struct ib_device *device, u8 port_num); From patchwork Wed Oct 16 07:22:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 11192491 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 28A8E1668 for ; Wed, 16 Oct 2019 07:23:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0834620872 for ; Wed, 16 Oct 2019 07:23:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZNkGJuli" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727565AbfJPHXD (ORCPT ); Wed, 16 Oct 2019 03:23:03 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:34948 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727447AbfJPHXD (ORCPT ); Wed, 16 Oct 2019 03:23:03 -0400 Received: by mail-wm1-f65.google.com with SMTP id y21so1538869wmi.0 for ; Wed, 16 Oct 2019 00:23:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TycqH6hRWVQcQ82ZcSfaibr4XzfZ5J5iKsyxzuflrxg=; b=ZNkGJulizU9/cOjUsRXIz2b0V2H2c3vqa/71oELKcIldVHiuYWxlEcif0DaDqXRxIJ pIo1xl7t+q0VpbWP2lW70wCrTfynaF8w3zHc7NIpMiTozUMHkf6O005OM+7kRvdkEsRj G4D/hZ6X8MsBpZVrzM2BXviGAcrn37LkVP9OWRfJHQitWs3YjgCpZTYgi9JOwOvAi2l0 cslTJuA6h2olS2QaMDGxCMOC9v74QhUjkS8BJKa7X0GqSUfye4ss/Oz+srSAceQhXJGb o2WBpqbtwu6LV0xSPL2zcFLOEVfFP/nmGc00i1RjQK/1H35WQirGhRzsTPjfFi3AF2RN 4dDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TycqH6hRWVQcQ82ZcSfaibr4XzfZ5J5iKsyxzuflrxg=; b=nsAN2lIDTNMng2ssr9Rjc8zv313bJGBCJp2YHn3Qu6yr9+gQjEId+yGmz7WFAD6ZhY LHYLQ8ydLO8tuxEiqL1rDgq/mrzxhirSfgz7PVrPczCoc6jdfgVTHKlGPJnQsH7+90Jz fqWLjhfSuCo4wge64dCHdnmKBxekk8RnksGM5fnnHww7UQS7EdCGnF3QXdlDk7IhZf8u pk06ymQB0fXGDf+6ySbnZIomJYvgjFU5r7DmvD3VG7bYLTYyeZgttny8Ry4NOXv847he 47fmEF/DelDJ1Tc3S6Daaeg5ml/TtYU/ohLG5as653LxaPLpDGtFU6PnS8P+ThHg0Yn9 IbiA== X-Gm-Message-State: APjAAAXZfvTCIY7FazRkIcwrmypzuSxysIYMWO5iUcDmCPPe0aXVshot TlaW1zG5uAjd86kIwhnM1sRSERP5 X-Google-Smtp-Source: APXvYqy7fp/e4SI5Ee/RSgn/u5d0efM7SpC2qgXxpUls22op4vrgBN0Rw77PhodrGY5992Ka+8m66Q== X-Received: by 2002:a7b:c7d4:: with SMTP id z20mr2097912wmk.145.1571210580214; Wed, 16 Oct 2019 00:23:00 -0700 (PDT) Received: from kheib-workstation.redhat.com (bzq-79-179-0-252.red.bezeqint.net. [79.179.0.252]) by smtp.gmail.com with ESMTPSA id r140sm1687046wme.47.2019.10.16.00.22.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2019 00:22:59 -0700 (PDT) From: Kamal Heib To: linux-rdma@vger.kernel.org Cc: Doug Ledford , Jason Gunthorpe , Lijun Ou , Selvin Xavier , Michal Kalderon , Kamal Heib Subject: [PATCH for-next v2 4/4] RDMA/qedr: Remove unsupported modify_port callback Date: Wed, 16 Oct 2019 10:22:34 +0300 Message-Id: <20191016072234.28442-5-kamalheib1@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191016072234.28442-1-kamalheib1@gmail.com> References: <20191016072234.28442-1-kamalheib1@gmail.com> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org There is no need to return always zero for function which is not supported. Fixes: ac1b36e55a51 ("qedr: Add support for user context verbs") Signed-off-by: Kamal Heib --- drivers/infiniband/hw/qedr/main.c | 1 - drivers/infiniband/hw/qedr/verbs.c | 6 ------ drivers/infiniband/hw/qedr/verbs.h | 2 -- 3 files changed, 9 deletions(-) diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c index 5136b835e1ba..e5f36adb0120 100644 --- a/drivers/infiniband/hw/qedr/main.c +++ b/drivers/infiniband/hw/qedr/main.c @@ -212,7 +212,6 @@ static const struct ib_device_ops qedr_dev_ops = { .get_link_layer = qedr_link_layer, .map_mr_sg = qedr_map_mr_sg, .mmap = qedr_mmap, - .modify_port = qedr_modify_port, .modify_qp = qedr_modify_qp, .modify_srq = qedr_modify_srq, .poll_cq = qedr_poll_cq, diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c index 6f3ce86019b7..fee02ac47f32 100644 --- a/drivers/infiniband/hw/qedr/verbs.c +++ b/drivers/infiniband/hw/qedr/verbs.c @@ -250,12 +250,6 @@ int qedr_query_port(struct ib_device *ibdev, u8 port, struct ib_port_attr *attr) return 0; } -int qedr_modify_port(struct ib_device *ibdev, u8 port, int mask, - struct ib_port_modify *props) -{ - return 0; -} - static int qedr_add_mmap(struct qedr_ucontext *uctx, u64 phy_addr, unsigned long len) { diff --git a/drivers/infiniband/hw/qedr/verbs.h b/drivers/infiniband/hw/qedr/verbs.h index 9aaa90283d6e..d81b81f86f0a 100644 --- a/drivers/infiniband/hw/qedr/verbs.h +++ b/drivers/infiniband/hw/qedr/verbs.h @@ -35,8 +35,6 @@ int qedr_query_device(struct ib_device *ibdev, struct ib_device_attr *attr, struct ib_udata *udata); int qedr_query_port(struct ib_device *, u8 port, struct ib_port_attr *props); -int qedr_modify_port(struct ib_device *, u8 port, int mask, - struct ib_port_modify *props); int qedr_iw_query_gid(struct ib_device *ibdev, u8 port, int index, union ib_gid *gid);