From patchwork Fri Oct 18 09:41:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 11197957 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AF14318A6 for ; Fri, 18 Oct 2019 09:41:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8ECDE21D7C for ; Fri, 18 Oct 2019 09:41:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MrJXh9tR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732590AbfJRJld (ORCPT ); Fri, 18 Oct 2019 05:41:33 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:38591 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2409690AbfJRJld (ORCPT ); Fri, 18 Oct 2019 05:41:33 -0400 Received: by mail-wm1-f68.google.com with SMTP id 3so5416766wmi.3 for ; Fri, 18 Oct 2019 02:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qkzmz2qGtNZ7G3wa+kWShhmOGmor0JHxullS6dxBu0c=; b=MrJXh9tRQBaXCv1YMqTQnJX4E/4R+J7pNn0QY8PLBZQfCq0jtqI4u3mlBpBTSjoK1N UeK6ibxkxaGOmTo4bJE4df5u8pEuyHLrntEYvSoAgX0OY5d2pUjwNEViuOFIb65JJ3W4 ddMJuIIofw2DWnsKSoK6p2Wo5sDbQsI5nGg9uBYQn80YeZdmA+K+zJQZ/DOFZ3PfaCQ4 saJE80sEnwSejY1DCbwbx6qgWYVTa7v1q759ePWMzcuUHUedtq7xABZLdwsQvLzrsBIu Znya2DA/5OIoSbS7OAjwjZ/WAxh7DJ/na4aSILfT6miUAm5rP4g5ByYAfCP3PhO3LWkI ILDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qkzmz2qGtNZ7G3wa+kWShhmOGmor0JHxullS6dxBu0c=; b=S1achaFY3n5aXpOlNRtXUuS604KkD929ZORmbV3u7U9l56w+j32cT3QNmB4wJAvNMk 6urmvt5itT7PMUCTWPtO2cU5PkvPtAeG8SosAnEVhD1EOK6y0hQZJK4LBgxSvtxRRQ6W rjEMT4Fn5M4XCHBrmLlNWe60p22zf+c8ueaxg16ef2KfwHiOscC2ry+o99LLs/NGQtef A9gWEMuqf3+9f9ifW7yJMPDNlbBEQwNQuLk7OWYUZ1Q0CcXf8sH1u+ASebLSDcTmse0c vhIbTkxgjDUyHwm468HjFvAN1D3P1Lkl4W1qqnsD4QAcWJPjuxpwi1TSzpCJyyB607ZO U+LQ== X-Gm-Message-State: APjAAAWYZwnIVoTIYcmulnT4jg0L+2WaCfmK1yRAcgTNIvv2tbndIX/b Vv9Ut51w1D/+3uSffd85zjOAchaA X-Google-Smtp-Source: APXvYqwzThDUqaIUNYHCwMvPHmjObD2i4FAWR1q1VLjZ+UMzOA5Xg2ULIt/ahtSZr6u7X/AK4NgFSg== X-Received: by 2002:a1c:a444:: with SMTP id n65mr7097384wme.111.1571391692185; Fri, 18 Oct 2019 02:41:32 -0700 (PDT) Received: from kheib-workstation.redhat.com (bzq-79-179-0-252.red.bezeqint.net. [79.179.0.252]) by smtp.gmail.com with ESMTPSA id 126sm2186111wma.48.2019.10.18.02.41.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 02:41:31 -0700 (PDT) From: Kamal Heib To: linux-rdma@vger.kernel.org Cc: Doug Ledford , Jason Gunthorpe , Lijun Ou , Selvin Xavier , Michal Kalderon , Kamal Heib Subject: [PATCH for-next v3 1/4] RDMA/core: Fix return code when modify_port isn't supported Date: Fri, 18 Oct 2019 12:41:12 +0300 Message-Id: <20191018094115.13167-2-kamalheib1@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191018094115.13167-1-kamalheib1@gmail.com> References: <20191018094115.13167-1-kamalheib1@gmail.com> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Improving return code from ib_modify_port() by doing the following: 1- Use "-EOPNOTSUPP" instead "-ENOSYS" which is the proper return code. 2- Avoid confusion by return "-EOPNOTSUPP" when modify_port() isn't supplied by the provider and the protocol is IB, otherwise return success to avoid failure of the ib_modify_port() in CM layer. Fixes: 61e0962d5221 ("IB: Avoid ib_modify_port() failure for RoCE devices") Signed-off-by: Kamal Heib Reviewed-by: Michal Kalderon  --- drivers/infiniband/core/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c index a667636f74bf..626ac18dd3a7 100644 --- a/drivers/infiniband/core/device.c +++ b/drivers/infiniband/core/device.c @@ -2397,7 +2397,7 @@ int ib_modify_port(struct ib_device *device, port_modify_mask, port_modify); else - rc = rdma_protocol_roce(device, port_num) ? 0 : -ENOSYS; + rc = rdma_protocol_ib(device, port_num) ? -EOPNOTSUPP : 0; return rc; } EXPORT_SYMBOL(ib_modify_port); From patchwork Fri Oct 18 09:41:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 11197959 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0E58A14ED for ; Fri, 18 Oct 2019 09:41:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E2F8221D7C for ; Fri, 18 Oct 2019 09:41:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bc0N4yFt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392366AbfJRJlg (ORCPT ); Fri, 18 Oct 2019 05:41:36 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:39596 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2409690AbfJRJlf (ORCPT ); Fri, 18 Oct 2019 05:41:35 -0400 Received: by mail-wm1-f65.google.com with SMTP id v17so5400330wml.4 for ; Fri, 18 Oct 2019 02:41:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hAZ2TrIIVcLEbxIdOVbHEBWi4WBUQuacFKnyYRaMGgU=; b=bc0N4yFtCDvQuTeYZbrZBl0MvigSkN/d+Owm/UhJoB/Yuf0yGrx+N8VJ5xbxaLkcIs 3aFzoCDF3e0CzGJ+YBO5rGqGr2dGriND5Wiscx4WR9TQBnjhqEbQlHhaLkQPHqqz8TOO qGfmbxc+w8AHxnGffbbkLYh6JBgqH8jU+0x7NRFCjJHnVzTk2kYdRq4WfF2bil7nP7+i P/flMoP5CliusO2wAcYkcPzxgiBjl3CaYCdTybMzOixSuSCZ45J2Z1YX+8zHqrG34M9P Y+0saYfebZjgxoZRRvd6cglPj3OcubZyAlChApE7OMg3pk89iEuB1mp6cdOF2dvRqo8x 5tyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hAZ2TrIIVcLEbxIdOVbHEBWi4WBUQuacFKnyYRaMGgU=; b=GjLoroG+jN6tmI4n4vVry+AoBpcEbfkYkAwoJLJqaSxowzQeJzwwLHA+wtdt6qgf4W YG6mAo2GmEib7a3bzXBmlAaYmlKXPmgYvZNtOTsQZUkEZOTNS74vbwZTjEvDE96XM6og IXfHxIFWycpeySdbZNRN+uPX+Skw36rWcbAzVbsWyZCPf60oJoids1lAWyHZkDrwXPDY SzdZ2uWg3Ozf3FvHybg7C1g42QmmZQilD/bpTZr9OEQuX2DtQgi79Vr5B/phrliqbdJL uwEDend9pmdGA4u5pL5CXlnefL6MHwBf+sb9fnwA/UWJUARfQ+fWQLzqSUXHaqQo+WQU 5Ntg== X-Gm-Message-State: APjAAAVYUDmvj7e+TLVWT7nU7W4IR+CoK3IspzliKz+HbtYmELwgxZpq QpHSo16Fcrbx3VEcJVRlVjgh6ATQ X-Google-Smtp-Source: APXvYqyerypUNCBquYnHL2UsrO76eXBKC/pqW1dHPXbMKYbmPA7ia01iOOZbGxSf2WFkEsWA9YlDLA== X-Received: by 2002:a1c:3c07:: with SMTP id j7mr691766wma.122.1571391693514; Fri, 18 Oct 2019 02:41:33 -0700 (PDT) Received: from kheib-workstation.redhat.com (bzq-79-179-0-252.red.bezeqint.net. [79.179.0.252]) by smtp.gmail.com with ESMTPSA id 126sm2186111wma.48.2019.10.18.02.41.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 02:41:33 -0700 (PDT) From: Kamal Heib To: linux-rdma@vger.kernel.org Cc: Doug Ledford , Jason Gunthorpe , Lijun Ou , Selvin Xavier , Michal Kalderon , Kamal Heib Subject: [PATCH for-next v3 2/4] RDMA/hns: Remove unsupported modify_port callback Date: Fri, 18 Oct 2019 12:41:13 +0300 Message-Id: <20191018094115.13167-3-kamalheib1@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191018094115.13167-1-kamalheib1@gmail.com> References: <20191018094115.13167-1-kamalheib1@gmail.com> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org There is no need to return always zero for function which is not supported. Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver") Signed-off-by: Kamal Heib --- drivers/infiniband/hw/hns/hns_roce_main.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c index b5d196c119ee..b241f74a7e3b 100644 --- a/drivers/infiniband/hw/hns/hns_roce_main.c +++ b/drivers/infiniband/hw/hns/hns_roce_main.c @@ -301,12 +301,6 @@ static int hns_roce_modify_device(struct ib_device *ib_dev, int mask, return 0; } -static int hns_roce_modify_port(struct ib_device *ib_dev, u8 port_num, int mask, - struct ib_port_modify *props) -{ - return 0; -} - static int hns_roce_alloc_ucontext(struct ib_ucontext *uctx, struct ib_udata *udata) { @@ -438,7 +432,6 @@ static const struct ib_device_ops hns_roce_dev_ops = { .get_port_immutable = hns_roce_port_immutable, .mmap = hns_roce_mmap, .modify_device = hns_roce_modify_device, - .modify_port = hns_roce_modify_port, .modify_qp = hns_roce_modify_qp, .query_ah = hns_roce_query_ah, .query_device = hns_roce_query_device, From patchwork Fri Oct 18 09:41:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 11197961 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A3CFC13B1 for ; Fri, 18 Oct 2019 09:41:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8393021D7C for ; Fri, 18 Oct 2019 09:41:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CpxitlkK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404496AbfJRJlh (ORCPT ); Fri, 18 Oct 2019 05:41:37 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:50838 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390553AbfJRJlg (ORCPT ); Fri, 18 Oct 2019 05:41:36 -0400 Received: by mail-wm1-f66.google.com with SMTP id 5so5474063wmg.0 for ; Fri, 18 Oct 2019 02:41:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/nLBDNnI2ytUN/R+LaCECQ51HAzPdQVxI7fwxKBAxkk=; b=CpxitlkK2kw5eHHRk/N7OrnkoOy+P0zGzG0FmJIMB2MbV3WrohuYgu7VeCT965LXix NsZnPXvMHendhlQKMBHMM13Dg/KFMrCQgJFOPY4CCdxQFthi7MZcqfpMkNlRz9zTd+qQ Oh2/5es82icn3vZ5EFLWilirGhZhIYQjtPNWTeAWB22tg3NGT3gswexcw7O+ZPWCruPn rBf6fm+clg2SdQQkY5OM721xQqj/D5L38EazyMnHi5AM5cA837XLDFlVu/FXmoRhT/Z2 A1dVma2RrKxwVUI5eX97Zn1Hit+/cpTJjAN48ZFYAqnc0KItIaj69Q8vuh6Dhdi3Sdbx x5DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/nLBDNnI2ytUN/R+LaCECQ51HAzPdQVxI7fwxKBAxkk=; b=Qwo3to1Ju1P5MiIBSo7c/dOZei0e9eVOXtEKIeoDmHZo5eZjA1XyYdjkUamt0Vnz1H DBbLXoy1dgW5a9pChm5QSzcvTorpMcNW3hFQ1wJ9/00wf2UIAPstSqP1XG3YeyeNC0zB WFwHIY4swo6KtKKfjaVlKiOVYHbJvsMzCl687yVQcG0Dd61qY9S4rrjqo7c/i5vI4Z1+ zZnSHYUUkomGjAh3PHQc2/JG59pSDOfeF/KV3/vbWtdo1uYmldEx38rH+WBDX/PQ3Qbq M/7vSRUDoL5spck7cjmLlUZ0j2P0XFCAlY/zDAj9GBNME7zb3rF1sfqiU6jNOczVlT7h RjzQ== X-Gm-Message-State: APjAAAWS4g4wSwRrJ2IL/Vlj+IJbUxhT7xVCBps+TwTI6XNzTPxJnjMr fvu1InqsMNeBuXQPveuaenDghJDL X-Google-Smtp-Source: APXvYqwXFdQwrnCRkItvWKX2IOgKa7qdfY8yNC+MyyKM7doWRl9fMd9AkCIW/wAUphjNVfS7XS2bPw== X-Received: by 2002:a05:600c:2185:: with SMTP id e5mr6970504wme.78.1571391694848; Fri, 18 Oct 2019 02:41:34 -0700 (PDT) Received: from kheib-workstation.redhat.com (bzq-79-179-0-252.red.bezeqint.net. [79.179.0.252]) by smtp.gmail.com with ESMTPSA id 126sm2186111wma.48.2019.10.18.02.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 02:41:34 -0700 (PDT) From: Kamal Heib To: linux-rdma@vger.kernel.org Cc: Doug Ledford , Jason Gunthorpe , Lijun Ou , Selvin Xavier , Michal Kalderon , Kamal Heib Subject: [PATCH for-next v3 3/4] RDMA/ocrdma: Remove unsupported modify_port callback Date: Fri, 18 Oct 2019 12:41:14 +0300 Message-Id: <20191018094115.13167-4-kamalheib1@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191018094115.13167-1-kamalheib1@gmail.com> References: <20191018094115.13167-1-kamalheib1@gmail.com> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org There is no need to return always zero for function which is not supported. Fixes: fe2caefcdf58 ("RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMAadapter") Signed-off-by: Kamal Heib --- drivers/infiniband/hw/ocrdma/ocrdma_main.c | 1 - drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 6 ------ drivers/infiniband/hw/ocrdma/ocrdma_verbs.h | 2 -- 3 files changed, 9 deletions(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_main.c b/drivers/infiniband/hw/ocrdma/ocrdma_main.c index c15cfc6cef81..d8c47d24d6d6 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_main.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_main.c @@ -166,7 +166,6 @@ static const struct ib_device_ops ocrdma_dev_ops = { .get_port_immutable = ocrdma_port_immutable, .map_mr_sg = ocrdma_map_mr_sg, .mmap = ocrdma_mmap, - .modify_port = ocrdma_modify_port, .modify_qp = ocrdma_modify_qp, .poll_cq = ocrdma_poll_cq, .post_recv = ocrdma_post_recv, diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c index e8267e590772..e72050de5734 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c @@ -190,12 +190,6 @@ int ocrdma_query_port(struct ib_device *ibdev, return 0; } -int ocrdma_modify_port(struct ib_device *ibdev, u8 port, int mask, - struct ib_port_modify *props) -{ - return 0; -} - static int ocrdma_add_mmap(struct ocrdma_ucontext *uctx, u64 phy_addr, unsigned long len) { diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.h b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.h index 32488da1b752..3a5010881be5 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.h +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.h @@ -54,8 +54,6 @@ int ocrdma_arm_cq(struct ib_cq *, enum ib_cq_notify_flags flags); int ocrdma_query_device(struct ib_device *, struct ib_device_attr *props, struct ib_udata *uhw); int ocrdma_query_port(struct ib_device *, u8 port, struct ib_port_attr *props); -int ocrdma_modify_port(struct ib_device *, u8 port, int mask, - struct ib_port_modify *props); enum rdma_protocol_type ocrdma_query_protocol(struct ib_device *device, u8 port_num); From patchwork Fri Oct 18 09:41:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 11197963 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6668C14ED for ; Fri, 18 Oct 2019 09:41:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46ACD21D7C for ; Fri, 18 Oct 2019 09:41:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oAsxnhlP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2409690AbfJRJli (ORCPT ); Fri, 18 Oct 2019 05:41:38 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:38599 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390553AbfJRJli (ORCPT ); Fri, 18 Oct 2019 05:41:38 -0400 Received: by mail-wm1-f67.google.com with SMTP id 3so5416967wmi.3 for ; Fri, 18 Oct 2019 02:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TycqH6hRWVQcQ82ZcSfaibr4XzfZ5J5iKsyxzuflrxg=; b=oAsxnhlPVGpHefr/4yMqNpIhoKlf2k08+Du8VIFBo4P9CGN3BmM6uYZvfAjS0BSswH i5OPotMzrYoYg84hUt5isPlj4T1tQ/LGiLqUUeFQGJEtKoyhNI9lisar5E54hrY8kxUK va8kpu5HSXM/JvjPiUrDCRF+M16RBunL/Ocbt/89I6K0QZwD1+Tf30zoCK17Oh/OxABk qT0r5yPVhxRIkX5jXeIv6QF3LOVuetjui85P7Mt11kwXTh0kE+0iXhbqaGZuqgefMaHr 0pYUzUaIQoNZ/qosB1lhENBVm2MmRE181CwwJ2kl82LZdByf2SjWOV5RZuiaCkLtBViW JFbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TycqH6hRWVQcQ82ZcSfaibr4XzfZ5J5iKsyxzuflrxg=; b=e0OtRbhXJopBNRol5c1z1S+p5EQZPd7a2+vzlu6MpzbcgKKI6wPke6r9p4hFcfe61J Oj/vzUFGWG2v93Iak2RKXoUpIpu7UiVlH9cKTnThfbvlK8auluFRm3v6xriv0vOTvIJG 7Sohl097yNiw21B9kVhLa9CW3ltH5q0dpTmuLwQUjn09pfNe1qSgtROk4Lgs1px8Sr+N lc8G3a4iWU+9zz9EoMVQWksxzdpsaSCzw9ewxFJ7q/NcwcxstgmivJtqfNcJykfvrcjT fdngFfvlQyVyF/Kg1sBa+t/n1HMmGvDBtzHkp+Mr3jduAh/QNhhrl5pgdgVZm00/ur7i jk6Q== X-Gm-Message-State: APjAAAUj1pyp/9uwv3VGllaTvC/F43G/5ssJn2NDRDaGfLCHSy0GYJMr tBr8YiR5nkiQbGjM+NI/BJLM8P04 X-Google-Smtp-Source: APXvYqzwH1BHvW+dm7MmuJtQokcRtVatCs1JbxdkIgOuX+C/tfqN/SAasTtw5t/8GiFH0FeUqDucKg== X-Received: by 2002:a1c:6389:: with SMTP id x131mr6734186wmb.55.1571391696189; Fri, 18 Oct 2019 02:41:36 -0700 (PDT) Received: from kheib-workstation.redhat.com (bzq-79-179-0-252.red.bezeqint.net. [79.179.0.252]) by smtp.gmail.com with ESMTPSA id 126sm2186111wma.48.2019.10.18.02.41.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 02:41:35 -0700 (PDT) From: Kamal Heib To: linux-rdma@vger.kernel.org Cc: Doug Ledford , Jason Gunthorpe , Lijun Ou , Selvin Xavier , Michal Kalderon , Kamal Heib Subject: [PATCH for-next v3 4/4] RDMA/qedr: Remove unsupported modify_port callback Date: Fri, 18 Oct 2019 12:41:15 +0300 Message-Id: <20191018094115.13167-5-kamalheib1@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191018094115.13167-1-kamalheib1@gmail.com> References: <20191018094115.13167-1-kamalheib1@gmail.com> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org There is no need to return always zero for function which is not supported. Fixes: ac1b36e55a51 ("qedr: Add support for user context verbs") Signed-off-by: Kamal Heib Acked-by: Michal Kalderon  --- drivers/infiniband/hw/qedr/main.c | 1 - drivers/infiniband/hw/qedr/verbs.c | 6 ------ drivers/infiniband/hw/qedr/verbs.h | 2 -- 3 files changed, 9 deletions(-) diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c index 5136b835e1ba..e5f36adb0120 100644 --- a/drivers/infiniband/hw/qedr/main.c +++ b/drivers/infiniband/hw/qedr/main.c @@ -212,7 +212,6 @@ static const struct ib_device_ops qedr_dev_ops = { .get_link_layer = qedr_link_layer, .map_mr_sg = qedr_map_mr_sg, .mmap = qedr_mmap, - .modify_port = qedr_modify_port, .modify_qp = qedr_modify_qp, .modify_srq = qedr_modify_srq, .poll_cq = qedr_poll_cq, diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c index 6f3ce86019b7..fee02ac47f32 100644 --- a/drivers/infiniband/hw/qedr/verbs.c +++ b/drivers/infiniband/hw/qedr/verbs.c @@ -250,12 +250,6 @@ int qedr_query_port(struct ib_device *ibdev, u8 port, struct ib_port_attr *attr) return 0; } -int qedr_modify_port(struct ib_device *ibdev, u8 port, int mask, - struct ib_port_modify *props) -{ - return 0; -} - static int qedr_add_mmap(struct qedr_ucontext *uctx, u64 phy_addr, unsigned long len) { diff --git a/drivers/infiniband/hw/qedr/verbs.h b/drivers/infiniband/hw/qedr/verbs.h index 9aaa90283d6e..d81b81f86f0a 100644 --- a/drivers/infiniband/hw/qedr/verbs.h +++ b/drivers/infiniband/hw/qedr/verbs.h @@ -35,8 +35,6 @@ int qedr_query_device(struct ib_device *ibdev, struct ib_device_attr *attr, struct ib_udata *udata); int qedr_query_port(struct ib_device *, u8 port, struct ib_port_attr *props); -int qedr_modify_port(struct ib_device *, u8 port, int mask, - struct ib_port_modify *props); int qedr_iw_query_gid(struct ib_device *ibdev, u8 port, int index, union ib_gid *gid);