From patchwork Mon Oct 21 16:47:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mihail Atanassov X-Patchwork-Id: 11202749 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E163914ED for ; Mon, 21 Oct 2019 16:47:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C789E20882 for ; Mon, 21 Oct 2019 16:47:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C789E20882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 353B26E183; Mon, 21 Oct 2019 16:47:30 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150079.outbound.protection.outlook.com [40.107.15.79]) by gabe.freedesktop.org (Postfix) with ESMTPS id 742DB6E183 for ; Mon, 21 Oct 2019 16:47:29 +0000 (UTC) Received: from VI1PR08CA0177.eurprd08.prod.outlook.com (2603:10a6:800:d1::31) by DB7PR08MB3900.eurprd08.prod.outlook.com (2603:10a6:10:33::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Mon, 21 Oct 2019 16:47:25 +0000 Received: from VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::209) by VI1PR08CA0177.outlook.office365.com (2603:10a6:800:d1::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.21 via Frontend Transport; Mon, 21 Oct 2019 16:47:25 +0000 Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT028.mail.protection.outlook.com (10.152.18.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.23 via Frontend Transport; Mon, 21 Oct 2019 16:47:24 +0000 Received: ("Tessian outbound 081de437afc7:v33"); Mon, 21 Oct 2019 16:47:22 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b2b627294ba105bc X-CR-MTA-TID: 64aa7808 Received: from e73906f62ecb.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.13.52]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3E7EF3FF-36EC-4CAC-AE51-7A41C97904CD.1; Mon, 21 Oct 2019 16:47:17 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e73906f62ecb.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 21 Oct 2019 16:47:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ispBJWdzjzVJqhSOPVru+/3jwKYXJA9SoxiN32xXG7meIBSobfLGiZwi4WDFb3FankZFWq/2kgc0zh4UWBCDl81FBfQuHPjV4bgMO6huQoBbS38ez+CB9UyX+SmmWpak+HIWTwJ/UtQjErmPZvho5qWUYw26T8X1ZyaMQfbsO28veuiKpWDfTDI2Syb1Nta5pGFHGMG/7ZhwzBk1JVmXNQS8MAYbZ00uKdIKHEnXWd+dXj9lbj5WkyQlM90dVNdbRpnZhaIPDmqUtdXl2ozQCf8JMavSG2GnOaMhEh9iE7Yql9gzb7rNxmQPSSiBgOHBvfI6l1pnJWevopMXFdQGlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2lFNENYY2WBTzISF1cViWb9ogN+++Rr/m8RIJQFVph0=; b=mImirJsU7w+enaAWb6S0mbSG/i2jp19WyCLtZGLTmv1eUAAaXGvN/KkArDwngRHjYXFYFu5M307i2Oi5pblprFRKAlfX2qa3QRF4sFoSV/+u5iZPJaXFHSTh7VO9j5RCGLT5sYv6My5U66OYXQi7Ta6aryNq2/pzJrDKS0yWFi4ylKufrx1/jLo2Cm6aW/wl04lh2QlgWVrbmSqdJCHJMS8hj3jNjUqPh7nxaXsHB8pUxkwFm3MQR4Sj/qET2Cbc19zipGzAEuuwDFyQuLyOOkpgZU/6XI+G/rtI8iaLXfzyo4Xr5kXsZpNehjRW8ueapDQLqKCgUzThZOm0KtdOAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from VI1PR08MB4078.eurprd08.prod.outlook.com (20.178.127.92) by VI1PR08MB3231.eurprd08.prod.outlook.com (52.134.123.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.21; Mon, 21 Oct 2019 16:47:14 +0000 Received: from VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::7d25:d1f2:e3eb:868b]) by VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::7d25:d1f2:e3eb:868b%6]) with mapi id 15.20.2367.022; Mon, 21 Oct 2019 16:47:14 +0000 From: Mihail Atanassov To: "dri-devel@lists.freedesktop.org" Subject: [PATCH 1/5] drm/komeda: Add debugfs node to control error verbosity Thread-Topic: [PATCH 1/5] drm/komeda: Add debugfs node to control error verbosity Thread-Index: AQHViC8xuPMk/kmsbUCVoX21Aq4jyg== Date: Mon, 21 Oct 2019 16:47:14 +0000 Message-ID: <20191021164654.9642-2-mihail.atanassov@arm.com> References: <20191021164654.9642-1-mihail.atanassov@arm.com> In-Reply-To: <20191021164654.9642-1-mihail.atanassov@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.140.106.51] x-clientproxiedby: LO2P123CA0003.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::15) To VI1PR08MB4078.eurprd08.prod.outlook.com (2603:10a6:803:e5::28) x-mailer: git-send-email 2.23.0 Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 580f9f6a-2e21-4467-b0c1-08d75646596c X-MS-Office365-Filtering-HT: Tenant X-MS-TrafficTypeDiagnostic: VI1PR08MB3231:|VI1PR08MB3231:|DB7PR08MB3900: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:1850;OLM:1850; x-forefront-prvs: 0197AFBD92 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(346002)(136003)(376002)(366004)(396003)(189003)(199004)(66476007)(8936002)(2616005)(81166006)(81156014)(386003)(50226002)(44832011)(76176011)(6506007)(2501003)(102836004)(1076003)(25786009)(71200400001)(6486002)(3846002)(6116002)(476003)(11346002)(316002)(71190400001)(256004)(446003)(99286004)(486006)(54906003)(14454004)(26005)(5640700003)(86362001)(305945005)(7736002)(8676002)(6436002)(6916009)(5660300002)(4326008)(6512007)(66446008)(64756008)(66946007)(66556008)(478600001)(36756003)(52116002)(66066001)(2906002)(2351001)(186003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3231; H:VI1PR08MB4078.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2VO7Tqx8aoVFFuhlMZWvq3Ph9VmYVldu8iY4dT0oxoV/uGfZkejSq9tmU8ER9/GMJLDzycAzgZ6PpCk3SsFpRwJStC+XsqlohhX7YpP/fhPZobAfQaWTqU63qzwkR1tN4S6lxWFT1Qu1KrMKc+6cuULSe390LxXKveDNzih230o+FNaHu3sc+2UxYZDgivXELbZkIAkP9hiy6uVCmJx87ZS+ZA4/0uYS3smndEzRlHCNPJ91WOgUAPz1nhi6euLd8Zv6YN3i5aTtcZ75OZXqYFrQsYLIFYxH0oBfEkujsZZHfhfvI7OLZP2I5B9YYY+c3xHPe92vfWZDEr8BcevVqUMbxyxw27nel7y+7YPY2sw7mfOEGorJiCX41H9ZXJFn1Ouo5vlozzRHDWBvOQOXAI6NCVFUgP2KSbFziUyG8SvAbl8HuV3AhFxwe/S+CpS2 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3231 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT028.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(136003)(346002)(376002)(396003)(189003)(199004)(36756003)(2501003)(6512007)(2351001)(486006)(126002)(54906003)(25786009)(50226002)(47776003)(6916009)(316002)(36906005)(2616005)(476003)(6486002)(11346002)(8936002)(446003)(478600001)(336012)(2906002)(26826003)(81156014)(81166006)(8746002)(63350400001)(6506007)(4326008)(22756006)(186003)(7736002)(1076003)(5660300002)(305945005)(14454004)(8676002)(3846002)(50466002)(386003)(66066001)(86362001)(5640700003)(23756003)(70586007)(76176011)(99286004)(70206006)(107886003)(356004)(76130400001)(26005)(6116002)(102836004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB3900; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: f0cabc26-5c2c-4b5e-39ce-08d756465375 NoDisclaimer: True X-Forefront-PRVS: 0197AFBD92 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jgNo5nqHNP8PivbVp+6Kf3FgFwGbHa7jq7uJPxndlb1sdWjHwnhFvvn+eVpy1BprInTzLM6nYCwo8V9mZbZChVUVCztEe/YjDyMxhgefRE1Lvg4wgq+Q7tfesHRP4P1U0Z4qk8eVzPyvTjwyiaI/nKeVcX05pl8w6avxkimo4Lje9gemn7/ySF1XI2zxzGZyFM/3VxT+r5ncttCGR7BzQdJAa5dJl0Io5AOukCibZaaxmfh+4hRy4E7Kns/yS28m9UMAHkJTYyBbFpGk+wdRiNycRGd3PSHeQbdgqcnrXh7Zg3Kx8om9xjLgw6zqTrylIZoCz2TDkgsYMYhiaK8mKdjOnFbnYpeheAse83AtWrojL3DWp4WVvKjxHhbxjmXr/UJDR73VFT4iKfAjd5h4vIDk4zhkQ96dKBMqFTNcd7A= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2019 16:47:24.3098 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 580f9f6a-2e21-4467-b0c1-08d75646596c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3900 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2lFNENYY2WBTzISF1cViWb9ogN+++Rr/m8RIJQFVph0=; b=57mjF/6g6NIB1lvp12k7RLxMNkoR8cgA5B2+EmglsgNj8IBQo8DeQa1su1M29swLU+s4pbsakLtbrvwOpNh2yFUQBPMGsLxVrljcsalrrfbeUXjp1Sa3hqQXqe+HRThK/8uI8oUPEksaPuBHPj0HCWuh1frJWVdGtN6ZiUk8OpI= X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2lFNENYY2WBTzISF1cViWb9ogN+++Rr/m8RIJQFVph0=; b=57mjF/6g6NIB1lvp12k7RLxMNkoR8cgA5B2+EmglsgNj8IBQo8DeQa1su1M29swLU+s4pbsakLtbrvwOpNh2yFUQBPMGsLxVrljcsalrrfbeUXjp1Sa3hqQXqe+HRThK/8uI8oUPEksaPuBHPj0HCWuh1frJWVdGtN6ZiUk8OpI= X-Mailman-Original-Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.freedesktop.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.freedesktop.org; dmarc=none action=none header.from=arm.com; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mihail Atanassov , David Airlie , Liviu Dudau , "linux-kernel@vger.kernel.org" , "james qian wang \(Arm Technology China\)" , "Lowry Li \(Arm Technology China\)" , nd , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Named 'err_verbosity', currently with only 1 active bit in that replicates the existing level - print error events once per flip. Signed-off-by: Mihail Atanassov Reviewed-by: James Qian Wang (Arm Technology China) --- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 4 ++++ drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 14 ++++++++++++-- drivers/gpu/drm/arm/display/komeda/komeda_event.c | 9 +++++++-- drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 2 +- 4 files changed, 24 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c index 937a6d4c4865..82230c0ddec3 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c @@ -58,6 +58,8 @@ static void komeda_debugfs_init(struct komeda_dev *mdev) mdev->debugfs_root = debugfs_create_dir("komeda", NULL); debugfs_create_file("register", 0444, mdev->debugfs_root, mdev, &komeda_register_fops); + debugfs_create_x16("err_verbosity", 0664, mdev->debugfs_root, + &mdev->err_verbosity); } #endif @@ -280,6 +282,8 @@ struct komeda_dev *komeda_dev_create(struct device *dev) goto err_cleanup; } + mdev->err_verbosity = KOMEDA_DEV_PRINT_ERR_EVENTS; + #ifdef CONFIG_DEBUG_FS komeda_debugfs_init(mdev); #endif diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h index 414200233b64..b5bd3d5898ee 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h @@ -202,6 +202,14 @@ struct komeda_dev { /** @debugfs_root: root directory of komeda debugfs */ struct dentry *debugfs_root; + /** + * @err_verbosity: bitmask for how much extra info to print on error + * + * See KOMEDA_DEV_* macros for details. + */ + u16 err_verbosity; + /* Print a single line per error per frame with error events. */ +#define KOMEDA_DEV_PRINT_ERR_EVENTS BIT(0) }; static inline bool @@ -219,9 +227,11 @@ void komeda_dev_destroy(struct komeda_dev *mdev); struct komeda_dev *dev_to_mdev(struct device *dev); #ifdef CONFIG_DRM_KOMEDA_ERROR_PRINT -void komeda_print_events(struct komeda_events *evts); +void komeda_print_events(struct komeda_events *evts, struct drm_device *dev); #else -static inline void komeda_print_events(struct komeda_events *evts) {} +static inline void komeda_print_events(struct komeda_events *evts, + struct drm_device *dev) +{} #endif int komeda_dev_resume(struct komeda_dev *mdev); diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c index a36fb86cc054..575ed4df74ed 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c @@ -107,10 +107,12 @@ static bool is_new_frame(struct komeda_events *a) (KOMEDA_EVENT_FLIP | KOMEDA_EVENT_EOW); } -void komeda_print_events(struct komeda_events *evts) +void komeda_print_events(struct komeda_events *evts, struct drm_device *dev) { - u64 print_evts = KOMEDA_ERR_EVENTS; + u64 print_evts = 0; static bool en_print = true; + struct komeda_dev *mdev = dev->dev_private; + u16 const err_verbosity = mdev->err_verbosity; /* reduce the same msg print, only print the first evt for one frame */ if (evts->global || is_new_frame(evts)) @@ -118,6 +120,9 @@ void komeda_print_events(struct komeda_events *evts) if (!en_print) return; + if (err_verbosity & KOMEDA_DEV_PRINT_ERR_EVENTS) + print_evts |= KOMEDA_ERR_EVENTS; + if ((evts->global | evts->pipes[0] | evts->pipes[1]) & print_evts) { char msg[256]; struct komeda_str str; diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c index d49772de93e0..e30a5b43caa9 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c @@ -48,7 +48,7 @@ static irqreturn_t komeda_kms_irq_handler(int irq, void *data) memset(&evts, 0, sizeof(evts)); status = mdev->funcs->irq_handler(mdev, &evts); - komeda_print_events(&evts); + komeda_print_events(&evts, drm); /* Notify the crtc to handle the events */ for (i = 0; i < kms->n_crtcs; i++) From patchwork Mon Oct 21 16:47:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mihail Atanassov X-Patchwork-Id: 11202751 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5859414ED for ; Mon, 21 Oct 2019 16:47:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B7C320873 for ; Mon, 21 Oct 2019 16:47:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B7C320873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 96BA66E186; Mon, 21 Oct 2019 16:47:33 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03on062a.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe09::62a]) by gabe.freedesktop.org (Postfix) with ESMTPS id B4CEA6E186 for ; Mon, 21 Oct 2019 16:47:31 +0000 (UTC) Received: from AM6PR08CA0046.eurprd08.prod.outlook.com (2603:10a6:20b:c0::34) by VI1PR08MB3086.eurprd08.prod.outlook.com (2603:10a6:803:46::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.24; Mon, 21 Oct 2019 16:47:27 +0000 Received: from AM5EUR03FT052.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::203) by AM6PR08CA0046.outlook.office365.com (2603:10a6:20b:c0::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.21 via Frontend Transport; Mon, 21 Oct 2019 16:47:27 +0000 Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT052.mail.protection.outlook.com (10.152.17.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.23 via Frontend Transport; Mon, 21 Oct 2019 16:47:26 +0000 Received: ("Tessian outbound 3fba803f6da3:v33"); Mon, 21 Oct 2019 16:47:26 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d78833cbaa10bce8 X-CR-MTA-TID: 64aa7808 Received: from eb75fcf24e5c.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.9.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id A2E6B801-A93A-4E86-9164-10572C3BB85B.1; Mon, 21 Oct 2019 16:47:21 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2050.outbound.protection.outlook.com [104.47.9.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eb75fcf24e5c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 21 Oct 2019 16:47:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WSQV9/h+1vdCTNaSAmAUORQjM4SNA/f4gta6Znaorvr2GMCSiESLOjTk8uuo+ZBgfZG9K3XlWScusJsUoP4gcJK/mgOGzouU825OnkgatzYLMi0MdEQyFM8YOwJ0p4Wqz4QN3f0zY+z2+Teq1zXRQPF1qn5K0V0VFgneWaccbLvjfp3IcBoaUzrHK4M8ONrfdd5jQETOYlwqZySm2YXG/zgVJziKBQSQiO33fuvNMbBWGahCsKRgWFmtlAaE6hthJe8Ukp80HV/MsJIcoIBElvihmPfOGj+qFZ0Wx3IOcVb9UM9+G/HG7wwePVrQ53zWXMKu6jOyoXnxPiAFoOvOPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q3V9noWMBRpfRoY49oT6UDQXbQXYaQlVevKp/l4BnO0=; b=UXStiOLzEU+PCSEQTa+8ZrA1SLE60sLUdMDhvIEkx0XWRc+heWOKzt6OjoHhu4oLFr66XUWVbYWge2JqB/jd7PJib78+aqpsi9StqYPg2nRLV8AlS0RMbQD0l5hB0TMKfb1ZQKENzAsLGLd9fIw57F4e7JLBi8DMAFG9GWQdP/t1cpm0sG8eBG010sKLsY0rHvOJgZXnPHWKaF9vEmOP3HER6adXRmmdKoEIy7w9NZLrzccSZL8ISUegJr/5ElwJR/CHMol/Pi4bVDk2YoxdPIgUvLKGqc0aluGpu2JMLWxBgd58OeijxOVLyFlfufcaY3L0pAe8kzPKHpW7stl5mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from VI1PR08MB4078.eurprd08.prod.outlook.com (20.178.127.92) by VI1PR08MB3693.eurprd08.prod.outlook.com (20.178.13.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.18; Mon, 21 Oct 2019 16:47:19 +0000 Received: from VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::7d25:d1f2:e3eb:868b]) by VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::7d25:d1f2:e3eb:868b%6]) with mapi id 15.20.2367.022; Mon, 21 Oct 2019 16:47:19 +0000 From: Mihail Atanassov To: "dri-devel@lists.freedesktop.org" Subject: [PATCH 2/5] drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT Thread-Topic: [PATCH 2/5] drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT Thread-Index: AQHViC80o3rsgkgVM0CzSwA5fpvmTw== Date: Mon, 21 Oct 2019 16:47:19 +0000 Message-ID: <20191021164654.9642-3-mihail.atanassov@arm.com> References: <20191021164654.9642-1-mihail.atanassov@arm.com> In-Reply-To: <20191021164654.9642-1-mihail.atanassov@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.140.106.51] x-clientproxiedby: LO2P123CA0003.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::15) To VI1PR08MB4078.eurprd08.prod.outlook.com (2603:10a6:803:e5::28) x-mailer: git-send-email 2.23.0 Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 13b43450-07fb-4585-522b-08d756465afd X-MS-Office365-Filtering-HT: Tenant X-MS-TrafficTypeDiagnostic: VI1PR08MB3693:|VI1PR08MB3693:|VI1PR08MB3086: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:1051;OLM:1051; x-forefront-prvs: 0197AFBD92 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(366004)(396003)(346002)(39860400002)(199004)(189003)(11346002)(6436002)(316002)(54906003)(256004)(8936002)(6512007)(14444005)(2501003)(71200400001)(5640700003)(71190400001)(50226002)(486006)(2906002)(446003)(6486002)(2616005)(44832011)(5660300002)(8676002)(476003)(305945005)(66066001)(36756003)(86362001)(25786009)(14454004)(186003)(478600001)(6506007)(386003)(102836004)(26005)(4326008)(2351001)(81156014)(1076003)(6116002)(3846002)(66946007)(81166006)(66556008)(52116002)(66476007)(7736002)(64756008)(66446008)(99286004)(76176011)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3693; H:VI1PR08MB4078.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: g3WiCLgsbKoApXfA2UA3urdyAfQO0BPdci21FtjmX9GR0cbejAqeM+sQJhbcqaIewfSyd2OO96h18P9RcsbWct17rcL738xILGF4nFYVEr2zWCAFGGEvWn9eLhWvkbYWW0LmsPt6opAySot00T0juxDLIHXMke2bqakOjznrLL7oMEnGGlwqE47utRv1V18uLvVxLUxK5T7G0IwfHMzGZ4wAu3CnUHOamfWHoa3Jo+Zdi77WvYVxpZlwr06WstOGy2Qo/Hccg620naUQRxhsv0DQD8zBTwIEy9dTsC7D/LFRa1lmEyuVYnRhpzZhWHWaagdjkgShuRu773xd85JdcXCkuFnpOkEFWPxAk2hSy46gZlEZiciQI57EN6Gpx5EGULUN8/woDMJHMjhj/Xrat2MJKTYqGoOWn3kGEmb7hK9RkAAmq1Wys71BZQdo21K7 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3693 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT052.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(346002)(396003)(39860400002)(199004)(189003)(6486002)(6116002)(3846002)(14454004)(356004)(478600001)(26826003)(76130400001)(70206006)(2501003)(70586007)(54906003)(6916009)(5640700003)(316002)(36906005)(25786009)(2351001)(186003)(2616005)(476003)(126002)(486006)(336012)(63350400001)(11346002)(446003)(6506007)(86362001)(23756003)(107886003)(14444005)(2906002)(4326008)(7736002)(6512007)(99286004)(102836004)(305945005)(26005)(76176011)(386003)(8676002)(50466002)(81166006)(8746002)(8936002)(1076003)(81156014)(50226002)(22756006)(47776003)(5660300002)(36756003)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3086; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 7fd0f2a2-b54f-4f90-6dbb-08d75646566f NoDisclaimer: True X-Forefront-PRVS: 0197AFBD92 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RJqYo2GdydQ9hG/egQojtX1sRqO0NPeQAdttKsdHVNxooAGzbZaxE4Iwjvs0/iO++44MV+qMoCNyuf+p4Uu8agVMcDwgsTzO/cu5MyILX1RwXNM/g+96HnFMvV7yEO04HqABwlp4uAbodQVAMTHcv7cbBjMFOrhMhgoCVBkuAahiTF/fpSF/7Jsffwv7LBBpsRzijjcx+wTQDjfiOsMaTHFGlhP/5jLgl7ZP+tHcfvB5AIvcjtQzleRm6cN9LRhpQpHX2KMwqsSMNC2Ysu+rULUyvoi4Ry6/VvLVdnRPX2C2/CBKAT5wlTUrIfB0MO+33ThS9kafFFl6Ga8S/kPkE/aTJix/XHUNSJohwhqwH5RHG36fl/n6OB4qqiuvGF9kq9Qr/bGSenozxkOGPoXBfGFMiYzpkfIBpxgJjtPJTLcBgnYme7UCtb4a37yVLTUk X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2019 16:47:26.9904 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 13b43450-07fb-4585-522b-08d756465afd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3086 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q3V9noWMBRpfRoY49oT6UDQXbQXYaQlVevKp/l4BnO0=; b=YFPZF0bEjsvnl8jGivdvohf2ST2CFTc8CeOWpirnDyQMIcHOuQBArHvCNmL2/Mb3Qv5Rqb8IsUG1s7bjZJZ9l5vjcAr8R/pRdmoTnrXd9updP3JNx42i7n2pHb9varxHiLokq6g7rh+jJqTCoog8Q2RH/G9xYGqnch2zTYmvSZA= X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q3V9noWMBRpfRoY49oT6UDQXbQXYaQlVevKp/l4BnO0=; b=YFPZF0bEjsvnl8jGivdvohf2ST2CFTc8CeOWpirnDyQMIcHOuQBArHvCNmL2/Mb3Qv5Rqb8IsUG1s7bjZJZ9l5vjcAr8R/pRdmoTnrXd9updP3JNx42i7n2pHb9varxHiLokq6g7rh+jJqTCoog8Q2RH/G9xYGqnch2zTYmvSZA= X-Mailman-Original-Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.freedesktop.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.freedesktop.org; dmarc=none action=none header.from=arm.com; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mihail Atanassov , David Airlie , Liviu Dudau , "linux-kernel@vger.kernel.org" , "james qian wang \(Arm Technology China\)" , "Lowry Li \(Arm Technology China\)" , nd , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Now that there's a debugfs node to control the same, remove the config option. Signed-off-by: Mihail Atanassov Reviewed-by: James Qian Wang (Arm Technology China) --- drivers/gpu/drm/arm/display/Kconfig | 6 ------ drivers/gpu/drm/arm/display/komeda/Makefile | 5 ++--- drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 6 ------ 3 files changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/arm/display/Kconfig b/drivers/gpu/drm/arm/display/Kconfig index e87ff8623076..cec0639e3aa1 100644 --- a/drivers/gpu/drm/arm/display/Kconfig +++ b/drivers/gpu/drm/arm/display/Kconfig @@ -12,9 +12,3 @@ config DRM_KOMEDA Processor driver. It supports the D71 variants of the hardware. If compiled as a module it will be called komeda. - -config DRM_KOMEDA_ERROR_PRINT - bool "Enable komeda error print" - depends on DRM_KOMEDA - help - Choose this option to enable error printing. diff --git a/drivers/gpu/drm/arm/display/komeda/Makefile b/drivers/gpu/drm/arm/display/komeda/Makefile index f095a1c68ac7..1931a7fa1a14 100644 --- a/drivers/gpu/drm/arm/display/komeda/Makefile +++ b/drivers/gpu/drm/arm/display/komeda/Makefile @@ -16,12 +16,11 @@ komeda-y := \ komeda_crtc.o \ komeda_plane.o \ komeda_wb_connector.o \ - komeda_private_obj.o + komeda_private_obj.o \ + komeda_event.o komeda-y += \ d71/d71_dev.o \ d71/d71_component.o -komeda-$(CONFIG_DRM_KOMEDA_ERROR_PRINT) += komeda_event.o - obj-$(CONFIG_DRM_KOMEDA) += komeda.o diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h index b5bd3d5898ee..831c375180f8 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h @@ -226,13 +226,7 @@ void komeda_dev_destroy(struct komeda_dev *mdev); struct komeda_dev *dev_to_mdev(struct device *dev); -#ifdef CONFIG_DRM_KOMEDA_ERROR_PRINT void komeda_print_events(struct komeda_events *evts, struct drm_device *dev); -#else -static inline void komeda_print_events(struct komeda_events *evts, - struct drm_device *dev) -{} -#endif int komeda_dev_resume(struct komeda_dev *mdev); int komeda_dev_suspend(struct komeda_dev *mdev); From patchwork Mon Oct 21 16:47:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mihail Atanassov X-Patchwork-Id: 11202755 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 75E3613B1 for ; Mon, 21 Oct 2019 16:47:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D13320873 for ; Mon, 21 Oct 2019 16:47:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D13320873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 741FE6E18E; Mon, 21 Oct 2019 16:47:49 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03on060d.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0a::60d]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC4BA6E187 for ; Mon, 21 Oct 2019 16:47:44 +0000 (UTC) Received: from VI1PR08CA0150.eurprd08.prod.outlook.com (2603:10a6:800:d5::28) by AM5PR0801MB1987.eurprd08.prod.outlook.com (2603:10a6:203:47::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.19; Mon, 21 Oct 2019 16:47:40 +0000 Received: from DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::202) by VI1PR08CA0150.outlook.office365.com (2603:10a6:800:d5::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2367.21 via Frontend Transport; Mon, 21 Oct 2019 16:47:40 +0000 Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT015.mail.protection.outlook.com (10.152.20.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2305.15 via Frontend Transport; Mon, 21 Oct 2019 16:47:39 +0000 Received: ("Tessian outbound 0cf06bf5c60e:v33"); Mon, 21 Oct 2019 16:47:33 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 89bd12e1453a1bd7 X-CR-MTA-TID: 64aa7808 Received: from 26dbf25f3ac7.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.9.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9AA667B3-BC90-4D48-A6C9-F3A33A3B69B5.1; Mon, 21 Oct 2019 16:47:27 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2050.outbound.protection.outlook.com [104.47.9.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 26dbf25f3ac7.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 21 Oct 2019 16:47:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FpLw7VCKGQF0I9Wxbi3OUepmlFpgjF4OUW++aSWsnYNeWr726at2Fk5fvYRikwgVgbye95LxX6JWjZFIcbRF2LUZ/PXLPdgUmKGKcJEweyY1O8VV3k0XQjEXykL51egjLwykskbXJ+9s0sRo1+g2muX6pajGB6RnxCdw2mwXDRhWaedxjKO2Sjz+gUWzQWNEDlqbVW0p+swpiWqIdXaBe4t05cUXtc2qM/+9+MusX1G5dzafmRzH8YWoxxlAB6zJZw7T3tt4tlPYpgbGHamgXPsnSEntiAN5wQXmd1NhfcsoD/bS48xxdodL5d0lDiWLCNjyR1wRDdY+LyefnehGmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e2yjDsqDr+TeKkIanekjVyEis3xaMX3qJidSclXgt24=; b=b0dLeeo3FYwc4fpZyiBOrhwv02z2EuvlGoRXyQ77cLwLwc8DNktN3J/GiefLEFIFPUxzx9xnelQHFlt0ZbL85GfYOjBQWhXFz2tGgdy91JSZlrCE2Ua6IAYcG0cLH3idWBcsHr48+qaiIhBX+xUjKzQzSmCIfKifwi7YFS9gGFq0jEmfjc6+r/qsgXUTdy3eAcT+ZrfIEdwQ3gUtvjbo1fb1balEPW+rSWctsc5bBH+OkGMSGrdtS2blZB3t+Gy5MweYJ0iwbYkXjrX0F6y/26ts9N6yC2L1SalIDGj6u3nR52yxCCdJ5RY93bATySz1DBV+4Lm004XBr4kC6fne1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from VI1PR08MB4078.eurprd08.prod.outlook.com (20.178.127.92) by VI1PR08MB3693.eurprd08.prod.outlook.com (20.178.13.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.18; Mon, 21 Oct 2019 16:47:24 +0000 Received: from VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::7d25:d1f2:e3eb:868b]) by VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::7d25:d1f2:e3eb:868b%6]) with mapi id 15.20.2367.022; Mon, 21 Oct 2019 16:47:24 +0000 From: Mihail Atanassov To: "dri-devel@lists.freedesktop.org" Subject: [PATCH 3/5] drm/komeda: Optionally dump DRM state on interrupts Thread-Topic: [PATCH 3/5] drm/komeda: Optionally dump DRM state on interrupts Thread-Index: AQHViC82sr9B7tdJG0SX6V/x8vl4Ug== Date: Mon, 21 Oct 2019 16:47:24 +0000 Message-ID: <20191021164654.9642-4-mihail.atanassov@arm.com> References: <20191021164654.9642-1-mihail.atanassov@arm.com> In-Reply-To: <20191021164654.9642-1-mihail.atanassov@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.140.106.51] x-clientproxiedby: LO2P123CA0003.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::15) To VI1PR08MB4078.eurprd08.prod.outlook.com (2603:10a6:803:e5::28) x-mailer: git-send-email 2.23.0 Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: c96deefc-311b-4ce8-29f5-08d756466237 X-MS-Office365-Filtering-HT: Tenant X-MS-TrafficTypeDiagnostic: VI1PR08MB3693:|VI1PR08MB3693:|AM5PR0801MB1987: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; x-forefront-prvs: 0197AFBD92 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(366004)(396003)(346002)(39860400002)(199004)(189003)(11346002)(6436002)(316002)(54906003)(256004)(8936002)(6512007)(14444005)(2501003)(71200400001)(5640700003)(71190400001)(50226002)(486006)(2906002)(446003)(6486002)(2616005)(44832011)(5660300002)(8676002)(476003)(305945005)(66066001)(36756003)(86362001)(25786009)(14454004)(186003)(478600001)(6506007)(386003)(102836004)(26005)(4326008)(2351001)(81156014)(1076003)(6116002)(3846002)(66946007)(81166006)(66556008)(52116002)(66476007)(7736002)(64756008)(66446008)(99286004)(76176011)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3693; H:VI1PR08MB4078.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fI5DFA0OaEvwUGRfBjUPpzYFwp6+qufH86B3IzpDme/hNcrwas42rl1RYOzrMJPeIZ2q6f8U3D1D8ndhzgGxG8dLQWv3tNPFRM5aPCF+97FZ53Pv/ZJovdyEHv4T7jieGQKUwp92S/AHF3ySlxHg5iduTFhpjRKhz6jexhe+dLSGsg98p9R17dPnrbEtXOB1NoRZih9H4MuVBmrnDAtsfP7YCrFT5eYb+okQRDGJVuJs3OV24WiliUsQ+aTppItNJCUD82IxN0mNCPTvybzSxrfXvvgn25NFZgC+XZBRUt67ouRZJeEPqsHCIz72POzorwIxPRwmsQCAUB+ySdaq07ySxkmttrXa5lNe8vTf2eaQbhZt+TCsCrk8apbgHqlEGlb+1AyYPkbJbkz5NQ3Spiq3Xc+GTcv0exOBHgXc3U+mHPgsDNMsHWJA+r6bm4zw MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3693 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(376002)(346002)(396003)(199004)(189003)(99286004)(6916009)(22756006)(14444005)(356004)(25786009)(76176011)(102836004)(386003)(6506007)(14454004)(2351001)(5660300002)(66066001)(6512007)(1076003)(47776003)(5640700003)(63350400001)(336012)(305945005)(7736002)(486006)(446003)(126002)(476003)(4326008)(26005)(2616005)(11346002)(26826003)(8746002)(6486002)(36756003)(70586007)(76130400001)(478600001)(2906002)(81156014)(186003)(81166006)(8676002)(3846002)(54906003)(6116002)(70206006)(2501003)(8936002)(86362001)(50466002)(107886003)(50226002)(23756003)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0801MB1987; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: b784c45c-298f-4e8e-90b0-08d75646595f NoDisclaimer: True X-Forefront-PRVS: 0197AFBD92 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XEv93rUfbNutz8Yv3V1JnWYqCbTSV281tSUnonYMsmXnDlr7P6OGQa8u4yIgIKmKFvNQn11S/5peCFNe0nZYDiOdlu3KbZuj4mQcTIaz1B6liDp8bxmGOF2E5O2ljsV/9DeUP7calPPvXx3SsQAmCWQhwg6CLHjOyaHCKKrouRIRwE6+gkjMOlamx3H8QN9jwuhG94V/UNYWcFjtV3xcTNEWZYeOdNPEc2HsTN51dXPc7swegRret8xGNEBN06zRAfuhfrIf59qKZ4arfJl812Hr6x+ucs4cA8cfkbczoeZfGZLjDvBuO3qKULsQv0YozPpcGT4DMEQIfprtFJMG+fTbnPZDx9QeRuEo9C41fxAnCV4YWzKmulnnvcdMZ/7tN7ECJ9bkoVLtG8RQsbCXcdao4ABha0FsD3i88wAQOE+WfMu+eyUBfYex0AjZkeLO X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2019 16:47:39.1175 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c96deefc-311b-4ce8-29f5-08d756466237 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1987 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e2yjDsqDr+TeKkIanekjVyEis3xaMX3qJidSclXgt24=; b=QqpqHXPcUBjttmeWlYY57e05gCm61hv5Lljdi6SfJw6DQJnqtdexMLY7YSyTYnpNq7fvfWKTKffp9idrN843Pmb+Bi/G7bnEh7TcOIT4XhNgnnAV6MGCul7upB2JUm3fyaW2qZZ3gf3hWpSoMODzyCUe6H6D6d9SzhvXygoMO7s= X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e2yjDsqDr+TeKkIanekjVyEis3xaMX3qJidSclXgt24=; b=QqpqHXPcUBjttmeWlYY57e05gCm61hv5Lljdi6SfJw6DQJnqtdexMLY7YSyTYnpNq7fvfWKTKffp9idrN843Pmb+Bi/G7bnEh7TcOIT4XhNgnnAV6MGCul7upB2JUm3fyaW2qZZ3gf3hWpSoMODzyCUe6H6D6d9SzhvXygoMO7s= X-Mailman-Original-Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.freedesktop.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.freedesktop.org; dmarc=none action=none header.from=arm.com; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mihail Atanassov , David Airlie , Liviu Dudau , "linux-kernel@vger.kernel.org" , "james qian wang \(Arm Technology China\)" , "Lowry Li \(Arm Technology China\)" , nd , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" It's potentially useful information when diagnosing error/warn IRQs, so dump it to dmesg with a drm_info_printer. Hide this extra debug dumping behind another komeda_dev->err_verbosity bit. Note that there's not much sense in dumping it for INFO events, since the VSYNC event will swamp the log. Signed-off-by: Mihail Atanassov Reviewed-by: James Qian Wang (Arm Technology China) --- drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 5 ++++- drivers/gpu/drm/arm/display/komeda/komeda_event.c | 8 +++++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h index 831c375180f8..4809000c1efb 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h @@ -205,11 +205,14 @@ struct komeda_dev { /** * @err_verbosity: bitmask for how much extra info to print on error * - * See KOMEDA_DEV_* macros for details. + * See KOMEDA_DEV_* macros for details. Low byte contains the debug + * level categories, the high byte contains extra debug options. */ u16 err_verbosity; /* Print a single line per error per frame with error events. */ #define KOMEDA_DEV_PRINT_ERR_EVENTS BIT(0) + /* Dump DRM state on an error or warning event. */ +#define KOMEDA_DEV_PRINT_DUMP_STATE_ON_EVENT BIT(8) }; static inline bool diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c index 575ed4df74ed..5da61e7d75d5 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c @@ -4,6 +4,7 @@ * Author: James.Qian.Wang * */ +#include #include #include "komeda_dev.h" @@ -113,6 +114,7 @@ void komeda_print_events(struct komeda_events *evts, struct drm_device *dev) static bool en_print = true; struct komeda_dev *mdev = dev->dev_private; u16 const err_verbosity = mdev->err_verbosity; + u64 evts_mask = evts->global | evts->pipes[0] | evts->pipes[1]; /* reduce the same msg print, only print the first evt for one frame */ if (evts->global || is_new_frame(evts)) @@ -123,9 +125,10 @@ void komeda_print_events(struct komeda_events *evts, struct drm_device *dev) if (err_verbosity & KOMEDA_DEV_PRINT_ERR_EVENTS) print_evts |= KOMEDA_ERR_EVENTS; - if ((evts->global | evts->pipes[0] | evts->pipes[1]) & print_evts) { + if (evts_mask & print_evts) { char msg[256]; struct komeda_str str; + struct drm_printer p = drm_info_printer(dev->dev); str.str = msg; str.sz = sizeof(msg); @@ -139,6 +142,9 @@ void komeda_print_events(struct komeda_events *evts, struct drm_device *dev) evt_str(&str, evts->pipes[1]); DRM_ERROR("err detect: %s\n", msg); + if ((err_verbosity & KOMEDA_DEV_PRINT_DUMP_STATE_ON_EVENT) + && (evts_mask & (KOMEDA_ERR_EVENTS | KOMEDA_WARN_EVENTS))) + drm_state_dump(dev, &p); en_print = false; } From patchwork Mon Oct 21 16:47:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mihail Atanassov X-Patchwork-Id: 11202753 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 516B213B1 for ; Mon, 21 Oct 2019 16:47:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3882220873 for ; Mon, 21 Oct 2019 16:47:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3882220873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 56CF56E187; Mon, 21 Oct 2019 16:47:46 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60057.outbound.protection.outlook.com [40.107.6.57]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1019C6E188 for ; Mon, 21 Oct 2019 16:47:45 +0000 (UTC) Received: from DB6PR0802CA0030.eurprd08.prod.outlook.com (2603:10a6:4:a3::16) by DB6PR0801MB1911.eurprd08.prod.outlook.com (2603:10a6:4:74::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Mon, 21 Oct 2019 16:47:40 +0000 Received: from VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::209) by DB6PR0802CA0030.outlook.office365.com (2603:10a6:4:a3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.21 via Frontend Transport; Mon, 21 Oct 2019 16:47:40 +0000 Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT005.mail.protection.outlook.com (10.152.18.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.23 via Frontend Transport; Mon, 21 Oct 2019 16:47:38 +0000 Received: ("Tessian outbound 6481c7fa5a3c:v33"); Mon, 21 Oct 2019 16:47:38 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 668dfe31dcc6a0fb X-CR-MTA-TID: 64aa7808 Received: from 8df1632baa3c.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.9.51]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9DF02324-B19A-406F-9504-5165503D2FBD.1; Mon, 21 Oct 2019 16:47:33 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2051.outbound.protection.outlook.com [104.47.9.51]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8df1632baa3c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 21 Oct 2019 16:47:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FAwBiQGAxZ5uhq8tEv//sBZ5qstEfYRTrBEsPs5Rsqo4bX50xKKXhS6f06m00GjVrlL1sL21blbEJIfzt7Eem0CKclrII7TrFgj7UtiCXj7SC/q1bgASdDDCdv9NUS8a3bo1gQcHqHqHpVTYkcjkVbrv+GRqC+AodJACzemkiZGxcpefFM6IKO8LwAxi13UgJ5pE91A+a4XBonvhUVx6zmZlO9uU+RlSKjVz5yNd7HkUEJBuA+lmNXiGRq0fOqYlGEPL8x8TY2Ld3t7FSbyLMSmm7TXlEPJ5gKD0ep1J1XqmpS0axwVUG+Ov6SlAJSee677W3tByeK8z4RlGzsZSbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zWsSnQvJtQ+r5qSKgtU+rOw+cTaU+Npr3oF1zqZ62NU=; b=NBxvyPYsWVZhXLBeK1QWSZCWfi8qfUIC5t6BVMHO0slTVsZ2x0OoTh4nnLct0IJi9gJZsIDsyFJOs5+P4m59Eb4mgtIMQpBa/O3odWCdf6zNCcjvh/mTry1RP+zU9QyTStLiBvCyXCCDVRUGD1wmIUgxL7t+HQXp7TFXEfn4GB7MQa/zbYOt42NQCUF/EIS94GmkoqH0CSGcPashx7nmK/HVXAzCehZyFXB2ZktWDeMkZpxN7Ylj5krlhmcUJOWBjHh7wCSzRIIrh4UjSnvnIuqEA6MQ19ZKq/etYpV/90q4wV047wLj4FW2K3viknZ8sJ+rpYqUV7rqWXyiAWcO6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from VI1PR08MB4078.eurprd08.prod.outlook.com (20.178.127.92) by VI1PR08MB3693.eurprd08.prod.outlook.com (20.178.13.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.18; Mon, 21 Oct 2019 16:47:29 +0000 Received: from VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::7d25:d1f2:e3eb:868b]) by VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::7d25:d1f2:e3eb:868b%6]) with mapi id 15.20.2367.022; Mon, 21 Oct 2019 16:47:29 +0000 From: Mihail Atanassov To: "dri-devel@lists.freedesktop.org" Subject: [PATCH 4/5] drm/komeda: Add option to print WARN- and INFO-level IRQ events Thread-Topic: [PATCH 4/5] drm/komeda: Add option to print WARN- and INFO-level IRQ events Thread-Index: AQHViC86lQh6BhWPhkSdWiuXUeWqOw== Date: Mon, 21 Oct 2019 16:47:29 +0000 Message-ID: <20191021164654.9642-5-mihail.atanassov@arm.com> References: <20191021164654.9642-1-mihail.atanassov@arm.com> In-Reply-To: <20191021164654.9642-1-mihail.atanassov@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.140.106.51] x-clientproxiedby: LO2P123CA0003.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::15) To VI1PR08MB4078.eurprd08.prod.outlook.com (2603:10a6:803:e5::28) x-mailer: git-send-email 2.23.0 Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 92c20dda-129d-4062-cce5-08d7564661df X-MS-Office365-Filtering-HT: Tenant X-MS-TrafficTypeDiagnostic: VI1PR08MB3693:|VI1PR08MB3693:|DB6PR0801MB1911: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:1388;OLM:1388; x-forefront-prvs: 0197AFBD92 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(366004)(396003)(346002)(39860400002)(199004)(189003)(11346002)(6436002)(316002)(54906003)(256004)(8936002)(6512007)(14444005)(2501003)(71200400001)(5640700003)(71190400001)(50226002)(486006)(2906002)(446003)(6486002)(2616005)(44832011)(5660300002)(8676002)(476003)(305945005)(66066001)(36756003)(86362001)(25786009)(14454004)(186003)(478600001)(6506007)(386003)(102836004)(26005)(4326008)(2351001)(81156014)(1076003)(6116002)(3846002)(66946007)(81166006)(66556008)(52116002)(66476007)(7736002)(64756008)(66446008)(99286004)(76176011)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3693; H:VI1PR08MB4078.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /LkEXHfkUUbTUyBF3hDHpD6g+u1DEcGGRcjkX8nxTcUdGVb6GzRz1Uz+KWcauw5IpcQcyPTq8b/h20tGOIabjeTx/h5UBEBJ8cGkm+cXYf2E7ZP3Akv92wLaZ6VXeKyR5nkKxRs69AzM8jy0K0xAl+gTNJzvLEkgNW7h89zu4eYWn2AF7AFNVE5bXfhdoASWmhCr7o+Eg66mPipCmO3nn+b0Kl35g/CLAJUGUUAv892Q9I07bbEjYICJlxetfAkp/qKU4LaHFzzNxrHhNyssyN/vEH4Ux2LjobI2C6pjp8rBgue0vwzX0enzs40MFjXESMVtQlfTfHa0xWR9wZYFgZkBC5wLRpewJAhWoHVn7Bp4eGhUJQpbNck4JFXmwXiWpdVHrd3Cj/k797ckNptbZCUFTm4+Ie23TquO0oHqkZ1NIaEwlXSWNqd/hPteZ2g2 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3693 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(346002)(39860400002)(396003)(136003)(376002)(189003)(199004)(11346002)(7736002)(336012)(1076003)(8936002)(50226002)(26826003)(8746002)(478600001)(5660300002)(316002)(446003)(2906002)(6916009)(50466002)(476003)(2616005)(305945005)(3846002)(14444005)(25786009)(6116002)(63350400001)(486006)(126002)(86362001)(76176011)(5640700003)(23756003)(36906005)(70206006)(2501003)(99286004)(22756006)(66066001)(54906003)(6486002)(36756003)(6512007)(70586007)(76130400001)(14454004)(356004)(26005)(6506007)(81166006)(81156014)(186003)(2351001)(107886003)(102836004)(386003)(47776003)(8676002)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0801MB1911; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: f3670ba4-12a0-40d4-70a7-08d756465c6d NoDisclaimer: True X-Forefront-PRVS: 0197AFBD92 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5Z1In7kzOUN0krgaWglYq3Rg0BJiZcP/YeQt3Iv3YekPKGsBitC67yskOPrvsdiaowC9wT3Gv0nPNMWZoeM/FI7EEGp0/sq1pA7VTmXOvU/FfD5zgdnyEDyg5Ld9opUsbj1mRBJ8v1vYHYVs9DlspdPl5SZdWfGW1msHkcGMTORiFKsMn/F5Wo178OxOlPTRwS2ZFzlAcAYVP0A2oe8FOSQ8Jd1WvWA9CZY6wH+CZ0KMsj1K8ZwUl41eaXicD243WVjDJ5elaTqxHDyDl1ChyIYN8W4MRSdCZHfRVXR0bar32xphakZ/vIXBRVdczbgfdoJ9HcuPx0qiNa4YWT8CkouwP5I0/Nbas8FFstcJLHBu/K+FqocxBO7T/evxX1IZsBQan5K57SzFHUsM4XhjstdZW15n3X5G3DjqicDmh0edK8BqcR0mdWDWEsUFiXxg X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2019 16:47:38.4870 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 92c20dda-129d-4062-cce5-08d7564661df X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1911 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zWsSnQvJtQ+r5qSKgtU+rOw+cTaU+Npr3oF1zqZ62NU=; b=lCZpulkXKD+5MMk203KPXYuhPv0BhlFnibjNr+SqNT59Xl0kq1R/i70cvVPHvtlBJTfIWlG20SCp9pGrdafoUzKLOUHAFnUlLfPvlgOAd7nmSUVPmJpAMVHcC6DYFP6mWhtjd3YXYtYfphvCO2Lc92AtKmXJXsRRMLjAdJt1Hug= X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zWsSnQvJtQ+r5qSKgtU+rOw+cTaU+Npr3oF1zqZ62NU=; b=lCZpulkXKD+5MMk203KPXYuhPv0BhlFnibjNr+SqNT59Xl0kq1R/i70cvVPHvtlBJTfIWlG20SCp9pGrdafoUzKLOUHAFnUlLfPvlgOAd7nmSUVPmJpAMVHcC6DYFP6mWhtjd3YXYtYfphvCO2Lc92AtKmXJXsRRMLjAdJt1Hug= X-Mailman-Original-Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.freedesktop.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.freedesktop.org; dmarc=none action=none header.from=arm.com; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mihail Atanassov , David Airlie , Liviu Dudau , "linux-kernel@vger.kernel.org" , "james qian wang \(Arm Technology China\)" , "Lowry Li \(Arm Technology China\)" , nd , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Extra detail (normally off) almost never hurts. Signed-off-by: Mihail Atanassov Reviewed-by: James Qian Wang (Arm Technology China) --- drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 11 +++++++++++ drivers/gpu/drm/arm/display/komeda/komeda_event.c | 4 ++++ 2 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h index 4809000c1efb..d9fc9c48859a 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h @@ -51,6 +51,13 @@ #define KOMEDA_WARN_EVENTS KOMEDA_ERR_CSCE +#define KOMEDA_INFO_EVENTS ({0 \ + | KOMEDA_EVENT_VSYNC \ + | KOMEDA_EVENT_FLIP \ + | KOMEDA_EVENT_EOW \ + | KOMEDA_EVENT_MODE \ + }) + /* malidp device id */ enum { MALI_D71 = 0, @@ -211,6 +218,10 @@ struct komeda_dev { u16 err_verbosity; /* Print a single line per error per frame with error events. */ #define KOMEDA_DEV_PRINT_ERR_EVENTS BIT(0) + /* Print a single line per warning per frame with error events. */ +#define KOMEDA_DEV_PRINT_WARN_EVENTS BIT(1) + /* Print a single line per info event per frame with error events. */ +#define KOMEDA_DEV_PRINT_INFO_EVENTS BIT(2) /* Dump DRM state on an error or warning event. */ #define KOMEDA_DEV_PRINT_DUMP_STATE_ON_EVENT BIT(8) }; diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c index 5da61e7d75d5..bf88463bb4d9 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c @@ -124,6 +124,10 @@ void komeda_print_events(struct komeda_events *evts, struct drm_device *dev) if (err_verbosity & KOMEDA_DEV_PRINT_ERR_EVENTS) print_evts |= KOMEDA_ERR_EVENTS; + if (err_verbosity & KOMEDA_DEV_PRINT_WARN_EVENTS) + print_evts |= KOMEDA_WARN_EVENTS; + if (err_verbosity & KOMEDA_DEV_PRINT_INFO_EVENTS) + print_evts |= KOMEDA_INFO_EVENTS; if (evts_mask & print_evts) { char msg[256]; From patchwork Mon Oct 21 16:47:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mihail Atanassov X-Patchwork-Id: 11202757 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5584914ED for ; Mon, 21 Oct 2019 16:47:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C81120873 for ; Mon, 21 Oct 2019 16:47:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C81120873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 63D996E18F; Mon, 21 Oct 2019 16:47:54 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80045.outbound.protection.outlook.com [40.107.8.45]) by gabe.freedesktop.org (Postfix) with ESMTPS id 078E46E188 for ; Mon, 21 Oct 2019 16:47:48 +0000 (UTC) Received: from VI1PR08CA0259.eurprd08.prod.outlook.com (2603:10a6:803:dc::32) by AM6PR08MB4487.eurprd08.prod.outlook.com (2603:10a6:20b:74::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.20; Mon, 21 Oct 2019 16:47:44 +0000 Received: from DB5EUR03FT033.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::202) by VI1PR08CA0259.outlook.office365.com (2603:10a6:803:dc::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2367.21 via Frontend Transport; Mon, 21 Oct 2019 16:47:43 +0000 Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT033.mail.protection.outlook.com (10.152.20.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2305.15 via Frontend Transport; Mon, 21 Oct 2019 16:47:42 +0000 Received: ("Tessian outbound 3fba803f6da3:v33"); Mon, 21 Oct 2019 16:47:42 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e9a25194a78a757f X-CR-MTA-TID: 64aa7808 Received: from 0883c3b38210.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.9.54]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id CD9AD2BC-D4F5-4AA8-AE85-95C16E356AB9.1; Mon, 21 Oct 2019 16:47:37 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2054.outbound.protection.outlook.com [104.47.9.54]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0883c3b38210.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 21 Oct 2019 16:47:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dh8A34tH++BdlsbHp71S4ooIsjM7Do4unGUK9U3vEFHYTp0J/6DF4u/q758XpDRZN9s7QfIkgjwXJhwbjR1HCiDLDzw9vmFhisBSNq5OSBVUl+La8cvwTA/1T4zOPVbHcEBQ0lEi/PCQp5l8gCm2EAglfqWMrLWvEHFN4px5e9/2Crt5RcBi02oTmXVfX8d35AFWvXpiYqJ2LFbs3VUcKzKNJgXzaGoxnw9FSOxuIIy8aiDFPevNQS0dJyMWzPUi0wpgjKsEGKN1rrg7+wSV6qhAu7ySCFqxX6HZZycNwczrVtO5XSHDZLZuS7JdyZGskdgcyrfRnyPPn+TZBDWZEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LqjsYGtito0owHXQyV4kjHNN6CmmoCoNhwj27nXP6vE=; b=jc/ujFe27o8obaY6EgiXW/6aO6XOpchsBej1qrWEp5ZwODa8cYQOhkYfotW8KDiJiLOnH139qTQb6FSTDeghCqG/TunGYM2hoVy+fOJ56I/Rqv8jFEW5USeJ1oly0bPdPUSxBP6LWiUNlAya0jkMJhdP2CEFs1jLihYE03ghRai+mjBrUb6xZ9FD9QC8yOB+GjVop/bdQ+icuwK0uAqVhst5wv1z5ES5Te78j5pDY82h1TywOKX3+gbPMEeCC2u5jCm5sIH8u2cMwgS7kEce/iimdZDupx0aXACn3HzHohmf9+UzQeeGEFvLIrWsNsMrm+0cbiNsXOUdDd7D6+Q/4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from VI1PR08MB4078.eurprd08.prod.outlook.com (20.178.127.92) by VI1PR08MB3693.eurprd08.prod.outlook.com (20.178.13.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.18; Mon, 21 Oct 2019 16:47:35 +0000 Received: from VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::7d25:d1f2:e3eb:868b]) by VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::7d25:d1f2:e3eb:868b%6]) with mapi id 15.20.2367.022; Mon, 21 Oct 2019 16:47:35 +0000 From: Mihail Atanassov To: "dri-devel@lists.freedesktop.org" Subject: [PATCH 5/5] drm/komeda: add rate limiting disable to err_verbosity Thread-Topic: [PATCH 5/5] drm/komeda: add rate limiting disable to err_verbosity Thread-Index: AQHViC89H1LXrklOHUu4e/U5aAFNnw== Date: Mon, 21 Oct 2019 16:47:35 +0000 Message-ID: <20191021164654.9642-6-mihail.atanassov@arm.com> References: <20191021164654.9642-1-mihail.atanassov@arm.com> In-Reply-To: <20191021164654.9642-1-mihail.atanassov@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.140.106.51] x-clientproxiedby: LO2P123CA0003.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::15) To VI1PR08MB4078.eurprd08.prod.outlook.com (2603:10a6:803:e5::28) x-mailer: git-send-email 2.23.0 Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: edd5fc5d-e665-4504-28e9-08d756466465 X-MS-Office365-Filtering-HT: Tenant X-MS-TrafficTypeDiagnostic: VI1PR08MB3693:|VI1PR08MB3693:|AM6PR08MB4487: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:2449;OLM:2449; x-forefront-prvs: 0197AFBD92 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(366004)(396003)(346002)(39860400002)(199004)(189003)(11346002)(6436002)(316002)(54906003)(256004)(8936002)(6512007)(14444005)(2501003)(71200400001)(5640700003)(71190400001)(50226002)(486006)(2906002)(446003)(6486002)(2616005)(44832011)(5660300002)(8676002)(476003)(305945005)(66066001)(36756003)(86362001)(25786009)(14454004)(186003)(478600001)(6506007)(386003)(102836004)(26005)(4326008)(2351001)(81156014)(1076003)(6116002)(3846002)(66946007)(81166006)(66556008)(52116002)(66476007)(7736002)(64756008)(66446008)(99286004)(76176011)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3693; H:VI1PR08MB4078.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: HLkzIMJEQxzlI9copX2NPj0yiWNa8wBN39G2iPJ9LYDFDKx3no8aPiV2lddOQ4qf0KSznQ+tIoReapEbfhW9rkAvw5Vq0rPPJwN8kx+h71IyKY5jKFXu07vJpZU388K01J8iNFhTdFfkcJOfhNfMKSVFOCO/RMwnG7md10/B9nGxm65wLLpJ0urrWMu+baCr/wLFXS1zG7JF/p/Kok3jltVYDNO3icOsx3PK26YVtXAasOPSrC+iS9RPfKQ5MRap8IYlvfhdn82AypvpxIepZhVnSpljhnEkq3NFnV9V4BQq/O97ANZ0VdPY6DYmT6D8r8Y723m9F3DYdYoU+DY15XiaS25552kSpl53J4L4ttVHNFCILA2ef5VgNp3m2boLhs9HhyBmUeV58Q/J33Jw3X8yiStOD+nYI/o8sJ6BcKaV1gv+JaMSeF9P6fHbdslF MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3693 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT033.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(376002)(39860400002)(136003)(189003)(199004)(6486002)(2351001)(478600001)(86362001)(26826003)(70206006)(1076003)(356004)(70586007)(76130400001)(2501003)(3846002)(6116002)(2906002)(14454004)(25786009)(6916009)(7736002)(50226002)(81156014)(8746002)(5640700003)(8936002)(81166006)(8676002)(305945005)(50466002)(5660300002)(14444005)(47776003)(54906003)(316002)(186003)(107886003)(76176011)(4326008)(99286004)(26005)(102836004)(6506007)(386003)(66066001)(22756006)(2616005)(11346002)(446003)(6512007)(126002)(476003)(486006)(23756003)(36756003)(336012)(63350400001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB4487; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: a8b2873a-98fe-4272-17fa-08d756465ffd NoDisclaimer: True X-Forefront-PRVS: 0197AFBD92 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gnc0GVEdgaskReBNZF9mfiEybDcG3okxBPTyt6iOdqhLXDWc8Mk0VYRmgkIIGtos4aKN+p8SxvnYhTHgZf4qmEQAMvKVXFyK5kSjx/7Jud2UGrXjJOCO4149obHS2r4r55Fbh76ki4Ws36R9sC6IkQI2njLxRs0YCS+AZZqBV9PUf7SiWND5bCyGHzUWsJRtVCK8pe97HIOJjP5ZL8pUvrYkj7PBTdjYzteq/u5qRluL7sglp8sodQ01yW5wj0GMddWS9Hsh4Tt05f7WZ5DD84d8wfdfwrrZcrlkvCD9Pjr7Hga1twcTDCWyJZefVd6ZP+0frtIChP97PdDnnI1+SWvSOra91COpixoCxgWCw8NKGAhiNM+ReduiRgIU+/m7sxB0RMN7ydEw08qcOzVqmfkApNRZE0eMYOiT8sS4q9vBN1hUnte6/uh8x2lLI3/p X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2019 16:47:42.7774 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: edd5fc5d-e665-4504-28e9-08d756466465 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4487 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LqjsYGtito0owHXQyV4kjHNN6CmmoCoNhwj27nXP6vE=; b=6jcl66n4LMmg2Lezx5wQs+mvEHCPf/eF10A6OrrfW70+kwdZ2q2ui/6z8C/D+3HZJG2XOGreDMkOsDS+YvqCnPBRo6NhbrzMqdFRVwzcn0q11y1qG+c6/XkP1xRqbup5QJS2MCICEKNU0x1FilPkQjneSjAcljQY0Xc37qOc2RE= X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LqjsYGtito0owHXQyV4kjHNN6CmmoCoNhwj27nXP6vE=; b=6jcl66n4LMmg2Lezx5wQs+mvEHCPf/eF10A6OrrfW70+kwdZ2q2ui/6z8C/D+3HZJG2XOGreDMkOsDS+YvqCnPBRo6NhbrzMqdFRVwzcn0q11y1qG+c6/XkP1xRqbup5QJS2MCICEKNU0x1FilPkQjneSjAcljQY0Xc37qOc2RE= X-Mailman-Original-Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.freedesktop.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.freedesktop.org; dmarc=none action=none header.from=arm.com; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mihail Atanassov , David Airlie , Liviu Dudau , "linux-kernel@vger.kernel.org" , "james qian wang \(Arm Technology China\)" , "Lowry Li \(Arm Technology China\)" , nd , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" It's possible to get multiple events in a single frame/flip, so add an option to print them all. Signed-off-by: Mihail Atanassov Reviewed-by: James Qian Wang (Arm Technology China) --- drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 2 ++ drivers/gpu/drm/arm/display/komeda/komeda_event.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h index d9fc9c48859a..15f52e304c08 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h @@ -224,6 +224,8 @@ struct komeda_dev { #define KOMEDA_DEV_PRINT_INFO_EVENTS BIT(2) /* Dump DRM state on an error or warning event. */ #define KOMEDA_DEV_PRINT_DUMP_STATE_ON_EVENT BIT(8) + /* Disable rate limiting of event prints (normally one per commit) */ +#define KOMEDA_DEV_PRINT_DISABLE_RATELIMIT BIT(12) }; static inline bool diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c index bf88463bb4d9..86e33fed8a91 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c @@ -119,7 +119,8 @@ void komeda_print_events(struct komeda_events *evts, struct drm_device *dev) /* reduce the same msg print, only print the first evt for one frame */ if (evts->global || is_new_frame(evts)) en_print = true; - if (!en_print) + if (!(err_verbosity & KOMEDA_DEV_PRINT_DISABLE_RATELIMIT) + && !en_print) return; if (err_verbosity & KOMEDA_DEV_PRINT_ERR_EVENTS)