From patchwork Fri Oct 25 14:13:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Passaro via GitGitGadget X-Patchwork-Id: 11212445 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A22E91920 for ; Fri, 25 Oct 2019 14:13:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81471206DD for ; Fri, 25 Oct 2019 14:13:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SDJ2sl/f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390133AbfJYONl (ORCPT ); Fri, 25 Oct 2019 10:13:41 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:51897 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727367AbfJYONj (ORCPT ); Fri, 25 Oct 2019 10:13:39 -0400 Received: by mail-wm1-f66.google.com with SMTP id q70so2324399wme.1 for ; Fri, 25 Oct 2019 07:13:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:in-reply-to:references:from:date:subject:fcc :content-transfer-encoding:mime-version:to:cc; bh=yHzDynbjsCiXFV/kKp1mWEXKmYwehPsSAdfvuYZ+duM=; b=SDJ2sl/foBwqkyQZ/XzpL5SpVKnYBd9TKSgbbaqz2bFIxTeZJUcOJOztZOV8EhTofq GUk3ViGr+PbHGTCS3HpFcLhMhiO3k3tpsp/bJXJVP/1aojlmz6TRGljffrvhKNeXLBqP fI6hmt45KNjTi95ssyMgvGy0vGsh4kbW+2ibamOM3IbLydxLd+I7dHHzvmuc9sqx/mhg qVggCKcTlcYe1eKTNH2XwrykaAQHtuAYgMgVW7HpFbfa/elMbIqMRaTjDED5sOt+VsEm H9N1LJ5xSJSidZRLjca2oULXNjZ4vfGnQSzpzKottkTPLkMkiUrlHsPgEL3WGt7RrEC8 xrkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:in-reply-to:references:from:date :subject:fcc:content-transfer-encoding:mime-version:to:cc; bh=yHzDynbjsCiXFV/kKp1mWEXKmYwehPsSAdfvuYZ+duM=; b=YIaLq5x21SQLDe2ZtHA07tjUi8Z6TRTZk/vsjOljNP94OnSTwza1TJ2a0T+H8R/K6e 6M8c2q9aUmtcq9uYV6IuDXEYYhKtKedAZE3gKkHwWYxKRCri9/1B28ZxpmGSrB2pgYhA Rt+HwkxYAaTEyoWvlMjCra89pg8QY/4FXcajiMrBrsycxXS/ZD1CLjwrBJzGlgzsJcTP WDIcB7mc7ljSM7rtNSog8HOH4DU4jMaY6UsiGr0UEftAnT6d9wCV8G7XEYwLl40cSzcm FWCQuoXMLIbzN1NOUXn2Fxl9tBfRkN59rlmwWUvo6rUxT/Jq0w94o6KX/a8bK6UToYYO Df+g== X-Gm-Message-State: APjAAAXKvX5XEnkjG3zOPFkeMJFJ2CY0q3hO8/wB3+wKgt56+Tqgy/Ll H+Xg+rFxVmjAw968v/oXXpSG7CWk X-Google-Smtp-Source: APXvYqwxFDtgZjLoUjUzDXXVdHXJe9MZiUxPoAl0eXI0hNsQphp+8y/s2MLpJxY3y0ZNag5rznakqQ== X-Received: by 2002:a7b:c846:: with SMTP id c6mr3936063wml.68.1572012817982; Fri, 25 Oct 2019 07:13:37 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id o1sm1877682wmc.38.2019.10.25.07.13.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Oct 2019 07:13:37 -0700 (PDT) Message-Id: In-Reply-To: References: From: "Johannes Schindelin via GitGitGadget" Date: Fri, 25 Oct 2019 14:13:36 +0000 Subject: [PATCH 1/1] mingw: avoid a buffer overrun in `needs_hiding()` Fcc: Sent MIME-Version: 1.0 To: git@vger.kernel.org Cc: Johannes Schindelin , Junio C Hamano , Johannes Schindelin Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Johannes Schindelin When this function is passed a path with a trailing slash, it runs right over the end of that path. Let's fix this. Co-authored-by: Alexandr Miloslavskiy Signed-off-by: Johannes Schindelin --- compat/mingw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/compat/mingw.c b/compat/mingw.c index 6b765d936c..fe609239dd 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -363,6 +363,8 @@ static inline int needs_hiding(const char *path) /* ignore trailing slashes */ if (*path) basename = path; + else + break; } if (hide_dotfiles == HIDE_DOTFILES_TRUE)