From patchwork Fri Oct 25 05:13:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Ellerman X-Patchwork-Id: 11214819 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 53466197C for ; Mon, 28 Oct 2019 07:34:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 448992086D for ; Mon, 28 Oct 2019 07:34:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="nEBfElKI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="MUki5QF2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 448992086D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1A8C31AE6; Mon, 28 Oct 2019 08:33:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1A8C31AE6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572248050; bh=hWHZmJVa2GJ+T63cjFSf8GzCUoqun93lDs6zPwywLxE=; h=From:To:Date:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=nEBfElKImEeVOSR7Cb3aa8mtcObJqMQcHEiV3q2rytZuDYc9V+tUvmmUhKoSktKkc KYWsxiILgLsJqvaagkv6XcbY0O1UpkswU3t5NLZ45W+r0gHEBxkTY4PXVZRvZEL+Qi 1p+BaLv6e0YTRExR51RhH2ZQZRY/FX9vxYXnL8ho= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 991F0F802BD; Mon, 28 Oct 2019 08:33:19 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id C525EF8036F; Fri, 25 Oct 2019 07:14:13 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on alsa1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_PASS,SPF_PASS, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CF1BDF802A0 for ; Fri, 25 Oct 2019 07:14:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CF1BDF802A0 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="MUki5QF2" Received: by ozlabs.org (Postfix, from userid 1034) id 46zsj62wkXz9sPh; Fri, 25 Oct 2019 16:14:02 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1571980442; bh=XUnk/aDzI0RoSsU6UPnlmFhYiY8BJtc3RoeNDTw86bM=; h=From:To:Cc:Subject:Date:From; b=MUki5QF2/NzyA9s6I4tsE0/RhIMRunvvcWUI/eur+Y3/IFtPPa5GAwPuoJQsX84HS mnIMlmHusHuUlAZMruibKVWTPQOQ+ej3SD/XamhJyeeWhKmSSM6Uj2JdFYm39w3olA xzqHC06myjj6dleKseudkjfXnyAYyneGY+QlR9yrvnQt31J4OKDyt0F620cncHR41v i2Y3cI3Ytx1xdjYQ4rDviFhu94UY5i0kwXliphOuklCXrKvmpIjNEoeXmbCjVtc1Em F7yArYWGpmOjSVnXff5xvKf/of+78I4EUxYdXTpFBgOSOIBK3CKrCkyO8Tdr+jLgGX Bykg0EcXt+WCA== From: Michael Ellerman To: alsa-devel@alsa-project.org Date: Fri, 25 Oct 2019 16:13:53 +1100 Message-Id: <20191025051353.2878-1-mpe@ellerman.id.au> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 28 Oct 2019 08:33:18 +0100 Cc: linuxppc-dev@ozlabs.org, broonie@kernel.org, kuninori.morimoto.gx@renesas.com Subject: [alsa-devel] [PATCH] ASoC: fsl: fsl_dma: fix build failure X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Commit 4ac85de9977e ("ASoC: fsl: fsl_dma: remove snd_pcm_ops") removed fsl_dma_ops but left a usage, leading to a build error for some configs, eg. mpc85xx_defconfig: sound/soc/fsl/fsl_dma.c: In function ‘fsl_soc_dma_probe’: sound/soc/fsl/fsl_dma.c:905:18: error: ‘fsl_dma_ops’ undeclared (first use in this function) dma->dai.ops = &fsl_dma_ops; ^~~~~~~~~~~ Remove the usage to fix the build. Fixes: 4ac85de9977e ("ASoC: fsl: fsl_dma: remove snd_pcm_ops") Signed-off-by: Michael Ellerman --- sound/soc/fsl/fsl_dma.c | 1 - 1 file changed, 1 deletion(-) This breakage is only in linux-next. diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c index a092726510d4..2868c4f97cb2 100644 --- a/sound/soc/fsl/fsl_dma.c +++ b/sound/soc/fsl/fsl_dma.c @@ -901,7 +901,6 @@ static int fsl_soc_dma_probe(struct platform_device *pdev) } dma->dai.name = DRV_NAME; - dma->dai.ops = &fsl_dma_ops; dma->dai.open = fsl_dma_open; dma->dai.close = fsl_dma_close; dma->dai.ioctl = snd_soc_pcm_lib_ioctl;