From patchwork Mon Oct 28 15:59:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 11215807 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 211681390 for ; Mon, 28 Oct 2019 16:00:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3F8920873 for ; Mon, 28 Oct 2019 16:00:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tooKU51b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731561AbfJ1QAH (ORCPT ); Mon, 28 Oct 2019 12:00:07 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:44596 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730448AbfJ1QAH (ORCPT ); Mon, 28 Oct 2019 12:00:07 -0400 Received: by mail-wr1-f66.google.com with SMTP id z11so10431706wro.11 for ; Mon, 28 Oct 2019 09:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1oAb42sZZnx0GHz8zCdLCMmekFS0iw5KiZS34/CPk4k=; b=tooKU51bYYf1gF016u+c81AEuMXscSfSovfJ/EDkbLFB04aStD3mLoO+NUTyJaeMo7 Gd0zVRLA3hmTuqX4quwt4Afq+NMEXw6HQVOyWBY71EagsnSWDm++sa7QfL39oGoOMV3T rFT2qFID6aW7XZ8a6v67Gpbno0FjrDfiemU50pbtlGzzgPOEs4t7kgJtmgWi1qIa69Jp smbUhA5doLiSdFEpNmZofHnf8K3GDCoR21apKb49dLV0Ah4CJY8hcUIORsjn8HrmoIVD UD+xuVWTTESPh7gajyQKrD4/r/Q7BPClADeAwvVOb8r5FLwEm9PAbj+MOm1uzIO+SI5g vLdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1oAb42sZZnx0GHz8zCdLCMmekFS0iw5KiZS34/CPk4k=; b=VQOsVfPyaOtkZzdDHhgZE47f4jonPtx5FT+yWUOcKnzn5EWqpbQ+jKYCp5OYtgl9rR AV1dS+2FHGNj+yOjirMV3cXuKYyMenX/0Ptb2lTbOVS585ZkdirfFVvbjgWo97dqGfbm eaeIkIi/2JU1PE9Ynq5J8i3wpCn/Hj+GH00p3EOT01M3RYUFBfsmpzxmv9FPa2YolivN IDGq80yaXT3BVJmvDrNPvw1jqSWxUTkSq1TGA6OpYxl69SJSle1mJIhqJ5mv226UqwSn v9Ws/ubnruUtEasmFcKiEC48l13Qgi45jvTb+8w0Y/ZuzA/wZbtaCyqOlL1rpaxB/XAI lHcg== X-Gm-Message-State: APjAAAU+dIenSHCPfjnJw3MBOeLd/8Lf2YZPz1V/ogF0YVNCShiUYFwU 84vh1CT8OXaeRAoW5CXWWbcHHbrNn8c= X-Google-Smtp-Source: APXvYqzErUlZTf9VjIv3POxBpIqJbqoWcV0/wANgcpnF0hbGAK7HB6spU4kLAID3fAtG3aGTGqpCtg== X-Received: by 2002:adf:fe90:: with SMTP id l16mr15359441wrr.81.1572278403719; Mon, 28 Oct 2019 09:00:03 -0700 (PDT) Received: from kheib-workstation.redhat.com (bzq-79-179-0-252.red.bezeqint.net. [79.179.0.252]) by smtp.gmail.com with ESMTPSA id a2sm11871600wrv.39.2019.10.28.09.00.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2019 09:00:03 -0700 (PDT) From: Kamal Heib To: linux-rdma@vger.kernel.org Cc: Doug Ledford , Jason Gunthorpe , Lijun Ou , Selvin Xavier , Michal Kalderon , Kamal Heib Subject: [for-next v4 1/4] RDMA/core: Fix return code when modify_port isn't supported Date: Mon, 28 Oct 2019 17:59:28 +0200 Message-Id: <20191028155931.1114-2-kamalheib1@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191028155931.1114-1-kamalheib1@gmail.com> References: <20191028155931.1114-1-kamalheib1@gmail.com> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Improving return code from ib_modify_port() by doing the following: 1- Use "-EOPNOTSUPP" instead "-ENOSYS" which is the proper return code. 2- Allow only IB_PORT_CM_SUP fake manipulation for RoCE providers that didn't implement the modify_port callback, otherwise return "-EOPNOTSUPP". Fixes: 61e0962d5221 ("IB: Avoid ib_modify_port() failure for RoCE devices") Signed-off-by: Kamal Heib --- drivers/infiniband/core/device.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c index eb35b663a742..ee5fe20bd8b0 100644 --- a/drivers/infiniband/core/device.c +++ b/drivers/infiniband/core/device.c @@ -2395,8 +2395,12 @@ int ib_modify_port(struct ib_device *device, rc = device->ops.modify_port(device, port_num, port_modify_mask, port_modify); + else if (rdma_protocol_roce(device, port_num) && + ((port_modify->set_port_cap_mask & ~IB_PORT_CM_SUP) == 0 || + (port_modify->clr_port_cap_mask & ~IB_PORT_CM_SUP) == 0)) + rc = 0; else - rc = rdma_protocol_roce(device, port_num) ? 0 : -ENOSYS; + rc = -EOPNOTSUPP; return rc; } EXPORT_SYMBOL(ib_modify_port); From patchwork Mon Oct 28 15:59:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 11215811 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E2E67139A for ; Mon, 28 Oct 2019 16:00:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C0DB420873 for ; Mon, 28 Oct 2019 16:00:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sgw7ru1D" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730448AbfJ1QAJ (ORCPT ); Mon, 28 Oct 2019 12:00:09 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:45972 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726612AbfJ1QAI (ORCPT ); Mon, 28 Oct 2019 12:00:08 -0400 Received: by mail-wr1-f68.google.com with SMTP id q13so10439366wrs.12 for ; Mon, 28 Oct 2019 09:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hAZ2TrIIVcLEbxIdOVbHEBWi4WBUQuacFKnyYRaMGgU=; b=sgw7ru1DsRo0TyXW0gHHwXcUYoy+N9LoqhPn0HrKLDmEj5RMM9FC290GeyhCJarlTl xiZoM2i4JsCUz+EdoucSFIKFnYWchVGBqtgYvTTd3Cd8zzyrXJC67jFvyNGr+HxVA05M IzXeZfFgOrAGgEL85XuHE1T1xxwkO85YP/MSb6C/acfMwbMxENwqpl8Fg5tNG9GE0Tgm SNPDkZrj9scF2nNWboyabzcpTTW0mCYnT37yhDxLaQTU8WLxifKb4dMn2C+m7s1pub3T Thh679+YZ6ak0SZOSjuwZN9k9kQqovRn0BbXIrgCzrNvrLYrRaG1bs9epLXtSStLrnDL g2/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hAZ2TrIIVcLEbxIdOVbHEBWi4WBUQuacFKnyYRaMGgU=; b=BcBW/Sm0s3/q3Jr5r3m0ixy1QJIygTswFzptHAzc1ODXzZTdlwS7MfTvpVFxw0vw/1 ARcRBHLkWffEAssfYdwFZwvNvjHKkLy775W9NM0nDQsVssXj8M5MmidYLhiMSD5tr1nC jgfz/EkgkN+odtAxKic5m5vNDHbgkiXnIuH+WLPc0EB9o5dQ8Orn+FF7x+kILbSo1HpK IOaRDr5Qu8pNspSRMqZB0R8fI+nUkxACzJNh5In0/ZUpoP9foSDO33W+QPkao8bwMjTm bLmFAIAQbzJZekM07kHLIHtSiZ8rVRDvYEAleNU4rFlCdin0tZMc6w7dIVc+zs9WuH/2 UKgw== X-Gm-Message-State: APjAAAWTs3ctVEuljsmm6LW/LIyY5gOWC028jrsGmRkEOj6iHFI0TJz6 U4t1TCDwIYsRqd4yNZog9Ax/xp7ektw= X-Google-Smtp-Source: APXvYqx/Qip1QWATRUNuH/1/EXxcoVRshNmsztmj4ogu45KgSTh6KHOmeZrQHWM5VJEegT4FnxCDuQ== X-Received: by 2002:adf:e886:: with SMTP id d6mr3105482wrm.188.1572278405106; Mon, 28 Oct 2019 09:00:05 -0700 (PDT) Received: from kheib-workstation.redhat.com (bzq-79-179-0-252.red.bezeqint.net. [79.179.0.252]) by smtp.gmail.com with ESMTPSA id a2sm11871600wrv.39.2019.10.28.09.00.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2019 09:00:04 -0700 (PDT) From: Kamal Heib To: linux-rdma@vger.kernel.org Cc: Doug Ledford , Jason Gunthorpe , Lijun Ou , Selvin Xavier , Michal Kalderon , Kamal Heib Subject: [for-next v4 2/4] RDMA/hns: Remove unsupported modify_port callback Date: Mon, 28 Oct 2019 17:59:29 +0200 Message-Id: <20191028155931.1114-3-kamalheib1@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191028155931.1114-1-kamalheib1@gmail.com> References: <20191028155931.1114-1-kamalheib1@gmail.com> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org There is no need to return always zero for function which is not supported. Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver") Signed-off-by: Kamal Heib --- drivers/infiniband/hw/hns/hns_roce_main.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c index b5d196c119ee..b241f74a7e3b 100644 --- a/drivers/infiniband/hw/hns/hns_roce_main.c +++ b/drivers/infiniband/hw/hns/hns_roce_main.c @@ -301,12 +301,6 @@ static int hns_roce_modify_device(struct ib_device *ib_dev, int mask, return 0; } -static int hns_roce_modify_port(struct ib_device *ib_dev, u8 port_num, int mask, - struct ib_port_modify *props) -{ - return 0; -} - static int hns_roce_alloc_ucontext(struct ib_ucontext *uctx, struct ib_udata *udata) { @@ -438,7 +432,6 @@ static const struct ib_device_ops hns_roce_dev_ops = { .get_port_immutable = hns_roce_port_immutable, .mmap = hns_roce_mmap, .modify_device = hns_roce_modify_device, - .modify_port = hns_roce_modify_port, .modify_qp = hns_roce_modify_qp, .query_ah = hns_roce_query_ah, .query_device = hns_roce_query_device, From patchwork Mon Oct 28 15:59:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 11215809 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B6A3E1390 for ; Mon, 28 Oct 2019 16:00:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 952B720873 for ; Mon, 28 Oct 2019 16:00:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nodnf2sR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731684AbfJ1QAJ (ORCPT ); Mon, 28 Oct 2019 12:00:09 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:35745 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730448AbfJ1QAI (ORCPT ); Mon, 28 Oct 2019 12:00:08 -0400 Received: by mail-wm1-f66.google.com with SMTP id x5so2469121wmi.0 for ; Mon, 28 Oct 2019 09:00:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/nLBDNnI2ytUN/R+LaCECQ51HAzPdQVxI7fwxKBAxkk=; b=nodnf2sRqlZqlo2vQ/hdno2iYJ6Ru5PmNQkP645SG5eYXTuO8PLb/beTbDK7mu+28e UmINNW9BMWYonxuRM2wxEkmKHTGxNCQsitmOo1NvuU+c4bxZvQr0eHoMwNkLNq4aYO9c ITeTys/9j8HlN8fXAcUIJtcaAswQzCXFNVJe1zzmN9GIxwaVSKws+2VvSdqfkOvVBdkD BbB5bS3WTRGWqxKj6V8Samm6bGoI0lFWL7Nni3xLfNSjVJ9qI2mMCASAO6osrgMgTaUP RhlsDg/8BEx5CwogBiEm0IwB2pSjFvlZH59JDklNJqZD+lBj1AyBNHFdTE8ryiBV2KgA lndg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/nLBDNnI2ytUN/R+LaCECQ51HAzPdQVxI7fwxKBAxkk=; b=VHhlGv+vEcncYm0pmCf64oEJ7+YRwAofhpCKsA/NM0xGRZusH1JaMJRjagT34KU9QD Np8oTMUs13Xk5ugORW7d0UvuNVg3QsnT9LxP0y4qGlDikXFocImBXExHLDkFTgr8DC+o vNGXpildrFmvKkESihfNGUs9VDWRUV34kXV3BaQj44HnhcPBoGr61UW08Pi/0qY9EKlP SgafJ7oDlbqs30CGA4HvrZxaGs/PQ/m+/CU9fYQBMgk6bUPjKu8Ws3UcqZhKFti9QrHI KJUCL7Nvq5REWGbPVb45jnpiEc8eE0OIB+NLHVvAmnX2hdT6EED4bibj7UmvNb2yKGJJ OsTQ== X-Gm-Message-State: APjAAAWvnv6zFVbk7OvoTbCF24IUCi17VYASAE+H2JSTbmKXmEoMZ9Vv KEu2Am8w7vzC/uStWNMWz6If8T9fsus= X-Google-Smtp-Source: APXvYqw9EdZszj07yN0CtK6/aFlorqwi06zyjmrrmbo80De5PVZWyY/slwGlHQPjldJHT3f/qL2Pdg== X-Received: by 2002:a1c:f00a:: with SMTP id a10mr16503wmb.138.1572278406584; Mon, 28 Oct 2019 09:00:06 -0700 (PDT) Received: from kheib-workstation.redhat.com (bzq-79-179-0-252.red.bezeqint.net. [79.179.0.252]) by smtp.gmail.com with ESMTPSA id a2sm11871600wrv.39.2019.10.28.09.00.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2019 09:00:06 -0700 (PDT) From: Kamal Heib To: linux-rdma@vger.kernel.org Cc: Doug Ledford , Jason Gunthorpe , Lijun Ou , Selvin Xavier , Michal Kalderon , Kamal Heib Subject: [for-next v4 3/4] RDMA/ocrdma: Remove unsupported modify_port callback Date: Mon, 28 Oct 2019 17:59:30 +0200 Message-Id: <20191028155931.1114-4-kamalheib1@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191028155931.1114-1-kamalheib1@gmail.com> References: <20191028155931.1114-1-kamalheib1@gmail.com> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org There is no need to return always zero for function which is not supported. Fixes: fe2caefcdf58 ("RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMAadapter") Signed-off-by: Kamal Heib --- drivers/infiniband/hw/ocrdma/ocrdma_main.c | 1 - drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 6 ------ drivers/infiniband/hw/ocrdma/ocrdma_verbs.h | 2 -- 3 files changed, 9 deletions(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_main.c b/drivers/infiniband/hw/ocrdma/ocrdma_main.c index c15cfc6cef81..d8c47d24d6d6 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_main.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_main.c @@ -166,7 +166,6 @@ static const struct ib_device_ops ocrdma_dev_ops = { .get_port_immutable = ocrdma_port_immutable, .map_mr_sg = ocrdma_map_mr_sg, .mmap = ocrdma_mmap, - .modify_port = ocrdma_modify_port, .modify_qp = ocrdma_modify_qp, .poll_cq = ocrdma_poll_cq, .post_recv = ocrdma_post_recv, diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c index e8267e590772..e72050de5734 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c @@ -190,12 +190,6 @@ int ocrdma_query_port(struct ib_device *ibdev, return 0; } -int ocrdma_modify_port(struct ib_device *ibdev, u8 port, int mask, - struct ib_port_modify *props) -{ - return 0; -} - static int ocrdma_add_mmap(struct ocrdma_ucontext *uctx, u64 phy_addr, unsigned long len) { diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.h b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.h index 32488da1b752..3a5010881be5 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.h +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.h @@ -54,8 +54,6 @@ int ocrdma_arm_cq(struct ib_cq *, enum ib_cq_notify_flags flags); int ocrdma_query_device(struct ib_device *, struct ib_device_attr *props, struct ib_udata *uhw); int ocrdma_query_port(struct ib_device *, u8 port, struct ib_port_attr *props); -int ocrdma_modify_port(struct ib_device *, u8 port, int mask, - struct ib_port_modify *props); enum rdma_protocol_type ocrdma_query_protocol(struct ib_device *device, u8 port_num); From patchwork Mon Oct 28 15:59:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 11215813 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7B150139A for ; Mon, 28 Oct 2019 16:00:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 59E2920873 for ; Mon, 28 Oct 2019 16:00:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iuWEyiob" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726612AbfJ1QAK (ORCPT ); Mon, 28 Oct 2019 12:00:10 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:40644 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731619AbfJ1QAK (ORCPT ); Mon, 28 Oct 2019 12:00:10 -0400 Received: by mail-wr1-f65.google.com with SMTP id o28so10466166wro.7 for ; Mon, 28 Oct 2019 09:00:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TycqH6hRWVQcQ82ZcSfaibr4XzfZ5J5iKsyxzuflrxg=; b=iuWEyiobUP9puSRAbKS1qbroa23dq8GlnO2OjxXb6vcPm7LQAyvNPbhZM0z8Birjcu 7hiqW6egcpx2a5i7/uMIYCJA6kBjbrxgIjWv3udSU8iRrs0hUO5VPqdd4uIdZProNmXN OSoQCTroO6de/wJMYRL5aRxtqv6nXKjiYQE+gocZ5c5X0gySXvWY7C+7VwufLRl8dU3Q nivIY6KOW3f1qMlgFFcfSZxzbVvZRdOMznd4iY2i8enEjOtqrzMn/lVZG+Hk09Pqanjs iXBCRcrkLxrpq7j0sPQpQ+TVy0sItCYc2Vu0PGr4VmXtyuOzgvWieC45A9u740pR6LVa yrJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TycqH6hRWVQcQ82ZcSfaibr4XzfZ5J5iKsyxzuflrxg=; b=B7Q/Eam9p8HAYrEj5wBf5hUTnF4FOX7nP95R4CFq/CiSysHTuLarGNxcc2HbWirXTe GsRZOWWGM0H0sz6my1c+HX0uuu9dPAGkBj92ZwrgYJhKWxQYChWK7MCwMICloq4MQD44 ggRORgWW4wRzoxr2mcgJutmKRn27UuR6ZpPjB99pxMjh5MNpJXyFksXSKIwbrk2ZXLvh 1wV1E2fJQe67ieKO8k2nMqIiW1JX4trgfn1lK83z5d19OiNmBaue/Dq8wq+2+twqEaXQ 4pEkqVrC/MeUmgKK0wpIpOslb42L42TNbJln1H1plJnn/llMH8D6WRD01FBwP9ZDagjc zYdA== X-Gm-Message-State: APjAAAUtYD8JMu9wFiHsVsfI35zo0lLJz2tmHZuoGL9hFraFFdVqFXXF 2sJupA23Cj5dGt06ebf2DjQxv+6Tbp8= X-Google-Smtp-Source: APXvYqzNE6N5MaNJ5GMXkKvE54QGHMPHNsNg3s6CM43Ofm67yZiwpimJZU1dzgXtAB26eDTOJhEsvQ== X-Received: by 2002:adf:f343:: with SMTP id e3mr15437475wrp.315.1572278408097; Mon, 28 Oct 2019 09:00:08 -0700 (PDT) Received: from kheib-workstation.redhat.com (bzq-79-179-0-252.red.bezeqint.net. [79.179.0.252]) by smtp.gmail.com with ESMTPSA id a2sm11871600wrv.39.2019.10.28.09.00.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2019 09:00:07 -0700 (PDT) From: Kamal Heib To: linux-rdma@vger.kernel.org Cc: Doug Ledford , Jason Gunthorpe , Lijun Ou , Selvin Xavier , Michal Kalderon , Kamal Heib Subject: [for-next v4 4/4] RDMA/qedr: Remove unsupported modify_port callback Date: Mon, 28 Oct 2019 17:59:31 +0200 Message-Id: <20191028155931.1114-5-kamalheib1@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191028155931.1114-1-kamalheib1@gmail.com> References: <20191028155931.1114-1-kamalheib1@gmail.com> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org There is no need to return always zero for function which is not supported. Fixes: ac1b36e55a51 ("qedr: Add support for user context verbs") Signed-off-by: Kamal Heib --- drivers/infiniband/hw/qedr/main.c | 1 - drivers/infiniband/hw/qedr/verbs.c | 6 ------ drivers/infiniband/hw/qedr/verbs.h | 2 -- 3 files changed, 9 deletions(-) diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c index 5136b835e1ba..e5f36adb0120 100644 --- a/drivers/infiniband/hw/qedr/main.c +++ b/drivers/infiniband/hw/qedr/main.c @@ -212,7 +212,6 @@ static const struct ib_device_ops qedr_dev_ops = { .get_link_layer = qedr_link_layer, .map_mr_sg = qedr_map_mr_sg, .mmap = qedr_mmap, - .modify_port = qedr_modify_port, .modify_qp = qedr_modify_qp, .modify_srq = qedr_modify_srq, .poll_cq = qedr_poll_cq, diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c index 6f3ce86019b7..fee02ac47f32 100644 --- a/drivers/infiniband/hw/qedr/verbs.c +++ b/drivers/infiniband/hw/qedr/verbs.c @@ -250,12 +250,6 @@ int qedr_query_port(struct ib_device *ibdev, u8 port, struct ib_port_attr *attr) return 0; } -int qedr_modify_port(struct ib_device *ibdev, u8 port, int mask, - struct ib_port_modify *props) -{ - return 0; -} - static int qedr_add_mmap(struct qedr_ucontext *uctx, u64 phy_addr, unsigned long len) { diff --git a/drivers/infiniband/hw/qedr/verbs.h b/drivers/infiniband/hw/qedr/verbs.h index 9aaa90283d6e..d81b81f86f0a 100644 --- a/drivers/infiniband/hw/qedr/verbs.h +++ b/drivers/infiniband/hw/qedr/verbs.h @@ -35,8 +35,6 @@ int qedr_query_device(struct ib_device *ibdev, struct ib_device_attr *attr, struct ib_udata *udata); int qedr_query_port(struct ib_device *, u8 port, struct ib_port_attr *props); -int qedr_modify_port(struct ib_device *, u8 port, int mask, - struct ib_port_modify *props); int qedr_iw_query_gid(struct ib_device *ibdev, u8 port, int index, union ib_gid *gid);