From patchwork Mon Oct 28 09:20:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wambui Karuga X-Patchwork-Id: 11216605 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BD32A913 for ; Mon, 28 Oct 2019 21:09:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A395D217D6 for ; Mon, 28 Oct 2019 21:09:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A395D217D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9B0CB6EA76; Mon, 28 Oct 2019 21:09:50 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 132076E50C; Mon, 28 Oct 2019 09:20:19 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id q130so8272015wme.2; Mon, 28 Oct 2019 02:20:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wIuGwn2jgbDtMcHHOszupBu+fQifNyNj/PTHe+Q5iEw=; b=hZzbvCOM8aDRz/3UwzrNiz4yfzR30lrsPfejnq6jzNMVAsv1YPKd+2O3LnUKkPmX+R 8AqCxQpiQkGNKyAcX9LLX97NU6mfHDs9VpRNfN6CX1/eqL4nchkve2waPTH9jwLXv2hc Brp+1yz+cOajigXNVKR9VtX8rFVoFEDsU0ou9qJY6nL5OhaqZc6xqO0uS4mZDDw6CCiz AdadQjxLa294ly+HSju5psbZTaHpytwQZOojyPbMYkOAVVgxIUVp+bpZ82ojr5FqXBdJ oFVUyvEVfSqCbewwTCVMv2pkbU9VRQh9dRxpSwOawtQkLxV5XxX+l2w0qTrA1LYvwiCl hOtw== X-Gm-Message-State: APjAAAX7WObblBTKhptZ0vN5BkEbETC2S18OXcTGjxZh/LO4KiGpQ/Ol O5uqpJVXGJfyPwgMh1eXYs9V+8Fp+lcRUg== X-Google-Smtp-Source: APXvYqxBcssIkhamPko/fax5AmALlb8thgEIQaTOHQbgFgVvAlPSNmDGOtswJVwTfhME3llhdxSSmw== X-Received: by 2002:a1c:1d10:: with SMTP id d16mr15486351wmd.14.1572254417401; Mon, 28 Oct 2019 02:20:17 -0700 (PDT) Received: from localhost.localdomain ([197.254.95.38]) by smtp.googlemail.com with ESMTPSA id z9sm11427513wrv.1.2019.10.28.02.20.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2019 02:20:16 -0700 (PDT) From: Wambui Karuga To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [Outreachy][PATCH 1/2] drm/amd: declare amdgpu_exp_hw_support in amdgpu.h Date: Mon, 28 Oct 2019 12:20:04 +0300 Message-Id: <20191028092005.31121-2-wambui.karugax@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191028092005.31121-1-wambui.karugax@gmail.com> References: <20191028092005.31121-1-wambui.karugax@gmail.com> X-Mailman-Approved-At: Mon, 28 Oct 2019 21:09:49 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wIuGwn2jgbDtMcHHOszupBu+fQifNyNj/PTHe+Q5iEw=; b=CMh/MkDfospgY1lS3Xa8YLvgA9gN95y9aLEw+FmGBfX8eZl2bSwff0ji6BoiaaTSLy MOJK+6FLYglo4N6XVNJmnHdND7sNqftfNoXJocRfHqY8UgcbKumVjpa7W7zjCIHbjphq Bpsq49P0mzhpqPzd1E2iLq2T1Yka06IFlCMvpJAl5jyGgJp0O0Pwz43p6dJmNQ4csW9l T5RLdsVBLcBayfL+eTTaDCLM7Pq+42LucGCwv9KfRrGvRvVt4stEiYwVyGh0LkMF4pBb LkrHy+VKanwipDT7oyQZU28VX1uF6YWijZbK+woXWBY/8RAsAdecnMhEVnz4uW68Issh qwsg== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, outreachy-kernel@googlegroups.com, alexander.deucher@amd.com, christian.koenig@amd.com MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Declare `amdgpu_exp_hw_support` as extern in amdgpu.h to address the following sparse warning: drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:118:5: warning: symbol 'amdgpu_exp_hw_support' was not declared. Should it be static? Signed-off-by: Wambui Karuga Suggested-by: Harry Wentland --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index f4d9041ef430..3610defdfae1 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h @@ -140,6 +140,7 @@ extern int amdgpu_vm_fragment_size; extern int amdgpu_vm_fault_stop; extern int amdgpu_vm_debug; extern int amdgpu_vm_update_mode; +extern int amdgpu_exp_hw_support; extern int amdgpu_dc; extern int amdgpu_sched_jobs; extern int amdgpu_sched_hw_submission; From patchwork Mon Oct 28 09:20:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wambui Karuga X-Patchwork-Id: 11216607 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8DE8B1599 for ; Mon, 28 Oct 2019 21:09:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74769217D6 for ; Mon, 28 Oct 2019 21:09:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74769217D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5973C6EA77; Mon, 28 Oct 2019 21:09:51 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 630996E50C; Mon, 28 Oct 2019 09:20:21 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id 6so9085084wmf.0; Mon, 28 Oct 2019 02:20:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GQTK6QpjvNTdkkg2NeYSTEMRpVNQAutWzeXrakegZZQ=; b=gKKZmOKpEpyLQ7tP8MUvfivz+4++v77PKw8rzbQGdx0rNSF58tKIiVkA1Qf4PQcfWz wNN+nehoxhdTvmvq2dH68t3vbR1qyEaOlRhXt0hrFmUcXTgNprBXDod9bYepSdu630Sb j22FEqcRTNd6dIqibtgrf9GByjuuUOf2FKlrypuIDjukQPnyxKkNBz8vPPd1eCP+YhY0 JUvVHV83RRXoFvn7EILzwKcKK/HF72J4t7TzHehx6aXzROoxbvUXfp9EKETZ4mrVSu7q VR8Se4WpSRJY6pC/Fj2ZWCjZdZGyImhkacvQW98knRJGkboS74CeBiNj6mculIDxZRkY q2mw== X-Gm-Message-State: APjAAAVO7a5tgQQVXN5txYh4Pwh+BZoqoclL9/wTxLXQCvuvj5AMPuhL qu6yOT9G8ON4BzfVbL2ICDXxUxHHAu6wZ8Gp X-Google-Smtp-Source: APXvYqx1BQoiYhrKFTknW040OjzddO8ontuaiBfn4yCuEELwZZAbBvZlPM7HPLyzkV8nlztk19/jUA== X-Received: by 2002:a05:600c:2908:: with SMTP id i8mr15527215wmd.142.1572254419663; Mon, 28 Oct 2019 02:20:19 -0700 (PDT) Received: from localhost.localdomain ([197.254.95.38]) by smtp.googlemail.com with ESMTPSA id z9sm11427513wrv.1.2019.10.28.02.20.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2019 02:20:19 -0700 (PDT) From: Wambui Karuga To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [Outreachy][PATCH 2/2] drm/amd: correct "_LENTH" mispelling in constant Date: Mon, 28 Oct 2019 12:20:05 +0300 Message-Id: <20191028092005.31121-3-wambui.karugax@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191028092005.31121-1-wambui.karugax@gmail.com> References: <20191028092005.31121-1-wambui.karugax@gmail.com> X-Mailman-Approved-At: Mon, 28 Oct 2019 21:09:49 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GQTK6QpjvNTdkkg2NeYSTEMRpVNQAutWzeXrakegZZQ=; b=uFCEi25z78vO8pPx6uy4YXZTY67190GV4H/4YC/RV7/sY+NngnG7S883JdfxH/qOwD t09XGp4SjLb9SZVQSqP3/LiONdAwAooJVFxfnwEUkUig2HPGwmwZCOufWLPYVdOgHsCH cHbaP7P9RHfbFnbKko1mZiWNVTyXvA+vjALFF7LWvJw62n3BJrxCuuLFH34Ic4wlp9It udGh2SW5WZp93jauFy8ghOPtN05wVZxg0uGILj/bkvcUgTyw1N0+XZ4YoPCgBIw919qr cUk6VDna7bOqkRHmcY6cwzZTIK/kZdE20pPW+l5uc0bC1NBmTOKT2IKXLnoULRmGL8xi byAg== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, outreachy-kernel@googlegroups.com, alexander.deucher@amd.com, christian.koenig@amd.com MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Correct the "_LENTH" mispelling in the AMDGPU_MAX_TIMEOUT_PARAM_LENGTH constant. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index 3610defdfae1..7d1e528cc783 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h @@ -108,7 +108,7 @@ struct amdgpu_mgpu_info uint32_t num_apu; }; -#define AMDGPU_MAX_TIMEOUT_PARAM_LENTH 256 +#define AMDGPU_MAX_TIMEOUT_PARAM_LENGTH 256 /* * Modules parameters. @@ -126,7 +126,7 @@ extern int amdgpu_disp_priority; extern int amdgpu_hw_i2c; extern int amdgpu_pcie_gen2; extern int amdgpu_msi; -extern char amdgpu_lockup_timeout[AMDGPU_MAX_TIMEOUT_PARAM_LENTH]; +extern char amdgpu_lockup_timeout[AMDGPU_MAX_TIMEOUT_PARAM_LENGTH]; extern int amdgpu_dpm; extern int amdgpu_fw_load_type; extern int amdgpu_aspm; diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 676cad15239f..4eee40b9d0b0 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -2631,9 +2631,9 @@ static int amdgpu_device_get_job_timeout_settings(struct amdgpu_device *adev) else adev->compute_timeout = MAX_SCHEDULE_TIMEOUT; - if (strnlen(input, AMDGPU_MAX_TIMEOUT_PARAM_LENTH)) { + if (strnlen(input, AMDGPU_MAX_TIMEOUT_PARAM_LENGTH)) { while ((timeout_setting = strsep(&input, ",")) && - strnlen(timeout_setting, AMDGPU_MAX_TIMEOUT_PARAM_LENTH)) { + strnlen(timeout_setting, AMDGPU_MAX_TIMEOUT_PARAM_LENGTH)) { ret = kstrtol(timeout_setting, 0, &timeout); if (ret) return ret; diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index c685400febe2..16147ca9b851 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c @@ -101,7 +101,7 @@ int amdgpu_disp_priority = 0; int amdgpu_hw_i2c = 0; int amdgpu_pcie_gen2 = -1; int amdgpu_msi = -1; -char amdgpu_lockup_timeout[AMDGPU_MAX_TIMEOUT_PARAM_LENTH]; +char amdgpu_lockup_timeout[AMDGPU_MAX_TIMEOUT_PARAM_LENGTH]; int amdgpu_dpm = -1; int amdgpu_fw_load_type = -1; int amdgpu_aspm = -1;