From patchwork Fri Nov 1 09:34:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru Ardelean X-Patchwork-Id: 11222847 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 71E3714E5 for ; Fri, 1 Nov 2019 09:36:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4533D21855 for ; Fri, 1 Nov 2019 09:36:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=analog.onmicrosoft.com header.i=@analog.onmicrosoft.com header.b="ALkl0GAi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727143AbfKAJf3 (ORCPT ); Fri, 1 Nov 2019 05:35:29 -0400 Received: from mx0a-00128a01.pphosted.com ([148.163.135.77]:55686 "EHLO mx0a-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727270AbfKAJf2 (ORCPT ); Fri, 1 Nov 2019 05:35:28 -0400 Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xA19XUxf003899; Fri, 1 Nov 2019 05:35:16 -0400 Received: from nam04-bn3-obe.outbound.protection.outlook.com (mail-bn3nam04lp2051.outbound.protection.outlook.com [104.47.46.51]) by mx0a-00128a01.pphosted.com with ESMTP id 2vxwhjrw13-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Nov 2019 05:35:16 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R3m+9NQBxhx2KxGlzFTi83xpVr3qiXZpYbZRtBMAjlJxDsLu+UGUUW7YJssyllr1PGOEQir7nh8E92H9YCAmNlwyvCvkE76Qq4AC++s6rFBuVtCCePLKqOoS0FtDqxQVkiHTMk9SK1UOdYyeV22CMThtezfbsDWoEB/6MPWyVYF1M9cK2N3N1HDUKR2BfCbaO2qdFEDI0HsvwHTuo5WvVfOTezR+EZWgHyoWi5yIhWIh0L3esx2JCnNTQ/PefljOJBidQWQNEeZYYmw6EOe43JpuBN2sdwt4NE9sXq9tkmQXAm3uMr8qjtlwzdfPhsgL6rVGl3dLk+XeaObvaA8SNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Je9+9pGOzDXkfWuRqa3QHNdnv44LmOlGvLG4UXexLx0=; b=QnRix/z2+SQVuWaXAb2C6LfxNbjI4euL27peEAz4HrgmT6E0rj52HKJViGowH+Q55/Dby+z+3YWN9GEoU8Aa3BUtdpu1itroug6nmcBWr9BB9ELEwT9U/VENi0w+Gr9Qn6nPL3JZDyPjJQL/l6fTY14Cwed1wPz+oFEjnaMpBEccpoSL167c8LWL495bp0Rf2JWMh5rjL6DrJrMsd3xfmNE+K5lmzh0bpr3/2eDhXs5SoNz4iJ03zmfRS3MOMUqhYI4ZTxOf31M93Fp65FqNPeIEFA8g6VJjJH42OumH8SR57+BuO3X5hJXSTq5fQFiOsZknxUn5G3MDtQqdkSL2iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 137.71.25.57) smtp.rcpttodomain=metafoo.de smtp.mailfrom=analog.com; dmarc=bestguesspass action=none header.from=analog.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.onmicrosoft.com; s=selector2-analog-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Je9+9pGOzDXkfWuRqa3QHNdnv44LmOlGvLG4UXexLx0=; b=ALkl0GAi4q3bRj0iW8ORR5gYzmvn6Z25cYS8rJbb6Z5fJtgRijVF2Xx7W/aTEv6J/xseRixiWfj972EUJijX5Rh2IRDkp0Wp2xdmg0r/pUWxd1LSuNtzF/urJiVvshkGwz7VAfls2x8S8HpXGwMZZIqaMhmmjl88pCw654B8dNY= Received: from CH2PR03CA0003.namprd03.prod.outlook.com (2603:10b6:610:59::13) by BN6PR03MB2451.namprd03.prod.outlook.com (2603:10b6:404:14::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.24; Fri, 1 Nov 2019 09:35:14 +0000 Received: from BL2NAM02FT040.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::203) by CH2PR03CA0003.outlook.office365.com (2603:10b6:610:59::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2408.17 via Frontend Transport; Fri, 1 Nov 2019 09:35:13 +0000 Received-SPF: Pass (protection.outlook.com: domain of analog.com designates 137.71.25.57 as permitted sender) receiver=protection.outlook.com; client-ip=137.71.25.57; helo=nwd2mta2.analog.com; Received: from nwd2mta2.analog.com (137.71.25.57) by BL2NAM02FT040.mail.protection.outlook.com (10.152.77.193) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2387.20 via Frontend Transport; Fri, 1 Nov 2019 09:35:13 +0000 Received: from NWD2HUBCAS7.ad.analog.com (nwd2hubcas7.ad.analog.com [10.64.69.107]) by nwd2mta2.analog.com (8.13.8/8.13.8) with ESMTP id xA19Z5IX024992 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK); Fri, 1 Nov 2019 02:35:05 -0700 Received: from saturn.ad.analog.com (10.48.65.117) by NWD2HUBCAS7.ad.analog.com (10.64.69.107) with Microsoft SMTP Server id 14.3.408.0; Fri, 1 Nov 2019 05:35:12 -0400 From: Alexandru Ardelean To: , CC: , , , , Alexandru Ardelean Subject: [PATCH 01/10] iio: gyro: adis16136: check ret val for non-zero vs less-than-zero Date: Fri, 1 Nov 2019 11:34:56 +0200 Message-ID: <20191101093505.9408-2-alexandru.ardelean@analog.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191101093505.9408-1-alexandru.ardelean@analog.com> References: <20191101093505.9408-1-alexandru.ardelean@analog.com> MIME-Version: 1.0 X-ADIRoutedOnPrem: True X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.57;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(396003)(136003)(39860400002)(346002)(376002)(189003)(199004)(7696005)(305945005)(70206006)(8936002)(26005)(50226002)(7636002)(8676002)(426003)(44832011)(76176011)(4326008)(1076003)(14444005)(336012)(70586007)(186003)(51416003)(36756003)(486006)(246002)(6666004)(107886003)(50466002)(47776003)(2870700001)(356004)(316002)(54906003)(106002)(5660300002)(110136005)(478600001)(476003)(48376002)(86362001)(2616005)(126002)(11346002)(446003)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR03MB2451;H:nwd2mta2.analog.com;FPR:;SPF:Pass;LANG:en;PTR:nwd2mail11.analog.com;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0b0f40d6-24cf-42dc-5096-08d75eaecbfc X-MS-TrafficTypeDiagnostic: BN6PR03MB2451: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-Forefront-PRVS: 020877E0CB X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1Zi7XrweeFfw+6XzPgS/yGKIxrEhnTMWteNXrbbJUWSjXhJuc3b/GrITlf8pvpGRX6uicpaeL32PSH/zd0stBVdB2k5WhZ7uYPfLPzB5HxdkAIGm5tciEWSOgZDjRLmvQiWKdM5fgJ/Sdqr4TOQncA7Gdkkq0dtxbnNwqHrWWwmm4ogOre1wqYE0S35uHNHmLfFoBA9TqPbQrlrTXBjvvwtW6JVQSzFo8trndXzDS8MSIFoZCy8inGqtDgcERLMBxlIbSOXaljnep9smMOeK9NUAp1BSWZAVLfNHGgU2XDgn3LnnzL0XfIQVS+OP+wGiozoWSmiNT4fWYF6v0JEf1P66BFR6bHYkviakMr/AQ4HwJrD7PV8zbbGVs4+Z0yYZ+tTQXt6B4VjCW29u7l/WYVtvQnA5pz1b9JmILVTyaoAzL9QPXh4zykLBPocy4UH8 X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2019 09:35:13.5365 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0b0f40d6-24cf-42dc-5096-08d75eaecbfc X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.57];Helo=[nwd2mta2.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2451 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-11-01_03:2019-10-30,2019-11-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxlogscore=947 priorityscore=1501 adultscore=0 mlxscore=0 malwarescore=0 bulkscore=0 spamscore=0 phishscore=0 clxscore=1015 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1911010095 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org The ADIS library functions return zero on success, and negative values for error. Positive values aren't returned, but we only care about the success value (which is zero). This change is mostly needed so that the compiler won't make any inferences about some about values being potentially un-initialized. This only triggers after making some functions inline, because the compiler can better follow return paths. Signed-off-by: Alexandru Ardelean --- drivers/iio/gyro/adis16136.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/iio/gyro/adis16136.c b/drivers/iio/gyro/adis16136.c index 5bec7ad53d8b..d637d52d051a 100644 --- a/drivers/iio/gyro/adis16136.c +++ b/drivers/iio/gyro/adis16136.c @@ -80,19 +80,19 @@ static ssize_t adis16136_show_serial(struct file *file, ret = adis_read_reg_16(&adis16136->adis, ADIS16136_REG_SERIAL_NUM, &serial); - if (ret < 0) + if (ret) return ret; ret = adis_read_reg_16(&adis16136->adis, ADIS16136_REG_LOT1, &lot1); - if (ret < 0) + if (ret) return ret; ret = adis_read_reg_16(&adis16136->adis, ADIS16136_REG_LOT2, &lot2); - if (ret < 0) + if (ret) return ret; ret = adis_read_reg_16(&adis16136->adis, ADIS16136_REG_LOT3, &lot3); - if (ret < 0) + if (ret) return ret; len = snprintf(buf, sizeof(buf), "%.4x%.4x%.4x-%.4x\n", lot1, lot2, @@ -116,7 +116,7 @@ static int adis16136_show_product_id(void *arg, u64 *val) ret = adis_read_reg_16(&adis16136->adis, ADIS16136_REG_PROD_ID, &prod_id); - if (ret < 0) + if (ret) return ret; *val = prod_id; @@ -134,7 +134,7 @@ static int adis16136_show_flash_count(void *arg, u64 *val) ret = adis_read_reg_16(&adis16136->adis, ADIS16136_REG_FLASH_CNT, &flash_count); - if (ret < 0) + if (ret) return ret; *val = flash_count; @@ -191,7 +191,7 @@ static int adis16136_get_freq(struct adis16136 *adis16136, unsigned int *freq) int ret; ret = adis_read_reg_16(&adis16136->adis, ADIS16136_REG_SMPL_PRD, &t); - if (ret < 0) + if (ret) return ret; *freq = 32768 / (t + 1); @@ -228,7 +228,7 @@ static ssize_t adis16136_read_frequency(struct device *dev, int ret; ret = adis16136_get_freq(adis16136, &freq); - if (ret < 0) + if (ret) return ret; return sprintf(buf, "%d\n", freq); @@ -256,7 +256,7 @@ static int adis16136_set_filter(struct iio_dev *indio_dev, int val) int i, ret; ret = adis16136_get_freq(adis16136, &freq); - if (ret < 0) + if (ret) return ret; for (i = ARRAY_SIZE(adis16136_3db_divisors) - 1; i >= 1; i--) { @@ -277,11 +277,11 @@ static int adis16136_get_filter(struct iio_dev *indio_dev, int *val) mutex_lock(&indio_dev->mlock); ret = adis_read_reg_16(&adis16136->adis, ADIS16136_REG_AVG_CNT, &val16); - if (ret < 0) + if (ret) goto err_unlock; ret = adis16136_get_freq(adis16136, &freq); - if (ret < 0) + if (ret) goto err_unlock; *val = freq / adis16136_3db_divisors[val16 & 0x07]; @@ -318,7 +318,7 @@ static int adis16136_read_raw(struct iio_dev *indio_dev, case IIO_CHAN_INFO_CALIBBIAS: ret = adis_read_reg_32(&adis16136->adis, ADIS16136_REG_GYRO_OFF2, &val32); - if (ret < 0) + if (ret) return ret; *val = sign_extend32(val32, 31); From patchwork Fri Nov 1 09:34:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru Ardelean X-Patchwork-Id: 11222845 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B4AED912 for ; Fri, 1 Nov 2019 09:36:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 894A5218AC for ; Fri, 1 Nov 2019 09:36:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=analog.onmicrosoft.com header.i=@analog.onmicrosoft.com header.b="TtW/3VI7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728900AbfKAJfb (ORCPT ); Fri, 1 Nov 2019 05:35:31 -0400 Received: from mx0a-00128a01.pphosted.com ([148.163.135.77]:57596 "EHLO mx0a-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727270AbfKAJfa (ORCPT ); Fri, 1 Nov 2019 05:35:30 -0400 Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xA19XUxh003899; Fri, 1 Nov 2019 05:35:19 -0400 Received: from nam04-bn3-obe.outbound.protection.outlook.com (mail-bn3nam04lp2056.outbound.protection.outlook.com [104.47.46.56]) by mx0a-00128a01.pphosted.com with ESMTP id 2vxwhjrw17-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 01 Nov 2019 05:35:19 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H78Llg+Q0nE/ZAY4OOahknXXBQdfPsjZBuxyTsXceTZqUuS9Xzu8DVHTG3tMUdGH9Nuyt0Y/ttsKm9VbOPTmLWhiuGdJIGj+lPMTD4OCFylXnyw8j0glW8qvBZoUpHBpPmRCIi6m1mFgkqDMR0LlydhRnk5pfyF1SO/WDKJbTK5A1KhkdeDHNcZrM1cmrdopDwjG9tpshQBJ0Ec6tLfKqW9ZuE0eZS0AjfkuvqXtk3FGAyyxkR067kkjcRgz8Pzxv38uxF8kXuI+MQC18Fpg8NevJwm+Wz8qjB49rPwxjsvbbRuURkms9gGSq6Lr2WeG2y6Qf8DA7XJn4OzA6bQL6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2G65wO7Q+8Wo/ReS6nFB4Ml8UlOgZXigBZFLRRrqW2g=; b=nUyVBEedT8cKm8P3caBmk3LHDJNxXnWRgY1WakHVN8FPAQWJnPHsOAHcJ8WLzbYP90IUyC5GqA7mjxzqGCvPp7Y5Ubctw6ldrP2GKxrWWmeaSv05bDYnpPRDgVhZAXTBKn7qXpod4Pdi8BvfcyhwiPSZmoH0dh26xTV01c4d28Or6mZw0T9yTHNiDOl9vD/i6hSkbeEGC7efhBpfj4WIOp8vYAQS3Sdqoq1glPBALMs7+evJIEokxaghYLTMvMo0Ysn2/ukKDwWCx75TJvcqJdb4wivc/bpSyWJfCm+ZTRNFXAgTswX4UuNoYgSwvmeooPbg+5cSegCdDdF6Ri1qfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 137.71.25.57) smtp.rcpttodomain=metafoo.de smtp.mailfrom=analog.com; dmarc=bestguesspass action=none header.from=analog.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.onmicrosoft.com; s=selector2-analog-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2G65wO7Q+8Wo/ReS6nFB4Ml8UlOgZXigBZFLRRrqW2g=; b=TtW/3VI7zTlhb1B8Wry5yxDaZgkBcWyqkiZx1ht+fGjCJmkDApdi6l/qCeGEvGd/X/Oxz8K4Saf1ttRwNnS8jmTC7uf7GZdB6l/P1/TWYzaqEAd7Tt/EWOyd6/+mJ5MT7WOkzuMVGG7X40OOnnJljHqhLc4xoxzgkEVmZJjfhfg= Received: from BN6PR03CA0120.namprd03.prod.outlook.com (2603:10b6:404:10::34) by BYAPR03MB3477.namprd03.prod.outlook.com (2603:10b6:a02:b7::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.24; Fri, 1 Nov 2019 09:35:15 +0000 Received: from BL2NAM02FT051.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::208) by BN6PR03CA0120.outlook.office365.com (2603:10b6:404:10::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.17 via Frontend Transport; Fri, 1 Nov 2019 09:35:15 +0000 Received-SPF: Pass (protection.outlook.com: domain of analog.com designates 137.71.25.57 as permitted sender) receiver=protection.outlook.com; client-ip=137.71.25.57; helo=nwd2mta2.analog.com; Received: from nwd2mta2.analog.com (137.71.25.57) by BL2NAM02FT051.mail.protection.outlook.com (10.152.76.181) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2387.20 via Frontend Transport; Fri, 1 Nov 2019 09:35:15 +0000 Received: from NWD2HUBCAS7.ad.analog.com (nwd2hubcas7.ad.analog.com [10.64.69.107]) by nwd2mta2.analog.com (8.13.8/8.13.8) with ESMTP id xA19Z7EU024998 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK); Fri, 1 Nov 2019 02:35:07 -0700 Received: from saturn.ad.analog.com (10.48.65.117) by NWD2HUBCAS7.ad.analog.com (10.64.69.107) with Microsoft SMTP Server id 14.3.408.0; Fri, 1 Nov 2019 05:35:14 -0400 From: Alexandru Ardelean To: , CC: , , , , Alexandru Ardelean Subject: [PATCH 02/10] iio: imu: adis16400: check ret val for non-zero vs less-than-zero Date: Fri, 1 Nov 2019 11:34:57 +0200 Message-ID: <20191101093505.9408-3-alexandru.ardelean@analog.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191101093505.9408-1-alexandru.ardelean@analog.com> References: <20191101093505.9408-1-alexandru.ardelean@analog.com> MIME-Version: 1.0 X-ADIRoutedOnPrem: True X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.57;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(39860400002)(136003)(396003)(376002)(346002)(199004)(189003)(305945005)(476003)(44832011)(7696005)(8676002)(51416003)(356004)(246002)(76176011)(126002)(6666004)(7636002)(26005)(36756003)(486006)(86362001)(1076003)(70586007)(50226002)(70206006)(8936002)(5660300002)(107886003)(50466002)(2870700001)(336012)(2906002)(186003)(446003)(106002)(47776003)(110136005)(316002)(2616005)(478600001)(54906003)(4326008)(426003)(48376002)(11346002);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR03MB3477;H:nwd2mta2.analog.com;FPR:;SPF:Pass;LANG:en;PTR:nwd2mail11.analog.com;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 06799c7f-73e8-4399-7e6e-08d75eaecd09 X-MS-TrafficTypeDiagnostic: BYAPR03MB3477: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-Forefront-PRVS: 020877E0CB X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TuR47KlX5rvUsAbui7g31XAmz2q09IWrIzkoO0cF8ohsiXVpS6kMYNbGoqOK82klKLkebOyMm00sqOSHDOVO6XQWsSLVIfQdlHPi2uAw8Tee2BhGLZ6Rd/FTi2NnDaAVdQQxv/oyUsC8+aEZ95uTxezackbwy2VCcdYn9AX9jtgGmVstUbvvdU4pLWmT/27yQ94xLxV5WCxJXUsVznY5sHCvnR+MBSXLyylW1/5Fr49XbFlQPwr7Swm+eUKprhHhU3JHPW6YnerPFVuS7F8oztV9yOZk5WljVlIEhMxTYwCLXEPzoeLhGg0gYFU9dEOl/i7mFz3v7fdzrCJ2dISzHb4c+i6GfqCUh4zoHn8Rx0GMbRcGiTXaqif9OAfNfmR/3Xb79l05Rr6RJoT7zmlJg1Appkz9iRxOcZNrL0pBQqZeC/bPVsmIbq1O/dyM/e8v X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2019 09:35:15.3076 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 06799c7f-73e8-4399-7e6e-08d75eaecd09 X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.57];Helo=[nwd2mta2.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3477 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-11-01_03:2019-10-30,2019-11-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxlogscore=966 priorityscore=1501 adultscore=0 mlxscore=0 malwarescore=0 bulkscore=0 spamscore=0 phishscore=0 clxscore=1015 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1911010095 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org The ADIS library functions return zero on success, and negative values for error. Positive values aren't returned, but we only care about the success value (which is zero). This change is mostly needed so that the compiler won't make any inferences about some about values being potentially un-initialized. This only triggers after making some functions inline, because the compiler can better follow return paths. Signed-off-by: Alexandru Ardelean --- drivers/iio/imu/adis16400.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/iio/imu/adis16400.c b/drivers/iio/imu/adis16400.c index 0575ff706bd4..44e46dc96e00 100644 --- a/drivers/iio/imu/adis16400.c +++ b/drivers/iio/imu/adis16400.c @@ -217,16 +217,16 @@ static ssize_t adis16400_show_serial_number(struct file *file, int ret; ret = adis_read_reg_16(&st->adis, ADIS16334_LOT_ID1, &lot1); - if (ret < 0) + if (ret) return ret; ret = adis_read_reg_16(&st->adis, ADIS16334_LOT_ID2, &lot2); - if (ret < 0) + if (ret) return ret; ret = adis_read_reg_16(&st->adis, ADIS16334_SERIAL_NUMBER, &serial_number); - if (ret < 0) + if (ret) return ret; len = snprintf(buf, sizeof(buf), "%.4x-%.4x-%.4x\n", lot1, lot2, @@ -249,7 +249,7 @@ static int adis16400_show_product_id(void *arg, u64 *val) int ret; ret = adis_read_reg_16(&st->adis, ADIS16400_PRODUCT_ID, &prod_id); - if (ret < 0) + if (ret) return ret; *val = prod_id; @@ -266,7 +266,7 @@ static int adis16400_show_flash_count(void *arg, u64 *val) int ret; ret = adis_read_reg_16(&st->adis, ADIS16400_FLASH_CNT, &flash_count); - if (ret < 0) + if (ret) return ret; *val = flash_count; @@ -327,7 +327,7 @@ static int adis16334_get_freq(struct adis16400_state *st) uint16_t t; ret = adis_read_reg_16(&st->adis, ADIS16400_SMPL_PRD, &t); - if (ret < 0) + if (ret) return ret; t >>= ADIS16334_RATE_DIV_SHIFT; @@ -359,7 +359,7 @@ static int adis16400_get_freq(struct adis16400_state *st) uint16_t t; ret = adis_read_reg_16(&st->adis, ADIS16400_SMPL_PRD, &t); - if (ret < 0) + if (ret) return ret; sps = (t & ADIS16400_SMPL_PRD_TIME_BASE) ? 52851 : 1638404; @@ -416,7 +416,7 @@ static int adis16400_set_filter(struct iio_dev *indio_dev, int sps, int val) } ret = adis_read_reg_16(&st->adis, ADIS16400_SENS_AVG, &val16); - if (ret < 0) + if (ret) return ret; ret = adis_write_reg_16(&st->adis, ADIS16400_SENS_AVG, @@ -615,7 +615,7 @@ static int adis16400_read_raw(struct iio_dev *indio_dev, ret = adis_read_reg_16(&st->adis, ADIS16400_SENS_AVG, &val16); - if (ret < 0) { + if (ret) { mutex_unlock(&indio_dev->mlock); return ret; } @@ -626,12 +626,12 @@ static int adis16400_read_raw(struct iio_dev *indio_dev, *val2 = (ret % 1000) * 1000; } mutex_unlock(&indio_dev->mlock); - if (ret < 0) + if (ret) return ret; return IIO_VAL_INT_PLUS_MICRO; case IIO_CHAN_INFO_SAMP_FREQ: ret = st->variant->get_freq(st); - if (ret < 0) + if (ret) return ret; *val = ret / 1000; *val2 = (ret % 1000) * 1000; From patchwork Fri Nov 1 09:34:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru Ardelean X-Patchwork-Id: 11222843 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AA80417D5 for ; Fri, 1 Nov 2019 09:36:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8912821906 for ; Fri, 1 Nov 2019 09:36:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=analog.onmicrosoft.com header.i=@analog.onmicrosoft.com header.b="OlUC9epE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728948AbfKAJfc (ORCPT ); Fri, 1 Nov 2019 05:35:32 -0400 Received: from mx0a-00128a01.pphosted.com ([148.163.135.77]:58338 "EHLO mx0a-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728901AbfKAJfc (ORCPT ); Fri, 1 Nov 2019 05:35:32 -0400 Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xA19XUxi003899; Fri, 1 Nov 2019 05:35:20 -0400 Received: from nam03-dm3-obe.outbound.protection.outlook.com (mail-dm3nam03lp2057.outbound.protection.outlook.com [104.47.41.57]) by mx0a-00128a01.pphosted.com with ESMTP id 2vxwhjrw19-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 01 Nov 2019 05:35:20 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dn2UkTkbMCS9b1bCYm8ftpCjDpIjzW4scg5gE/0Z2wb92e3rzTGI4KiH5wbOvUdcIFGFA9e5jaDaAO1iKc8maof0DQ64p2QBEO6zI8RZG0TEYmEAGhlQjadO0riirhfrRZH1Lt57pRij9FDAn4IKqW2DYr9iccz+ZLo0GkEjp4u+/8oJlWQ7dRT/NeC9pJtjZ3QCx/qjD1wfk63Cz4TXN5T7YUvOdd/LFuouJanb3JDs6f8KXa7eJzuPtW3vSOgWajwG8C5rHcpgsi0nufDyKlfZW3k9nByZq7BacHD0EzTt0exCe16iAtn5Y46VgrTBWtTVwDJuX05ZfEWbfdr+tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uqAbtWyP1oqZstS4KcjRFQseXzYuanor1MeW60wBkRI=; b=hSvsfUu/3/WwbS0ZZ2WfXcl7vLbUvfx7ccUY4EQGUtRyVuTsvSgYNGyu8c0YX4fo6aYvDtzpgR4BmQXCv2vMKH90UsaNYlQl7q5J+E+9vnfZKAy6BwMjhjGE7WOQMxF5zlqbIKFO1/2a+t0ehekx+8zOhXf2vZJ2QHOImbfvhVBukWOkur3zqh1zArUz5pSq1nKkGCmPWYSTzTLeyq5ckMdWMzVU6dmKcMvfx0QVs8kBwi2ia/HCNihX+ui0MfDB2Xg/1bNcQnVdThFW2knTpU3gg0jLF8uQ5zxH1Vl//KcfUXRcGZw8hmQkEgwX51qbQ4TtxjtOHt+IH24FFrZxGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 137.71.25.57) smtp.rcpttodomain=metafoo.de smtp.mailfrom=analog.com; dmarc=bestguesspass action=none header.from=analog.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.onmicrosoft.com; s=selector2-analog-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uqAbtWyP1oqZstS4KcjRFQseXzYuanor1MeW60wBkRI=; b=OlUC9epEkDFX6h8RgVGWHzIuy0UAAtPlruQ9FXgBtH5i1zlceSt4/grquChkzKZ7mYXq+g/2FtIENeDfz3c87BUjuyOn2X2yoIE/GM6TJrupx6LQCtGB3JdxuRsuyoBwW0nDQ9lSzH1JRlRVVfvzzQhW29XEueLK3MQ3JoJ24D0= Received: from CH2PR03CA0029.namprd03.prod.outlook.com (2603:10b6:610:59::39) by MWHPR03MB2543.namprd03.prod.outlook.com (2603:10b6:300:7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.20; Fri, 1 Nov 2019 09:35:18 +0000 Received: from BL2NAM02FT049.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::209) by CH2PR03CA0029.outlook.office365.com (2603:10b6:610:59::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2408.20 via Frontend Transport; Fri, 1 Nov 2019 09:35:17 +0000 Received-SPF: Pass (protection.outlook.com: domain of analog.com designates 137.71.25.57 as permitted sender) receiver=protection.outlook.com; client-ip=137.71.25.57; helo=nwd2mta2.analog.com; Received: from nwd2mta2.analog.com (137.71.25.57) by BL2NAM02FT049.mail.protection.outlook.com (10.152.77.118) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2387.20 via Frontend Transport; Fri, 1 Nov 2019 09:35:17 +0000 Received: from NWD2HUBCAS7.ad.analog.com (nwd2hubcas7.ad.analog.com [10.64.69.107]) by nwd2mta2.analog.com (8.13.8/8.13.8) with ESMTP id xA19Z9Qx025004 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK); Fri, 1 Nov 2019 02:35:09 -0700 Received: from saturn.ad.analog.com (10.48.65.117) by NWD2HUBCAS7.ad.analog.com (10.64.69.107) with Microsoft SMTP Server id 14.3.408.0; Fri, 1 Nov 2019 05:35:16 -0400 From: Alexandru Ardelean To: , CC: , , , , Alexandru Ardelean Subject: [PATCH 03/10] iio: imu: adis16460: check ret val for non-zero vs less-than-zero Date: Fri, 1 Nov 2019 11:34:58 +0200 Message-ID: <20191101093505.9408-4-alexandru.ardelean@analog.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191101093505.9408-1-alexandru.ardelean@analog.com> References: <20191101093505.9408-1-alexandru.ardelean@analog.com> MIME-Version: 1.0 X-ADIRoutedOnPrem: True X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.57;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(396003)(136003)(376002)(346002)(39860400002)(189003)(199004)(86362001)(426003)(7696005)(476003)(446003)(51416003)(356004)(336012)(6666004)(5660300002)(126002)(4326008)(44832011)(2906002)(11346002)(50466002)(110136005)(486006)(186003)(70586007)(70206006)(54906003)(36756003)(106002)(8676002)(48376002)(47776003)(1076003)(2870700001)(246002)(26005)(478600001)(316002)(2616005)(76176011)(107886003)(305945005)(50226002)(8936002)(7636002);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR03MB2543;H:nwd2mta2.analog.com;FPR:;SPF:Pass;LANG:en;PTR:nwd2mail11.analog.com;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7a8c9ba3-c9e8-41f7-ddb6-08d75eaece1a X-MS-TrafficTypeDiagnostic: MWHPR03MB2543: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-Forefront-PRVS: 020877E0CB X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 637tHRv6wg7BREuQOU/l3cBrDHyRxPw0OhzKeqME3wRC999WBOPKQnbQJK4ACUBEr8RN0IW+jRNXAGJlZf9f4AU7Uo/zPVD/HTMd+zZ8GsrLoiKbbAV9a2/MvDm6qVUwFVa/mE5ODA4f+8gzWHDVMnB6fPvVhlTUzdevBipAhgSEzVeLEN7FAFeI8YcMmxvBUH5ZXCmj3fXmTJHOPO9YnfOBiCJ0/TXbNLgL4O0uPVUK2SB7ELqUSd7c8N44OYSdgmHsqj3bZERDLjKyRr0KE8IxHtNptX/mmDR2CCk2oyPjSq8gAe72aWd1okVw9O1eXSjNpmofVkdhD422khsq9u5e8dMF6yJmYlIZuDg3rb6+0P5Z53Uif8mg5gGjDxqOMEm6Z31jAL5UxnXzfKNYl1Kv9B/ApGbGKtbm4ex8P7dg8V2XS9YJ+z+cr1XOIg9K X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2019 09:35:17.0981 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7a8c9ba3-c9e8-41f7-ddb6-08d75eaece1a X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.57];Helo=[nwd2mta2.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2543 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-11-01_03:2019-10-30,2019-11-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxlogscore=828 priorityscore=1501 adultscore=0 mlxscore=0 malwarescore=0 bulkscore=0 spamscore=0 phishscore=0 clxscore=1015 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1911010095 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org The ADIS library functions return zero on success, and negative values for error. Positive values aren't returned, but we only care about the success value (which is zero). This change is mostly needed so that the compiler won't make any inferences about some about values being potentially un-initialized. This only triggers after making some functions inline, because the compiler can better follow return paths. Signed-off-by: Alexandru Ardelean --- drivers/iio/imu/adis16460.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/imu/adis16460.c b/drivers/iio/imu/adis16460.c index 6aed9e84abbf..b55812521537 100644 --- a/drivers/iio/imu/adis16460.c +++ b/drivers/iio/imu/adis16460.c @@ -80,7 +80,7 @@ static int adis16460_show_serial_number(void *arg, u64 *val) ret = adis_read_reg_16(&adis16460->adis, ADIS16460_REG_SERIAL_NUM, &serial); - if (ret < 0) + if (ret) return ret; *val = serial; @@ -98,7 +98,7 @@ static int adis16460_show_product_id(void *arg, u64 *val) ret = adis_read_reg_16(&adis16460->adis, ADIS16460_REG_PROD_ID, &prod_id); - if (ret < 0) + if (ret) return ret; *val = prod_id; @@ -116,7 +116,7 @@ static int adis16460_show_flash_count(void *arg, u64 *val) ret = adis_read_reg_32(&adis16460->adis, ADIS16460_REG_FLASH_CNT, &flash_count); - if (ret < 0) + if (ret) return ret; *val = flash_count; @@ -176,7 +176,7 @@ static int adis16460_get_freq(struct iio_dev *indio_dev, int *val, int *val2) unsigned int freq; ret = adis_read_reg_16(&st->adis, ADIS16460_REG_DEC_RATE, &t); - if (ret < 0) + if (ret) return ret; freq = 2048000 / (t + 1); From patchwork Fri Nov 1 09:34:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru Ardelean X-Patchwork-Id: 11222835 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BB5051390 for ; Fri, 1 Nov 2019 09:35:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E282218DE for ; Fri, 1 Nov 2019 09:35:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=analog.onmicrosoft.com header.i=@analog.onmicrosoft.com header.b="XXbc/FTF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729099AbfKAJfn (ORCPT ); Fri, 1 Nov 2019 05:35:43 -0400 Received: from mx0b-00128a01.pphosted.com ([148.163.139.77]:55572 "EHLO mx0b-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728901AbfKAJff (ORCPT ); Fri, 1 Nov 2019 05:35:35 -0400 Received: from pps.filterd (m0167090.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xA19XTSU026930; Fri, 1 Nov 2019 05:35:23 -0400 Received: from nam05-dm3-obe.outbound.protection.outlook.com (mail-dm3nam05lp2051.outbound.protection.outlook.com [104.47.49.51]) by mx0b-00128a01.pphosted.com with ESMTP id 2vxwgwh8wv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Nov 2019 05:35:22 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kq/mv8nVQZxQ1WvBT1SlTABuI3T9jKKOmu/nvzt53DbTrPbtvE5goEKJz44q13viAcYTe1DicRCK9QekiERWssjNOe2ygPURuDB5aTAf5kis+VgI2wVm4jfiVIQv8X6Z85oo5o0hqRyaT1Hp2l694vJBihu/8LsjFlSgUBVzvsGjpIvmjmcrflu4qZbzUWJScz275DBqYNzhvJr1G4UOA6A0WqSg1jDeiKbGzY/uhyvddo9k7w6h5KW5+D/pS6v/CsNjCrnPgqE7YwcUL0kkXGOc9fpLrxM+3Igd8oask4cZlyLC2fJQQWOOaBq+zhGbVh054e7wwVFUvX9wb/RVwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6qWuMSIf3Vk6QvjbMmfHsYntFAg5LbGQwvLNnz5cEJo=; b=MFx1M7utTQ8pXOANGAlu7oI8lGZN5sTl3UktfE2jtRstLE92XJ9WjX5I/KyYQESXHHmmfz9cAp+moolPMA2GlIpm+u/oFjBv+2XAtbJa5woIARkPoG3PIPX8CxwabbM++g6Gg59pfXThvDy6t73VLJrsFLZQGJzbkRxwsF/i99QSkXocFPkFwRNhZmeg25cuSNikTiciBnr2E5TlF5vvkpwPWDsdY+jkj9TiFKtGqhV+hRX2/tLGwA/XEmUjDciBgsSEzky0HXuuatw3YpSM8bCQ18SmRr9Nwo0GCRGcMOCgT/WUD6JnkmSRuIemJdgu6SmQZdlGF9bI7bj+HSkqxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 137.71.25.57) smtp.rcpttodomain=metafoo.de smtp.mailfrom=analog.com; dmarc=bestguesspass action=none header.from=analog.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.onmicrosoft.com; s=selector2-analog-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6qWuMSIf3Vk6QvjbMmfHsYntFAg5LbGQwvLNnz5cEJo=; b=XXbc/FTFf8i69Ps0TOXexQzbFs6+TnHNSgg724H8Govd4w1w5Tk4ag3LRoaHo8eXRLdNaqXzxZaR5CCuNhNvlCa97mb2oZBLn7qrxB8ezn3vm+iIX6MDwKgvZDYD5pPXUbXUvkAGCrddCKEgdWBhwdReZmHymfWd1xemkaq1wNo= Received: from BN3PR03CA0058.namprd03.prod.outlook.com (2a01:111:e400:7a4d::18) by CY4PR03MB2485.namprd03.prod.outlook.com (2603:10b6:903:38::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.17; Fri, 1 Nov 2019 09:35:20 +0000 Received: from BL2NAM02FT042.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::207) by BN3PR03CA0058.outlook.office365.com (2a01:111:e400:7a4d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2408.22 via Frontend Transport; Fri, 1 Nov 2019 09:35:19 +0000 Received-SPF: Pass (protection.outlook.com: domain of analog.com designates 137.71.25.57 as permitted sender) receiver=protection.outlook.com; client-ip=137.71.25.57; helo=nwd2mta2.analog.com; Received: from nwd2mta2.analog.com (137.71.25.57) by BL2NAM02FT042.mail.protection.outlook.com (10.152.76.193) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2387.20 via Frontend Transport; Fri, 1 Nov 2019 09:35:18 +0000 Received: from NWD2HUBCAS7.ad.analog.com (nwd2hubcas7.ad.analog.com [10.64.69.107]) by nwd2mta2.analog.com (8.13.8/8.13.8) with ESMTP id xA19ZBC0025012 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK); Fri, 1 Nov 2019 02:35:11 -0700 Received: from saturn.ad.analog.com (10.48.65.117) by NWD2HUBCAS7.ad.analog.com (10.64.69.107) with Microsoft SMTP Server id 14.3.408.0; Fri, 1 Nov 2019 05:35:18 -0400 From: Alexandru Ardelean To: , CC: , , , , Alexandru Ardelean Subject: [PATCH 04/10] iio: imu: adis16480: check ret val for non-zero vs less-than-zero Date: Fri, 1 Nov 2019 11:34:59 +0200 Message-ID: <20191101093505.9408-5-alexandru.ardelean@analog.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191101093505.9408-1-alexandru.ardelean@analog.com> References: <20191101093505.9408-1-alexandru.ardelean@analog.com> MIME-Version: 1.0 X-ADIRoutedOnPrem: True X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.57;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(376002)(346002)(136003)(39860400002)(396003)(189003)(199004)(476003)(44832011)(2616005)(26005)(2906002)(47776003)(4326008)(246002)(126002)(305945005)(50226002)(107886003)(6666004)(356004)(7636002)(8936002)(336012)(7696005)(51416003)(70206006)(486006)(11346002)(76176011)(2870700001)(8676002)(186003)(70586007)(446003)(426003)(54906003)(86362001)(110136005)(1076003)(50466002)(36756003)(316002)(48376002)(5660300002)(478600001)(106002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR03MB2485;H:nwd2mta2.analog.com;FPR:;SPF:Pass;LANG:en;PTR:nwd2mail11.analog.com;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: df8df1cc-1c14-4c4a-3482-08d75eaecf32 X-MS-TrafficTypeDiagnostic: CY4PR03MB2485: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-Forefront-PRVS: 020877E0CB X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IpF2sffXz0MQJ+34XhxMmU9S7HdH6QAvKXMMcl16imtjhyAqYfC0VpsONy1u29VXrQtcWr2aMNIlQ49/sq9Yu9CIolYYcvEtPSOhl+Qgdv9Hqdw5+3PC9bubsnjDxG1/541qN1enxAbC6QRAi0tU/iyWMtGZ4eUG7WGb4XFQV7lT2JOc33XRsYLmO+LjZzAUTlj1GcPitBu4BhaoJcDNWUz8sFkFEBAZh5y5JFfmtI/jK9EFKRK3OdmtodXKVP23Bfb0Vu1CKR4atAiAigYqcqV8wkNh3g4z3tvNuTFVIlkPGXKopMp6xpj+dSeSwF5vlw50V4NqCRjRXd9pBdQN+UBcye/Lq8sd/GZENIPSkB6TZ3ovaOPzVx8MLOahErdUvUGQKPCd1ePzOhAoYD1nhHEHIoe//x2mcB8MxDMgyrLDuwoinS/hdGCzGI8wVsm3 X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2019 09:35:18.9298 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: df8df1cc-1c14-4c4a-3482-08d75eaecf32 X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.57];Helo=[nwd2mta2.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2485 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-11-01_03:2019-10-30,2019-11-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=868 lowpriorityscore=0 bulkscore=0 mlxscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 adultscore=0 malwarescore=0 impostorscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1911010095 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org The ADIS library functions return zero on success, and negative values for error. Positive values aren't returned, but we only care about the success value (which is zero). This change is mostly needed so that the compiler won't make any inferences about some about values being potentially un-initialized. This only triggers after making some functions inline, because the compiler can better follow return paths. Signed-off-by: Alexandru Ardelean --- drivers/iio/imu/adis16480.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c index b99d73887c9f..86801f3c5f0d 100644 --- a/drivers/iio/imu/adis16480.c +++ b/drivers/iio/imu/adis16480.c @@ -181,7 +181,7 @@ static ssize_t adis16480_show_firmware_revision(struct file *file, int ret; ret = adis_read_reg_16(&adis16480->adis, ADIS16480_REG_FIRM_REV, &rev); - if (ret < 0) + if (ret) return ret; len = scnprintf(buf, sizeof(buf), "%x.%x\n", rev >> 8, rev & 0xff); @@ -206,11 +206,11 @@ static ssize_t adis16480_show_firmware_date(struct file *file, int ret; ret = adis_read_reg_16(&adis16480->adis, ADIS16480_REG_FIRM_Y, &year); - if (ret < 0) + if (ret) return ret; ret = adis_read_reg_16(&adis16480->adis, ADIS16480_REG_FIRM_DM, &md); - if (ret < 0) + if (ret) return ret; len = snprintf(buf, sizeof(buf), "%.2x-%.2x-%.4x\n", @@ -234,7 +234,7 @@ static int adis16480_show_serial_number(void *arg, u64 *val) ret = adis_read_reg_16(&adis16480->adis, ADIS16480_REG_SERIAL_NUM, &serial); - if (ret < 0) + if (ret) return ret; *val = serial; @@ -252,7 +252,7 @@ static int adis16480_show_product_id(void *arg, u64 *val) ret = adis_read_reg_16(&adis16480->adis, ADIS16480_REG_PROD_ID, &prod_id); - if (ret < 0) + if (ret) return ret; *val = prod_id; @@ -270,7 +270,7 @@ static int adis16480_show_flash_count(void *arg, u64 *val) ret = adis_read_reg_32(&adis16480->adis, ADIS16480_REG_FLASH_CNT, &flash_count); - if (ret < 0) + if (ret) return ret; *val = flash_count; @@ -359,7 +359,7 @@ static int adis16480_get_freq(struct iio_dev *indio_dev, int *val, int *val2) reg = ADIS16480_REG_DEC_RATE; ret = adis_read_reg_16(&st->adis, reg, &t); - if (ret < 0) + if (ret) return ret; /* @@ -462,7 +462,7 @@ static int adis16480_get_calibbias(struct iio_dev *indio_dev, ret = -EINVAL; } - if (ret < 0) + if (ret) return ret; return IIO_VAL_INT; @@ -489,7 +489,7 @@ static int adis16480_get_calibscale(struct iio_dev *indio_dev, int ret; ret = adis_read_reg_16(&st->adis, reg, &val16); - if (ret < 0) + if (ret) return ret; *scale = sign_extend32(val16, 15); @@ -535,7 +535,7 @@ static int adis16480_get_filter_freq(struct iio_dev *indio_dev, enable_mask = BIT(offset + 2); ret = adis_read_reg_16(&st->adis, reg, &val); - if (ret < 0) + if (ret) return ret; if (!(val & enable_mask)) @@ -561,7 +561,7 @@ static int adis16480_set_filter_freq(struct iio_dev *indio_dev, enable_mask = BIT(offset + 2); ret = adis_read_reg_16(&st->adis, reg, &val); - if (ret < 0) + if (ret) return ret; if (freq == 0) { @@ -937,7 +937,7 @@ static int adis16480_enable_irq(struct adis *adis, bool enable) int ret; ret = adis_read_reg_16(adis, ADIS16480_REG_FNCTIO_CTRL, &val); - if (ret < 0) + if (ret) return ret; val &= ~ADIS16480_DRDY_EN_MSK; @@ -1115,7 +1115,7 @@ static int adis16480_ext_clk_config(struct adis16480 *st, int ret; ret = adis_read_reg_16(&st->adis, ADIS16480_REG_FNCTIO_CTRL, &val); - if (ret < 0) + if (ret) return ret; pin = adis16480_of_get_ext_clk_pin(st, of_node); @@ -1141,7 +1141,7 @@ static int adis16480_ext_clk_config(struct adis16480 *st, val |= mode; ret = adis_write_reg_16(&st->adis, ADIS16480_REG_FNCTIO_CTRL, val); - if (ret < 0) + if (ret) return ret; return clk_prepare_enable(st->ext_clk); From patchwork Fri Nov 1 09:35:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru Ardelean X-Patchwork-Id: 11222829 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EE65C1390 for ; Fri, 1 Nov 2019 09:35:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1E16217F9 for ; Fri, 1 Nov 2019 09:35:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=analog.onmicrosoft.com header.i=@analog.onmicrosoft.com header.b="fsigeBMI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728984AbfKAJfg (ORCPT ); Fri, 1 Nov 2019 05:35:36 -0400 Received: from mx0b-00128a01.pphosted.com ([148.163.139.77]:55582 "EHLO mx0b-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728981AbfKAJff (ORCPT ); Fri, 1 Nov 2019 05:35:35 -0400 Received: from pps.filterd (m0167091.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xA19Xdid010602; Fri, 1 Nov 2019 05:35:22 -0400 Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2058.outbound.protection.outlook.com [104.47.36.58]) by mx0b-00128a01.pphosted.com with ESMTP id 2vxwh5s4ku-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Nov 2019 05:35:22 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AkH9NbTqxuV/RUzpQkwvtu6Sd1T3c4PaKvfYD37pCd37eD/ptqT0Ayv+WbaYr//NV9pIDPNI2h5ad8VxiiMORhukCz7lOAtnlRVm6hc2XA2HXMrv2XJ89BYb0wkn2JdKnZx+K1uZoc39jYMv8uaQSZWkyQh0E5Jh8PQ2pyo5zVpzcL8V+ytRTbJpgBz47SRHvcwHn9lREjoTMwmKznQyglCcHP+Ab3SCIKRj5ZYzz5WT6e7De0OeIq62r+vpPsu2vKvbpbZnOXypq6hVTzTEc4j4o6uL4GCV+QkTJVQnF5auOVxBR+9Fwmh1I2ykU+/BvXPKFP/HlAG+LcO7G8tT5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JQvYV0WgMQqPwq0ToZ2AEKAmvjg3oPJiAnqxo+fKhrM=; b=WYcBYEFfqYvP2Xxutc82GqKfeDb18A6wvD0UOeb6qZ3MmxQJ/anZShD4nPR7YJnNzKpvX+/s0mGi0SfSCkHDOcknMxgUUKmfRsCUS66Kg8LUYp5xvyKFf/moRY/gNgyyKD9P0JD1S4s3LK81txxY+NQnh5+WN9xOR44u1bPKSfVFyhRza7LQN07KGCRceRjIKleUc65CHml2L6g53esVjwN3jMtTJgJGhPmYHMRGlzasHgM+98vJKA1n6IOrjzgNRTjPMi9kqdcA44rLvZw9AoRWfEJ27+GnHi7rmAO0B5rDVRd4BQwvDpbCDIq05UEW2Q0I2qjUCB2QFDXJfP2rjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 137.71.25.57) smtp.rcpttodomain=metafoo.de smtp.mailfrom=analog.com; dmarc=bestguesspass action=none header.from=analog.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.onmicrosoft.com; s=selector2-analog-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JQvYV0WgMQqPwq0ToZ2AEKAmvjg3oPJiAnqxo+fKhrM=; b=fsigeBMIhpPd3P084Ps2e4QH8+HLDg2O10Y0RXH7XYchBVbxd4sigHVudGQZ4+iUqUgHhbRrvL1DnXLr1DvkbwTM+T9OlK2iA0UeQk3fxEXIgsDIhZKCyh9bvX3jRLA9sUS05oFcu6ApD9m1oFa8iMpiSVyXfdRS3svCE6SKfac= Received: from CH2PR03CA0023.namprd03.prod.outlook.com (2603:10b6:610:59::33) by MN2PR03MB5103.namprd03.prod.outlook.com (2603:10b6:208:1aa::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.24; Fri, 1 Nov 2019 09:35:21 +0000 Received: from BL2NAM02FT052.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::205) by CH2PR03CA0023.outlook.office365.com (2603:10b6:610:59::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2408.18 via Frontend Transport; Fri, 1 Nov 2019 09:35:21 +0000 Received-SPF: Pass (protection.outlook.com: domain of analog.com designates 137.71.25.57 as permitted sender) receiver=protection.outlook.com; client-ip=137.71.25.57; helo=nwd2mta2.analog.com; Received: from nwd2mta2.analog.com (137.71.25.57) by BL2NAM02FT052.mail.protection.outlook.com (10.152.77.0) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2387.20 via Frontend Transport; Fri, 1 Nov 2019 09:35:20 +0000 Received: from NWD2HUBCAS7.ad.analog.com (nwd2hubcas7.ad.analog.com [10.64.69.107]) by nwd2mta2.analog.com (8.13.8/8.13.8) with ESMTP id xA19ZDSM025038 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK); Fri, 1 Nov 2019 02:35:13 -0700 Received: from saturn.ad.analog.com (10.48.65.117) by NWD2HUBCAS7.ad.analog.com (10.64.69.107) with Microsoft SMTP Server id 14.3.408.0; Fri, 1 Nov 2019 05:35:20 -0400 From: Alexandru Ardelean To: , CC: , , , , Alexandru Ardelean Subject: [PATCH 05/10] iio: imu: adis: check ret val for non-zero vs less-than-zero Date: Fri, 1 Nov 2019 11:35:00 +0200 Message-ID: <20191101093505.9408-6-alexandru.ardelean@analog.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191101093505.9408-1-alexandru.ardelean@analog.com> References: <20191101093505.9408-1-alexandru.ardelean@analog.com> MIME-Version: 1.0 X-ADIRoutedOnPrem: True X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.57;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(136003)(346002)(39860400002)(376002)(396003)(189003)(199004)(54906003)(110136005)(106002)(7636002)(70206006)(5660300002)(1076003)(316002)(36756003)(4326008)(2870700001)(2906002)(246002)(305945005)(50226002)(107886003)(50466002)(47776003)(4744005)(70586007)(426003)(8676002)(26005)(356004)(44832011)(126002)(8936002)(86362001)(486006)(2616005)(476003)(14444005)(478600001)(11346002)(446003)(6666004)(51416003)(76176011)(48376002)(186003)(336012)(7696005);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR03MB5103;H:nwd2mta2.analog.com;FPR:;SPF:Pass;LANG:en;PTR:nwd2mail11.analog.com;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9c179eb3-d8ab-48f4-84b0-08d75eaed056 X-MS-TrafficTypeDiagnostic: MN2PR03MB5103: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-Forefront-PRVS: 020877E0CB X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Q7KyG9Oln6YXAKWa7JrpUaRG9ygLCaHO/yHvGZmzt7fwylLFJo7gKasXqks8X1ZzHG+ZGcOOykrt6IZ9K5d4JBgHhQ5A+9k5e8CD/mjpmJ7x3wpGEdGewOugLembQhxFrGHtgAsJk0DqiH1gdqFCyCrlJbJlIkD4NmO/ig36KqdHoD/dynMVgR5u6jkogmB0oQEbZB4wQmfvjZ6iF9kRlAdksJQxvhHJrJ7jA2wmMSiX87t1ueIOxWf3SHPTamAHkfyqDatSWbDDc53o12g2TUSsjfSkmUx296iiVFxiaTht53mh44ztZuYfaNZMiVkJ14InXnoqb/xPsLG/H5gU4g7HDVLuzbu7/SlXMowXBPbuGImBZU8yjREcuo/3yzRzJVYB+ClEUUEl00E9TIgjg/H6PA8yg+tW0sJJ6b8oCGSgNDy2vPHUXJxl6MPMDfQF X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2019 09:35:20.8445 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9c179eb3-d8ab-48f4-84b0-08d75eaed056 X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.57];Helo=[nwd2mta2.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5103 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-11-01_03:2019-10-30,2019-11-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=826 malwarescore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1911010095 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org The ADIS library functions return zero on success, and negative values for error. Positive values aren't returned, but we only care about the success value (which is zero). This change is mostly needed so that the compiler won't make any inferences about some about values being potentially un-initialized. This only triggers after making some functions inline, because the compiler can better follow return paths. Signed-off-by: Alexandru Ardelean --- drivers/iio/imu/adis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c index 1631c255deab..dc2f9e061d98 100644 --- a/drivers/iio/imu/adis.c +++ b/drivers/iio/imu/adis.c @@ -286,7 +286,7 @@ int adis_check_status(struct adis *adis) int i; ret = adis_read_reg_16(adis, adis->data->diag_stat_reg, &status); - if (ret < 0) + if (ret) return ret; status &= adis->data->status_error_mask; From patchwork Fri Nov 1 09:35:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru Ardelean X-Patchwork-Id: 11222831 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9DBA8912 for ; Fri, 1 Nov 2019 09:35:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7158B217D9 for ; Fri, 1 Nov 2019 09:35:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=analog.onmicrosoft.com header.i=@analog.onmicrosoft.com header.b="2dixdCO4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728981AbfKAJfi (ORCPT ); Fri, 1 Nov 2019 05:35:38 -0400 Received: from mx0a-00128a01.pphosted.com ([148.163.135.77]:62556 "EHLO mx0a-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729017AbfKAJfh (ORCPT ); Fri, 1 Nov 2019 05:35:37 -0400 Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xA19Xbxx012665; Fri, 1 Nov 2019 05:35:25 -0400 Received: from nam01-sn1-obe.outbound.protection.outlook.com (mail-sn1nam01lp2057.outbound.protection.outlook.com [104.47.32.57]) by mx0a-00128a01.pphosted.com with ESMTP id 2vxwhg8u98-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Nov 2019 05:35:25 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N9W5NgVX43t1FeOUckuDnydDGS7cDiEaP4g3NO/Wo7PfGYOV9KD87qbRTzHWuCYaGW2qoKeYito9pKVJHromY1M0gRP0kOkDtmMooJ05SXPn1YrExsFpmBTdnGe3xjya9ov0XANrcO8vJfRNa1FHGoTdr9ibq0qOlWIlGjO77K2VKupMlYzm/WK4mIYx17RVFLI5wFK+zUoBjy1jAyHt+YnEC8h+EFtnI2UaJ6YGdK3zR5E20xtAdV44tssVK1yclFWWJLA730FcJJojNQg/GKBXSwjaFzczwXNyi+v8kSIG/FLL9VNOAaQCawnQ3VGVwgqi6WqCsmWTv8D255PZ/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lp+e5kDIj+xDqBrgO7a1Ln65A10nooRUSq0Uclc5CKI=; b=Ms/smMefkhUJ8SVbwRjzGTnSqDmSp46siSd6YyaaBu/I+OEgu68HREyH+3A2JDzKpjnjH+b2qo0H4TxONPmS9BKPZIDX9mbvRGdBwes+CXa3TnB5rx23lJE6B8fxk5KgFojPMPuVxSiTT7BQxx2IFWECNpPpNnLVjvISeoagcCaUqjLdHgEKUn90ZF+ZTmBUzUK8EDP0dAYwibrzVHTA9LjJUCGZSM2Qny/nQxuK2nQwIXU1PLfIeKXbee7GVl9mlUVJ6j9r8alDh+iygUewtii3wvRhWnxQpNZXhATEK5Jhu8eFbb7GHqas+lBF0nW6Jgg07rV0bhsERvSFFZGfzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 137.71.25.57) smtp.rcpttodomain=metafoo.de smtp.mailfrom=analog.com; dmarc=bestguesspass action=none header.from=analog.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.onmicrosoft.com; s=selector2-analog-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lp+e5kDIj+xDqBrgO7a1Ln65A10nooRUSq0Uclc5CKI=; b=2dixdCO4km3cUYXb6HfzpSkrEeJul+zWk5tcto1XUVfyLv7maR99J4mc8Q8DaHmwYfQm9boyfeuW7LPqtKUZBVL6Wax0FzYvy2Y6Zbs2E7VZ5Y3CGk85LWnBpKAc3yC2r6VyQVjq7+PmuP4LGNmDCSu/P5OEI9JRl3fsbT8q4bU= Received: from CY4PR03CA0002.namprd03.prod.outlook.com (2603:10b6:903:33::12) by BY5PR03MB5062.namprd03.prod.outlook.com (2603:10b6:a03:1eb::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.23; Fri, 1 Nov 2019 09:35:24 +0000 Received: from BL2NAM02FT004.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::204) by CY4PR03CA0002.outlook.office365.com (2603:10b6:903:33::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.17 via Frontend Transport; Fri, 1 Nov 2019 09:35:23 +0000 Received-SPF: Pass (protection.outlook.com: domain of analog.com designates 137.71.25.57 as permitted sender) receiver=protection.outlook.com; client-ip=137.71.25.57; helo=nwd2mta2.analog.com; Received: from nwd2mta2.analog.com (137.71.25.57) by BL2NAM02FT004.mail.protection.outlook.com (10.152.76.168) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2387.20 via Frontend Transport; Fri, 1 Nov 2019 09:35:22 +0000 Received: from NWD2HUBCAS7.ad.analog.com (nwd2hubcas7.ad.analog.com [10.64.69.107]) by nwd2mta2.analog.com (8.13.8/8.13.8) with ESMTP id xA19ZFW6025065 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK); Fri, 1 Nov 2019 02:35:15 -0700 Received: from saturn.ad.analog.com (10.48.65.117) by NWD2HUBCAS7.ad.analog.com (10.64.69.107) with Microsoft SMTP Server id 14.3.408.0; Fri, 1 Nov 2019 05:35:21 -0400 From: Alexandru Ardelean To: , CC: , , , , Alexandru Ardelean Subject: [PATCH 06/10] iio: imu: adis16480: fix indentation of return statement Date: Fri, 1 Nov 2019 11:35:01 +0200 Message-ID: <20191101093505.9408-7-alexandru.ardelean@analog.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191101093505.9408-1-alexandru.ardelean@analog.com> References: <20191101093505.9408-1-alexandru.ardelean@analog.com> MIME-Version: 1.0 X-ADIRoutedOnPrem: True X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.57;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(979002)(39860400002)(396003)(346002)(136003)(376002)(189003)(199004)(36756003)(186003)(48376002)(106002)(51416003)(486006)(44832011)(4326008)(426003)(476003)(126002)(2616005)(446003)(8936002)(50226002)(26005)(76176011)(7696005)(478600001)(107886003)(336012)(11346002)(6666004)(54906003)(356004)(50466002)(86362001)(110136005)(2906002)(5660300002)(14444005)(246002)(4744005)(70586007)(8676002)(316002)(305945005)(70206006)(7636002)(1076003)(47776003)(2870700001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY5PR03MB5062;H:nwd2mta2.analog.com;FPR:;SPF:Pass;LANG:en;PTR:nwd2mail11.analog.com;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 236ba2c5-4455-4136-cbec-08d75eaed186 X-MS-TrafficTypeDiagnostic: BY5PR03MB5062: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3173; X-Forefront-PRVS: 020877E0CB X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ClKcIbrX8+cJKiLkbQ9U6EdCOxvLSXCYq57GAcnOkMJTgvUj6bBlx966TM8UNnXrJU4Mui3XX6G11pC615j0ebiQmnt0bSHPShHk0A7WIeYsLVy+H3f5NwMWHh/ZMp6IsMNDxZFBpEOSsRTV8dxbwBQtHsgOYA96Cw40YQuFwe498mkHCd0Uac7cD2xFT3B/YswWr/ub4Rwn9giwXTJH13uFtOyIQvK24skSVi12ubU3ahTQpDthg8H2wDQ7F/vqyUGscxfsG8YEi/ccwdRUHrRL64+gWnMijEQi+Thzchi0bLDpyyqrgGMyGaJvvBj/Ar8T2ZUilm3j9RwjNlwTO3KQQD8oCR4pYPh5rvtEtqqKFfk+YjmCi9yIa2WpNle39FkmUN1BxSnFC3aJSqq4lwIB5ApXZ68w/jFVX0pYSHPjNHFkFVuKhpdSllVm77jf X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2019 09:35:22.8396 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 236ba2c5-4455-4136-cbec-08d75eaed186 X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.57];Helo=[nwd2mta2.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5062 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-11-01_03:2019-10-30,2019-11-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0 spamscore=0 impostorscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 priorityscore=1501 malwarescore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1911010095 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org This is just a minor indentation/alignment fix for the default case of a switch statement. Signed-off-by: Alexandru Ardelean --- drivers/iio/imu/adis16480.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c index 86801f3c5f0d..d199d3d3c4bd 100644 --- a/drivers/iio/imu/adis16480.c +++ b/drivers/iio/imu/adis16480.c @@ -459,7 +459,7 @@ static int adis16480_get_calibbias(struct iio_dev *indio_dev, *bias = sign_extend32(val32, 31); break; default: - ret = -EINVAL; + ret = -EINVAL; } if (ret) From patchwork Fri Nov 1 09:35:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru Ardelean X-Patchwork-Id: 11222841 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5E90A14E5 for ; Fri, 1 Nov 2019 09:36:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3CA0D218DE for ; Fri, 1 Nov 2019 09:36:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=analog.onmicrosoft.com header.i=@analog.onmicrosoft.com header.b="P2MUnBRB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729085AbfKAJfn (ORCPT ); Fri, 1 Nov 2019 05:35:43 -0400 Received: from mx0a-00128a01.pphosted.com ([148.163.135.77]:64478 "EHLO mx0a-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729017AbfKAJfk (ORCPT ); Fri, 1 Nov 2019 05:35:40 -0400 Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xA19XUH6003902; Fri, 1 Nov 2019 05:35:28 -0400 Received: from nam01-bn3-obe.outbound.protection.outlook.com (mail-bn3nam01lp2054.outbound.protection.outlook.com [104.47.33.54]) by mx0a-00128a01.pphosted.com with ESMTP id 2vxwhjrw1a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Nov 2019 05:35:28 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RUZzslhYVj6yXtz9+F/7VKSgw1ZUDitufuPpGs/vIzFug8TLKlNz/25Wv9Y3XHng3cM6jDg8VoA+sIhthmHE0/TzgBqdT/9l43kHpA1AzX9FCePxDCvNCcBk1VRRADoMbP1OZC5ZOPzqnD/95Eb4lC0vSYNsUbVuLsSlDsMqqHI+59rh5PSU2LK1k1wsq5UhxOkoDO62ZRGsJ7hdG+NENr751+ldLP04BULqbr3GdW/Hti+wxIoY6mzkb/KgQosIyTrwBcnaeC/8pETwqpHP9FscCAWdezzXLrFRTVQaQQMKPgczHgCvw/8+jqbViCyQ/zhkxbvKx3rpD1zlGjDcIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iutoMGZBZJr043uZlhisldR32lkJFHY26oYznxwowBA=; b=VG8oqZoXF/ayBSqh6y9kDdN2KQmzXUtjGuNiY65Zf/6PW8cXFOYCwtHOvYyIEs1cxAStSsFsib971gi4A9pvOniwdF0Rd3MjIsU5PgQqptXggIbyDA7ifBV2NNs5sgcKxB7hfSL7m9o7zeWW4iy9HFXhYUpX2fxBxt2eUqeGL5Q8i7xqh1EaDAbQAKEUUNJnBrANaZSkmPdRwgrU1kg81aFm+4BHbfs6BUfQRbyjG5uSN7SYtaf8J77yfkdVFHPOQBdsP9tu8C7zC5A2XkIKqhUFjcFZg+yP4QY2LyapXx7gY9HmFwNXooA3HJfzVyU3EnB2BmKgR9LJPDN/PfveZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 137.71.25.57) smtp.rcpttodomain=metafoo.de smtp.mailfrom=analog.com; dmarc=bestguesspass action=none header.from=analog.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.onmicrosoft.com; s=selector2-analog-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iutoMGZBZJr043uZlhisldR32lkJFHY26oYznxwowBA=; b=P2MUnBRBiUa0Y/4WyacpOQJH+dKbxKwMdPCPmsnqHHwPvyyFIWymah1POGHir8GyILxjguhKrsVmE5/lykpVMigu+w6jiKIPtLZEsJJw+m76FuLB1Z8xCDW7Chlm0NlHlosWGpHref4NcxuNKeXBDbcvDbjGtEvJiV6Q29kd+RM= Received: from CY4PR03CA0092.namprd03.prod.outlook.com (2603:10b6:910:4d::33) by MWHPR03MB3101.namprd03.prod.outlook.com (2603:10b6:301:3c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.24; Fri, 1 Nov 2019 09:35:26 +0000 Received: from BL2NAM02FT044.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::206) by CY4PR03CA0092.outlook.office365.com (2603:10b6:910:4d::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2408.21 via Frontend Transport; Fri, 1 Nov 2019 09:35:25 +0000 Received-SPF: Pass (protection.outlook.com: domain of analog.com designates 137.71.25.57 as permitted sender) receiver=protection.outlook.com; client-ip=137.71.25.57; helo=nwd2mta2.analog.com; Received: from nwd2mta2.analog.com (137.71.25.57) by BL2NAM02FT044.mail.protection.outlook.com (10.152.77.35) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2387.20 via Frontend Transport; Fri, 1 Nov 2019 09:35:24 +0000 Received: from NWD2HUBCAS7.ad.analog.com (nwd2hubcas7.ad.analog.com [10.64.69.107]) by nwd2mta2.analog.com (8.13.8/8.13.8) with ESMTP id xA19ZHIM025084 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK); Fri, 1 Nov 2019 02:35:17 -0700 Received: from saturn.ad.analog.com (10.48.65.117) by NWD2HUBCAS7.ad.analog.com (10.64.69.107) with Microsoft SMTP Server id 14.3.408.0; Fri, 1 Nov 2019 05:35:23 -0400 From: Alexandru Ardelean To: , CC: , , , , Alexandru Ardelean Subject: [PATCH 07/10] iio: imu: adis16480: prefer `unsigned int` over `unsigned` Date: Fri, 1 Nov 2019 11:35:02 +0200 Message-ID: <20191101093505.9408-8-alexandru.ardelean@analog.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191101093505.9408-1-alexandru.ardelean@analog.com> References: <20191101093505.9408-1-alexandru.ardelean@analog.com> MIME-Version: 1.0 X-ADIRoutedOnPrem: True X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.57;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(39860400002)(136003)(346002)(376002)(396003)(189003)(199004)(86362001)(4326008)(54906003)(4744005)(47776003)(5660300002)(316002)(356004)(6666004)(14444005)(8936002)(26005)(50226002)(2906002)(478600001)(246002)(50466002)(70586007)(336012)(76176011)(51416003)(44832011)(305945005)(7636002)(70206006)(48376002)(106002)(107886003)(1076003)(36756003)(476003)(2870700001)(486006)(446003)(126002)(2616005)(110136005)(11346002)(426003)(7696005)(186003)(8676002)(81973001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR03MB3101;H:nwd2mta2.analog.com;FPR:;SPF:Pass;LANG:en;PTR:nwd2mail11.analog.com;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5fc5e79e-322c-46d6-bcd8-08d75eaed2b6 X-MS-TrafficTypeDiagnostic: MWHPR03MB3101: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2276; X-Forefront-PRVS: 020877E0CB X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i/JV8M5uGIfCaK9pTPk8c0+eFK9TMwNYqS33Re1aShqZB2lP9H6A7/cFH5ycxTiZCqyKaDT7vf8JEdULaCuSO27Klx68+98ysmYgsv+HWw017BOW9VNwH+BlejnKb2kobOqnOmcZBSaBorF6SltkxOoNx4rjCXap37cnOAOQTO3cPU2dKhfrxdHUO8AIr3ktUqtH3/ia4O0B9yZLxl8uaQCp//5jTYnCycxcam8rbWbYNf3rn17qqveBgE+jRm9YUMvuvggKXqZw41M/O8JPskGA1GnTB39WZM8tYc0NkH8FmIsDRDCMNU37cMUm9rB/L3Olke0rYk9v+Y3ig3QYt/WXOCy5zXHDZIh5i3ooVviViFdA0/DTIugKyHnP4Fej1XjISfgwLaLFkTAu50rQeW8S8W7MFdEwT/bab4SsqigEf6HDzDvB8n8WcnKRYKkB X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2019 09:35:24.8305 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5fc5e79e-322c-46d6-bcd8-08d75eaed2b6 X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.57];Helo=[nwd2mta2.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB3101 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-11-01_03:2019-10-30,2019-11-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxlogscore=923 priorityscore=1501 adultscore=0 mlxscore=0 malwarescore=0 bulkscore=0 spamscore=0 phishscore=0 clxscore=1015 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1911010095 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org This is a typical checkpatch warning. The change just renames the type of the `freq` var to `unsigned int`. Signed-off-by: Alexandru Ardelean --- drivers/iio/imu/adis16480.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c index d199d3d3c4bd..b9e2695bcfad 100644 --- a/drivers/iio/imu/adis16480.c +++ b/drivers/iio/imu/adis16480.c @@ -350,7 +350,7 @@ static int adis16480_get_freq(struct iio_dev *indio_dev, int *val, int *val2) struct adis16480 *st = iio_priv(indio_dev); uint16_t t; int ret; - unsigned freq; + unsigned int freq; unsigned int reg; if (st->clk_mode == ADIS16480_CLK_PPS) From patchwork Fri Nov 1 09:35:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru Ardelean X-Patchwork-Id: 11222833 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EF550912 for ; Fri, 1 Nov 2019 09:35:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C361821734 for ; Fri, 1 Nov 2019 09:35:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=analog.onmicrosoft.com header.i=@analog.onmicrosoft.com header.b="J3Q01ClS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729076AbfKAJfn (ORCPT ); Fri, 1 Nov 2019 05:35:43 -0400 Received: from mx0a-00128a01.pphosted.com ([148.163.135.77]:65220 "EHLO mx0a-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729072AbfKAJfm (ORCPT ); Fri, 1 Nov 2019 05:35:42 -0400 Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xA19XUH7003902; Fri, 1 Nov 2019 05:35:30 -0400 Received: from nam04-co1-obe.outbound.protection.outlook.com (mail-co1nam04lp2057.outbound.protection.outlook.com [104.47.45.57]) by mx0a-00128a01.pphosted.com with ESMTP id 2vxwhjrw1c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Nov 2019 05:35:29 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ejILztXPFyFbl9bvv6vri1e3hHL61ef7ZLic+XB8Y4teCYynL0Y3TVqguoH8TQPSmfM6tO26H/tl7C9fVa/CLHdNmP11C6KGMGbirVab+4fihRPpptaCNF+NAOKxq6LBuROS7tlmMONOersTSd1sdDoE2kU3hY2zPv2zdT6c6ymdupE7lwSkRaZDIO5AkGe+SI2CbndbwEV6SmCCb10smrUq8ZMUwl2vCjPTqkUdUQi0S87NzdKNYZD4tz8giVTdkJ3IkXacf6ekSmfsAoYltG++Ond2EYmkN3GtsLLhG8Wp/yBmWrZdIggfhUla1PUeBro6A5hn3FX2pHoFs0eiYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZAEsj+9LhmJetlL3s1pIRNs7VvOSWs4OtR+XG031FlI=; b=UZNsqRO0jjQo+LIayQP9RAo3dokLPUGjfmWgu5gXo7mmvBwTMCEquVsjDE9emXyt+hwfEljpWOVA0v2HX+8vwThBdNcn7t+E2zJwUy9YtiaYCmNIW89NgNXSPK88aKPPAW1gXlu8e2qMy6Pigm7YcQXQ051B6Xk8Epam02MYqq0ah/TsPHiJNpc79+RBwKrhettNOA2UzoO8KdDC7Vl8HAAR+0CdsPSAgKuf336v8QHyvXm/4EjQwWdp6qKFWTw+d7dcn+66B8SYGdxVW+0YzSRNmW0LOUnv03L9iy88lWdzZAjkxBNYf6L6AJyFkUVXbymYdbgK4BOnlawux/eIZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 137.71.25.57) smtp.rcpttodomain=metafoo.de smtp.mailfrom=analog.com; dmarc=bestguesspass action=none header.from=analog.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.onmicrosoft.com; s=selector2-analog-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZAEsj+9LhmJetlL3s1pIRNs7VvOSWs4OtR+XG031FlI=; b=J3Q01ClSvCrhJE9KX/q5VoIXqnwGOEKAueYQUwa7odJWgbWzO1eh3RNNECXgKiBBJez26iJTTiNO7IY51OCsvkLAOOBwcjZuCYlASpAw6Wrl3SQdEh/1CAb9J1476mkF5LcRrI+cfaTW8dXHZlgajysbAcgIxIAtLRmci2PDU8w= Received: from CY4PR03CA0010.namprd03.prod.outlook.com (2603:10b6:903:33::20) by MN2PR03MB4622.namprd03.prod.outlook.com (2603:10b6:208:af::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.22; Fri, 1 Nov 2019 09:35:28 +0000 Received: from CY1NAM02FT063.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::209) by CY4PR03CA0010.outlook.office365.com (2603:10b6:903:33::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.20 via Frontend Transport; Fri, 1 Nov 2019 09:35:28 +0000 Received-SPF: Pass (protection.outlook.com: domain of analog.com designates 137.71.25.57 as permitted sender) receiver=protection.outlook.com; client-ip=137.71.25.57; helo=nwd2mta2.analog.com; Received: from nwd2mta2.analog.com (137.71.25.57) by CY1NAM02FT063.mail.protection.outlook.com (10.152.75.161) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2387.20 via Frontend Transport; Fri, 1 Nov 2019 09:35:27 +0000 Received: from NWD2HUBCAS7.ad.analog.com (nwd2hubcas7.ad.analog.com [10.64.69.107]) by nwd2mta2.analog.com (8.13.8/8.13.8) with ESMTP id xA19ZJlH025103 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK); Fri, 1 Nov 2019 02:35:19 -0700 Received: from saturn.ad.analog.com (10.48.65.117) by NWD2HUBCAS7.ad.analog.com (10.64.69.107) with Microsoft SMTP Server id 14.3.408.0; Fri, 1 Nov 2019 05:35:25 -0400 From: Alexandru Ardelean To: , CC: , , , , Alexandru Ardelean Subject: [PATCH 08/10] iio: imu: adis16480: assign bias value only if operation succeeded Date: Fri, 1 Nov 2019 11:35:03 +0200 Message-ID: <20191101093505.9408-9-alexandru.ardelean@analog.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191101093505.9408-1-alexandru.ardelean@analog.com> References: <20191101093505.9408-1-alexandru.ardelean@analog.com> MIME-Version: 1.0 X-ADIRoutedOnPrem: True X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.57;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(136003)(376002)(346002)(396003)(39860400002)(199004)(189003)(8936002)(110136005)(316002)(51416003)(54906003)(106002)(246002)(1076003)(50226002)(7696005)(76176011)(8676002)(5660300002)(47776003)(2870700001)(70206006)(36756003)(305945005)(7636002)(478600001)(50466002)(107886003)(446003)(336012)(26005)(2616005)(86362001)(476003)(126002)(2906002)(486006)(356004)(11346002)(426003)(44832011)(70586007)(186003)(4326008)(6666004)(48376002);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR03MB4622;H:nwd2mta2.analog.com;FPR:;SPF:Pass;LANG:en;PTR:nwd2mail11.analog.com;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f8a33a64-4a55-47f3-d6ac-08d75eaed420 X-MS-TrafficTypeDiagnostic: MN2PR03MB4622: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-Forefront-PRVS: 020877E0CB X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dBN1Z7l4qo7q28vJhmI/KF2amc/WZ1fbra4GXDPlsVF7NzQgUnmUs3NSybG+HHapRSoCiEfrnAb6dgkghp7PNsF6LVuygVzFQqRPkYtb1sN6H72iDNOVkNZ6TdLCmeBjMTr7ly00ZF26l3HqFPk/Kqi9mgqheKsO3UFhboE4yJ+rpPW23FWpBsbK3rHDIqOtdQfuBSq8yYuQObaRhozne6jgpLvi0jibUSpYLKoPixO2Lcep/ablAblRk9dhuduLpszqEpuwQAqx/65nQhM/NvwgRuz7uSG+OxrH3t3YaH+ucttL1eqzo61hCxxmnZDn3nAnnJIR0SfUH3sSzSll0AGMuDMe2FilzEa8RXVQ9c3OlawGHbDmXa0mm0kodh0EUSPQJ2XMZG8jgGKtwgZstDuNcXild0vPOevLkFmYuXnaC0smVi6ilFs+yaJC+ixK X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2019 09:35:27.1285 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f8a33a64-4a55-47f3-d6ac-08d75eaed420 X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.57];Helo=[nwd2mta2.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4622 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-11-01_03:2019-10-30,2019-11-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxlogscore=999 priorityscore=1501 adultscore=0 mlxscore=0 malwarescore=0 bulkscore=0 spamscore=0 phishscore=0 clxscore=1015 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1911010095 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org This was found only after the whole thing with the inline functions, but the compiler actually found something. The value of the `bias` (in adis16480_get_calibbias()) should only be set if the read operation was successful. Fixes: 2f3abe6cbb6c9 ("iio:imu: Add support for the ADIS16480 and similar IMUs") Signed-off-by: Alexandru Ardelean --- drivers/iio/imu/adis16480.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c index b9e2695bcfad..c0e7e768be41 100644 --- a/drivers/iio/imu/adis16480.c +++ b/drivers/iio/imu/adis16480.c @@ -451,12 +451,14 @@ static int adis16480_get_calibbias(struct iio_dev *indio_dev, case IIO_MAGN: case IIO_PRESSURE: ret = adis_read_reg_16(&st->adis, reg, &val16); - *bias = sign_extend32(val16, 15); + if (ret == 0) + *bias = sign_extend32(val16, 15); break; case IIO_ANGL_VEL: case IIO_ACCEL: ret = adis_read_reg_32(&st->adis, reg, &val32); - *bias = sign_extend32(val32, 31); + if (ret == 0) + *bias = sign_extend32(val32, 31); break; default: ret = -EINVAL; From patchwork Fri Nov 1 09:35:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru Ardelean X-Patchwork-Id: 11222837 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DA0CB1390 for ; Fri, 1 Nov 2019 09:35:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF04B218AC for ; Fri, 1 Nov 2019 09:35:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=analog.onmicrosoft.com header.i=@analog.onmicrosoft.com header.b="KpZ2pVCO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729205AbfKAJf4 (ORCPT ); Fri, 1 Nov 2019 05:35:56 -0400 Received: from mx0b-00128a01.pphosted.com ([148.163.139.77]:63116 "EHLO mx0b-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729074AbfKAJfn (ORCPT ); Fri, 1 Nov 2019 05:35:43 -0400 Received: from pps.filterd (m0167090.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xA19YdbW027913; Fri, 1 Nov 2019 05:35:31 -0400 Received: from nam05-dm3-obe.outbound.protection.outlook.com (mail-dm3nam05lp2055.outbound.protection.outlook.com [104.47.49.55]) by mx0b-00128a01.pphosted.com with ESMTP id 2vxwgwh8x6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 01 Nov 2019 05:35:31 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kEUv508WoVmq9vA7vGRAjBTTPpQblcdKpYHBdoB0tbHQkxEX3GmUhIjuEvMvXG8XngOQxJ7xnvcZugNSnULdzLIMbR7GSdY72VvuAuA0ez+lQxD9LQCExs/Wt0yWqzEsVN2q+coiqBA+jNRxKC6OhWEi4g+7VEPubsCeOiwEEo4Me++spkYcV72vD2EBstEzazV3EYgYfljCghrgPMnFphVAwRB9B3tCK8I7E6KPr+Ru/1pYvHENecriIljuuRj3OfjUmIN1cw4nJgv/0MNXNAPURTYECiYjjgSrxu4LORy3hS9MypCZEIlMlAcD61ZdRKJomDnqeADJuRTZUp9OHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tb7UZOr139aoTeDFSnbx1h6lLPxo8UuX3qcWC9LfMzE=; b=YUMX1KqgLtiWzM/4Q+oKCyiJy7hKWbvQEpnFGeLwubhIo5710cOHydskZaA6u2CL7+BGwY1oKBzBKT2CRK2ccvOcY1j69c+YpbETKxbwQZiNNJaZW7G/y1+rfuaCRpbQEDZkdiu2yD7AYdAOSIKzGoM10cItjFEM6clArhgDGcavxTlPc9AXvn+Gr3KAYTL9Y06FLNVzq9KnDoWOdctrIJm3X6j8jzTC1Qyh+P/QBg6XouE0bwBiEYuc1L2LBF4f5kCLK5jXBFMrXeuJoYkzR+64A5T7Elnn9Yw/u7QP95LOBch/q2KCPsk5nMGrtdFJRS9gceWbUQzb32bTFdFffQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 137.71.25.57) smtp.rcpttodomain=metafoo.de smtp.mailfrom=analog.com; dmarc=bestguesspass action=none header.from=analog.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.onmicrosoft.com; s=selector2-analog-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tb7UZOr139aoTeDFSnbx1h6lLPxo8UuX3qcWC9LfMzE=; b=KpZ2pVCOGdc9w+4HWmO/nGk2jfrS2KGbACVA6TO/0hfrHniEnHT/DAl/d1Bu9il8/O0ob6H94vzitF6oWTp5yS8eZ7DJWkHcH0hBor9aWE0QvUooGWe4VjT+0PjuHBalMCUggE1uxWofBp/skFNXvK3kcb9jNlBOQwTOI3Q3LwY= Received: from CY4PR03CA0013.namprd03.prod.outlook.com (2603:10b6:903:33::23) by CY4PR03MB2534.namprd03.prod.outlook.com (2603:10b6:903:39::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.17; Fri, 1 Nov 2019 09:35:29 +0000 Received: from CY1NAM02FT027.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::206) by CY4PR03CA0013.outlook.office365.com (2603:10b6:903:33::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.20 via Frontend Transport; Fri, 1 Nov 2019 09:35:29 +0000 Received-SPF: Pass (protection.outlook.com: domain of analog.com designates 137.71.25.57 as permitted sender) receiver=protection.outlook.com; client-ip=137.71.25.57; helo=nwd2mta2.analog.com; Received: from nwd2mta2.analog.com (137.71.25.57) by CY1NAM02FT027.mail.protection.outlook.com (10.152.75.159) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2387.20 via Frontend Transport; Fri, 1 Nov 2019 09:35:29 +0000 Received: from NWD2HUBCAS7.ad.analog.com (nwd2hubcas7.ad.analog.com [10.64.69.107]) by nwd2mta2.analog.com (8.13.8/8.13.8) with ESMTP id xA19ZLDs025106 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK); Fri, 1 Nov 2019 02:35:21 -0700 Received: from saturn.ad.analog.com (10.48.65.117) by NWD2HUBCAS7.ad.analog.com (10.64.69.107) with Microsoft SMTP Server id 14.3.408.0; Fri, 1 Nov 2019 05:35:27 -0400 From: Alexandru Ardelean To: , CC: , , , , Alexandru Ardelean Subject: [PATCH 09/10] iio: imu: adis: assign read val in debugfs hook only if op successful Date: Fri, 1 Nov 2019 11:35:04 +0200 Message-ID: <20191101093505.9408-10-alexandru.ardelean@analog.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191101093505.9408-1-alexandru.ardelean@analog.com> References: <20191101093505.9408-1-alexandru.ardelean@analog.com> MIME-Version: 1.0 X-ADIRoutedOnPrem: True X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.57;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(39860400002)(376002)(346002)(396003)(136003)(189003)(199004)(2906002)(51416003)(476003)(446003)(50466002)(44832011)(2616005)(426003)(126002)(2870700001)(48376002)(11346002)(246002)(356004)(106002)(50226002)(6666004)(8936002)(486006)(1076003)(47776003)(7696005)(316002)(4326008)(336012)(36756003)(8676002)(76176011)(86362001)(70206006)(305945005)(14444005)(186003)(7636002)(70586007)(107886003)(5660300002)(4744005)(54906003)(478600001)(110136005)(26005);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR03MB2534;H:nwd2mta2.analog.com;FPR:;SPF:Pass;LANG:en;PTR:nwd2mail11.analog.com;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5bb042c9-b3ae-43d9-708f-08d75eaed550 X-MS-TrafficTypeDiagnostic: CY4PR03MB2534: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-Forefront-PRVS: 020877E0CB X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pIIdAczUE7w/vRewBnabEjHetvGue8DPtV4dN89Drwu9njoroLYyAOGuRUU2cUeIuHBaoBjddO6s1DomIhdVdkduv68Rz/0UKjBw0kVe4p3hV026QBwmZFNCFPEi5nROWn+pmVv63NpP01hbXPlE6J/rr+/3E6EklpMHCtOZ3LVhd7KZgqwIfMIEX5T0bCC1RQncpxe9RFrCGw1zJh8f/i0KQFEAbZcGPAGNOyQODH9jkBXChluqixM6WJSCRjYnROEJELFOFuZwTU9GroC67XbA3HhZ/T+Wc+rv8LH0SmYiQrmO97Zzzk0we9DDw4CU3yqxPoG5UZo46SEuGiYwJMVbAoxisVGS5xKERbHNPj7qhXentXIN+cZyCXER+jm/GloEC9qZVVWOiQo78ytxxNnq/QzsdeuQGjEqR41VpoHi8FC5rAH1krNAmCNsLiYO X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2019 09:35:29.1162 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5bb042c9-b3ae-43d9-708f-08d75eaed550 X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.57];Helo=[nwd2mta2.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2534 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-11-01_03:2019-10-30,2019-11-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 lowpriorityscore=0 bulkscore=0 mlxscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 adultscore=0 malwarescore=0 impostorscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1911010095 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org This was also caught by the `-Wmaybe-uninitialized` warning, which (ironically as-is) it makes quite a lot of sense to do for this. Fixes: 78026a6fde8f7 ("iio:imu:adis: Add debugfs register access support") Signed-off-by: Alexandru Ardelean --- drivers/iio/imu/adis.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c index dc2f9e061d98..85de565a4e80 100644 --- a/drivers/iio/imu/adis.c +++ b/drivers/iio/imu/adis.c @@ -229,7 +229,8 @@ int adis_debugfs_reg_access(struct iio_dev *indio_dev, int ret; ret = adis_read_reg_16(adis, reg, &val16); - *readval = val16; + if (ret == 0) + *readval = val16; return ret; } else { From patchwork Fri Nov 1 09:35:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru Ardelean X-Patchwork-Id: 11222839 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1B1F6912 for ; Fri, 1 Nov 2019 09:36:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3084218DE for ; Fri, 1 Nov 2019 09:36:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=analog.onmicrosoft.com header.i=@analog.onmicrosoft.com header.b="RQBZgM2f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728901AbfKAJf4 (ORCPT ); Fri, 1 Nov 2019 05:35:56 -0400 Received: from mx0b-00128a01.pphosted.com ([148.163.139.77]:65500 "EHLO mx0b-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729121AbfKAJfq (ORCPT ); Fri, 1 Nov 2019 05:35:46 -0400 Received: from pps.filterd (m0167090.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xA19XOcH026879; Fri, 1 Nov 2019 05:35:34 -0400 Received: from nam03-dm3-obe.outbound.protection.outlook.com (mail-dm3nam03lp2057.outbound.protection.outlook.com [104.47.41.57]) by mx0b-00128a01.pphosted.com with ESMTP id 2vxwgwh8x8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 01 Nov 2019 05:35:34 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RK1MYycEewj6hEsfN1BfA8wh73uXtfvma7Fuhp1ajqVLBQRl3RRXfzV4cwegNFiPXQVdTp1Sn7+NdgQRrpWHMYGqUb9zYoQqOjZh5H6no62gdx8Fs6AW+NmWaxqEIGCjbVEdfEDc7cHSyQ+hmZuNqtvceCTVVzuvooRcwMevVqhGm/BUK9lTF6s5TvgqVCNtLRjMVm0EnbtPFIzQu6w8uuuC+RVfMMulwKVrom3RmUcyRgpe2GlwdO/r2Ps3dEqEYZC7rb41w+L1no87lHxYmbjimWyNQm69pL0og/BqmIAaAkYoMLe3o3w/g9o9KIA15eyO5OX/fzaBXnjD/OR6Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mNVqn/wOghXwSVSvCsoW0WLZEJQ+8rG4X/dJV39Dcj0=; b=LoHgZbOgK4rEM4h1zHSjB6yNdbMTx6Mg/PKh6rtMMoCeaHYgHvv/70Buz9jTG824L0rUNcqz1QrKlJOpHrSrqjDk1syxz80Yd5z18KZMCSbFbxF5ETMWJCHbC2Pp+D1VSjB9BDu0Af8IXHePbvmv7nEDnqIYy+OI/zJocrV1F0tlKhjhvFI7XtgguQ4u/rkVGUS3knIAffJfdSm9+nu4XlR3IpaoPzNXiLgSfXY95nsqNTnFIyEc1gCY5cj5/gG27Dz5+k4TqTbajMQAbNL8SlCoO00K6lu7qC+mZL930n5aCtQEeBPmu7SPeOARSx6WvuJ+yR8cx6Hb8ZqCR8d94g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 137.71.25.57) smtp.rcpttodomain=metafoo.de smtp.mailfrom=analog.com; dmarc=bestguesspass action=none header.from=analog.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.onmicrosoft.com; s=selector2-analog-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mNVqn/wOghXwSVSvCsoW0WLZEJQ+8rG4X/dJV39Dcj0=; b=RQBZgM2f8rPFwYyUgGz1nQ00aJvSFhD2QFUUgL+onTogVkIn+LPv5H2zF+iy0FhtncK2k6QY0wOZop3bq057/e4xlGkrtmlc4EoQL3rGsvQgkaNohHpB/jDJ0EblC+lPDNHgyUcRTDLNolxRoAO0qcTtlUAkhHAfmXSBtRn7gJQ= Received: from DM6PR03CA0048.namprd03.prod.outlook.com (2603:10b6:5:100::25) by SN6PR03MB3646.namprd03.prod.outlook.com (2603:10b6:805:42::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.23; Fri, 1 Nov 2019 09:35:31 +0000 Received: from CY1NAM02FT064.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::207) by DM6PR03CA0048.outlook.office365.com (2603:10b6:5:100::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.20 via Frontend Transport; Fri, 1 Nov 2019 09:35:31 +0000 Received-SPF: Pass (protection.outlook.com: domain of analog.com designates 137.71.25.57 as permitted sender) receiver=protection.outlook.com; client-ip=137.71.25.57; helo=nwd2mta2.analog.com; Received: from nwd2mta2.analog.com (137.71.25.57) by CY1NAM02FT064.mail.protection.outlook.com (10.152.74.64) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2387.20 via Frontend Transport; Fri, 1 Nov 2019 09:35:31 +0000 Received: from NWD2HUBCAS7.ad.analog.com (nwd2hubcas7.ad.analog.com [10.64.69.107]) by nwd2mta2.analog.com (8.13.8/8.13.8) with ESMTP id xA19ZNc9025109 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK); Fri, 1 Nov 2019 02:35:23 -0700 Received: from saturn.ad.analog.com (10.48.65.117) by NWD2HUBCAS7.ad.analog.com (10.64.69.107) with Microsoft SMTP Server id 14.3.408.0; Fri, 1 Nov 2019 05:35:29 -0400 From: Alexandru Ardelean To: , CC: , , , , Alexandru Ardelean Subject: [PATCH 10/10] iio: imu: adis: assign value only if return code zero in read funcs Date: Fri, 1 Nov 2019 11:35:05 +0200 Message-ID: <20191101093505.9408-11-alexandru.ardelean@analog.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191101093505.9408-1-alexandru.ardelean@analog.com> References: <20191101093505.9408-1-alexandru.ardelean@analog.com> MIME-Version: 1.0 X-ADIRoutedOnPrem: True X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.57;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(396003)(136003)(39860400002)(376002)(346002)(199004)(189003)(50226002)(186003)(356004)(6666004)(316002)(2870700001)(26005)(7696005)(4326008)(106002)(2906002)(36756003)(5660300002)(107886003)(54906003)(76176011)(48376002)(51416003)(110136005)(70586007)(44832011)(446003)(476003)(50466002)(7636002)(336012)(1076003)(70206006)(47776003)(426003)(86362001)(8676002)(2616005)(486006)(478600001)(8936002)(246002)(126002)(305945005)(11346002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN6PR03MB3646;H:nwd2mta2.analog.com;FPR:;SPF:Pass;LANG:en;PTR:nwd2mail11.analog.com;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e5a09f80-5e48-4fd7-2552-08d75eaed685 X-MS-TrafficTypeDiagnostic: SN6PR03MB3646: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-Forefront-PRVS: 020877E0CB X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h6UmQ/FyOjyVO77P2DzpBUmQRD/P/tfD4WwCk8ASEWMuSLgM3+gezoNCKZJNKibAlnMLh0Vkur/2mM3m/tvSG3HvFYTmaJn0LcgvFOSSSV1BttoWGigZpX6YHCPzdzPHjGx5OiuwT5o3BBR/860AKNssiMVJA0Z/wCIGgQpjINqSY0Ifqr0mF0oOhOy3ij0eLL+z/doB4ji0JrJ7jGuXD++lVnVTuNw5ZuImIywyqowEP06kZr65f/aULWcHeBfM7ISPT6cSaLnBg+OQL2p57rpIm+CuZx2wbAR/s2pisHfR6BfnuDpvHJ4EK4w49S2/Ln1irBiiHhKa6wg8MjLKR0kQMuFteGjiDfY+g5TIyJgfDAgFjXWvvgEbPJ6Z0WI9Zdqkb+cKaPKRRYN+oguOTlMq8lqxPUFooCN99Bhyk4olawxX+LJJHXLiCv/r9cmM X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2019 09:35:31.1384 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e5a09f80-5e48-4fd7-2552-08d75eaed685 X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.57];Helo=[nwd2mta2.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3646 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-11-01_03:2019-10-30,2019-11-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=928 lowpriorityscore=0 bulkscore=0 mlxscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 adultscore=0 malwarescore=0 impostorscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1911010095 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org The inline read functions in the ADIS library don't check the return value of the `adis_read_reg()` function and assign the value of `tmp` regardless. Fix this by checking if return value is zero and only then assigning the value of `tmp`. Fixes: 57a1228a06b7a ("iio:imu:adis: Add support for 32bit registers") Signed-off-by: Alexandru Ardelean --- include/linux/iio/imu/adis.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux/iio/imu/adis.h b/include/linux/iio/imu/adis.h index 4c53815bb729..92aae14593bf 100644 --- a/include/linux/iio/imu/adis.h +++ b/include/linux/iio/imu/adis.h @@ -129,7 +129,8 @@ static inline int adis_read_reg_16(struct adis *adis, unsigned int reg, int ret; ret = adis_read_reg(adis, reg, &tmp, 2); - *val = tmp; + if (ret == 0) + *val = tmp; return ret; } @@ -147,7 +148,8 @@ static inline int adis_read_reg_32(struct adis *adis, unsigned int reg, int ret; ret = adis_read_reg(adis, reg, &tmp, 4); - *val = tmp; + if (ret == 0) + *val = tmp; return ret; }