From patchwork Fri Nov 1 19:06:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jean-Fran=C3=A7ois_Dagenais?= X-Patchwork-Id: 11223611 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E9D7E1390 for ; Fri, 1 Nov 2019 19:07:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C81E3218AC for ; Fri, 1 Nov 2019 19:07:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ko9UsUUa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727577AbfKATHX (ORCPT ); Fri, 1 Nov 2019 15:07:23 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:40320 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726671AbfKATHX (ORCPT ); Fri, 1 Nov 2019 15:07:23 -0400 Received: by mail-qk1-f193.google.com with SMTP id y81so11670046qkb.7 for ; Fri, 01 Nov 2019 12:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YE7oISnKVk7mXz3OCRJJQp+KcsIdNkba4xrI7QohlOA=; b=ko9UsUUaKkDpPGy9+87wREy71m4qnhI+KWrvPjZiLorXMt5Va6LYv+XxS7WESN4RFJ L1Ef93N5AJPLRSZIJ+lH22m7t2vRpmGzSTx8kahC7U7pbfUqqFo47dpiIe/s7gtsbIeL JF3kuUeZGrBnkR5U9uApd5JuqBXUVZp0VsewtT0l3hPnBdhWnQeGv311cWpbXrYXFclL Qv7TRikvrs4oCogMDckZC/iZikUMloZXFLgHFsY1shrB5xGlpJnSWyK2Y3pc/GJCJUDY S5h7RSnL3VEHN0lRuNDcvDzheb+Erb6f4G/YSY8sqAUXV0Dn1FlyNWf9nkkeMWvfliVY 0RLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YE7oISnKVk7mXz3OCRJJQp+KcsIdNkba4xrI7QohlOA=; b=rKAtuN2jJASaFZMBcEX/NiKNM+CQVi1pFboyACL1TuLa7AZZ7FYC0rkPVoBOeoQZDL LsL/kJMKyYYUDDiLFVGrpZ/zDXHtJcsytuOI8EQHv+IysAERwbnbUJxlNALsGx08OXrq qqnUbhHNSt/MeqdaqO21sVwRTrdxnv11CEaQmG1wHskZINseruo8cBJixX0C7K26M3zI UABTwBNB8hrdrNtd4cH2ozteHW6yO4Eo2KufhpiiXemW7TlbzFrlwVnGJsEydpKZlzfh lr+eOwFkGRKEpU9VUNNwtbSXPc/gg48mt+N7wkdmFOHQ4siNy1+xtiiKQ0Vl2RbEa1OO 1Hhg== X-Gm-Message-State: APjAAAXeYaYOh15WcJ5C9MM9kd2QIpGgMDtthRAc1O4QMQbJn6vRTxA3 KniYN7MfsM5EFBlJlJDQdlo= X-Google-Smtp-Source: APXvYqwXgwYkbT9Oiky1Or+CF4HptP4T9eNITYcSZXW2ijhOhoHcg7VQzFJivo77BWsEmDpVsgyoYw== X-Received: by 2002:a05:620a:1244:: with SMTP id a4mr11840221qkl.208.1572635242092; Fri, 01 Nov 2019 12:07:22 -0700 (PDT) Received: from jfddesk.Sonatest.net (ipagstaticip-d73c7528-4de5-0861-800b-03d8b15e3869.sdsl.bell.ca. [174.94.156.236]) by smtp.gmail.com with ESMTPSA id d139sm5105905qkb.36.2019.11.01.12.07.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Nov 2019 12:07:21 -0700 (PDT) From: Jean-Francois Dagenais To: sre@kernel.org, linux-pm@vger.kernel.org Cc: Jean-Francois Dagenais Subject: [PATCH 1/7] power: supply: sbs-battery: use octal permissions on module param Date: Fri, 1 Nov 2019 15:06:59 -0400 Message-Id: <20191101190705.13393-1-jeff.dagenais@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Symbolic permissions 'S_IRUSR | S_IRGRP | S_IROTH' are not preferred. Use octal permissions '0444'. Signed-off-by: Jean-Francois Dagenais --- drivers/power/supply/sbs-battery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c index 048d205d7074..0e66968dabc3 100644 --- a/drivers/power/supply/sbs-battery.c +++ b/drivers/power/supply/sbs-battery.c @@ -994,6 +994,6 @@ module_i2c_driver(sbs_battery_driver); MODULE_DESCRIPTION("SBS battery monitor driver"); MODULE_LICENSE("GPL"); -module_param(force_load, bool, S_IRUSR | S_IRGRP | S_IROTH); +module_param(force_load, bool, 0444); MODULE_PARM_DESC(force_load, "Attempt to load the driver even if no battery is connected"); From patchwork Fri Nov 1 19:07:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jean-Fran=C3=A7ois_Dagenais?= X-Patchwork-Id: 11223613 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 429E41390 for ; Fri, 1 Nov 2019 19:07:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 220C7218AC for ; Fri, 1 Nov 2019 19:07:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QU8qQueq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727516AbfKATH1 (ORCPT ); Fri, 1 Nov 2019 15:07:27 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:39321 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726671AbfKATH1 (ORCPT ); Fri, 1 Nov 2019 15:07:27 -0400 Received: by mail-qk1-f195.google.com with SMTP id 15so11680768qkh.6 for ; Fri, 01 Nov 2019 12:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s7KgS1GjohJOLHMPh2cKOpzGRBgkOIJAxx5JgFXYTTA=; b=QU8qQueq2LshHnhXpxCStJxa/tfBoVnZxsE82Csd6hDIF5l4vKBwgm53Hb+RG4NtGr YGlCeFjBNIBvI89PBv9TCi7E4DH8IdYIssDQYg7j13RRZIKa0RL6KmpLXiWZmfmbUEGf XiNMps6hN91n44KQvMkQTAMhOsptNlq3NrV2APu8oR3X9KKii7XADoYSluBvOBi2dwCJ 0RnUqOJeNph+nFDaO30hVTA/MiNAyqe7NU1ilfWIZbMCKCdEcg2pQCFow53EbbMM2c7g lMFZQKhyZR9NmOcvNulYIzGKWYqq9LFrYO5mOtPIHiWOsC7elSZTCdKGypSVcz6zKkst oefQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s7KgS1GjohJOLHMPh2cKOpzGRBgkOIJAxx5JgFXYTTA=; b=ay6V9OYUTrVtZm9hGfFzE0TgjsWG2X3AUrISdhSA5tAxLTk3HQPC1OAOYxY1aR+A9s 8Wy8oD9y18CiRTN87HfWwxkfb8vvwy2BIZI7LkbSNSZ7qXJ0XO2c7smlNqHy5kS3ocni +6wbBIvaGkVfwwPAuYeeRR9t3PqjOBwV1U5WFX0ChnyDlj4eN+NwZaGoKUKuu/vLdT02 YdBCDoufj70b0+gFHyS+WKfs8OUYOC7nFVGy+0nxHTDInjzTLIrSZpy5X4eOeuB3kpwK y+LVzmZHiocexKWGVHCmU/QcWtTQgPZeWt4LlGb7j7aiWDRgQPuxPPDAS3MmPhVfnrPh 5IhQ== X-Gm-Message-State: APjAAAXaTZb9PWlHrBF1j2crfuPW6JSxeh3tGMoIdGs5lCQZOcQByvQC XeYT3719qgLIFDjP9AWyhHQ= X-Google-Smtp-Source: APXvYqwSXbQai1aHn4yLdNyYccy/XoDkR252NUPl6Wxjv5yN8uJcUCTq5tUmNDlNhsE5iXZxV/tBNw== X-Received: by 2002:a37:e10d:: with SMTP id c13mr11460762qkm.35.1572635245125; Fri, 01 Nov 2019 12:07:25 -0700 (PDT) Received: from jfddesk.Sonatest.net (ipagstaticip-d73c7528-4de5-0861-800b-03d8b15e3869.sdsl.bell.ca. [174.94.156.236]) by smtp.gmail.com with ESMTPSA id d139sm5105905qkb.36.2019.11.01.12.07.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Nov 2019 12:07:24 -0700 (PDT) From: Jean-Francois Dagenais To: sre@kernel.org, linux-pm@vger.kernel.org Cc: Jean-Francois Dagenais Subject: [PATCH 2/7] power: supply: sbs-battery: prefix module param variable Date: Fri, 1 Nov 2019 15:07:00 -0400 Message-Id: <20191101190705.13393-2-jeff.dagenais@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191101190705.13393-1-jeff.dagenais@gmail.com> References: <20191101190705.13393-1-jeff.dagenais@gmail.com> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org This is to prevent confusion with the upcoming devicetree binding for force_load. Signed-off-by: Jean-Francois Dagenais --- drivers/power/supply/sbs-battery.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c index 0e66968dabc3..f9e8c14ac830 100644 --- a/drivers/power/supply/sbs-battery.c +++ b/drivers/power/supply/sbs-battery.c @@ -168,7 +168,7 @@ struct sbs_info { static char model_name[I2C_SMBUS_BLOCK_MAX + 1]; static char manufacturer[I2C_SMBUS_BLOCK_MAX + 1]; -static bool force_load; +static bool param_force_load; static int sbs_read_word_data(struct i2c_client *client, u8 address) { @@ -890,7 +890,7 @@ static int sbs_probe(struct i2c_client *client, * Before we register, we might need to make sure we can actually talk * to the battery. */ - if (!(force_load || chip->gpio_detect)) { + if (!(param_force_load || chip->gpio_detect)) { rc = sbs_read_word_data(client, sbs_data[REG_STATUS].addr); if (rc < 0) { @@ -994,6 +994,6 @@ module_i2c_driver(sbs_battery_driver); MODULE_DESCRIPTION("SBS battery monitor driver"); MODULE_LICENSE("GPL"); -module_param(force_load, bool, 0444); -MODULE_PARM_DESC(force_load, +module_param(param_force_load, bool, 0444); +MODULE_PARM_DESC(param_force_load, "Attempt to load the driver even if no battery is connected"); From patchwork Fri Nov 1 19:07:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jean-Fran=C3=A7ois_Dagenais?= X-Patchwork-Id: 11223615 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 992C01390 for ; Fri, 1 Nov 2019 19:07:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77D0F218AC for ; Fri, 1 Nov 2019 19:07:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SBj7at5R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727592AbfKATHd (ORCPT ); Fri, 1 Nov 2019 15:07:33 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:37047 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726671AbfKATHd (ORCPT ); Fri, 1 Nov 2019 15:07:33 -0400 Received: by mail-qk1-f195.google.com with SMTP id u184so11684900qkd.4 for ; Fri, 01 Nov 2019 12:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wVfSPJ9zvMnUU5ly0+xbA4vuN0APYA1A0PaPALobUlo=; b=SBj7at5RDnaViDCsq1YnwgGzXDla0NhUa/yFYA11hNExkymPOVnJyUGsnnRv1YcQAb G543MMkGozOejW9CbEyLRCWf392g7zPthhOU/+yfQp/EIeyQCF2PjoxQxILsCF8sOlhs 1LP2HDAvV1CSBUOboUkNWUnZCb8neUV80awYaybu2tJ0Q59ESuInkOL02eWy18i9uMFV dZE+Lks6+GxjzpM84M7/IjAlwIZyfAquvO46fNk9YLc6Ahtg4lv/j28LdcGB/5fncOv3 YWlef4RluZuwp40fE2I0yNKZOIAQYlZJnpedZHORM8EmeK8sa2LD02Ffrr7rm4ls4vvG e2dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wVfSPJ9zvMnUU5ly0+xbA4vuN0APYA1A0PaPALobUlo=; b=tBkir/ZOJ6HzxCO+xFnAP2dg+bvUajZs4AxqGHySZy7SethQVjztksh/bf2zzVleyj xOJlQOkgZTEGrkyVD4OrQS9rfQ5HglQMzUnDRdgHG+6r40JkzCeOJQgzgLp1FRzOP5VO DDerk40TzO3+aTWILbv6quzso89KFAFxd6bWZRw3Y5EsP3xSi/n7MePLuzRTgdmjFDB7 t1uwdsVHMMx8IaSqtM0I+gO2m6Msb7mpoeCh9yiQSLKjy3z1ev58ebjMlZ2sF0PGpEPs C3hkTniyYJmpqGaMp7aLvZNOLq6dXx429p1kv1j1dfzPs2PYkXuipoespnAFKm7/0NGj oH6g== X-Gm-Message-State: APjAAAX1kfRUuRkyGiRZqaZuqMJiWbK0TZSJ5mLHSuNEnVbxouKOKsM9 H1Z08AYKe3IlFa33ggyXQnw= X-Google-Smtp-Source: APXvYqyqB1nZnfWC7XHJxvyyNNXzFu93iEIwir609A5iiDbXec5XOQIhvK/Oi1AY73GIA68QXCHJgg== X-Received: by 2002:a37:6ec3:: with SMTP id j186mr11949468qkc.473.1572635251963; Fri, 01 Nov 2019 12:07:31 -0700 (PDT) Received: from jfddesk.Sonatest.net (ipagstaticip-d73c7528-4de5-0861-800b-03d8b15e3869.sdsl.bell.ca. [174.94.156.236]) by smtp.gmail.com with ESMTPSA id d139sm5105905qkb.36.2019.11.01.12.07.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Nov 2019 12:07:31 -0700 (PDT) From: Jean-Francois Dagenais To: sre@kernel.org, linux-pm@vger.kernel.org Cc: Jean-Francois Dagenais Subject: [PATCH 3/7] power: supply: sbs-battery: add force_load as a dts property Date: Fri, 1 Nov 2019 15:07:01 -0400 Message-Id: <20191101190705.13393-3-jeff.dagenais@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191101190705.13393-1-jeff.dagenais@gmail.com> References: <20191101190705.13393-1-jeff.dagenais@gmail.com> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org This extends the behaviour of the existing module param so that system integrators can specify the flag in device-tree. Signed-off-by: Jean-Francois Dagenais --- drivers/power/supply/sbs-battery.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c index f9e8c14ac830..f92b98d900d2 100644 --- a/drivers/power/supply/sbs-battery.c +++ b/drivers/power/supply/sbs-battery.c @@ -814,6 +814,7 @@ static int sbs_probe(struct i2c_client *client, struct power_supply_desc *sbs_desc; struct sbs_platform_data *pdata = client->dev.platform_data; struct power_supply_config psy_cfg = {}; + bool force_load; int rc; int irq; @@ -858,6 +859,9 @@ static int sbs_probe(struct i2c_client *client, } chip->i2c_retry_count = chip->i2c_retry_count + 1; + force_load = of_property_read_bool(client->dev.of_node, + "sbs,force-load"); + chip->gpio_detect = devm_gpiod_get_optional(&client->dev, "sbs,battery-detect", GPIOD_IN); if (IS_ERR(chip->gpio_detect)) { @@ -890,7 +894,7 @@ static int sbs_probe(struct i2c_client *client, * Before we register, we might need to make sure we can actually talk * to the battery. */ - if (!(param_force_load || chip->gpio_detect)) { + if (!(param_force_load || force_load || chip->gpio_detect)) { rc = sbs_read_word_data(client, sbs_data[REG_STATUS].addr); if (rc < 0) { From patchwork Fri Nov 1 19:07:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jean-Fran=C3=A7ois_Dagenais?= X-Patchwork-Id: 11223617 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1E1331747 for ; Fri, 1 Nov 2019 19:07:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F1ECB21897 for ; Fri, 1 Nov 2019 19:07:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LYb2sQCf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727598AbfKATHf (ORCPT ); Fri, 1 Nov 2019 15:07:35 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:35470 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726671AbfKATHf (ORCPT ); Fri, 1 Nov 2019 15:07:35 -0400 Received: by mail-qt1-f196.google.com with SMTP id r22so4208251qtt.2 for ; Fri, 01 Nov 2019 12:07:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8Zrt7Ciu4aEbO1sutkMk41HncYdL+eJqeqa2yKbY6m8=; b=LYb2sQCf+hVD51/AaxMTr5P56gM5TugPuWmdhGKsEn/bKeuSP+E9QfBb3QnlBH1lPO /hjMCCaxzKEYUnBo2QTp5cmnmfvS01uZNBlilO8V4yaIN3irx9FKVqCcHnrFgp3hQBsc w4l4lZ5Dl03jBm+fpD3BR3wlNS5YN9q1F478RkUShv6z1DnMPwLjdtQwJU2bOHPVKNFN 9UAZSZWj395jWoJ6cbGbP+nCQhAALt+dErfkfv5eyeEgomiK9VdRk5oexkIup3IOZ+P0 ICFHlzmtmDsQjL1vIxmB43RQnbzPwEEFL2UdtYz1oIOKVIi9KiHu05OdY8jAkGd4dj0D I5Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8Zrt7Ciu4aEbO1sutkMk41HncYdL+eJqeqa2yKbY6m8=; b=O0eGxRYJjnXYISL+yYeCRIG+XvyRNNtzZGkMc/fwiyBqTbDcIs5bLlDrqFhMwhoy8E 32ae9q9zs6LkGJnkGHolvq8QZWtgjCp6wOi+wKMucZesYDBijhO4ZqAcJ01okdbzHDqA 759k9a+IaqKvGo073npbAxLjKKbOfan/Z+5qQyZlUTudYBeWwAeVTMAelF+POW+hWSe4 yD5bHan2L53GjkDHPbl1ldC2kAsqhMV5LbsD2Y4V0hUOXrZQbElv0IseEw741C8jlAo2 tQifuBeQuwfjcfuUIRQ3JiAZaKToCGdGEmH1jHdgExJ81aDRJ9t8KEiHihI+BjTpYEBt k9xA== X-Gm-Message-State: APjAAAVEQOHqC+VuqC8IJ5Cbvn0NhDsaObOMVdpFO7y6Myyy/h3cwJNL aPdxd5k4k/KEodBHoWLoozY= X-Google-Smtp-Source: APXvYqw0qim5XDlFLVZjFYFkwU15MKN9o9SCpHyR6JQ9cyjjPwcNg9u0vDqSxePgeGolvXfTms3aSQ== X-Received: by 2002:a0c:eb90:: with SMTP id x16mr11662879qvo.140.1572635254599; Fri, 01 Nov 2019 12:07:34 -0700 (PDT) Received: from jfddesk.Sonatest.net (ipagstaticip-d73c7528-4de5-0861-800b-03d8b15e3869.sdsl.bell.ca. [174.94.156.236]) by smtp.gmail.com with ESMTPSA id d139sm5105905qkb.36.2019.11.01.12.07.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Nov 2019 12:07:34 -0700 (PDT) From: Jean-Francois Dagenais To: sre@kernel.org, linux-pm@vger.kernel.org Cc: Jean-Francois Dagenais Subject: [PATCH 4/7] devicetree: bindings: sbs-battery: add sbs,force-load property Date: Fri, 1 Nov 2019 15:07:02 -0400 Message-Id: <20191101190705.13393-4-jeff.dagenais@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191101190705.13393-1-jeff.dagenais@gmail.com> References: <20191101190705.13393-1-jeff.dagenais@gmail.com> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Signed-off-by: Jean-Francois Dagenais --- .../devicetree/bindings/power/supply/sbs_sbs-battery.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt index 4e78e51018eb..62ec842325b4 100644 --- a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt +++ b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt @@ -15,6 +15,8 @@ Optional properties : after an external change notification. - sbs,battery-detect-gpios : The gpio which signals battery detection and a flag specifying its polarity. + - sbs,force-load : Same as the module param, makes the probe skip the + detection of the battery and assume it is (or will be) present. Example: @@ -24,4 +26,5 @@ Example: sbs,i2c-retry-count = <2>; sbs,poll-retry-count = <10>; sbs,battery-detect-gpios = <&gpio-controller 122 1>; + sbs,force-load; } From patchwork Fri Nov 1 19:07:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jean-Fran=C3=A7ois_Dagenais?= X-Patchwork-Id: 11223619 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EF06B139A for ; Fri, 1 Nov 2019 19:07:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB7802086D for ; Fri, 1 Nov 2019 19:07:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jwR9Bj0H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727605AbfKATHh (ORCPT ); Fri, 1 Nov 2019 15:07:37 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:44834 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726671AbfKATHh (ORCPT ); Fri, 1 Nov 2019 15:07:37 -0400 Received: by mail-qt1-f195.google.com with SMTP id o11so9200690qtr.11 for ; Fri, 01 Nov 2019 12:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lj1aUbt9PEV6Gdc4Q2RVOQ8l6t5blUEdDBYHs19jKj4=; b=jwR9Bj0HG7npBAO7dJ5AuIsF5sM2NFOXyAiYLDKUMKHFp9uo0mNga2BO1pBOmS7+Gr E2GJZZOclSpkOMjTOJZ5MTMptgB9emP4tIcu9jVHsI70T/bh3GPsWAUflYsYJsmvP2MO HH/vH73gIW9fUJT5B8JFdIBYoRm8f2UqJ8qcemcZnaoUWzBQCujfjDF9TjlPEY/eB6KH vQqf1qj7gp/NNdQCcstu9T4qXp8j3WsMetxtHHeDCtrJJOqp5BzvEUl9Hnc8jTldq9VS ZuqgmGQRF6SbIf12clXGNwUTuSrQAfAdFrMbqNyGfnYIeRBXjLynuPECsYiZhSuTX9Ki jVOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lj1aUbt9PEV6Gdc4Q2RVOQ8l6t5blUEdDBYHs19jKj4=; b=J6B13ivAyVGpNDZaofoJaJ6Dk5p7L8XTvUt5GyQVKRHECySM6vUDw3x2+7qHO53v3e f+BEI7K8Z9A/402wlW2zhcWJ1lfGe45VfLN2ct6JfkZFRyvmfdLSg5iIKV3HFnm4JHmg VyaVusLGZnr8ak5cO9s1t0HCceUKMiCyVEdXoD3ZyFUK7bgY1Y8rcC4e2cFoxissnLAK xOLSDCo7VZ7H4Uy1b4XvBDoeNP5tGYci8iDrtYgdj5jIo4yRdEXMAh9Twm8lBgcW4II8 rmhWR5F8UwzznvAjrcddas3PkjD2uOEQPbXe9+L81ZMy1gXZGzbRHBb9gVaUoW+COcOO FiYQ== X-Gm-Message-State: APjAAAWCzytjoQAODjtvO4OuMNviVao9VRjUr/S/HMkC58+k06rB/tUH 29UMH/wUPMCRevBgUvSFYpM= X-Google-Smtp-Source: APXvYqyGODdQuSV3v0aNR9dLteZeFxFjGMfXU8yLFvfwY7j8noN4s0bM89+N5D0UTBq2bhPilDwQcw== X-Received: by 2002:ac8:35a4:: with SMTP id k33mr970995qtb.354.1572635256416; Fri, 01 Nov 2019 12:07:36 -0700 (PDT) Received: from jfddesk.Sonatest.net (ipagstaticip-d73c7528-4de5-0861-800b-03d8b15e3869.sdsl.bell.ca. [174.94.156.236]) by smtp.gmail.com with ESMTPSA id d139sm5105905qkb.36.2019.11.01.12.07.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Nov 2019 12:07:35 -0700 (PDT) From: Jean-Francois Dagenais To: sre@kernel.org, linux-pm@vger.kernel.org Cc: Jean-Francois Dagenais Subject: [PATCH 5/7] power: supply: sbs-battery: fix CAPACITY_MODE bit naming Date: Fri, 1 Nov 2019 15:07:03 -0400 Message-Id: <20191101190705.13393-5-jeff.dagenais@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191101190705.13393-1-jeff.dagenais@gmail.com> References: <20191101190705.13393-1-jeff.dagenais@gmail.com> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org "Battery mode" is the name of the register, the bit manipulated by this code is "CAPACITY_MODE" (Smart Battery System Specifications). Signed-off-by: Jean-Francois Dagenais --- drivers/power/supply/sbs-battery.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c index f92b98d900d2..46c89dd05f46 100644 --- a/drivers/power/supply/sbs-battery.c +++ b/drivers/power/supply/sbs-battery.c @@ -46,10 +46,10 @@ enum { /* Battery Mode defines */ #define BATTERY_MODE_OFFSET 0x03 -#define BATTERY_MODE_MASK 0x8000 -enum sbs_battery_mode { - BATTERY_MODE_AMPS = 0, - BATTERY_MODE_WATTS = 0x8000 +#define BATTERY_MODE_CAPACITY_MASK (1<<15) +enum sbs_capacity_mode { + CAPACITY_MODE_AMPS = 0, + CAPACITY_MODE_WATTS = BATTERY_MODE_CAPACITY_MASK }; /* manufacturer access defines */ @@ -513,8 +513,8 @@ static void sbs_unit_adjustment(struct i2c_client *client, } } -static enum sbs_battery_mode sbs_set_battery_mode(struct i2c_client *client, - enum sbs_battery_mode mode) +static enum sbs_capacity_mode sbs_set_capacity_mode(struct i2c_client *client, + enum sbs_capacity_mode mode) { int ret, original_val; @@ -522,13 +522,13 @@ static enum sbs_battery_mode sbs_set_battery_mode(struct i2c_client *client, if (original_val < 0) return original_val; - if ((original_val & BATTERY_MODE_MASK) == mode) + if ((original_val & BATTERY_MODE_CAPACITY_MASK) == mode) return mode; - if (mode == BATTERY_MODE_AMPS) - ret = original_val & ~BATTERY_MODE_MASK; + if (mode == CAPACITY_MODE_AMPS) + ret = original_val & ~BATTERY_MODE_CAPACITY_MASK; else - ret = original_val | BATTERY_MODE_MASK; + ret = original_val | BATTERY_MODE_CAPACITY_MASK; ret = sbs_write_word_data(client, BATTERY_MODE_OFFSET, ret); if (ret < 0) @@ -536,7 +536,7 @@ static enum sbs_battery_mode sbs_set_battery_mode(struct i2c_client *client, usleep_range(1000, 2000); - return original_val & BATTERY_MODE_MASK; + return original_val & BATTERY_MODE_CAPACITY_MASK; } static int sbs_get_battery_capacity(struct i2c_client *client, @@ -544,12 +544,12 @@ static int sbs_get_battery_capacity(struct i2c_client *client, union power_supply_propval *val) { s32 ret; - enum sbs_battery_mode mode = BATTERY_MODE_WATTS; + enum sbs_capacity_mode mode = CAPACITY_MODE_WATTS; if (power_supply_is_amp_property(psp)) - mode = BATTERY_MODE_AMPS; + mode = CAPACITY_MODE_AMPS; - mode = sbs_set_battery_mode(client, mode); + mode = sbs_set_capacity_mode(client, mode); if (mode < 0) return mode; @@ -559,7 +559,7 @@ static int sbs_get_battery_capacity(struct i2c_client *client, val->intval = ret; - ret = sbs_set_battery_mode(client, mode); + ret = sbs_set_capacity_mode(client, mode); if (ret < 0) return ret; From patchwork Fri Nov 1 19:07:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jean-Fran=C3=A7ois_Dagenais?= X-Patchwork-Id: 11223621 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 08E461390 for ; Fri, 1 Nov 2019 19:07:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC50E218AC for ; Fri, 1 Nov 2019 19:07:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jT+HZSjD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727638AbfKATHj (ORCPT ); Fri, 1 Nov 2019 15:07:39 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:32878 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726671AbfKATHj (ORCPT ); Fri, 1 Nov 2019 15:07:39 -0400 Received: by mail-qk1-f193.google.com with SMTP id 71so11723515qkl.0 for ; Fri, 01 Nov 2019 12:07:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iZh3Z5MTmDVm4Ss7I93O+qDHyHAj+taMzuDCG4Cft3k=; b=jT+HZSjDBJzjsce+o2X7JiXpj5ujTH7NPxnQ1gBacbgBWnc7ECq6sBwKI/zrOeg8q6 BAvPcV3oghEm2WJoDGtPjqVOtW9VJSbMWmzlcU2195pOasUciRENoVXjocTCl+4Ot4Lw Z7H6X6pCMNu8KUFz5nY0LsoDlMrp9Qv25i94NNXrPgt7aJZS/YLZYlBs17VHa8flW9xV uK3jMWxr+UttnN+I9c9yKglEAOKH54T9cti71fuxLLrTDCBZuCs8VQ1t1w8AjTdpi5VC TVX5X5wu4hWXjeY2xxCXGKNwgFmsKNCTrOEzD+Ghb67T9/Yf6PVi+3HlDIv4DlfSP57y DIvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iZh3Z5MTmDVm4Ss7I93O+qDHyHAj+taMzuDCG4Cft3k=; b=NIK2WzqM6GTfE1+NNpcDwgUZYLxrdXU46O0ymld3AYk3LamX9/L7H+dN04gHIZkr3E iFraqBA6/sEcK6/6f4wkzFY9xBk4gg74mGd/6emMbX7p62fhQsFXofWCEKlzpEmMq9P/ V46zHXzc9O6x4BF1Y0MDbYXpd24aZoUruUlNdYH4GpjSd8zWTkrrQNRzCwB9DeXklzFp Ah6Ojrli9hGGZKc2yfknIRE1CFW3MlW7TjOt7/9D2I3I5ZGIKIHfxiFSEHu2qeZuuF7A ZBn3mdzMPvZvQmsT0yIDFkmWGnBiz0Y1kDoPlkhBthjrZvNcBVU2tbuMOKk30UzW60YV Y3bg== X-Gm-Message-State: APjAAAXIJT8vkb5i59h+WYjnEw2p7UhedbXUwAONvbXCS3fs2SXNZkr4 zqZrQnY4HPHB9ubV1EoWX/U= X-Google-Smtp-Source: APXvYqx3HmFbix6HjEcFQEbKWUHdF/SJlXjVYiD5tNntpxcVXOfsMZvSXcKDIBtktALStesjnCR78A== X-Received: by 2002:a37:9083:: with SMTP id s125mr10337379qkd.192.1572635258335; Fri, 01 Nov 2019 12:07:38 -0700 (PDT) Received: from jfddesk.Sonatest.net (ipagstaticip-d73c7528-4de5-0861-800b-03d8b15e3869.sdsl.bell.ca. [174.94.156.236]) by smtp.gmail.com with ESMTPSA id d139sm5105905qkb.36.2019.11.01.12.07.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Nov 2019 12:07:37 -0700 (PDT) From: Jean-Francois Dagenais To: sre@kernel.org, linux-pm@vger.kernel.org Cc: Jean-Francois Dagenais Subject: [PATCH 6/7] power: supply: sbs-battery: add ability to disable charger broadcasts Date: Fri, 1 Nov 2019 15:07:04 -0400 Message-Id: <20191101190705.13393-6-jeff.dagenais@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191101190705.13393-1-jeff.dagenais@gmail.com> References: <20191101190705.13393-1-jeff.dagenais@gmail.com> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org In certain designs, it is possible to add a battery on a populated i2c bus without an sbs compliant charger. In that case, the battery will un-necessarily and sometimes un-desirably master the bus trying to write info in the charger. It is observed in many occasion that these battery "broadcasts" are even corrupting other ongoing master to slave communication. I.e. the multi-master support in the battery is inadequate. Thankfully, the CHARGER_MODE bit allows designers to disable that SBS battery behaviour. This needs to be done once when the battery is first seen on the bus. Signed-off-by: Jean-Francois Dagenais --- drivers/power/supply/sbs-battery.c | 39 +++++++++++++++++++++++++++--- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c index 46c89dd05f46..fb116ab7752d 100644 --- a/drivers/power/supply/sbs-battery.c +++ b/drivers/power/supply/sbs-battery.c @@ -51,6 +51,7 @@ enum sbs_capacity_mode { CAPACITY_MODE_AMPS = 0, CAPACITY_MODE_WATTS = BATTERY_MODE_CAPACITY_MASK }; +#define BATTERY_MODE_CHARGER_MASK (1<<14) /* manufacturer access defines */ #define MANUFACTURER_ACCESS_STATUS 0x0006 @@ -157,6 +158,7 @@ struct sbs_info { bool is_present; struct gpio_desc *gpio_detect; bool enable_detection; + bool charger_broadcasts; int last_state; int poll_time; u32 i2c_retry_count; @@ -596,6 +598,34 @@ static int sbs_get_property_index(struct i2c_client *client, return -EINVAL; } +static void sbs_disable_charger_broadcasts(struct sbs_info *chip) +{ + int val = sbs_read_word_data(chip->client, BATTERY_MODE_OFFSET); + if (val < 0) + goto exit; + + val |= BATTERY_MODE_CHARGER_MASK; + + val = sbs_write_word_data(chip->client, BATTERY_MODE_OFFSET, val); + +exit: + if (val < 0) + dev_err(&chip->client->dev, + "Failed to disable charger broadcasting: %d\n", val); + else + dev_dbg(&chip->client->dev, "%s\n", __func__); +} + +static void sbs_set_is_present(struct sbs_info *chip, bool is_present) +{ + dev_dbg(&chip->client->dev, "%s %d\n", __func__, is_present); + + if (!chip->is_present && is_present && !chip->charger_broadcasts) + sbs_disable_charger_broadcasts(chip); + + chip->is_present = is_present; +} + static int sbs_get_property(struct power_supply *psy, enum power_supply_property psp, union power_supply_propval *val) @@ -610,7 +640,7 @@ static int sbs_get_property(struct power_supply *psy, return ret; if (psp == POWER_SUPPLY_PROP_PRESENT) { val->intval = ret; - chip->is_present = val->intval; + sbs_set_is_present(chip, val->intval); return 0; } if (ret == 0) @@ -706,7 +736,7 @@ static int sbs_get_property(struct power_supply *psy, if (!chip->gpio_detect && chip->is_present != (ret >= 0)) { - chip->is_present = (ret >= 0); + sbs_set_is_present(chip, ret >= 0); power_supply_changed(chip->power_supply); } @@ -737,7 +767,7 @@ static void sbs_supply_changed(struct sbs_info *chip) ret = gpiod_get_value_cansleep(chip->gpio_detect); if (ret < 0) return; - chip->is_present = ret; + sbs_set_is_present(chip, ret); power_supply_changed(battery); } @@ -862,6 +892,9 @@ static int sbs_probe(struct i2c_client *client, force_load = of_property_read_bool(client->dev.of_node, "sbs,force-load"); + chip->charger_broadcasts = !of_property_read_bool(client->dev.of_node, + "sbs,disable-charger-broadcasts"); + chip->gpio_detect = devm_gpiod_get_optional(&client->dev, "sbs,battery-detect", GPIOD_IN); if (IS_ERR(chip->gpio_detect)) { From patchwork Fri Nov 1 19:07:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jean-Fran=C3=A7ois_Dagenais?= X-Patchwork-Id: 11223623 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BE7B5139A for ; Fri, 1 Nov 2019 19:07:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DE67218AC for ; Fri, 1 Nov 2019 19:07:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V1B5jnhp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727646AbfKATHm (ORCPT ); Fri, 1 Nov 2019 15:07:42 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:34821 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726671AbfKATHm (ORCPT ); Fri, 1 Nov 2019 15:07:42 -0400 Received: by mail-qk1-f196.google.com with SMTP id i19so2564148qki.2 for ; Fri, 01 Nov 2019 12:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xKHiOGYnLpZff5oFAVLb69iuOICybW4S004M0YpS0iY=; b=V1B5jnhp8ReqjDQpQk8uW5ceGGJhaATSk0z+IUvr5z6Vs2WidTGmu9Gad/3dWUCmbA tT/dgBrEpwueF+TXHXTaQ/2Y3Mv30YsZ1Je3eli3dNpbZou1Zi1bx1hV9VnUTP/1mhqW VVAUB8mT6z+pLRAa8ooua/j4GMxgnvhaTc5tmQOfDO4j4aRh75uRO3VuEQ/3dWJJqFbH 8dddFSVeSMii2542TMuU1qCVkX0Dd2YErtHm0F3HkUTKQHcP30ywdJCCGJ//gs6wEI33 KNsRmVIs9Qi2qRztAF220+zKl+H4qjfNryltS2Yc7YPKEuJgYRiLGG0JvycGpdDV0fbY RQcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xKHiOGYnLpZff5oFAVLb69iuOICybW4S004M0YpS0iY=; b=HHisaPbo48cJWA7ynsjgwXZ3iCPb0T0PrUvytXHogXVcK3rRxT6B/SDJbzBPB0sCDN Hl9/+mWRxqOwETL2cBa5DS1LlJ0aRaE9hiixw1gNUR6pLekziBiR/eala5NeIkaXkGfO +uM/a9hvmd+hregFtyFCorXgitcInwg8QcD7H0qDgQthYt8/j9tXTQvb2boUAqWlDf2n naqj29iDs+APXtn0obNKX3VoDN8lMn2QXadNDJS8K7kUJOoXufJytAsi0hDXWrPouDTh jOY2n3aOmsouI2LhWggsi+reHVfJgWiK+GVMJLGUmudSZic5Pm3EHzuiNYlNsULo3NY1 +jrg== X-Gm-Message-State: APjAAAX2q8Nj5AXLHIyq2pr273aZ53XEJhoHQoQ1iet+tnsmR0wEldkx nBzilnyKpjhVqcR4T2d0ay8= X-Google-Smtp-Source: APXvYqyJHIGzeRfF0VVdnYMWAH0inD4u8+N02Y2C24uzbRb1O2JhllFjUqu9+DQr2n7e/tfSkBYPtw== X-Received: by 2002:a37:70c3:: with SMTP id l186mr11690945qkc.190.1572635260918; Fri, 01 Nov 2019 12:07:40 -0700 (PDT) Received: from jfddesk.Sonatest.net (ipagstaticip-d73c7528-4de5-0861-800b-03d8b15e3869.sdsl.bell.ca. [174.94.156.236]) by smtp.gmail.com with ESMTPSA id d139sm5105905qkb.36.2019.11.01.12.07.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Nov 2019 12:07:40 -0700 (PDT) From: Jean-Francois Dagenais To: sre@kernel.org, linux-pm@vger.kernel.org Cc: Jean-Francois Dagenais Subject: [PATCH 7/7] dt-bindings: power: sbs-battery: add disable-charger-broadcasts doc Date: Fri, 1 Nov 2019 15:07:05 -0400 Message-Id: <20191101190705.13393-7-jeff.dagenais@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191101190705.13393-1-jeff.dagenais@gmail.com> References: <20191101190705.13393-1-jeff.dagenais@gmail.com> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Signed-off-by: Jean-Francois Dagenais --- .../devicetree/bindings/power/supply/sbs_sbs-battery.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt index 62ec842325b4..578643f49b0a 100644 --- a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt +++ b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt @@ -17,6 +17,7 @@ Optional properties : a flag specifying its polarity. - sbs,force-load : Same as the module param, makes the probe skip the detection of the battery and assume it is (or will be) present. + - sbs,disable-charger-broadcasts: for systems without sbs compliant chargers Example: @@ -27,4 +28,5 @@ Example: sbs,poll-retry-count = <10>; sbs,battery-detect-gpios = <&gpio-controller 122 1>; sbs,force-load; + sbs,disable-charger-broadcasts; }