From patchwork Fri Nov 1 14:38:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuhong Yuan X-Patchwork-Id: 11223911 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 22A6E13BD for ; Fri, 1 Nov 2019 22:51:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BA27217D9 for ; Fri, 1 Nov 2019 22:51:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BA27217D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CBBDD6F89B; Fri, 1 Nov 2019 22:51:17 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 09C316E245 for ; Fri, 1 Nov 2019 14:38:14 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id v3so8879398wmh.1 for ; Fri, 01 Nov 2019 07:38:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=d/QAmQIaJZqvBZN9gtf42lfTOPBui/1bELKuGyuJdb8=; b=tj0HigCM5to1a9l9AP/f9W9e3IjD6J4xkthRxf1yO959FLNQrbyHqoH9EUKSMNRg2p HNt2OgZcWmzNq5eExDtcvCnXxYyzx6u9JhyEtJ8jmLxog2g3m37JA8phv9kGedPQlCTT D2JpAhv5dIabxyidCLtreORgzmB10jF2HBHja6m8SJsZC0iD9chXHLfBJAdanVpaL0xr JaRhUBraXAVL4b4Z3Jh87S63yAJ0IU4UflO36JqKpCdhj/yawDZZfbVuLNO7rpDMZNq6 FgiSWK8dyv7tbRlp4b4LN64ApxDMHx10Os6de0aXi5K08MlPHR/1uaNE2PwMj1iaVBkf IHwA== X-Gm-Message-State: APjAAAWJMKVs3FZD6iEIBRlYQIwBAAdMAMXAikS/FucqMScDSAzfttOl 1m76WnxZYvEP8Mniy0CCLhCs7Y6EyuY= X-Google-Smtp-Source: APXvYqyI+Q4wEtZDCOGjwU9VHlMJmHZrNaWIfLyrtIJAa8a3WH1InYAp3J1RaSxDOIYycLFVQMvstw== X-Received: by 2002:a1c:10a:: with SMTP id 10mr10579982wmb.17.1572619092780; Fri, 01 Nov 2019 07:38:12 -0700 (PDT) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id l15sm6391895wmh.18.2019.11.01.07.38.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2019 07:38:12 -0700 (PDT) From: Chuhong Yuan To: Subject: [PATCH] gpu: ipu-v3: prg: add missed clk_disable_unprepare in remove Date: Fri, 1 Nov 2019 22:38:01 +0800 Message-Id: <20191101143801.17774-1-hslester96@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-Mailman-Approved-At: Fri, 01 Nov 2019 22:51:09 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=d/QAmQIaJZqvBZN9gtf42lfTOPBui/1bELKuGyuJdb8=; b=A1/aTXY88hwx0sfCCWkO613b31JI7fBe2Fo7wc0qyRX1OqGtc1ZqPTHH3fVptzI2xR kjtzIFwT28c8pyCN1rXIAb7VEv+u4LqEx23SRT2bH3mzJkw5AkHNOs4lt482evX6TdWF Owbgw07QIaJIvXlIn0YuxP0DnJ1ZY33AiQXaHs13ZhtLhRBr6AsyzgXdcRaO31s6BfbC cq/gJdjEVmPEDAHhPV8CvWUhlxccGm2a3OBVYvTtNkvqGihMhGX0GOr/Ignd7Nxemwmz JnE2XSKIlW/ZcBwn1hZtqeovVZlQjWliWYbL8JCHXD5aWz0FsGz9AIOM/1cmNSrVmNYv 19yg== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chuhong Yuan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The driver forgets to disable and unprepare clks when remove. Add the calls to clk_disable_unprepare to fix the problem. Signed-off-by: Chuhong Yuan --- drivers/gpu/ipu-v3/ipu-prg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/ipu-v3/ipu-prg.c b/drivers/gpu/ipu-v3/ipu-prg.c index 196797c1b4b3..6ae6d634c983 100644 --- a/drivers/gpu/ipu-v3/ipu-prg.c +++ b/drivers/gpu/ipu-v3/ipu-prg.c @@ -430,6 +430,8 @@ static int ipu_prg_remove(struct platform_device *pdev) list_del(&prg->list); mutex_unlock(&ipu_prg_list_mutex); + clk_disable_unprepare(prg->clk_axi); + clk_disable_unprepare(prg->clk_ipg); return 0; }