From patchwork Mon Nov 4 13:09:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda Delgado X-Patchwork-Id: 11225785 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 611F2913 for ; Mon, 4 Nov 2019 13:10:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35D6B222C1 for ; Mon, 4 Nov 2019 13:10:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572873020; bh=nkoLVbNAWfBTTQ+apmIvIdYF3l3ZZ2bPV+p+EbUGX88=; h=From:To:Cc:Subject:Date:List-ID:From; b=Mprv67IwH6pM/Y45pN6bHEACQuhxL7joO2Qx/LYR9tQ+ny0/Hgq71t8N6cNqZqSzM +zgwZd2ogQGVkCwYohTPRnDJeBPmCOtXjNAygR69k7ykgOCyBYtvwUCdzX7585cjrm zdslhcAVl1F2utV0dKw6gAYhDzJWamBkWOzARPDo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729152AbfKDNKJ (ORCPT ); Mon, 4 Nov 2019 08:10:09 -0500 Received: from mail-lj1-f174.google.com ([209.85.208.174]:45085 "EHLO mail-lj1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728741AbfKDNKI (ORCPT ); Mon, 4 Nov 2019 08:10:08 -0500 Received: by mail-lj1-f174.google.com with SMTP id n21so3892909ljg.12; Mon, 04 Nov 2019 05:10:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=T+OjJ+6/I6gUD391Oea+4W1UmtPnSSXB5pb5k146uYU=; b=IqyPoXHGeBVO046+L7s4B45oDmzC0caWCsFS6u/7LEXJuLwsZY5cYNnKW8nCoMwD3V o+DGCuoJOoXGp2FOcPOuQRzwm7tRjxH37XOEMr3mzl2/Kbkb4/PAu913cpa4zzKOxs3m xZEpKhl6zCwa+P+RAGohqrnNBsVJrU7GNJoicXgcqkqKG/nrSOhZRZDzTBZ5yVYoqAN0 mSV73q5VrqihbPxmCrPor2Yks6e70nJtIMCtam/TPHevVTWXTO94+vYJmytqL5v0t+Gi BbUVFKpmj+J7fatWX/r2ylgMYCIOWLyPdcmq4uWhzpbu+BA7tODsog52NppWxR65CAje 49tw== X-Gm-Message-State: APjAAAV+7diWo8pcWVzVIIKf13cpcuRtcn58V6dvAZYyjQ4AlkFyu86m d45lkRto0rCfsgVk0rqHZzQ= X-Google-Smtp-Source: APXvYqwhkzL0mXb3lFP375fkPZPQRM79RegodUiRbelQjvnFHqUCfDyhrsZuohmx2OjxRc74rzr7zw== X-Received: by 2002:a2e:9449:: with SMTP id o9mr18241139ljh.110.1572873005318; Mon, 04 Nov 2019 05:10:05 -0800 (PST) Received: from neopili.qtec.com (cpe.xe-3-0-1-778.vbrnqe10.dk.customer.tdc.net. [80.197.57.18]) by smtp.gmail.com with ESMTPSA id z3sm5931801ljz.51.2019.11.04.05.10.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2019 05:10:04 -0800 (PST) From: Ricardo Ribalda Delgado To: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ricardo Ribalda Delgado Subject: [PATCH v2 1/3] v4l2-ctl: Support query V4L2_CTRL_TYPE_AREA controls Date: Mon, 4 Nov 2019 14:09:58 +0100 Message-Id: <20191104131000.22359-1-ribalda@kernel.org> X-Mailer: git-send-email 2.24.0.rc1 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Tested with vivid: $ v4l2-ctl -l | grep area area 0x0098f90b (area) : flags=has-payload Signed-off-by: Ricardo Ribalda Delgado --- utils/v4l2-ctl/v4l2-ctl-common.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/utils/v4l2-ctl/v4l2-ctl-common.cpp b/utils/v4l2-ctl/v4l2-ctl-common.cpp index 651917e7..b1c12b35 100644 --- a/utils/v4l2-ctl/v4l2-ctl-common.cpp +++ b/utils/v4l2-ctl/v4l2-ctl-common.cpp @@ -458,6 +458,9 @@ static void print_qctrl(int fd, struct v4l2_query_ext_ctrl *queryctrl, queryctrl->minimum, queryctrl->maximum, queryctrl->step, queryctrl->default_value); break; + case V4L2_CTRL_TYPE_AREA: + printf("%31s %#8.8x (area) :", s.c_str(), queryctrl->id); + break; default: printf("%31s %#8.8x (unknown): type=%x", s.c_str(), queryctrl->id, queryctrl->type); From patchwork Mon Nov 4 13:09:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda Delgado X-Patchwork-Id: 11225783 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ECBCA13BD for ; Mon, 4 Nov 2019 13:10:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C097C21E6F for ; Mon, 4 Nov 2019 13:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572873017; bh=h8Z3AnF7vXRAjXwVMTjLA3c0ADxJJIgEzh9hlBOMfGM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OjHNtn4Enw/PfT58sU89wmIeilXbTnTxmNbXlbQYuFM56UqC9w3d7NOALy1PAxCBE V8YBjep4TNnH5RH8DEeSGNZBJyONzUSwq2gxG8i/a+uYy/6JdRCbdNP/YjMZVZDEBb S4No+2siUG9Lw/PU44yMVnYhZXfldX9shX7kOKeU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729233AbfKDNKJ (ORCPT ); Mon, 4 Nov 2019 08:10:09 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:36947 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728905AbfKDNKJ (ORCPT ); Mon, 4 Nov 2019 08:10:09 -0500 Received: by mail-lj1-f193.google.com with SMTP id v2so17529754lji.4; Mon, 04 Nov 2019 05:10:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DaGUTMZTPvVQG7pcnt9rSBQcYcHWYKS+V0DM0nxl4Tk=; b=JKgTPYzZH+LX1jPkQTz+QQjdEqj+hUvxvKav+3k4omrEZqHXNvCkT1PKwiMWLdsbcg BIeo7JBZYKTvYjsvFyuOMzSit81ZejYL0bLjXvSiwhEOKawpQLnJDFX91iWweQo9gRLP 7Jz8T5i1IL6uFScb5sixG/s+iLtVBSFtUGL39C/HRbjbaZ69k7su9H9JYsqHIyYIF9+F kJRCLjwX1FrOiid66l9jV7eSB5ISuEFCT5QHkAESBsCDTLShA7ToTai5paBvm6Ju217s IjbmG7kVvkjJAfQ4SvYZlWhfC1GwVvgqyBOAvt4cqPvVUAIzQoKVq+O1Twy1TgYA1Vlm 5/wQ== X-Gm-Message-State: APjAAAWwgRgO6Lu4HCo9UQi+BTa6nrRbNtwO08STf0dNu8deuioQqUR2 tcSVXFAcPiiutdxtz24G0g2RgsRraMk= X-Google-Smtp-Source: APXvYqwttHpEeyFYXr19zdC+Qle+rn5YWM+8K5IlESpXcz+Jv3c2UkUuLNzCpSf2/IspyeDiSN+uiQ== X-Received: by 2002:a2e:9194:: with SMTP id f20mr7455672ljg.154.1572873007465; Mon, 04 Nov 2019 05:10:07 -0800 (PST) Received: from neopili.qtec.com (cpe.xe-3-0-1-778.vbrnqe10.dk.customer.tdc.net. [80.197.57.18]) by smtp.gmail.com with ESMTPSA id z3sm5931801ljz.51.2019.11.04.05.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2019 05:10:06 -0800 (PST) From: Ricardo Ribalda Delgado To: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ricardo Ribalda Delgado Subject: [PATCH v2 2/3] v4l2-ctl: Support getting V4L2_CTRL_TYPE_AREA controls Date: Mon, 4 Nov 2019 14:09:59 +0100 Message-Id: <20191104131000.22359-2-ribalda@kernel.org> X-Mailer: git-send-email 2.24.0.rc1 In-Reply-To: <20191104131000.22359-1-ribalda@kernel.org> References: <20191104131000.22359-1-ribalda@kernel.org> MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Tested with vivid: v4l2-ctl -C area -d /dev/video1 area: 51966x727837 Signed-off-by: Ricardo Ribalda Delgado --- utils/v4l2-ctl/v4l2-ctl-common.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/utils/v4l2-ctl/v4l2-ctl-common.cpp b/utils/v4l2-ctl/v4l2-ctl-common.cpp index b1c12b35..95339561 100644 --- a/utils/v4l2-ctl/v4l2-ctl-common.cpp +++ b/utils/v4l2-ctl/v4l2-ctl-common.cpp @@ -1150,6 +1150,11 @@ void common_get(cv4l_fd &_fd) printf("%s: '%s'\n", name.c_str(), safename(ctrl.string).c_str()); break; + case V4L2_CTRL_TYPE_AREA: + printf("%s: %dx%d\n", name.c_str(), + ctrl.p_area->width, + ctrl.p_area->height); + break; default: fprintf(stderr, "%s: unsupported payload type\n", qc.name); From patchwork Mon Nov 4 13:10:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda Delgado X-Patchwork-Id: 11225781 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5F06413BD for ; Mon, 4 Nov 2019 13:10:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DD7C21E6F for ; Mon, 4 Nov 2019 13:10:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572873016; bh=949vWIINs2DmNoKqK1hD5vH+gLVeNnPzbPqsjchDiyA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=lcu98CFjzGqyxTmMBsPz1h5pJlV8XfWQWNtitlagVKsZC67Xdq6hw2eaafNgiYN1V 1MVe17KDQZ4mQwcUPZpKQK9MuNTpMNHpu28q3Gygbb+pOzw0ENmf0WQXpSgd1IQ8Z9 kJGQm0t85dvqcKCN8ywNnHEZAYTi1ckjtw0/5KW8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729262AbfKDNKM (ORCPT ); Mon, 4 Nov 2019 08:10:12 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:44032 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729252AbfKDNKL (ORCPT ); Mon, 4 Nov 2019 08:10:11 -0500 Received: by mail-lf1-f68.google.com with SMTP id v4so12192009lfd.11; Mon, 04 Nov 2019 05:10:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VqMrwoYt+5Te3Fp0RTQohq/LCLMxxZa1B7gKAbWNkJo=; b=r/lVsDNgdTDGSHejiSjIrVqVkLlvN4erS8w9vtwjGPfRIcBAQzUDrqda25O7PnZHjI gfuNnZsLC/DrzqaU0k9RQ1ZeqFcLaw3Z7y/cXlaRCvXP3+JDOFydXPz2y3t2BfqIJJbU P936hdjxwxJQsX78F6laRsLcGIjtnpIO8E7zWmfRwAlJBufs/CEFgVvy6sB4PodAfu49 YV5EhNOox8qBjRoatgHlgyWB//YPSsDInz/YxE99aaMopHqEZxkPQCZNwh+HYUq646vC 8JoZy0NunGU1Xpb6hf5c3lW6SmTzmbWPMkQLiUEj0g8ry/c7nJYfgaSpP2VNH81a6kg8 NTXQ== X-Gm-Message-State: APjAAAWd6gk4Re97JWHod28+vI/O8qYLkMCjsxCoquVTNuHqlogOJodb lW42Dqv/eJneUSOrzdWljeQ= X-Google-Smtp-Source: APXvYqwZMbg/m6nbHubf97d8K0xUKVmBD1Rr8yfixTsKSLakuNH3dxdbOTepGNGQ7j4VPnGRXPT5YA== X-Received: by 2002:a19:9116:: with SMTP id t22mr15917787lfd.99.1572873009470; Mon, 04 Nov 2019 05:10:09 -0800 (PST) Received: from neopili.qtec.com (cpe.xe-3-0-1-778.vbrnqe10.dk.customer.tdc.net. [80.197.57.18]) by smtp.gmail.com with ESMTPSA id z3sm5931801ljz.51.2019.11.04.05.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2019 05:10:08 -0800 (PST) From: Ricardo Ribalda Delgado To: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ricardo Ribalda Delgado Subject: [PATCH v2 3/3] v4l2-ctl: Support setting V4L2_CTRL_TYPE_AREA controls Date: Mon, 4 Nov 2019 14:10:00 +0100 Message-Id: <20191104131000.22359-3-ribalda@kernel.org> X-Mailer: git-send-email 2.24.0.rc1 In-Reply-To: <20191104131000.22359-1-ribalda@kernel.org> References: <20191104131000.22359-1-ribalda@kernel.org> MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org $ v4l2-ctl -d /dev/video1 -c area=123123x233 Signed-off-by: Ricardo Ribalda Delgado --- utils/v4l2-ctl/v4l2-ctl-common.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/utils/v4l2-ctl/v4l2-ctl-common.cpp b/utils/v4l2-ctl/v4l2-ctl-common.cpp index 95339561..e079c274 100644 --- a/utils/v4l2-ctl/v4l2-ctl-common.cpp +++ b/utils/v4l2-ctl/v4l2-ctl-common.cpp @@ -973,6 +973,10 @@ void common_set(cv4l_fd &_fd) strncpy(ctrl.string, iter->second.c_str(), qc.maximum); ctrl.string[qc.maximum] = 0; break; + case V4L2_CTRL_TYPE_AREA: + sscanf(iter->second.c_str(), "%ux%u", + &ctrl.p_area->width, &ctrl.p_area->height); + break; default: fprintf(stderr, "%s: unsupported payload type\n", qc.name);