From patchwork Mon Sep 17 21:34:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 10603451 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3BC396CB for ; Mon, 17 Sep 2018 21:35:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2984A29567 for ; Mon, 17 Sep 2018 21:35:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1D08829D85; Mon, 17 Sep 2018 21:35:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 850D729567 for ; Mon, 17 Sep 2018 21:35:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728009AbeIRDEI (ORCPT ); Mon, 17 Sep 2018 23:04:08 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:34318 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728338AbeIRDEH (ORCPT ); Mon, 17 Sep 2018 23:04:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=z3yKpwZoVctuvB5oL0qqr5vtzVFrGwRf05zvsoZfMak=; b=XjiDbOhytjVP EV8xsoRDy/vXe9AwS5l/8H8lKmAGpfHCa1nUEi2F0EcBunnKc17PSc/g9UuOSDUeAX21NufnI1fMg 5S93yJREMb1MvTxS+L3mEF+xn2q3r/u+gRotfI66mFexf7TCkwshIMNQfwSb95nv5xwagg5kfF+Cq pI8gE=; Received: from [209.121.128.187] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1g21AV-0000mh-1r; Mon, 17 Sep 2018 21:34:55 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id EADDC440078; Mon, 17 Sep 2018 22:34:52 +0100 (BST) From: Mark Brown To: Lubomir Rintel Cc: Mark Brown , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Mark Brown , linux-spi@vger.kernel.org Subject: Applied "spi: pxa2xx: Remove the shutdown callback" to the spi tree In-Reply-To: <20180917121124.21305-1-lkundrak@v3.sk> Message-Id: <20180917213452.EADDC440078@finisterre.ee.mobilebroadband> Date: Mon, 17 Sep 2018 22:34:52 +0100 (BST) Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The patch spi: pxa2xx: Remove the shutdown callback has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 8089babee17c09cdd51ac1390e444ee0be0c2291 Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Mon, 17 Sep 2018 14:11:24 +0200 Subject: [PATCH] spi: pxa2xx: Remove the shutdown callback It makes no sense to remove the device on shutdown. And it break things when the hardware crucial for shutdown (such as the embedded controller) is attached to the SPI bus. Signed-off-by: Lubomir Rintel Signed-off-by: Mark Brown --- drivers/spi/spi-pxa2xx.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index e3cbc66a7061..fc9aac214239 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1764,14 +1764,6 @@ static int pxa2xx_spi_remove(struct platform_device *pdev) return 0; } -static void pxa2xx_spi_shutdown(struct platform_device *pdev) -{ - int status = 0; - - if ((status = pxa2xx_spi_remove(pdev)) != 0) - dev_err(&pdev->dev, "shutdown failed with %d\n", status); -} - #ifdef CONFIG_PM_SLEEP static int pxa2xx_spi_suspend(struct device *dev) { @@ -1845,7 +1837,6 @@ static struct platform_driver driver = { }, .probe = pxa2xx_spi_probe, .remove = pxa2xx_spi_remove, - .shutdown = pxa2xx_spi_shutdown, }; static int __init pxa2xx_spi_init(void)