From patchwork Thu Nov 7 11:42:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mihail Atanassov X-Patchwork-Id: 11232687 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CA49713BD for ; Thu, 7 Nov 2019 11:42:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B13E6218AE for ; Thu, 7 Nov 2019 11:42:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B13E6218AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ABC376F65B; Thu, 7 Nov 2019 11:42:41 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00058.outbound.protection.outlook.com [40.107.0.58]) by gabe.freedesktop.org (Postfix) with ESMTPS id 993266F65B for ; Thu, 7 Nov 2019 11:42:39 +0000 (UTC) Received: from VI1PR08CA0202.eurprd08.prod.outlook.com (2603:10a6:800:d2::32) by VE1PR08MB4862.eurprd08.prod.outlook.com (2603:10a6:802:a7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Thu, 7 Nov 2019 11:42:36 +0000 Received: from AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::201) by VI1PR08CA0202.outlook.office365.com (2603:10a6:800:d2::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2430.23 via Frontend Transport; Thu, 7 Nov 2019 11:42:36 +0000 Received-SPF: Fail (protection.outlook.com: domain of arm.com does not designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT037.mail.protection.outlook.com (10.152.17.241) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2430.21 via Frontend Transport; Thu, 7 Nov 2019 11:42:36 +0000 Received: ("Tessian outbound 6481c7fa5a3c:v33"); Thu, 07 Nov 2019 11:42:36 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 645030880de1a3c0 X-CR-MTA-TID: 64aa7808 Received: from 0078b69d08ee.2 (cr-mta-lb-1.cr-mta-net [104.47.10.59]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 31FF26D5-CEA3-4BE4-BA96-E536CF898A93.1; Thu, 07 Nov 2019 11:42:30 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2059.outbound.protection.outlook.com [104.47.10.59]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0078b69d08ee.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 07 Nov 2019 11:42:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ioa/rERS0IR96CSsebILIvJdVJfjfUwQ+a7LD3u/cN5l4Gpz+mjOA+8W/1WTo6htPTSHgxZaNnTA8ILz1rFhv1EdLXDSqHWlM8pFnxgDZRAei+iT4RqA6kDNOY9h9Sj2A3lA1rhrTEDAUOtQYx23tqT7DS3116XB71sbxYtXX6VzTjIs/QyUE7pjS1zhkuC136cxbI+H92vbGk95pzgbCDGCcKDhVmCBVmpuHevG1K6Bb75nVcAAtbFlhMWKCoFNrxNKCA10QwWO5BPQIsU/a+RI5SKWLJTo2Vg7iW8jmbgfq0eQL5o7tUdDIP82z/ZEJCsxC7UaTm/BQcamrx+xuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Px3I5x1exalU7sGPOYZ9So+eq2jzh/DWgR8Nc28y2p4=; b=Ige5gDllKU8Jl7sUi8isYnY40owRp57XStDVnugbNw6dc1rTwyZ5yUfNsL3UiS6fnGOhDsAsFjSWVns+k7e1yzWFx1P7hw0VSl1MiijSyx2+TI4/HD1Lt34bzM+ZHSi+OxQ67o5mNmHikaNtTDTNEdpYFHZkdjfJ2CiFqSFMHg0cIKwQ8OI9qgJ2rBuDAtyjItt7c+iByieR4jiNYYf7X+TP6wTqnH/p+KaeYGC+yZytXihbL8Zzj50znGbi6YAoynlyzxMGCME9lzcJUjcrNgphLTwtS7eC2KeU05dPxYBU/KljzdtRED0+G87gSZ/63nnBfBXprkIyHibDUoKvIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from VI1PR08MB4078.eurprd08.prod.outlook.com (20.178.127.92) by VI1PR08MB4351.eurprd08.prod.outlook.com (20.179.27.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Thu, 7 Nov 2019 11:42:29 +0000 Received: from VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::8191:f0ac:574a:d24d]) by VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::8191:f0ac:574a:d24d%3]) with mapi id 15.20.2408.028; Thu, 7 Nov 2019 11:42:29 +0000 From: Mihail Atanassov To: "dri-devel@lists.freedesktop.org" Subject: [PATCH v2 1/5] drm/komeda: Add debugfs node to control error verbosity Thread-Topic: [PATCH v2 1/5] drm/komeda: Add debugfs node to control error verbosity Thread-Index: AQHVlWBvEMFUMNrqkUyDY5X/ImK4tw== Date: Thu, 7 Nov 2019 11:42:28 +0000 Message-ID: <20191107114155.54307-2-mihail.atanassov@arm.com> References: <20191107114155.54307-1-mihail.atanassov@arm.com> In-Reply-To: <20191107114155.54307-1-mihail.atanassov@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.140.106.55] x-clientproxiedby: LO2P265CA0146.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::14) To VI1PR08MB4078.eurprd08.prod.outlook.com (2603:10a6:803:e5::28) x-mailer: git-send-email 2.23.0 Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 20a34134-500f-450f-8d47-08d7637795c9 X-MS-TrafficTypeDiagnostic: VI1PR08MB4351:|VI1PR08MB4351:|VE1PR08MB4862: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:1850;OLM:1850; x-forefront-prvs: 0214EB3F68 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(396003)(39860400002)(376002)(136003)(189003)(199004)(11346002)(316002)(54906003)(446003)(476003)(50226002)(71200400001)(6512007)(305945005)(6916009)(2906002)(8936002)(2616005)(44832011)(4326008)(6436002)(66066001)(256004)(486006)(86362001)(26005)(71190400001)(36756003)(52116002)(2351001)(6506007)(99286004)(6486002)(102836004)(2501003)(76176011)(386003)(186003)(6116002)(14454004)(66946007)(66476007)(66556008)(64756008)(66446008)(25786009)(478600001)(1076003)(3846002)(8676002)(81166006)(81156014)(7736002)(5640700003)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB4351; H:VI1PR08MB4078.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: O6fniMMiVL7OOTWcx4Fpdn0GZf/4hC/7AiTbyJwvDTeRaPWaOCgbb6d3XBgVaVounvbFj2azzgmxdCxv6b8Hd7QGemG/8lTedZGqSH+ZOcEFTTIyEYBJ9rpapOvRYEdy4TacFDWw68BrYywusoOpWFLwNZowH/t4iC+3wkcCgOms7FKokjYwZYPMTOk8Qt6mGpZKqNr9maK3gqVY36DL2GZaK7awGdczv+yg6+e0Bt07rMd/UltxKmv/HS/Zj6O8o0PpUYKLvZFsth0Wf6EKrie/KgdL64c/FNMXBolBMQnN0m9HukqSn38A2xO8Vl57jZ3AZkTv7ImDRw/i1vfKnnrzYQs87NJII1TRRZYF8LYlxOvgPrzNXLSmJuK/Y1UnJjSpt7nLYhHc6DEzlSJZ9ZRdHj8hgaoXUnmBymDnYG1OFf91umvIafj3nUhsiNao MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4351 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(39860400002)(136003)(376002)(1110001)(339900001)(189003)(199004)(11346002)(6116002)(2351001)(8676002)(6916009)(86362001)(66066001)(5660300002)(5640700003)(81166006)(386003)(14454004)(356004)(76176011)(486006)(3846002)(47776003)(316002)(22756006)(81156014)(99286004)(476003)(102836004)(105606002)(2616005)(126002)(6506007)(186003)(26005)(2501003)(50226002)(336012)(26826003)(446003)(107886003)(70206006)(4326008)(478600001)(54906003)(70586007)(8936002)(8746002)(25786009)(7736002)(305945005)(76130400001)(2906002)(36756003)(23756003)(6512007)(50466002)(1076003)(6486002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB4862; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:Fail; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 92ec3c68-c2d0-4213-9fd9-08d763779159 NoDisclaimer: True X-Forefront-PRVS: 0214EB3F68 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SA2fRD75Y2KUNFWK5vZEeKFDAAvDiC5CGvR98wxjiFwsCe8U2HxhP2VXsxq0rmSFyBZl4FIaN4hzYE9EUxYOvy0IEWasIvxI9rL6lFKrfgCJ3lj/Haf5RsbE7s8kQPIWVFvfDxP3AQKsSzkOcnzePmeQKiZvGdil5Yo+MTwUjVz8wR8qnoM07kfxBVk98zqvY2bqt+UXkMnN/9tEY7oq/FTy9vQzpSsiJaF8a5gA4TBHS7lG4N1TXwXKAvEz0uRlGYo4k7xoF0RzB26mKquOOeNReTQKSj6dh6Li2lDeIK/VY9vpiOg/5J/pgoHA85qv33p7Z9tEt2yFO2UI8qHzzzWU6oIEgsF1tB/8PuS7qLMseHM4sQGqcYwXVLjk2pSCXzle6yNWP0/aqbjiYzXMCGACT7Y5JWay67Z2wXYbi7hQ/mJo3CstxvjV6YC+dm6w X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2019 11:42:36.0906 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 20a34134-500f-450f-8d47-08d7637795c9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4862 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Px3I5x1exalU7sGPOYZ9So+eq2jzh/DWgR8Nc28y2p4=; b=MDIcln5YVLw6ZbC2AFHkCetlmx6MjLTc5GHrSUiLdDI5H6eKOlFMpoH/X70r0I0QWV/ImCiwsrH1s2yZ2cRRNkatG0PiA2eeJ0aJ74k9F8GigHNi35TwJItz60xAbbchiiqRyIQT9lGiBoAxYLVXFsNR17nL2ppM4t8zGwGmxQ8= X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Px3I5x1exalU7sGPOYZ9So+eq2jzh/DWgR8Nc28y2p4=; b=MDIcln5YVLw6ZbC2AFHkCetlmx6MjLTc5GHrSUiLdDI5H6eKOlFMpoH/X70r0I0QWV/ImCiwsrH1s2yZ2cRRNkatG0PiA2eeJ0aJ74k9F8GigHNi35TwJItz60xAbbchiiqRyIQT9lGiBoAxYLVXFsNR17nL2ppM4t8zGwGmxQ8= X-Mailman-Original-Authentication-Results: spf=fail (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.freedesktop.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.freedesktop.org; dmarc=none action=none header.from=arm.com; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mihail Atanassov , David Airlie , Liviu Dudau , "linux-kernel@vger.kernel.org" , "james qian wang \(Arm Technology China\)" , "Lowry Li \(Arm Technology China\)" , nd , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Named 'err_verbosity', currently with only 1 active bit in that replicates the existing level - print error events once per flip. Reviewed-by: James Qian Wang (Arm Technology China) Signed-off-by: Mihail Atanassov Acked-by: Liviu Dudau --- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 4 ++++ drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 14 ++++++++++++-- drivers/gpu/drm/arm/display/komeda/komeda_event.c | 9 +++++++-- drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 2 +- 4 files changed, 24 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c index 14d5c5da9e3b..4e46f650fddf 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c @@ -58,6 +58,8 @@ static void komeda_debugfs_init(struct komeda_dev *mdev) mdev->debugfs_root = debugfs_create_dir("komeda", NULL); debugfs_create_file("register", 0444, mdev->debugfs_root, mdev, &komeda_register_fops); + debugfs_create_x16("err_verbosity", 0664, mdev->debugfs_root, + &mdev->err_verbosity); } #endif @@ -273,6 +275,8 @@ struct komeda_dev *komeda_dev_create(struct device *dev) goto err_cleanup; } + mdev->err_verbosity = KOMEDA_DEV_PRINT_ERR_EVENTS; + #ifdef CONFIG_DEBUG_FS komeda_debugfs_init(mdev); #endif diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h index 414200233b64..b5bd3d5898ee 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h @@ -202,6 +202,14 @@ struct komeda_dev { /** @debugfs_root: root directory of komeda debugfs */ struct dentry *debugfs_root; + /** + * @err_verbosity: bitmask for how much extra info to print on error + * + * See KOMEDA_DEV_* macros for details. + */ + u16 err_verbosity; + /* Print a single line per error per frame with error events. */ +#define KOMEDA_DEV_PRINT_ERR_EVENTS BIT(0) }; static inline bool @@ -219,9 +227,11 @@ void komeda_dev_destroy(struct komeda_dev *mdev); struct komeda_dev *dev_to_mdev(struct device *dev); #ifdef CONFIG_DRM_KOMEDA_ERROR_PRINT -void komeda_print_events(struct komeda_events *evts); +void komeda_print_events(struct komeda_events *evts, struct drm_device *dev); #else -static inline void komeda_print_events(struct komeda_events *evts) {} +static inline void komeda_print_events(struct komeda_events *evts, + struct drm_device *dev) +{} #endif int komeda_dev_resume(struct komeda_dev *mdev); diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c index a36fb86cc054..575ed4df74ed 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c @@ -107,10 +107,12 @@ static bool is_new_frame(struct komeda_events *a) (KOMEDA_EVENT_FLIP | KOMEDA_EVENT_EOW); } -void komeda_print_events(struct komeda_events *evts) +void komeda_print_events(struct komeda_events *evts, struct drm_device *dev) { - u64 print_evts = KOMEDA_ERR_EVENTS; + u64 print_evts = 0; static bool en_print = true; + struct komeda_dev *mdev = dev->dev_private; + u16 const err_verbosity = mdev->err_verbosity; /* reduce the same msg print, only print the first evt for one frame */ if (evts->global || is_new_frame(evts)) @@ -118,6 +120,9 @@ void komeda_print_events(struct komeda_events *evts) if (!en_print) return; + if (err_verbosity & KOMEDA_DEV_PRINT_ERR_EVENTS) + print_evts |= KOMEDA_ERR_EVENTS; + if ((evts->global | evts->pipes[0] | evts->pipes[1]) & print_evts) { char msg[256]; struct komeda_str str; diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c index d49772de93e0..e30a5b43caa9 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c @@ -48,7 +48,7 @@ static irqreturn_t komeda_kms_irq_handler(int irq, void *data) memset(&evts, 0, sizeof(evts)); status = mdev->funcs->irq_handler(mdev, &evts); - komeda_print_events(&evts); + komeda_print_events(&evts, drm); /* Notify the crtc to handle the events */ for (i = 0; i < kms->n_crtcs; i++) From patchwork Thu Nov 7 11:42:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mihail Atanassov X-Patchwork-Id: 11232689 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 489E016B1 for ; Thu, 7 Nov 2019 11:42:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 182D121D6C for ; Thu, 7 Nov 2019 11:42:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 182D121D6C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE1BF6F65F; Thu, 7 Nov 2019 11:42:45 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03on0600.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe09::600]) by gabe.freedesktop.org (Postfix) with ESMTPS id 76C036F661 for ; Thu, 7 Nov 2019 11:42:43 +0000 (UTC) Received: from VI1PR08CA0195.eurprd08.prod.outlook.com (2603:10a6:800:d2::25) by VE1PR08MB5184.eurprd08.prod.outlook.com (2603:10a6:803:105::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Thu, 7 Nov 2019 11:42:40 +0000 Received: from AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::206) by VI1PR08CA0195.outlook.office365.com (2603:10a6:800:d2::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.22 via Frontend Transport; Thu, 7 Nov 2019 11:42:40 +0000 Received-SPF: Fail (protection.outlook.com: domain of arm.com does not designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT015.mail.protection.outlook.com (10.152.16.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.21 via Frontend Transport; Thu, 7 Nov 2019 11:42:39 +0000 Received: ("Tessian outbound 927f2cdd66cc:v33"); Thu, 07 Nov 2019 11:42:39 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4826ba7dcdbc61c1 X-CR-MTA-TID: 64aa7808 Received: from d74b0305b8f4.2 (cr-mta-lb-1.cr-mta-net [104.47.10.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id BDC9ABAD-C30F-491D-856C-536121798DAD.1; Thu, 07 Nov 2019 11:42:34 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2050.outbound.protection.outlook.com [104.47.10.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d74b0305b8f4.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 07 Nov 2019 11:42:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GMnaPiy0w03Jr9WS7EMWxfqGW73SdCFfHrDUm8OLTZUwW4Hlq19R+r5MvbZqwCZBKAHM1z1pcTDaQMMNEbIzoC7Jm/T4WaObBQakc0shhAIcnY2NF3CVy+fUhgmONqdPSrvJgvKJEkl8P4gtHowhrX6xK0cnLlfH7/Nd4wAzNjnTjCB+ZweAUEphZYnqEBqAuMXFSsn8iaFiqh23N/XCDfi4YeMl/M/Xe0o+8X2cQIumOycTzKRUmdSNCkAv3gD+Oz/lR6IEmzuBqLbJxrKAZeG7c5UsMaPsxFFSKFC7QnWOYgwrH44qfVAyqdtmCb6bOZptP+G12TovfqcuMMj4SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+b3iYlLZWzR/gv7TQUT6UmWjYNPax9/PEPOebKvxCHE=; b=btguVs0hRqaSOsyFxyWwZh44IDJN3O06f1Q/GwUWsyh95on2KRNP6L+jdztith65ZpcYcomJT7Pzwc7858UX9IqHO7gkbg50I789EEJhngHwJI8Gs6R6rPjQ7J/lFdHS8TYUQI8+WD/tIAH+vEdLuiNi+SLyyuYznDKX0fsnHODJon3ezRvbq1gRlG6TDjWrVn0MPSYBupfQy5PeaVMVaTtnUxgy9XnLfwAsUI2oQgUJ1rBn6iDD7iASIG5XdAb3LPVBrFgrjHvALuy0aFqBzOGXuZ/0QE2jaO/Vpt7CPNAtEzV1f6XrW+VlDHAc3hcev3JED3Ly+fuzSJFdp2UGSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from VI1PR08MB4078.eurprd08.prod.outlook.com (20.178.127.92) by VI1PR08MB4351.eurprd08.prod.outlook.com (20.179.27.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Thu, 7 Nov 2019 11:42:33 +0000 Received: from VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::8191:f0ac:574a:d24d]) by VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::8191:f0ac:574a:d24d%3]) with mapi id 15.20.2408.028; Thu, 7 Nov 2019 11:42:33 +0000 From: Mihail Atanassov To: "dri-devel@lists.freedesktop.org" Subject: [PATCH v2 2/5] drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT Thread-Topic: [PATCH v2 2/5] drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT Thread-Index: AQHVlWBx2XXtfB7TZUW+rZWpSHV87g== Date: Thu, 7 Nov 2019 11:42:32 +0000 Message-ID: <20191107114155.54307-3-mihail.atanassov@arm.com> References: <20191107114155.54307-1-mihail.atanassov@arm.com> In-Reply-To: <20191107114155.54307-1-mihail.atanassov@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.140.106.55] x-clientproxiedby: LO2P265CA0146.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::14) To VI1PR08MB4078.eurprd08.prod.outlook.com (2603:10a6:803:e5::28) x-mailer: git-send-email 2.23.0 Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 72c334e0-31ca-4398-8e81-08d7637797fc X-MS-TrafficTypeDiagnostic: VI1PR08MB4351:|VI1PR08MB4351:|VE1PR08MB5184: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:1051;OLM:1051; x-forefront-prvs: 0214EB3F68 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(396003)(39860400002)(376002)(136003)(189003)(199004)(11346002)(316002)(54906003)(446003)(476003)(50226002)(71200400001)(6512007)(305945005)(6916009)(2906002)(8936002)(2616005)(44832011)(4326008)(6436002)(66066001)(256004)(486006)(86362001)(26005)(71190400001)(36756003)(52116002)(2351001)(14444005)(6506007)(99286004)(6486002)(102836004)(2501003)(76176011)(386003)(186003)(6116002)(14454004)(66946007)(66476007)(66556008)(64756008)(66446008)(25786009)(478600001)(1076003)(3846002)(8676002)(81166006)(81156014)(7736002)(5640700003)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB4351; H:VI1PR08MB4078.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ZZZB3el+pAAntxthtfbiPspqYYl/hnAHWMIbzr0q83FvDdB7TnteaNCxSwfAw/RHFReQfAtUyrbVHkRdoO24YWNr2SJIxFcmKjrVNDJ3I0ko2IdQqu1hcZTvUxLsD3SMgxF/HuZvHrcfigy7jkH9Gk3KzSl2YY34NI3SDMdAdCxFOK18Zm3X/BpqWeCdOr4atQpn4KrHe3z6IuQrHg5zDguIOC3u0t1Erko0uu69Q0EfDgwcf57HjfRmRBEIRPGwqR/G+r5/1VNCka92XYpYIbfrFC6SHUpEKz6oROCNyG47LYDC+FUpoTUsPvWNqt/NmkkGCdwT/+j83rzjOsGmbsrvLmnlcUQrQSlqhutAcfF4r2xmy+4JMoHYSjBh/Cc4Fr+21ZoK/YWuJDhgG+R65chltd9ku+zOngN60YUHBovMjBy2OOf2b9TlKkzLZlJR MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4351 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(136003)(396003)(39860400002)(376002)(346002)(1110001)(339900001)(199004)(189003)(23756003)(26005)(8746002)(14444005)(446003)(2351001)(3846002)(70586007)(6916009)(81156014)(476003)(1076003)(81166006)(8936002)(11346002)(22756006)(186003)(386003)(356004)(6506007)(336012)(6116002)(14454004)(2616005)(2501003)(8676002)(2906002)(102836004)(50226002)(25786009)(6512007)(76176011)(126002)(26826003)(316002)(5640700003)(105606002)(7736002)(99286004)(76130400001)(305945005)(478600001)(6486002)(5660300002)(36756003)(86362001)(54906003)(47776003)(486006)(70206006)(4326008)(66066001)(107886003)(50466002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB5184; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:Fail; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: e53b8a69-a7f0-44bf-589a-08d7637793a7 NoDisclaimer: True X-Forefront-PRVS: 0214EB3F68 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P1rObSokGVQi+ZklcMvikf3pttwkyUbObtXbUaZ+dOQQQL14ODuxxHANL+RJ3Cc6+fPo/HrISelxYtdsnnySPRbThWdf5aA9PmSSDHNW/SJyIzCX8CrvQq+uGz7gJqv8VslRUB1qdta4iIg58+5+JhBIQt1xUeDTsJlbeRRgfqMaZd4HUGI+z0JZKKxQsu0AQoTfIAhKQKLLxj7mj6DN3jLJHVcLjzg2P1hFZt649m9LtmAHcLj+x/9t1vJ5Ow9a0NVYUSPXHedq94FJCCU8xprtvYrSMuJMlpiJY2FxBSi62h+yrtzhw2AxkF975ShkqfOSTXO4AAUg7Vx7mhGY9BbAdU1gDGYqkgcnzDbtmeL8sVejuggEprRu0ApZM80SAtTE3EZ16GqUISs5FS7EKXvZS2oH99HA1lD4aE+iidFgbWAT2tJ1fGEHmOdZQ37f X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2019 11:42:39.7763 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 72c334e0-31ca-4398-8e81-08d7637797fc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5184 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+b3iYlLZWzR/gv7TQUT6UmWjYNPax9/PEPOebKvxCHE=; b=OpbLGSyvQz6d0KOmYEkm2f3VyTunopVEoT9Oc1W88pmJdminO/AqbC1hOkoxdNe3cUIn7MTV5W/fnKfm8rmUxZiVt9seYrVs4J28kBcatocqtwV+gN3Uo4S/r/O507H0+7A/o0IfKJRwfUucpts487lI6852wFqmOrR84KEK3Vs= X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+b3iYlLZWzR/gv7TQUT6UmWjYNPax9/PEPOebKvxCHE=; b=OpbLGSyvQz6d0KOmYEkm2f3VyTunopVEoT9Oc1W88pmJdminO/AqbC1hOkoxdNe3cUIn7MTV5W/fnKfm8rmUxZiVt9seYrVs4J28kBcatocqtwV+gN3Uo4S/r/O507H0+7A/o0IfKJRwfUucpts487lI6852wFqmOrR84KEK3Vs= X-Mailman-Original-Authentication-Results: spf=fail (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.freedesktop.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.freedesktop.org; dmarc=none action=none header.from=arm.com; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mihail Atanassov , David Airlie , Liviu Dudau , "linux-kernel@vger.kernel.org" , "james qian wang \(Arm Technology China\)" , "Lowry Li \(Arm Technology China\)" , nd , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Now that there's a debugfs node to control the same, remove the config option. Reviewed-by: James Qian Wang (Arm Technology China) Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/display/Kconfig | 6 ------ drivers/gpu/drm/arm/display/komeda/Makefile | 5 ++--- drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 6 ------ 3 files changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/arm/display/Kconfig b/drivers/gpu/drm/arm/display/Kconfig index e87ff8623076..cec0639e3aa1 100644 --- a/drivers/gpu/drm/arm/display/Kconfig +++ b/drivers/gpu/drm/arm/display/Kconfig @@ -12,9 +12,3 @@ config DRM_KOMEDA Processor driver. It supports the D71 variants of the hardware. If compiled as a module it will be called komeda. - -config DRM_KOMEDA_ERROR_PRINT - bool "Enable komeda error print" - depends on DRM_KOMEDA - help - Choose this option to enable error printing. diff --git a/drivers/gpu/drm/arm/display/komeda/Makefile b/drivers/gpu/drm/arm/display/komeda/Makefile index f095a1c68ac7..1931a7fa1a14 100644 --- a/drivers/gpu/drm/arm/display/komeda/Makefile +++ b/drivers/gpu/drm/arm/display/komeda/Makefile @@ -16,12 +16,11 @@ komeda-y := \ komeda_crtc.o \ komeda_plane.o \ komeda_wb_connector.o \ - komeda_private_obj.o + komeda_private_obj.o \ + komeda_event.o komeda-y += \ d71/d71_dev.o \ d71/d71_component.o -komeda-$(CONFIG_DRM_KOMEDA_ERROR_PRINT) += komeda_event.o - obj-$(CONFIG_DRM_KOMEDA) += komeda.o diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h index b5bd3d5898ee..831c375180f8 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h @@ -226,13 +226,7 @@ void komeda_dev_destroy(struct komeda_dev *mdev); struct komeda_dev *dev_to_mdev(struct device *dev); -#ifdef CONFIG_DRM_KOMEDA_ERROR_PRINT void komeda_print_events(struct komeda_events *evts, struct drm_device *dev); -#else -static inline void komeda_print_events(struct komeda_events *evts, - struct drm_device *dev) -{} -#endif int komeda_dev_resume(struct komeda_dev *mdev); int komeda_dev_suspend(struct komeda_dev *mdev); From patchwork Thu Nov 7 11:42:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mihail Atanassov X-Patchwork-Id: 11232691 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8D34A16B1 for ; Thu, 7 Nov 2019 11:42:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74CDD21D6C for ; Thu, 7 Nov 2019 11:42:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74CDD21D6C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD3E76F662; Thu, 7 Nov 2019 11:42:47 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00054.outbound.protection.outlook.com [40.107.0.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A1DD6F662 for ; Thu, 7 Nov 2019 11:42:46 +0000 (UTC) Received: from VI1PR08CA0122.eurprd08.prod.outlook.com (2603:10a6:800:d4::24) by AM0PR08MB3428.eurprd08.prod.outlook.com (2603:10a6:208:de::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Thu, 7 Nov 2019 11:42:44 +0000 Received: from DB5EUR03FT047.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::201) by VI1PR08CA0122.outlook.office365.com (2603:10a6:800:d4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2430.20 via Frontend Transport; Thu, 7 Nov 2019 11:42:43 +0000 Received-SPF: Fail (protection.outlook.com: domain of arm.com does not designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT047.mail.protection.outlook.com (10.152.21.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2430.21 via Frontend Transport; Thu, 7 Nov 2019 11:42:43 +0000 Received: ("Tessian outbound 6481c7fa5a3c:v33"); Thu, 07 Nov 2019 11:42:43 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ab1cdf98c70ca652 X-CR-MTA-TID: 64aa7808 Received: from a8bf8e949972.2 (cr-mta-lb-1.cr-mta-net [104.47.10.51]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 215E9767-0A9C-4AC4-9364-6F886BCDD82A.1; Thu, 07 Nov 2019 11:42:38 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2051.outbound.protection.outlook.com [104.47.10.51]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a8bf8e949972.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 07 Nov 2019 11:42:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iKxtUfUqjpuChkc7XNwD1LV7QVleleWVeMuU8JZt/1r6HO2QTwVAXo+Z306Z2vZEAlAJC3JeC0SMI5sxiaQ6dV98VteMHJjc0Vjzt8Ok6zalLGy3VVVGDVUKW1zVcYGj7vvWhD9s9WS6CuVe0VqseIS0u58kqJWtYQYkrZ8ivkLlmfsLLc4XU7exjJwh6aP/gKyyiwXbMPBZoZ3xDGuep2/RCMBB6acBcLOsYotSaRMBHdRyHbN+4XGmQCQBw3gqGckLztkkWi6UHXiAFEmrAWBuw33iuXuoGCYGPW0/u343OZEJCFApUoWzEWUQkLl13JbtMnnOCBfyp93sts9Z+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cNd6MJSFo+gICC6cfGG5jN+STD2M9K1MfN8WY7NyFS8=; b=Vp37GNBtwbdaVFxhrxgN+lr3kYZAv22SezYCPVI+nyJhiaqwkliYpZuIjJB63rrE7pqduOuFm7j7xdC/Do9g43OzqCz9a43XTuhP9r/fKogCYnM59Wu4bQcnQ1vR9aSFrLLxhCLOsXsX09SHroHymJ8WlCSko3QIUM+iTVjdncAmiElz+EnQFJBec1eO6F5ErxS7a4y9rnIR2nK/FU2YT5Bg8uChzzqIwWbwrSpFyyBvOl3zudg+AhIhqFSrix3UsMbh+gE/3zibOMjvc9IzaVt3poZkv+CYSCMMMbWng9t8kxyD5yqHspDhRbai1J9+0khY7NAvHWnaruLRSQi2XQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from VI1PR08MB4078.eurprd08.prod.outlook.com (20.178.127.92) by VI1PR08MB4351.eurprd08.prod.outlook.com (20.179.27.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Thu, 7 Nov 2019 11:42:36 +0000 Received: from VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::8191:f0ac:574a:d24d]) by VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::8191:f0ac:574a:d24d%3]) with mapi id 15.20.2408.028; Thu, 7 Nov 2019 11:42:36 +0000 From: Mihail Atanassov To: "dri-devel@lists.freedesktop.org" Subject: [PATCH v2 3/5] drm/komeda: Optionally dump DRM state on interrupts Thread-Topic: [PATCH v2 3/5] drm/komeda: Optionally dump DRM state on interrupts Thread-Index: AQHVlWBzAPfnXaxWaUmc63HFBTtG6g== Date: Thu, 7 Nov 2019 11:42:36 +0000 Message-ID: <20191107114155.54307-4-mihail.atanassov@arm.com> References: <20191107114155.54307-1-mihail.atanassov@arm.com> In-Reply-To: <20191107114155.54307-1-mihail.atanassov@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.140.106.55] x-clientproxiedby: LO2P265CA0146.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::14) To VI1PR08MB4078.eurprd08.prod.outlook.com (2603:10a6:803:e5::28) x-mailer: git-send-email 2.23.0 Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 022ed2e0-77e4-4393-36fd-08d763779a52 X-MS-TrafficTypeDiagnostic: VI1PR08MB4351:|VI1PR08MB4351:|AM0PR08MB3428: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; x-forefront-prvs: 0214EB3F68 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(396003)(39860400002)(376002)(136003)(189003)(199004)(11346002)(316002)(54906003)(446003)(476003)(50226002)(71200400001)(6512007)(305945005)(6916009)(2906002)(8936002)(2616005)(44832011)(4326008)(6436002)(66066001)(256004)(486006)(86362001)(26005)(71190400001)(36756003)(52116002)(2351001)(14444005)(6506007)(99286004)(6486002)(102836004)(2501003)(76176011)(386003)(186003)(6116002)(14454004)(66946007)(66476007)(66556008)(64756008)(66446008)(25786009)(478600001)(1076003)(3846002)(8676002)(81166006)(81156014)(7736002)(5640700003)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB4351; H:VI1PR08MB4078.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Sppi3GhYqwNfLGi3lL4FzrrODmoGBeeZPhG/Rvy9xFsZ7JwMck5Je0cAGpHTOKjmHGooMr5HoqVptTmT/9AaDxqi7WsQeUNFbR8TGD3rllK9MrpBwfbO0ylaADQ60DrdYWjn2iix4pBTRHxMcb4MJ1e0BiPLB30gULt7XfrnDsh5QWz3k30J6q59efawANKe5vlwseK6TVua7T6TgLjamtViFGYHE5sKf0wpxzlz+fL+n2HCyPRndcKitgt6vRNfuq8KW4G45cGPrmcqdQo8efr3PcKS0sfJmnrZ+1ixG177ARdyk8kWi8eHyMTKLAjb66wsMDPYJwIPglRgyPU1L+I8nz2acVjTmuSq4gGOnX6igKZk8zGS9w+VawFugtuwB9TiYGtvh41NPc/y2A/ZL/2FXd4QmdtpTBY+4qBNVSLLidYUHbvYcnTOcXZnoSMb MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4351 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(39860400002)(346002)(376002)(1110001)(339900001)(199004)(189003)(5660300002)(14454004)(2351001)(5640700003)(23756003)(70206006)(70586007)(14444005)(6486002)(446003)(86362001)(11346002)(54906003)(2501003)(478600001)(36756003)(26826003)(126002)(476003)(105606002)(76130400001)(2906002)(486006)(2616005)(336012)(22756006)(76176011)(66066001)(4326008)(50466002)(50226002)(7736002)(356004)(6916009)(316002)(186003)(47776003)(6506007)(3846002)(386003)(26005)(6116002)(102836004)(99286004)(25786009)(1076003)(107886003)(305945005)(81166006)(6512007)(81156014)(8936002)(8746002)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB3428; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:Fail; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: b3d7cc57-46bc-4c34-000b-08d7637795f4 NoDisclaimer: True X-Forefront-PRVS: 0214EB3F68 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b/L4Q0f/AhXLqPCGOrvWmVbJAxf0iI088IRkNw8McQXpLwwTcoUaOwsmCis0FIdEKHVxUrMMa/X9hSe0QSk/T/JbTNELRla3RXKk+WUT8R4nhKKkqSJTQI1MC8uRDL1+Cm2Ert/BYgb6KsRfvx1FtcCoKqiET4YULDYxRAd/wpj2rtsbZx8YQ0O6wcwR7EsXA6SXNGUJ43AQ6DRZZxDZvxUwtoWeJ9gLSRNmvQkMcPU+vf5pK63MKGGC2JIBjYA7Yfoefbhaf3qNd9R1D+NdXZRs6EB33i/ylruxzVVIge3gllilm5AHC2BkKNWXxIs2l0XR0NmJisoQfeHyf2fBvANPT4WzRuW1yW2C7VeF+sIAquwzHnqLrYScFOYEg76binvpitkNf+OXdh4yE1eT6oof9+5cQ4jtihT8GW0zPBnB34mhJsX1fcmXlSYP1q6m X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2019 11:42:43.7021 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 022ed2e0-77e4-4393-36fd-08d763779a52 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3428 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cNd6MJSFo+gICC6cfGG5jN+STD2M9K1MfN8WY7NyFS8=; b=UwN/rx3G5TDCIZrNv3nXg3hl/xr1r9Trs7l3CgI3t4TbjuN/y1D9uONSBhyf/svXeFEVmxEaL1YBGoTYjlwNzPpaCIG2Y/699xZHSdmGX9aMf6EEzCbO/TOLIdQgMSuchI4VMoxP6uvsO3vo69drllVkgKS4K8p+lnQetC/V39Q= X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cNd6MJSFo+gICC6cfGG5jN+STD2M9K1MfN8WY7NyFS8=; b=UwN/rx3G5TDCIZrNv3nXg3hl/xr1r9Trs7l3CgI3t4TbjuN/y1D9uONSBhyf/svXeFEVmxEaL1YBGoTYjlwNzPpaCIG2Y/699xZHSdmGX9aMf6EEzCbO/TOLIdQgMSuchI4VMoxP6uvsO3vo69drllVkgKS4K8p+lnQetC/V39Q= X-Mailman-Original-Authentication-Results: spf=fail (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.freedesktop.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.freedesktop.org; dmarc=none action=none header.from=arm.com; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mihail Atanassov , David Airlie , Liviu Dudau , "linux-kernel@vger.kernel.org" , "james qian wang \(Arm Technology China\)" , "Lowry Li \(Arm Technology China\)" , nd , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" It's potentially useful information when diagnosing error/warn IRQs, so dump it to dmesg with a drm_info_printer. Hide this extra debug dumping behind another komeda_dev->err_verbosity bit. Note that there's not much sense in dumping it for INFO events, since the VSYNC event will swamp the log. Reviewed-by: James Qian Wang (Arm Technology China) Signed-off-by: Mihail Atanassov --- v2: Clean up continuation line warning from checkpatch. drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 5 ++++- drivers/gpu/drm/arm/display/komeda/komeda_event.c | 8 +++++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h index 831c375180f8..4809000c1efb 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h @@ -205,11 +205,14 @@ struct komeda_dev { /** * @err_verbosity: bitmask for how much extra info to print on error * - * See KOMEDA_DEV_* macros for details. + * See KOMEDA_DEV_* macros for details. Low byte contains the debug + * level categories, the high byte contains extra debug options. */ u16 err_verbosity; /* Print a single line per error per frame with error events. */ #define KOMEDA_DEV_PRINT_ERR_EVENTS BIT(0) + /* Dump DRM state on an error or warning event. */ +#define KOMEDA_DEV_PRINT_DUMP_STATE_ON_EVENT BIT(8) }; static inline bool diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c index 575ed4df74ed..de99a588ed75 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c @@ -4,6 +4,7 @@ * Author: James.Qian.Wang * */ +#include #include #include "komeda_dev.h" @@ -113,6 +114,7 @@ void komeda_print_events(struct komeda_events *evts, struct drm_device *dev) static bool en_print = true; struct komeda_dev *mdev = dev->dev_private; u16 const err_verbosity = mdev->err_verbosity; + u64 evts_mask = evts->global | evts->pipes[0] | evts->pipes[1]; /* reduce the same msg print, only print the first evt for one frame */ if (evts->global || is_new_frame(evts)) @@ -123,9 +125,10 @@ void komeda_print_events(struct komeda_events *evts, struct drm_device *dev) if (err_verbosity & KOMEDA_DEV_PRINT_ERR_EVENTS) print_evts |= KOMEDA_ERR_EVENTS; - if ((evts->global | evts->pipes[0] | evts->pipes[1]) & print_evts) { + if (evts_mask & print_evts) { char msg[256]; struct komeda_str str; + struct drm_printer p = drm_info_printer(dev->dev); str.str = msg; str.sz = sizeof(msg); @@ -139,6 +142,9 @@ void komeda_print_events(struct komeda_events *evts, struct drm_device *dev) evt_str(&str, evts->pipes[1]); DRM_ERROR("err detect: %s\n", msg); + if ((err_verbosity & KOMEDA_DEV_PRINT_DUMP_STATE_ON_EVENT) && + (evts_mask & (KOMEDA_ERR_EVENTS | KOMEDA_WARN_EVENTS))) + drm_state_dump(dev, &p); en_print = false; } From patchwork Thu Nov 7 11:42:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mihail Atanassov X-Patchwork-Id: 11232693 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2B82D13BD for ; Thu, 7 Nov 2019 11:42:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12AC321D6C for ; Thu, 7 Nov 2019 11:42:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12AC321D6C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3355D6F665; Thu, 7 Nov 2019 11:42:53 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02on0610.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe07::610]) by gabe.freedesktop.org (Postfix) with ESMTPS id 992C46F667 for ; Thu, 7 Nov 2019 11:42:50 +0000 (UTC) Received: from VE1PR08CA0009.eurprd08.prod.outlook.com (2603:10a6:803:104::22) by AM6PR08MB4833.eurprd08.prod.outlook.com (2603:10a6:20b:ce::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Thu, 7 Nov 2019 11:42:47 +0000 Received: from DB5EUR03FT028.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::203) by VE1PR08CA0009.outlook.office365.com (2603:10a6:803:104::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20 via Frontend Transport; Thu, 7 Nov 2019 11:42:47 +0000 Received-SPF: Fail (protection.outlook.com: domain of arm.com does not designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT028.mail.protection.outlook.com (10.152.20.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.21 via Frontend Transport; Thu, 7 Nov 2019 11:42:47 +0000 Received: ("Tessian outbound 0939a6bab6b1:v33"); Thu, 07 Nov 2019 11:42:47 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2becc7e6f318a98b X-CR-MTA-TID: 64aa7808 Received: from c990ab8b960a.2 (cr-mta-lb-1.cr-mta-net [104.47.10.54]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id A55E4A59-CB71-49AE-B389-EEA9751D9034.1; Thu, 07 Nov 2019 11:42:42 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2054.outbound.protection.outlook.com [104.47.10.54]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c990ab8b960a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Thu, 07 Nov 2019 11:42:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QjL8f58YFKsPXiZL3S+VMSxOPvEuEAgLMjBN9LMo95uXRqWFs19iYYzrgFlsWp/RGjpabBNN9IpC/Q1vmbdWzUXkyv3Ahkdy9IwOzqrUV5BXr2X8vkmz9jyvk7s2whQIO4Er1rQugAby4kplQzd6iv0FH/qqiWQDQ3l4UAAgqy1rYycEHxdvfVETQ2DgxFMWM8gzxLwkxNUzW9AzClens/9cFobKJbDCOVfKCDI8L0l3fGS/sUEcaln3IA7uRfscfT6JXCw/Fa0pEB5radaZMzDEs0FTOrLo7m3jyuaErgjTwakNM1MXRyrxjfyNn6kR8OOqhV7joGsWyGDQJ10FxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hdEv+rpc6/qvleFAe3PSD5v3Qd51wjznRg/0aKpB75s=; b=hF/N2w9jPzWVDVLhdCGq4aM36c+nPOrwe0lcJWE6TINJaRQPYiS510kZwaJ6fGKCWebrud6Ithq8GTOYLR41VJe67Xl5oBznmfOinhJc2eWGklJNwsPi7tQshuxA7RqMIcU48X1RfyExOSaaOfkRrgVOx711g9ev+2p4tb0rAcYvHm4LVBiPGQzomoLJ+rtPZogDy+HEYYFBvI3yd6cLV0ouRxn4l8V9X7hgVhy0febrbgTE87rQmXB8fRHZMgBqQpyT3hfMziQ9Wnt1yXiEvoF1tjt5G5L9AgMpFIyeZVSqXhBFofoh49zLPp6XWYBlj4EzDaUb3wtYo8kIlAYQrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from VI1PR08MB4078.eurprd08.prod.outlook.com (20.178.127.92) by VI1PR08MB4351.eurprd08.prod.outlook.com (20.179.27.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Thu, 7 Nov 2019 11:42:40 +0000 Received: from VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::8191:f0ac:574a:d24d]) by VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::8191:f0ac:574a:d24d%3]) with mapi id 15.20.2408.028; Thu, 7 Nov 2019 11:42:40 +0000 From: Mihail Atanassov To: "dri-devel@lists.freedesktop.org" Subject: [PATCH v2 4/5] drm/komeda: Add option to print WARN- and INFO-level IRQ events Thread-Topic: [PATCH v2 4/5] drm/komeda: Add option to print WARN- and INFO-level IRQ events Thread-Index: AQHVlWB1Q0f+vy2V1k2vOdtTiirrgQ== Date: Thu, 7 Nov 2019 11:42:40 +0000 Message-ID: <20191107114155.54307-5-mihail.atanassov@arm.com> References: <20191107114155.54307-1-mihail.atanassov@arm.com> In-Reply-To: <20191107114155.54307-1-mihail.atanassov@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.140.106.55] x-clientproxiedby: LO2P265CA0146.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::14) To VI1PR08MB4078.eurprd08.prod.outlook.com (2603:10a6:803:e5::28) x-mailer: git-send-email 2.23.0 Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4c5d27c1-78e8-465b-026f-08d763779c95 X-MS-TrafficTypeDiagnostic: VI1PR08MB4351:|VI1PR08MB4351:|AM6PR08MB4833: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:1388;OLM:1388; x-forefront-prvs: 0214EB3F68 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(396003)(39860400002)(376002)(136003)(189003)(199004)(11346002)(316002)(54906003)(446003)(476003)(50226002)(71200400001)(6512007)(305945005)(6916009)(2906002)(8936002)(2616005)(44832011)(4326008)(6436002)(66066001)(256004)(486006)(86362001)(26005)(71190400001)(36756003)(52116002)(2351001)(14444005)(6506007)(99286004)(6486002)(102836004)(2501003)(76176011)(386003)(186003)(6116002)(14454004)(66946007)(66476007)(66556008)(64756008)(66446008)(25786009)(478600001)(1076003)(3846002)(8676002)(81166006)(81156014)(7736002)(5640700003)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB4351; H:VI1PR08MB4078.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: elWFsN2V9a1CqgiI+GP4h/WKFoNbsOG3+MaqvodtFPnx2KJ6KQCrL3is6DZpaWjbpvllnAl6KSVpmrfmNRiOp2dYrKG9XeBqbWQrtTnhHHg7i85L9Lw3JjaeyAQjFhIZjugyDtU0xpSH3IYf2hykze7AD9o/jYNnZJJMnESqEL/uLzk4R+3bSRv77NRAs0K3FzgW+ons8+6EIt9pGkurUKzztACDen9TkdOcJS8CyBOjSv9H7m+dhhlXhTwVfPkdlmQLfByTIRSH6dJ8G0a88aqIhhVjv+PKlmdcMDp/Im9qhHV2S6gRKR0WK0cYc6QPU02OzoY+k1jmiXkWDk+HOmtjS0fQkfwi/s1um/8EMEA9BIz9FdvXJRud3gEOaT1v6gdHac4auSJZvIg7pRY1S5uL2Z3rC2NLNEDEgMWDHEP6LRLuofuJPGoB9QtSGlfm MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4351 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT028.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(346002)(376002)(396003)(136003)(1110001)(339900001)(189003)(199004)(8936002)(1076003)(2351001)(107886003)(25786009)(102836004)(36756003)(50466002)(14454004)(6916009)(4326008)(478600001)(76130400001)(23756003)(86362001)(99286004)(186003)(305945005)(5660300002)(6116002)(81166006)(76176011)(81156014)(8746002)(26005)(3846002)(50226002)(2501003)(7736002)(26826003)(8676002)(476003)(11346002)(14444005)(6512007)(6506007)(386003)(66066001)(2616005)(486006)(22756006)(47776003)(446003)(316002)(5640700003)(70206006)(2906002)(70586007)(356004)(54906003)(105606002)(126002)(6486002)(336012); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB4833; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:Fail; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: a90ed5b8-f7c6-46f0-6b5b-08d763779838 NoDisclaimer: True X-Forefront-PRVS: 0214EB3F68 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WKBjJMH2UnB1KIqmRwWwg6dVKLHJOh78r7bTIEXjXUl6jS7DVOXUKq2O8Fs7lDfTMAXAePkc9heU/MOrJzCJhDUucBnaj6kHpgLI1LducH4KXopwa53aH7K+nXel7ZqK45zfZFwkjjfJr2yq3FGxUGJKdyWvy1RiCgfFAS2pt7VaU7WwvnKZM+L5W7stGocU+CU9m+RDMxJ1GsiHeSa7EbmA9exxsmTYgxiAcIMTgXuk7sHDV+nmhyKex7EDwRTWCzg7qo7Axx3tFKOJe1x8VFc7s57Z38WHtWgaa9KgzrCqbHGWOU6Vup6Sn3+18xf68Be4q1Z8D482fcCTjKd5fy6QCP2AcOdpikPcNH2AL50A9xaVkt7VztB9kq3IjF8lD5KgNKh59XWnFPHcIEZEvikEJvJ3GEHvFFVn+YyYcZwzujo3AQkCXD9XFjQpHaHh X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2019 11:42:47.4973 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4c5d27c1-78e8-465b-026f-08d763779c95 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4833 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hdEv+rpc6/qvleFAe3PSD5v3Qd51wjznRg/0aKpB75s=; b=DbhV45SVQ5sL8qYSzLQMIxD0HljUXf8wIRfthvGzTfpLQLwh5qjCJd1oqvEf3VKgip6FoJOJ/3e3ZHV7xMt6foWaS7HEt7zrsgT3I5ax15vAK4Re0iO3ZjTfoQrL4gi1OadYyVlsthr3wA5jt/FUfZPwEqHy/GvC3bk+CrbC7T0= X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hdEv+rpc6/qvleFAe3PSD5v3Qd51wjznRg/0aKpB75s=; b=DbhV45SVQ5sL8qYSzLQMIxD0HljUXf8wIRfthvGzTfpLQLwh5qjCJd1oqvEf3VKgip6FoJOJ/3e3ZHV7xMt6foWaS7HEt7zrsgT3I5ax15vAK4Re0iO3ZjTfoQrL4gi1OadYyVlsthr3wA5jt/FUfZPwEqHy/GvC3bk+CrbC7T0= X-Mailman-Original-Authentication-Results: spf=fail (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.freedesktop.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.freedesktop.org; dmarc=none action=none header.from=arm.com; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mihail Atanassov , David Airlie , Liviu Dudau , "linux-kernel@vger.kernel.org" , "james qian wang \(Arm Technology China\)" , "Lowry Li \(Arm Technology China\)" , nd , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Extra detail (normally off) almost never hurts. Reviewed-by: James Qian Wang (Arm Technology China) Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 11 +++++++++++ drivers/gpu/drm/arm/display/komeda/komeda_event.c | 4 ++++ 2 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h index 4809000c1efb..d9fc9c48859a 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h @@ -51,6 +51,13 @@ #define KOMEDA_WARN_EVENTS KOMEDA_ERR_CSCE +#define KOMEDA_INFO_EVENTS ({0 \ + | KOMEDA_EVENT_VSYNC \ + | KOMEDA_EVENT_FLIP \ + | KOMEDA_EVENT_EOW \ + | KOMEDA_EVENT_MODE \ + }) + /* malidp device id */ enum { MALI_D71 = 0, @@ -211,6 +218,10 @@ struct komeda_dev { u16 err_verbosity; /* Print a single line per error per frame with error events. */ #define KOMEDA_DEV_PRINT_ERR_EVENTS BIT(0) + /* Print a single line per warning per frame with error events. */ +#define KOMEDA_DEV_PRINT_WARN_EVENTS BIT(1) + /* Print a single line per info event per frame with error events. */ +#define KOMEDA_DEV_PRINT_INFO_EVENTS BIT(2) /* Dump DRM state on an error or warning event. */ #define KOMEDA_DEV_PRINT_DUMP_STATE_ON_EVENT BIT(8) }; diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c index de99a588ed75..7fd624761a2b 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c @@ -124,6 +124,10 @@ void komeda_print_events(struct komeda_events *evts, struct drm_device *dev) if (err_verbosity & KOMEDA_DEV_PRINT_ERR_EVENTS) print_evts |= KOMEDA_ERR_EVENTS; + if (err_verbosity & KOMEDA_DEV_PRINT_WARN_EVENTS) + print_evts |= KOMEDA_WARN_EVENTS; + if (err_verbosity & KOMEDA_DEV_PRINT_INFO_EVENTS) + print_evts |= KOMEDA_INFO_EVENTS; if (evts_mask & print_evts) { char msg[256]; From patchwork Thu Nov 7 11:42:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mihail Atanassov X-Patchwork-Id: 11232695 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 57DB113BD for ; Thu, 7 Nov 2019 11:43:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F75021D6C for ; Thu, 7 Nov 2019 11:43:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F75021D6C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 705BE6E429; Thu, 7 Nov 2019 11:43:00 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02on0608.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe05::608]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9210F6E429 for ; Thu, 7 Nov 2019 11:42:58 +0000 (UTC) Received: from VE1PR08CA0009.eurprd08.prod.outlook.com (2603:10a6:803:104::22) by AM6PR08MB3861.eurprd08.prod.outlook.com (2603:10a6:20b:80::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Thu, 7 Nov 2019 11:42:54 +0000 Received: from DB5EUR03FT028.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::203) by VE1PR08CA0009.outlook.office365.com (2603:10a6:803:104::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20 via Frontend Transport; Thu, 7 Nov 2019 11:42:54 +0000 Received-SPF: Fail (protection.outlook.com: domain of arm.com does not designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT028.mail.protection.outlook.com (10.152.20.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.21 via Frontend Transport; Thu, 7 Nov 2019 11:42:53 +0000 Received: ("Tessian outbound 0939a6bab6b1:v33"); Thu, 07 Nov 2019 11:42:51 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2d09edfc56120d9a X-CR-MTA-TID: 64aa7808 Received: from cd53f9309253.2 (cr-mta-lb-1.cr-mta-net [104.47.4.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2B815624-B4A2-4DE8-AB01-ED9F2940B646.1; Thu, 07 Nov 2019 11:42:46 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2050.outbound.protection.outlook.com [104.47.4.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cd53f9309253.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 07 Nov 2019 11:42:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XvCv8Qy9nPA2WSlzbRlZse8eeQUNF1PVdkuhUGtWYcgJ1oy1wIlIok9zML5UiDCYIHVQ5FOl8RFiNWwmtf1X3Xts+CGy3dmEf+nmPVZGqzMB9w3p0iKrZHxceuYxkttrP4SzwVmktQWFr6NQ7wvYeR9WHVtZ/xh+0Mv6VdvVXGwweDweejAvjFBe2d88FcyF7bKUfD3yl7twLrkCistMQMrJgA7IoiA4ahcrnLy1+XiPNlbiLT9OcYqh+3+5IEYSX/cN3gJWN/eAxkHXKlKALFMveoJdsAPBrCZr5FKkr2xlLfhOMv5sxvnPsecrOoXoTXJxGE5iSleIIEPFoeo8xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CTqYfVkOy0L0imb7lo5uGve4ym8KHPe/DRGzfmKfEdE=; b=ha5VnTXvDEBXnIx6TKbQLbAPn7ATokpUNRbRZ7MPqRSba4ZEKehi1LXJLhLIyDU/HN8m2dHMcBC/ugKoZK52u2w8hkLqTP/7wqKv/6SEiyOTRmS+MMoiyK2FZXWZmgtO1hPUFNqnb2LuQ1mM08JMtjETof0HQTQPGkFZbTEwyuuOQv0aHFX8xEIT47rqyQaM1dpyCXZ1+Tg0VZU8QQnP47nfsjeI0hJUzQ6gfC0nrBNy+E1KXVeSTx4O98JKHxlq/RqHMqfzslFo4i5cRGjWBMBPpEG9AUD/1LB2fZNR3gogO7ZUPK8Ngjv7T5hRFd08ymFUsx/Ts2329elOIXUajQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from VI1PR08MB4078.eurprd08.prod.outlook.com (20.178.127.92) by VI1PR08MB3567.eurprd08.prod.outlook.com (20.177.58.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Thu, 7 Nov 2019 11:42:44 +0000 Received: from VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::8191:f0ac:574a:d24d]) by VI1PR08MB4078.eurprd08.prod.outlook.com ([fe80::8191:f0ac:574a:d24d%3]) with mapi id 15.20.2408.028; Thu, 7 Nov 2019 11:42:44 +0000 From: Mihail Atanassov To: "dri-devel@lists.freedesktop.org" Subject: [PATCH v2 5/5] drm/komeda: add rate limiting disable to err_verbosity Thread-Topic: [PATCH v2 5/5] drm/komeda: add rate limiting disable to err_verbosity Thread-Index: AQHVlWB4xMPbXmf91UG5tobxnmp6wA== Date: Thu, 7 Nov 2019 11:42:44 +0000 Message-ID: <20191107114155.54307-6-mihail.atanassov@arm.com> References: <20191107114155.54307-1-mihail.atanassov@arm.com> In-Reply-To: <20191107114155.54307-1-mihail.atanassov@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.140.106.55] x-clientproxiedby: LO2P265CA0146.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::14) To VI1PR08MB4078.eurprd08.prod.outlook.com (2603:10a6:803:e5::28) x-mailer: git-send-email 2.23.0 Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 54962948-152a-4a18-43da-08d76377a06a X-MS-TrafficTypeDiagnostic: VI1PR08MB3567:|VI1PR08MB3567:|AM6PR08MB3861: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:2887;OLM:2887; x-forefront-prvs: 0214EB3F68 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(346002)(396003)(366004)(376002)(136003)(199004)(189003)(3846002)(64756008)(6436002)(71200400001)(66446008)(66556008)(66476007)(6486002)(71190400001)(86362001)(1076003)(81156014)(99286004)(6116002)(2351001)(66946007)(256004)(14444005)(2501003)(316002)(54906003)(7736002)(66066001)(6506007)(102836004)(44832011)(76176011)(26005)(6916009)(478600001)(52116002)(8676002)(81166006)(8936002)(486006)(11346002)(2616005)(25786009)(476003)(5660300002)(50226002)(5640700003)(2906002)(6512007)(446003)(36756003)(14454004)(4326008)(386003)(186003)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3567; H:VI1PR08MB4078.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ETSPPIelCJKtFqw8EYNNVz8XweAK8XjOlq7RSPtbGXomf+M+rJ+KdgerpqqeoIz+2JM3ZcMnAuqWD/Y2F1EARyGOt90y8RZTUHKjkOl7mWFYFe2f+ulF15AjBd3rMKa6umH+Up+qWhmQzdPA5q8VN+ZFQp4q15CtEVP4Lcufq4nYDKAKSSeNv3dNTde6f82kiZa9uu/wtm25MdDAbsNeJ26LsdRxA9osbuKzo6lxOOT9d+xEOLWdRGkIPpVWOMyMXbb4fo/G7rWK2iJrMpMwNfUe8Ada3K7FRwuJnhm9eqr18vtJeD/W/tSyKoVGe0kNC4ByKY+wK/XxIr1akZ00oNedibFgydo5TO5t0ek4oOu1zj7T1MFaFcsLMBY5lUqpeu//M22SI8fElb391csWiGYAsxgVkij2G5Y317ga7YKmW3T3Rjgk+rohhwZdpzdo MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3567 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Mihail.Atanassov@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT028.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(346002)(39860400002)(376002)(136003)(396003)(1110001)(339900001)(199004)(189003)(47776003)(8746002)(23756003)(316002)(50466002)(76176011)(6116002)(76130400001)(6506007)(14444005)(336012)(86362001)(102836004)(26005)(386003)(5660300002)(2501003)(6512007)(81166006)(54906003)(36756003)(4326008)(6486002)(107886003)(66066001)(186003)(50226002)(8676002)(5640700003)(8936002)(478600001)(105606002)(25786009)(99286004)(6916009)(2351001)(305945005)(7736002)(2616005)(356004)(446003)(476003)(11346002)(3846002)(14454004)(486006)(1076003)(81156014)(70586007)(126002)(2906002)(22756006)(70206006)(26826003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3861; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:Fail; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 0fcbfdb2-2375-429f-5d0c-08d763779a7e NoDisclaimer: True X-Forefront-PRVS: 0214EB3F68 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8R3lKH7PgQiXzWnZN0mvQ96e2w9GlFmkmdEBDCg9VHIGpNQ39P+0cGrsoiOHfwbAQTfZhoH8eORPa0Fd5hm2CGGVcqKvF3m03Ni1vMKlpxYZH49AdE0bqvIg8uL+bcU4qiQjbL2mTWnYes4oD00AwtD++JMzYUfKBZRhtYbcGE/fdK612kFHmPNTT/zHFtQ+jERdCGKuMONfj603P4mK4GG4CRYZnHX+w1ADi63KORb3kG2YGCz6MRCElNSPEUE3x81U5nJljg3z67W+iTW+1Mpq1LYgpVNPlbuJcUupF2+L+RR+TYJZwFtDoIxeRsVyI63DueEepi7Zk/47+UoCOS1zKY5D8XA0pot/HQKH8WgWQOMcRNorI1I7TtTCSj6qhnSc/i5t7kvLQ/gKifY/jZdivK80BdTZXJmC+6KUJY1iCN7UmO9EgV+qI5N2zGs1 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2019 11:42:53.9280 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 54962948-152a-4a18-43da-08d76377a06a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3861 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CTqYfVkOy0L0imb7lo5uGve4ym8KHPe/DRGzfmKfEdE=; b=oFHiLhATuHXJ4pf+VUshob3MZNPVG3vhIy4KqSi/ZBu1FlbDZsQghkAb4pPyUZuI33Ca5lNZlIImh3n7R4zPtSEn6RvHxMl9v2n87lutVWW3P7C++DhdACW3E2YHW5smKjzxwlI7pjBwGcRY33HXwlYqZPrOE1IpdAR8trIpwMw= X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CTqYfVkOy0L0imb7lo5uGve4ym8KHPe/DRGzfmKfEdE=; b=oFHiLhATuHXJ4pf+VUshob3MZNPVG3vhIy4KqSi/ZBu1FlbDZsQghkAb4pPyUZuI33Ca5lNZlIImh3n7R4zPtSEn6RvHxMl9v2n87lutVWW3P7C++DhdACW3E2YHW5smKjzxwlI7pjBwGcRY33HXwlYqZPrOE1IpdAR8trIpwMw= X-Mailman-Original-Authentication-Results: spf=fail (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.freedesktop.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.freedesktop.org; dmarc=none action=none header.from=arm.com; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mihail Atanassov , David Airlie , Liviu Dudau , "linux-kernel@vger.kernel.org" , "james qian wang \(Arm Technology China\)" , "Lowry Li \(Arm Technology China\)" , nd , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" It's possible to get multiple events in a single frame/flip, so add an option to print them all. Reviewed-by: James Qian Wang (Arm Technology China) Signed-off-by: Mihail Atanassov Acked-by: Liviu Dudau --- v2: Clean up continuation line warning from checkpatch. drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 2 ++ drivers/gpu/drm/arm/display/komeda/komeda_event.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h index d9fc9c48859a..15f52e304c08 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h @@ -224,6 +224,8 @@ struct komeda_dev { #define KOMEDA_DEV_PRINT_INFO_EVENTS BIT(2) /* Dump DRM state on an error or warning event. */ #define KOMEDA_DEV_PRINT_DUMP_STATE_ON_EVENT BIT(8) + /* Disable rate limiting of event prints (normally one per commit) */ +#define KOMEDA_DEV_PRINT_DISABLE_RATELIMIT BIT(12) }; static inline bool diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c index 7fd624761a2b..bf269683f811 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c @@ -119,7 +119,7 @@ void komeda_print_events(struct komeda_events *evts, struct drm_device *dev) /* reduce the same msg print, only print the first evt for one frame */ if (evts->global || is_new_frame(evts)) en_print = true; - if (!en_print) + if (!(err_verbosity & KOMEDA_DEV_PRINT_DISABLE_RATELIMIT) && !en_print) return; if (err_verbosity & KOMEDA_DEV_PRINT_ERR_EVENTS)