From patchwork Thu Nov 7 19:27:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 11233673 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6D5C014E5 for ; Thu, 7 Nov 2019 19:29:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4333321882 for ; Thu, 7 Nov 2019 19:29:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Oo4RjFXP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4333321882 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:47600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSnTF-0002SG-20 for patchwork-qemu-devel@patchwork.kernel.org; Thu, 07 Nov 2019 14:29:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49870) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSnRs-0001NP-9I for qemu-devel@nongnu.org; Thu, 07 Nov 2019 14:28:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSnRq-0008WJ-4n for qemu-devel@nongnu.org; Thu, 07 Nov 2019 14:28:04 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:59885 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iSnRq-0008Vn-14 for qemu-devel@nongnu.org; Thu, 07 Nov 2019 14:28:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573154881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ShqYAUE5QiCFY7MJ/v0mrQWsfecWkN91u+xbjdRw0b0=; b=Oo4RjFXPLt2arCHdQuXyyP1iK2lJIh49aVgqWxjfoUA9BUUL24uM/CilEiXDF+HEZPltg3 bJb6t9i6EsHsiDRkmK27g7EFWRACllOabcbh+TIzYigFI0iWFa3S48YVUhnfSW/KKaQPsP olgqkBw2ongFxDyEfVvEyo3T79MFxuU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-127-ejkqC6-bNdmd4b0R4MEnDg-1; Thu, 07 Nov 2019 14:28:00 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3976B800C61 for ; Thu, 7 Nov 2019 19:27:59 +0000 (UTC) Received: from localhost (ovpn-112-60.ams2.redhat.com [10.36.112.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 159515C57C; Thu, 7 Nov 2019 19:27:49 +0000 (UTC) From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= To: qemu-devel@nongnu.org Subject: [PATCH 1/3] virtio-input: fix memory leak on unrealize Date: Thu, 7 Nov 2019 23:27:29 +0400 Message-Id: <20191107192731.17330-2-marcandre.lureau@redhat.com> In-Reply-To: <20191107192731.17330-1-marcandre.lureau@redhat.com> References: <20191107192731.17330-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: ejkqC6-bNdmd4b0R4MEnDg-1 X-Mimecast-Spam-Score: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , "Michael S. Tsirkin" , Gerd Hoffmann , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Spotted by ASAN + minor stylistic change. Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin --- hw/input/virtio-input.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/input/virtio-input.c b/hw/input/virtio-input.c index 51617a5885..ec54e46ad6 100644 --- a/hw/input/virtio-input.c +++ b/hw/input/virtio-input.c @@ -275,6 +275,7 @@ static void virtio_input_finalize(Object *obj) g_free(vinput->queue); } + static void virtio_input_device_unrealize(DeviceState *dev, Error **errp) { VirtIOInputClass *vic = VIRTIO_INPUT_GET_CLASS(dev); @@ -288,6 +289,8 @@ static void virtio_input_device_unrealize(DeviceState *dev, Error **errp) return; } } + virtio_del_queue(vdev, 0); + virtio_del_queue(vdev, 1); virtio_cleanup(vdev); } From patchwork Thu Nov 7 19:27:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 11233677 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9DBF31575 for ; Thu, 7 Nov 2019 19:34:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73C332075C for ; Thu, 7 Nov 2019 19:34:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fte1GIoF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73C332075C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:47646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSnYF-000635-7S for patchwork-qemu-devel@patchwork.kernel.org; Thu, 07 Nov 2019 14:34:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49973) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSnS9-0001TM-K5 for qemu-devel@nongnu.org; Thu, 07 Nov 2019 14:28:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSnS8-0000DR-N2 for qemu-devel@nongnu.org; Thu, 07 Nov 2019 14:28:21 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:56868 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iSnS8-0000D3-Ja for qemu-devel@nongnu.org; Thu, 07 Nov 2019 14:28:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573154899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=beU4vFS75DQxJnwJWlGlrCxUCCfEj1fKrvK5Zq90pnU=; b=fte1GIoFtvs1Lk4hFMgn7AfdvnjjGob/0E1r6H+OFhBKVUC3jLzNZ11qv9aNl2JklKiV+7 EQYuUokr5Rf7jR9+c145cr+kyo35eDCrwnR//TiIuAMKpvIAuvf7Fn3i6OaMm1fiipp+Zs E/aaD6xYmL+9Vpe8KpFyQz8a0mkdHpY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-49-qWX8aI3bO-OIsLAgEVei-g-1; Thu, 07 Nov 2019 14:28:17 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 80820107ACC3 for ; Thu, 7 Nov 2019 19:28:16 +0000 (UTC) Received: from localhost (ovpn-112-60.ams2.redhat.com [10.36.112.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 07CAD608B4; Thu, 7 Nov 2019 19:28:04 +0000 (UTC) From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= To: qemu-devel@nongnu.org Subject: [PATCH 2/3] qtest: fix qtest_qmp_device_add leak Date: Thu, 7 Nov 2019 23:27:30 +0400 Message-Id: <20191107192731.17330-3-marcandre.lureau@redhat.com> In-Reply-To: <20191107192731.17330-1-marcandre.lureau@redhat.com> References: <20191107192731.17330-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: qWX8aI3bO-OIsLAgEVei-g-1 X-Mimecast-Spam-Score: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , "Michael S. Tsirkin" , Gerd Hoffmann , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- tests/libqtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index 3706bccd8d..91e9cb220c 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -1274,6 +1274,7 @@ void qtest_qmp_device_add(QTestState *qts, const char *driver, const char *id, qdict_put_str(args, "id", id); qtest_qmp_device_add_qdict(qts, driver, args); + qobject_unref(args); } static void device_deleted_cb(void *opaque, const char *name, QDict *data) From patchwork Thu Nov 7 19:27:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 11233675 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BAEA6139A for ; Thu, 7 Nov 2019 19:30:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F96C2087E for ; Thu, 7 Nov 2019 19:30:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y+VvgQcj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F96C2087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:47608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSnUR-0003AN-GH for patchwork-qemu-devel@patchwork.kernel.org; Thu, 07 Nov 2019 14:30:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50242) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSnSP-0001l4-7d for qemu-devel@nongnu.org; Thu, 07 Nov 2019 14:28:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSnSO-0000Yi-8w for qemu-devel@nongnu.org; Thu, 07 Nov 2019 14:28:37 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:25399 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iSnSO-0000YH-4w for qemu-devel@nongnu.org; Thu, 07 Nov 2019 14:28:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573154915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OvrhF9UNepAsMD3c4PvKr5DRGDwu5IQWuq2svRUoahE=; b=Y+VvgQcjJj/RaUn7XDayHmmhYOrEfrNchGN/py5YkB4oKDp5EY+5BQkImh7sk8KZb1Po/X AB4mjo4rjg0Nc97rWZ0UEQY1Ed3IgBnpUSQNgvB2XgW6FY2bczIFexd6JGeIhlrHiDpG3D x6VEhFaUjYXKzJxkoQN3AjFm9ZHDye8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-hEMCibHaO2OBS4nSb9LI2w-1; Thu, 07 Nov 2019 14:28:34 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 589C3477 for ; Thu, 7 Nov 2019 19:28:33 +0000 (UTC) Received: from localhost (ovpn-112-60.ams2.redhat.com [10.36.112.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3C35F5D9E5; Thu, 7 Nov 2019 19:28:21 +0000 (UTC) From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= To: qemu-devel@nongnu.org Subject: [PATCH 3/3] cpu-plug-test: fix leaks Date: Thu, 7 Nov 2019 23:27:31 +0400 Message-Id: <20191107192731.17330-4-marcandre.lureau@redhat.com> In-Reply-To: <20191107192731.17330-1-marcandre.lureau@redhat.com> References: <20191107192731.17330-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: hEMCibHaO2OBS4nSb9LI2w-1 X-Mimecast-Spam-Score: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , "Michael S. Tsirkin" , Gerd Hoffmann , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Spotted by ASAN. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- tests/cpu-plug-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/cpu-plug-test.c b/tests/cpu-plug-test.c index 058cef5ac1..30e514bbfb 100644 --- a/tests/cpu-plug-test.c +++ b/tests/cpu-plug-test.c @@ -99,6 +99,7 @@ static void test_plug_with_device_add(gconstpointer data) cpu = qobject_to(QDict, e); if (qdict_haskey(cpu, "qom-path")) { + qobject_unref(e); continue; } @@ -107,6 +108,7 @@ static void test_plug_with_device_add(gconstpointer data) qtest_qmp_device_add_qdict(qts, td->device_model, props); hotplugged++; + qobject_unref(e); } /* make sure that there were hotplugged CPUs */