From patchwork Tue Nov 12 12:09:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 11239167 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 879F9159A for ; Tue, 12 Nov 2019 12:10:54 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62F41206BB for ; Tue, 12 Nov 2019 12:10:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="EfjmeTer" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62F41206BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=eu.citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iUUz2-0003j2-8K; Tue, 12 Nov 2019 12:09:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iUUz0-0003ir-VT for xen-devel@lists.xenproject.org; Tue, 12 Nov 2019 12:09:18 +0000 X-Inumbo-ID: 4037d9d2-0545-11ea-984a-bc764e2007e4 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4037d9d2-0545-11ea-984a-bc764e2007e4; Tue, 12 Nov 2019 12:09:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1573560558; h=from:to:cc:subject:date:message-id:mime-version; bh=YHvOm2GgZeBtFDyrwjhT5r7GFPpPWD8wfq5jFzbwS0Y=; b=EfjmeTerFjeraBl/UiwZIddW7X6hd0cY4CVyO1MwFKtappq/LPGrN70N 5+CD/miqXuCXZxI1waxJ01U/BvvuviJB6QTemXfZZUjFt17GYr+OyjQaM J+A0i3eB/ovHlGkJsXqiiQ00SBQDUVlS3AzZxvWBbaNkjRlRi1gfzqmOU Y=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@eu.citrix.com; spf=Pass smtp.mailfrom=Ian.Jackson@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of ian.jackson@eu.citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="ian.jackson@eu.citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of Ian.Jackson@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="Ian.Jackson@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: JOtX5C9nvjfUmLa4xHS2Hi/ullLaCJrQRkJkGItecFtgxl3+0uO4zSeTG8lb1e5j76IT8HxLRV Tcfwz+p4+EalkJOUjKftspOMd2IdEKp8LG/fHKDnRwWjcUqTUd/qx5I921rQ9yJR5w+eJyCYFt 6s301ru99vRaV8C3hzPozaS/yelV733gP2VKp2CF+wuAFKMf3NN+WZvcLvweVQqv875k1GfN9b 4bEez0YBrE7TAwJumrZKpWXil4HDS/dCGDHQLWQCkMpw+FUnIVEwnqSZr5yJyBLdyc500cmJlB 9lg= X-SBRS: 2.7 X-MesageID: 8185778 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.68,296,1569297600"; d="scan'208";a="8185778" From: Ian Jackson To: Date: Tue, 12 Nov 2019 12:09:12 +0000 Message-ID: <20191112120913.25864-1-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [OSSTEST PATCH 1/2] ts-libvirt-build: Provide PKG_CONFIG_PATH X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= , Jim Fehlig , Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" In osstest we do not install the xen tree in /usr/local because the build environment is shared with many different build jobs which might be using different versions of Xen. We put it in a job-specific directory in ~osstest on the build host, and set environment variables to ensure that it all gets picked up. Recent versions of libvirt insist on finding xenlight.pc; otherwise they disable libxl support. So we must add a PKG_CONFIG_PATH setting. (In all cases, contrary to the usual protocol for path-like variables, we do not append but instead simply set the variable. This is OK because this is an osstest build script run via ssh to the build host, so the variables won't have been set already.) CC: Jim Fehlig Signed-off-by: Ian Jackson --- ts-libvirt-build | 1 + 1 file changed, 1 insertion(+) diff --git a/ts-libvirt-build b/ts-libvirt-build index bc08190a..2a363f43 100755 --- a/ts-libvirt-build +++ b/ts-libvirt-build @@ -60,6 +60,7 @@ sub config() { cd libvirt CFLAGS="-g -I$xenprefix/include/" \\ LDFLAGS="-g -L$xenprefix/lib/ -Wl,-rpath-link=$xenprefix/lib/" \\ + PKG_CONFIG_PATH="$xenprefix/lib/pkgconfig/" \\ GNULIB_SRCDIR=$builddir/libvirt/$gnulib->{Path} \\ ./autogen.sh --no-git \\ --with-libxl --without-xen --without-xenapi --without-selinux \\ From patchwork Tue Nov 12 12:09:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 11239169 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 33A1816B1 for ; Tue, 12 Nov 2019 12:10:55 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FBF5206BB for ; Tue, 12 Nov 2019 12:10:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="h2vF51+g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FBF5206BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=eu.citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iUUz2-0003j8-Gh; Tue, 12 Nov 2019 12:09:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iUUz1-0003iw-Az for xen-devel@lists.xenproject.org; Tue, 12 Nov 2019 12:09:19 +0000 X-Inumbo-ID: 4042d30a-0545-11ea-a21a-12813bfff9fa Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4042d30a-0545-11ea-a21a-12813bfff9fa; Tue, 12 Nov 2019 12:09:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1573560558; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=kTx4xEnm4GeHAVmA3bHYjYZOs7Te4PMHMwxju8yK0JE=; b=h2vF51+gLXsI1r1VUXE6Jvm680THzrJQAyb1a23jngJzJ0LQTgb4ioOr cNfxrbXLA3sMQrKidDPvejir6T+twJ2GzaPju9GwJRCAT16QvJv/fSt6U Emn+CAIPRhhA5M3ct3/LMvEZ4ROufVP7DotfepkDupaw/opNf2/tVNi6B E=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@eu.citrix.com; spf=Pass smtp.mailfrom=Ian.Jackson@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of ian.jackson@eu.citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="ian.jackson@eu.citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa5.hc3370-68.iphmx.com: domain of Ian.Jackson@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="Ian.Jackson@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="Ian.Jackson@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: khAKUS8rR/xBwMoxmNKSRB+PzDssTwtctRLiYJ1RrUWxQoYiuZZEkc6AmCNXKl5qHHI+zIX2BD 3hW1UOaDRLafb08q5Bh+mDpE3aVNa7C4RB/MuFngCtZtZT15v6tJO5/lfe90BddBkq6XR188SX VnsZtQhHFZg1kDD3L0OQ8Exiy6f80AesZd9EXFYeS1Hbs/UzFZctoM/dQ/DJjjzjfQ/UjBMGhE AjQQCIWF9D+YToNSeOxpu9ewzw2lO9SLNSm8Hb0M9/ExEbF1FYHAaT01dHvOzqUxa7WVWDwzc3 +7Y= X-SBRS: 2.7 X-MesageID: 8541390 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.68,296,1569297600"; d="scan'208";a="8541390" From: Ian Jackson To: Date: Tue, 12 Nov 2019 12:09:13 +0000 Message-ID: <20191112120913.25864-2-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20191112120913.25864-1-ian.jackson@eu.citrix.com> References: <20191112120913.25864-1-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [OSSTEST PATCH 2/2] ts-libvirt-build: Do an out-of-tree build X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= , Jim Fehlig , Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Recent versions of libvirt do not support in-tree builds (!) Cope with this by always building in a subdirectory `build' (a subdirectory of the source tree); this is the arrangement which the libvirt upstream messages and documentation now seem to recommend (at least where things have been updated). I compared the differences in build output between the results of this branch and a previous passing xen-unstable flight. The libvirt library version increased and a file usr/local/share/libvirt/cpu_map/arm_features.xml appeared. I think this is just due to changes in the libvirt version, 2cff65e4c60e..70218e10bcde, in particular 0de541bfc575 cpu_map: Ship arm_features.xml I also tested that a test job, built with current libvirt and these osstest changes, passes as expected. CC: Jim Fehlig Signed-off-by: Ian Jackson Tested-by: Ian Jackson --- ts-libvirt-build | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/ts-libvirt-build b/ts-libvirt-build index 2a363f43..e799f003 100755 --- a/ts-libvirt-build +++ b/ts-libvirt-build @@ -58,11 +58,13 @@ sub config() { my $gnulib = submodule_find($submodules, "gnulib"); target_cmd_build($ho, 3600, $builddir, <{Path} \\ - ./autogen.sh --no-git \\ + ../autogen.sh --no-git \\ --with-libxl --without-xen --without-xenapi --without-selinux \\ --without-lxc --without-vbox --without-uml \\ --without-qemu --without-openvz --without-vmware \\ @@ -72,9 +74,9 @@ END sub build() { target_cmd_build($ho, 3600, $builddir, <&1 && touch ../build-ok-stamp) |tee ../log - test -f ../build-ok-stamp #/ + cd libvirt/build + (make $makeflags 2>&1 && touch ../../build-ok-stamp) |tee ../log + test -f ../../build-ok-stamp #/ echo ok. END } @@ -82,7 +84,7 @@ END sub install() { target_cmd_build($ho, 300, $builddir, <