From patchwork Tue Nov 12 16:33:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Cristian Marussi X-Patchwork-Id: 11239773 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6FF0417E6 for ; Tue, 12 Nov 2019 16:33:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 597B621A49 for ; Tue, 12 Nov 2019 16:33:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726979AbfKLQd0 (ORCPT ); Tue, 12 Nov 2019 11:33:26 -0500 Received: from foss.arm.com ([217.140.110.172]:37214 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726978AbfKLQdZ (ORCPT ); Tue, 12 Nov 2019 11:33:25 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F0B6D30E; Tue, 12 Nov 2019 08:33:24 -0800 (PST) Received: from [10.1.197.50] (e120937-lin.cambridge.arm.com [10.1.197.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7FE7D3F534; Tue, 12 Nov 2019 08:33:24 -0800 (PST) From: Cristian Marussi To: Tim.Bird@sony.com, "shuah@kernel.org" , "linux-kselftest@vger.kernel.org" Subject: kselftest: failed to build with -C tool/testing/selftests when KBUILD_OUTPUT is set Message-ID: <8d34a9b9-f8f3-0e37-00bf-c342cf3d4074@arm.com> Date: Tue, 12 Nov 2019 16:33:21 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 Content-Language: en-US Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Hi while testing on linux-next I see that, when KBUILD_OUTPUT is set in the env, running something like (using TARGETS=exec as a random subsystem here...) $ make TARGETS=exec INSTALL_PATH=/nfs/LTP-official-debian-aarch64-rootfs/opt/KSFT_next kselftest-install works fine as usual, WHILE the alternative invocation (still documented in Documentation/dev-tools/kselftest.rst) make -C tools/testing/selftests/ TARGETS=exec INSTALL_PATH=/nfs/LTP-official-debian-aarch64-rootfs/opt/KSFT_next install fails miserably with: ... ... REMOVE usr/include/rdma/cxgb3-abi.h usr/include/rdma/nes-abi.h HDRINST usr/include/asm/kvm.h INSTALL /kselftest/usr/include mkdir: cannot create directory ‘/kselftest’: Permission denied /home/crimar01/ARM/dev/src/pdsw/linux/Makefile:1187: recipe for target 'headers_install' failed make[2]: *** [headers_install] Error 1 This is fixed by unsetting KBUILD_OUTPUT OR reverting: 303e6218ecec (ksft/fixes) selftests: Fix O= and KBUILD_OUTPUT handling for relative paths since bypassing top makefile with -C, the definition of abs-objtree used by the above patch is no more available. As a side effect when KBUILD_OUTPUT is set, this breaks also the usage kselftest_install.sh. $ ./kselftest_install.sh /home/crimar01/ARM/dev/nfs/LTP-official-debian-aarch64-rootfs/opt/KSFT_full_next ./kselftest_install.sh: Installing in specified location - /home/crimar01/ARM/dev/nfs/LTP-official-debian-aarch64-rootfs/opt/KSFT_full_next ... make --no-builtin-rules INSTALL_HDR_PATH=$BUILD/usr \ ARCH=arm64 -C ../../.. headers_install make[1]: Entering directory '/home/crimar01/ARM/dev/src/pdsw/linux' make[2]: Entering directory '/home/crimar01/ARM/dev/src/pdsw/out_linux' INSTALL /kselftest/usr/include mkdir: cannot create directory ‘/kselftest’: Permission denied /home/crimar01/ARM/dev/src/pdsw/linux/Makefile:1187: recipe for target 'headers_install' failed make[2]: *** [headers_install] Error 1 make[2]: Leaving directory '/home/crimar01/ARM/dev/src/pdsw/out_linux' Makefile:179: recipe for target 'sub-make' failed make[1]: *** [sub-make] Error 2 make[1]: Leaving directory '/home/crimar01/ARM/dev/src/pdsw/linux' Makefile:142: recipe for target 'khdr' failed make: *** [khdr] Error 2 A possible fix would be (but duplicates in fact the main Makefile logic) Any thoughts ? ... or am I missing something ? (I think I'm starting to see this in latest CI linaro kselftest while they cross-compile for arm64) Thanks Cristian diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 319e094c3212..491d8b3ef1c7 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -88,6 +88,15 @@ ifdef building_out_of_srctree override LDFLAGS = endif +ifeq ($(abs_objtree),) +ifneq ($(KBUILD_OUTPUT),) +abs_objtree := $(shell cd $(KBUILD_OUTPUT) && pwd) +abs_objtree := $(realpath $(abs_objtree)) +else +abs_objtree := $(shell pwd) +endif +endif #ifeq ($(abs_objtree),) + ifneq ($(O),) BUILD := $(abs_objtree) else