From patchwork Thu Nov 14 13:25:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wambui Karuga X-Patchwork-Id: 11243737 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 07A621390 for ; Thu, 14 Nov 2019 13:25:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5A4D20725 for ; Thu, 14 Nov 2019 13:25:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JLtFGWzP"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rds8wS/q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5A4D20725 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=5P4XtGO+McP/g+Ih4HSPD3ixT5qZuZlrI5suAi/2Eqk=; b=JLt FGWzPoMVTmVq39E+PBtkRY4BGt+6kWiRF8nHKNauJS1AjsPXbo2a4sRpc9H9lAAKiIfGzmmY5CXga a1c+ENbydmLwWYX2sX8S5LCYjFcRQuChJDJA0IoJ9bbFXHtW9ITE4IwiM64w5G+QDSJlM7QNNkO1v xbtYY3ljbZBWb8MX8FMpo3V8G+iCcL7YQG+zDv4N9/Icot+CfgutBOSME6in7sGRUPMzBVarBw6I8 XYfOUDg5kF/M68Q5hwGS3mdze2eS171ctyCO02FhzlqEE9Z0s8UGHTfM8i7ojNktXjLs/WH78/+5x DRR0qnsPO/R8Y2xObdZIVBseR8h5KYg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVF82-0000jY-JY; Thu, 14 Nov 2019 13:25:42 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVF7n-0000WN-B6; Thu, 14 Nov 2019 13:25:28 +0000 Received: by mail-wm1-x343.google.com with SMTP id 8so5891261wmo.0; Thu, 14 Nov 2019 05:25:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=q25FqYYq1HlyGPjqgeEbhuqnD600bhraE2cbn15efDk=; b=Rds8wS/qzXNcvC3Yd9f/9XdyvTQZ3Uht/UdVssSaiVWMebYp+LefE9/zU1mQKhPYcG rqPaBRv9FIUj1gh70+cLk7DG/OrEI9Zf+eFRgqaRCH+dZam7uZLaGPgmIGf4MQz6UeNy BtAq2oFoy958LNz9eMEe0z+wc4DgSymvgksD4Oh9j846cWK2FiE2j66n2K13H+fgH8Y1 P5Qss2xAvPiMNCGzltZv3vh8w0Kgclob0u9jLh9M2yumRm2YjnEDIOc+njNf16DNfWuP nWHjjdqV1qnlKajPHaqXymwBjZ3sKCpaT6Kd70M99pjohJRP0RP0Pf2lcpfp4LdLUw3i VPQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=q25FqYYq1HlyGPjqgeEbhuqnD600bhraE2cbn15efDk=; b=it1lhfxfkKJcDRakCCAxeqiM0lsU9dDw5RF3ZIE4ppRveP3TyDCZz5xClIwbgkxhya 1ViTU9Bua6+S2TLbMzzokcgOXKz8uWA5M/ua+OR3aa18lnjbhdUa36jwc7ioVFQM2bRW IbAijBPJTxUn+9vctO8xEHeur6MVE6zJQzC6Pok6/suWo4UgEqsorP7LNouGwgJusl2h U4BpeO4TTRGkJTna6Ng4XXvF+3v+Jolx5F+/d26p8yiV/iGsHblzBW1+SSc8Ap2IAOEL e1zDgq6hH7TLdzNM0h/wet6NkGyONFO2rkti0ieXlBCZMeXOSrwoXRgDc+fvAm+unrjR /O+Q== X-Gm-Message-State: APjAAAU9Ns+GuPpZb/MXtq+IzXdwyNaT9dStVJR1maSumUVnhIYruvpX UzGDZjq/pIX6WMGh+0eIrZsomWpW53Y= X-Google-Smtp-Source: APXvYqxDxppIeOPFqQWV1zapmmqSUALzzrPUav1RgTbEN138v5mV58ouZdmPPao15Uvzkn43K/TCWg== X-Received: by 2002:a1c:e386:: with SMTP id a128mr8279022wmh.52.1573737925338; Thu, 14 Nov 2019 05:25:25 -0800 (PST) Received: from localhost.localdomain ([197.254.95.38]) by smtp.googlemail.com with ESMTPSA id l4sm5897905wme.4.2019.11.14.05.25.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2019 05:25:24 -0800 (PST) From: Wambui Karuga To: maarten.lankhorst@linux.intel.com, mripard@kernel.org, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, hjc@rock-chips.com Subject: [PATCH 1/2] drm/print: add DRM_DEV_WARN macro Date: Thu, 14 Nov 2019 16:25:19 +0300 Message-Id: <20191114132520.7323-1-wambui.karugax@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191114_052527_383770_CC3B6936 X-CRM114-Status: UNSURE ( 7.74 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (wambui.karugax[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, heiko@sntech.de, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org Add the DRM_DEV_WARN helper macro for printing warnings that use device pointers in their log output format. DRM_DEV_WARN can replace the use of dev_warn in such cases. Signed-off-by: Wambui Karuga --- include/drm/drm_print.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h index 5b8049992c24..6ddf91c0cb29 100644 --- a/include/drm/drm_print.h +++ b/include/drm/drm_print.h @@ -329,6 +329,15 @@ void drm_err(const char *format, ...); #define DRM_WARN_ONCE(fmt, ...) \ _DRM_PRINTK(_once, WARNING, fmt, ##__VA_ARGS__) +/** + * Warning output. + * + * @dev: device pointer + * @fmt: printf() like format string. + */ +#define DRM_DEV_WARN(dev, fmt, ...) \ + drm_dev_printk(dev, KERN_WARNING, fmt, ##__VA_ARGS__) + /** * Error output. * From patchwork Thu Nov 14 13:25:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wambui Karuga X-Patchwork-Id: 11243741 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 244B714ED for ; Thu, 14 Nov 2019 13:26:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B034420725 for ; Thu, 14 Nov 2019 13:26:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="I4z5bzJ1"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CkN+qodG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B034420725 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=pUretnxVeVLBl4RI0pCQV5WFUUFakhpcoXbgs8mvDaM=; b=I4z5bzJ1LataEBYBgtOV/xrisB A8zMf5JPph4EZanm6M0CxA91eSiYaHPskLamGVpfA27tTSxgDkaMDijfTDZJ6O0eJSzSZ4iTC4KBI 0TSAQd+cubgWLFDWHzU2q4USzCgmyOy+0cdfZwT2vmQAzqyRpsG4W/TRenNSzE5Lntv+OE9PYrfMd wA8/Cp6tQPXE5RqVLYrn/BYkC+WIokf5lGw9lFWD9agpZhwGu2mHjMXYo/bsV/DF/7Q0G1zq47uv0 glw4CFxBbfQkNBHqKAShE+chLyBwTr9pBMLFEmTyOg7E7LwcdvsZQ0SaZjrq2aU4qZqFV2VMbThFk FT17hP6Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVF8I-0000x7-9W; Thu, 14 Nov 2019 13:25:58 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVF7q-0000Wk-D3; Thu, 14 Nov 2019 13:25:31 +0000 Received: by mail-wm1-x341.google.com with SMTP id z26so5653525wmi.4; Thu, 14 Nov 2019 05:25:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Y+NZFoUdEcf0PJWdPHX/G2eqhW4MUVM4QQTYn0oEj1I=; b=CkN+qodGvOgi3HNbVRPFCi2d/Rmb81dIwiBAj8ecN7XnKalPX/eTzj1ufQjZktOPYc tZlxPbHyj1g0xIzlwH31cxxmWqqXe7kqTrS4ZaJWbJQ4dtpuDEZCJZbZaFhNLOcUaoya nfax5ZQZUKlsOXpqBbFmiLtLqiz03tpU4fUlK/MHW62aO0TQ/6HBb2cldcFVX4LltOmk lanEy0j4Mc1NNHCD2Ry6TByzlRM4P2rlz2NEf1JMUXv8Wf/ObZneHSDcOh7K0v4ckgRC aupF0h6wmETm+DNx30WlXJJ2ar1bpMKgQQPIky5OWhbcaNENwEZMTHQeLpagqyQAMZ7B 33+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Y+NZFoUdEcf0PJWdPHX/G2eqhW4MUVM4QQTYn0oEj1I=; b=LtaVEXYtxD3YaqDLBHxDI+SF6TkhgpDKMK/vIN8FXWWbU7RjcAU9jmMaHZTixO3WMt 8dJ+wx9sD4ssEajxwX7TEB2FQ12MmWIytDFCJsxa6AU/sFmkJeVGKue7DHzTJhk2otlk gEsidbroAjJxHhbMjU6NEbg69GtA1ZCqFQKf1axDBPxKy3lD3hRYCJ0fBscVINEBW/KZ dWK6FU+auWv3jKS0Jb8PEmLiopJvpaciS5DlpTWDPno56PbXenkpZdDVhEPyeIDNd2NK /eIltMKBCPRxu/lXrHWJ5UtOMFw7jZ2uec9X7/qhzFqLzgVAV0jQr7s2kx8VCYnU3YxI kT1A== X-Gm-Message-State: APjAAAX9Qc4RImdySz8f7JA8nuaj8FSmD275liQKLz4GqKKZfggfi2ij Y1YI4aUlLgTwlA3jNq7zQlc= X-Google-Smtp-Source: APXvYqxdDVgViAKJ2YgU7ehgIo/fK4DVrmQv2FVO8JOYUn+KW7EwMEZTGrXyImi3jae5SwSx24noRQ== X-Received: by 2002:a1c:2e09:: with SMTP id u9mr7768943wmu.108.1573737928601; Thu, 14 Nov 2019 05:25:28 -0800 (PST) Received: from localhost.localdomain ([197.254.95.38]) by smtp.googlemail.com with ESMTPSA id l4sm5897905wme.4.2019.11.14.05.25.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2019 05:25:28 -0800 (PST) From: Wambui Karuga To: maarten.lankhorst@linux.intel.com, mripard@kernel.org, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, hjc@rock-chips.com Subject: [PATCH 2/2] drm/rockchip: use DRM_DEV_WARN macro in debug output Date: Thu, 14 Nov 2019 16:25:20 +0300 Message-Id: <20191114132520.7323-2-wambui.karugax@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191114132520.7323-1-wambui.karugax@gmail.com> References: <20191114132520.7323-1-wambui.karugax@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191114_052530_463621_0A9AA2DF X-CRM114-Status: GOOD ( 11.12 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (wambui.karugax[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, heiko@sntech.de, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org Replace the use of dev_warn in debug output with the new DRM specific DRM_DEV_WARN debug output macro to maintain consistency across the driver. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/rockchip/inno_hdmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index e5864e823020..d7ee8d1835c4 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -796,7 +796,8 @@ static struct i2c_adapter *inno_hdmi_i2c_adapter(struct inno_hdmi *hdmi) ret = i2c_add_adapter(adap); if (ret) { - dev_warn(hdmi->dev, "cannot add %s I2C adapter\n", adap->name); + DRM_DEV_WARN(hdmi->dev, + "cannot add %s I2C adapter\n", adap->name); devm_kfree(hdmi->dev, i2c); return ERR_PTR(ret); }