From patchwork Mon Nov 18 02:47:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuhong Yuan X-Patchwork-Id: 11249091 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E06421393 for ; Mon, 18 Nov 2019 08:37:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7843206A4 for ; Mon, 18 Nov 2019 08:37:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7843206A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9557489F2A; Mon, 18 Nov 2019 08:36:59 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4552989ED6 for ; Mon, 18 Nov 2019 02:48:05 +0000 (UTC) Received: by mail-pf1-x443.google.com with SMTP id r4so9609264pfl.7 for ; Sun, 17 Nov 2019 18:48:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3kl5ahZw2sQnevip0m9byS4aFaaYYEpVFO0JkWfU568=; b=TNwTM18c0DyeI6oqiuStXhDPqzeFDc5vdhGdxFoDhIW5D/H5d1qlNZcQANKttXrpVA mI1+5Gg/yRO7jkcnG8+32cq/R6LdJhUOwDrbUJx48CrTTSbk6z9zbMoWGO1TY0E9lsHc F32QtsshW+DS18n3NPVNpkH26rGqtDF2whmXJh7Onm1NTMteOZqYNqj58o8vQsD6NVko +jDnc4uCnQ177CioWE9V5BE5ECebUpNXDEB+VtyliCYiLmr4O5X6LMePJS9KgsMruYt1 uMygqolBI8cVGW2rgxJoRmr/neEOlCB8hv5tYzbYw93PS7rhApH3sIfr2BjoojiTYrtM QBMg== X-Gm-Message-State: APjAAAVs1Fq4wYwCLRkAwhtpWNgKf25wKO+KnCi4bW4CgbAWN1JBwP4t hxrMBxKyacKVgBoWssCbHRI= X-Google-Smtp-Source: APXvYqzOYITC4AQD4cll3vg5byNRwh0UT/CFOt1LAEbVB3s0Yr8Kp1aA98musXirXMhUJX8saTflKQ== X-Received: by 2002:a62:7643:: with SMTP id r64mr30020700pfc.191.1574045284995; Sun, 17 Nov 2019 18:48:04 -0800 (PST) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id r16sm15576124pgl.77.2019.11.17.18.48.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Nov 2019 18:48:04 -0800 (PST) From: Chuhong Yuan To: Subject: [PATCH] drm/v3d: add missed pm_runtime_disable Date: Mon, 18 Nov 2019 10:47:55 +0800 Message-Id: <20191118024755.21456-1-hslester96@gmail.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 18 Nov 2019 08:36:58 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3kl5ahZw2sQnevip0m9byS4aFaaYYEpVFO0JkWfU568=; b=tub8CI3C2kZF7VVfdEZdXWUm8Dt6YYRt0JM2LJ9MVDoSYCQ7LSblnmcfTyOsaR+qGW h8JhSZ1pG97f9SiDEf/aiJXeni+wSrKf4hl371gAT1eEdthYNLPeJ98HkQjsFIp1FUU4 RcjXEPXWFyZg0LvuhJV5AcB8xVfB8qv0jj9xR8A8Jtk6F79yHorUhwlWKHSB3sFErJLq r7MP4nPkmgTKQgzksGYYBeUZVnCiqS0IHcqdSAVGlZ1s/QATv6gdp3+lkE/cV7YlvIyM aVoF91H0071Idd+txdFXk/z/n245IoNWUSHFHoSylBTKDZKBXLNEFBu76uTntAUv47la B35w== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Chuhong Yuan , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The driver forgets to call pm_runtime_disable in probe failure and remove. Add the missed calls to fix it. Signed-off-by: Chuhong Yuan --- drivers/gpu/drm/v3d/v3d_drv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c index 3506ae2723ae..e109bb8cd67d 100644 --- a/drivers/gpu/drm/v3d/v3d_drv.c +++ b/drivers/gpu/drm/v3d/v3d_drv.c @@ -333,6 +333,7 @@ static int v3d_platform_drm_probe(struct platform_device *pdev) dev_destroy: drm_dev_put(drm); dma_free: + pm_runtime_disable(dev); dma_free_wc(dev, 4096, v3d->mmu_scratch, v3d->mmu_scratch_paddr); dev_free: kfree(v3d); @@ -350,6 +351,8 @@ static int v3d_platform_drm_remove(struct platform_device *pdev) drm_dev_put(drm); + pm_runtime_disable(v3d->dev); + dma_free_wc(v3d->dev, 4096, v3d->mmu_scratch, v3d->mmu_scratch_paddr); return 0;