From patchwork Wed Nov 20 12:01:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Theil X-Patchwork-Id: 11253705 X-Patchwork-Delegate: nbd@nbd.name Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 13DAB6C1 for ; Wed, 20 Nov 2019 12:01:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F35CF22444 for ; Wed, 20 Nov 2019 12:01:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729014AbfKTMBp (ORCPT ); Wed, 20 Nov 2019 07:01:45 -0500 Received: from smail.rz.tu-ilmenau.de ([141.24.186.67]:47378 "EHLO smail.rz.tu-ilmenau.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728728AbfKTMBp (ORCPT ); Wed, 20 Nov 2019 07:01:45 -0500 Received: from isengard.tu-ilmenau.de (unknown [141.24.207.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smail.rz.tu-ilmenau.de (Postfix) with ESMTPSA id 7AFA958007B; Wed, 20 Nov 2019 13:01:43 +0100 (CET) From: Markus Theil To: nbd@nbd.name Cc: linux-wireless@vger.kernel.org, Markus Theil Subject: [PATCH] mt76: use rcu_read_lock_bh in mt76u_rx_tasklet Date: Wed, 20 Nov 2019 13:01:38 +0100 Message-Id: <20191120120138.11427-1-markus.theil@tu-ilmenau.de> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes potential RCU issues and avoids calling ieee80211_rx_napi with softirq enabled. Signed-off-by: Markus Theil --- drivers/net/wireless/mediatek/mt76/usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wireless/mediatek/mt76/usb.c index 0ad83fb5fd38..1cfbb41f7a36 100644 --- a/drivers/net/wireless/mediatek/mt76/usb.c +++ b/drivers/net/wireless/mediatek/mt76/usb.c @@ -549,7 +549,7 @@ static void mt76u_rx_tasklet(unsigned long data) struct urb *urb; int err, count; - rcu_read_lock(); + rcu_read_lock_bh(); while (true) { urb = mt76u_get_next_rx_entry(dev); @@ -566,7 +566,7 @@ static void mt76u_rx_tasklet(unsigned long data) } mt76_rx_poll_complete(dev, MT_RXQ_MAIN, NULL); - rcu_read_unlock(); + rcu_read_unlock_bh(); } static int mt76u_submit_rx_buffers(struct mt76_dev *dev)