From patchwork Wed Nov 20 12:11:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Neeli X-Patchwork-Id: 11253731 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0502414E5 for ; Wed, 20 Nov 2019 12:11:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4D31224C4 for ; Wed, 20 Nov 2019 12:11:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ub4ztIIq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="G8a1i8uQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4D31224C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B5uk7hdQCOClZ++zYb/erTuxsHdsm7c0eLhJhcZz380=; b=ub4ztIIq9FV1cA SKc2zuAl+cZQsMIu7zUNXywNmKC7t43cjqMhOQuFv3ukhuqJTRQ3Wl4z6JD36i60ugZRXwoWGlLfy 4Kjau+9XTLCPKB2aIgWcpZ+hTE2XBTlXSuv0clBjgDGib/Dv8oSghjZqo/bzfFqkxwf23apDWwMyJ CrGsWTgL0MkEQdrnuEB8saGYs6LAlZTXTllRZc0kxazrEs449uk8pzQJkDVUltPhiyfrrzVmqJNSH nKHlk22z54hMW9rGe6klzCVdXHKbn004PwXKDRXjUruYcz61SeGmwo1Pg99guHIZ4SEU14bmyGi8h CdihD6QUfnPWMQ0CkITw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXOps-0000f5-VO; Wed, 20 Nov 2019 12:11:52 +0000 Received: from mail-eopbgr790052.outbound.protection.outlook.com ([40.107.79.52] helo=NAM03-CO1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXOpp-0000dV-Jp for linux-arm-kernel@lists.infradead.org; Wed, 20 Nov 2019 12:11:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aZY3H94tfRxAGwSdb+FQANv9PzC1/PRfxSncUzomqRvc1O3AROD7BbJ3+8so1ulyAJdmG6m7DoRUHL9gOza50vZZbt8QFAxnNOYkuKq4sstS432MNa7nsHrjDUSs2SYTJ6QjutUTSaufweiz8QS3AjYLyT08E0fXv4PhNsq8KMyvikHkapocMleR91wfGBi/Jq+KOprBEtzJ5ahV/Gb1z9gHLxyFnt+Warrmu/3ZH2rOkImTdzNEDy4UtdnKPtgQSh+2kAakiYamJEB6Jv2FgdXj530M1Coa1lang/KiqacekDcjF56AmrUc9aHMHDhEoqzTrkZbGMR3uAXsq8ewTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jTflLLVt7NRRSD5Auyb4CK2zSwT3eVPAtuFZwsFFYwA=; b=Nnxu/zuC72E4jk2VdaMmOAf4gDuWm963+hvTFBr1SSwIT30RsTjxI1zYN7ojYMZJ/4qs7yJkBCL+FtzgsoHw2Wo+rXDZxiuKDBzZfoVuwESF/tUKv5HoY5C4lie0VPhCaakd0I/jFFADEe3vhmQjv7T7I1wQk4mHGzMyidZzABHQbxKwClVMLQ2MgXCMVEimPjxgnfUHw0EVGYzANaBtMdCvL79OrpMzvodHeeReM8wBH/yYL1hh5zKAVFXz1KhvOkw2elEHL+xylmpnHVPPsXiLqbVGQb9nsuJ4m2Q0XySgPlcUe405rl8QpfNl5MTBteT0robPhyjHwaJQXe6NMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.60.83) smtp.rcpttodomain=grandegger.com smtp.mailfrom=xilinx.com; dmarc=bestguesspass action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jTflLLVt7NRRSD5Auyb4CK2zSwT3eVPAtuFZwsFFYwA=; b=G8a1i8uQBt6F/1OaZOKM3FCW5m7SLUKWvFJF5LgSdTCWr7Oaed3ADFERb1veuK5CtO9Hj48pw3tVlGylccpVpw4fBQgvWNVenHFBE5kyaxInjqlfKmuD+8OSYjl662cWeupYGoB09x10yb/lmkCr/yYXuOw4q4QV04FJ6gPttEM= Received: from DM6PR02CA0119.namprd02.prod.outlook.com (2603:10b6:5:1b4::21) by SN6PR02MB5038.namprd02.prod.outlook.com (2603:10b6:805:67::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.16; Wed, 20 Nov 2019 12:11:45 +0000 Received: from CY1NAM02FT034.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::209) by DM6PR02CA0119.outlook.office365.com (2603:10b6:5:1b4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2451.27 via Frontend Transport; Wed, 20 Nov 2019 12:11:45 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; grandegger.com; dkim=none (message not signed) header.d=none;grandegger.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by CY1NAM02FT034.mail.protection.outlook.com (10.152.75.190) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2474.17 via Frontend Transport; Wed, 20 Nov 2019 12:11:44 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1iXOpk-0000ga-9i; Wed, 20 Nov 2019 04:11:44 -0800 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1iXOpf-0002gB-6O; Wed, 20 Nov 2019 04:11:39 -0800 Received: from [10.140.6.6] (helo=xhdappanad40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1iXOpb-0002fi-AQ; Wed, 20 Nov 2019 04:11:35 -0800 From: Srinivas Neeli To: wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net, michal.simek@xilinx.com, appanad@xilinx.com Subject: [PATCH 1/2] can: xilinx_can: skip error message on deferred probe Date: Wed, 20 Nov 2019 17:41:04 +0530 Message-Id: <1574251865-19592-2-git-send-email-srinivas.neeli@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1574251865-19592-1-git-send-email-srinivas.neeli@xilinx.com> References: <1574251865-19592-1-git-send-email-srinivas.neeli@xilinx.com> X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(346002)(136003)(376002)(396003)(39860400002)(199004)(189003)(316002)(9786002)(26005)(186003)(5660300002)(47776003)(11346002)(107886003)(81156014)(8676002)(51416003)(7696005)(2616005)(50466002)(4326008)(48376002)(478600001)(14444005)(36756003)(50226002)(6666004)(356004)(16586007)(6636002)(305945005)(15650500001)(2906002)(54906003)(81166006)(446003)(106002)(126002)(476003)(486006)(44832011)(426003)(76176011)(336012)(70586007)(70206006)(36386004)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR02MB5038; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; LANG:en; PTR:unknown-60-83.xilinx.com; A:1; MX:1; MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 109d125b-3e66-497f-6c05-08d76db2cf7b X-MS-TrafficTypeDiagnostic: SN6PR02MB5038: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-Forefront-PRVS: 02272225C5 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cMJ2x88RAudW8Bvgfxrj8mRnmqcN90L29p3V8kNkxExu/3HezvsEH9sGjSkfUhmFW7VnTKvIevOuNh+UI9L8oMr2PP60Y6ipA2pDc/+443gczspAy1NVZcczQpSJPpZTgiMtlGsgb6/1KBprTcN1ZCpVY0DUtcNMNETWRo768p5ygf3RZi22atXTjFlYlwlY4HHwrQIApc6TuPUCCAx1e4AuL2NoUgfWxc62ziKYNZIJHTRkrGkPrRxOUN7PnUc6hNxea+WIB4EJEl0Ho49Co5aM434/QES/7JlFhKMgb9U7KAKB6pDKwYfk7fqIMxM2SwDyzXIDfL8JTGi/ZGQXfDokojJ6o5aZrT68BIoXvV8lVNlmw2N/biezdyxllDRPYqUVj1Z/Em2lOcTP9VfPuAcCg/YjveJgRy/mkv+dIJ+ImRQmKRxLlpvh5exLmz4L X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2019 12:11:44.7502 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 109d125b-3e66-497f-6c05-08d76db2cf7b X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR02MB5038 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191120_041149_711221_10E13AB8 X-CRM114-Status: GOOD ( 12.22 ) X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [40.107.79.52 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Srinivas Neeli , netdev@vger.kernel.org, Venkatesh Yadav Abbarapu , linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, nagasure@xilinx.com, git@xilinx.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Venkatesh Yadav Abbarapu When can clock is provided from the clock wizard, clock wizard driver may not be available when can driver probes resulting to the error message "bus clock not found error". As this error message is not very useful to the end user, skip printing in the case of deferred probe. Signed-off-by: Venkatesh Yadav Abbarapu Signed-off-by: Srinivas Neeli Signed-off-by: Michal Simek Reviewed-by: Appana Durga Kedareswara Rao in v2. --- drivers/net/can/xilinx_can.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index 4a96e2dd7d77..c5f05b994435 100644 --- a/drivers/net/can/xilinx_can.c +++ b/drivers/net/can/xilinx_can.c @@ -1772,7 +1772,8 @@ static int xcan_probe(struct platform_device *pdev) priv->bus_clk = devm_clk_get(&pdev->dev, devtype->bus_clk_name); if (IS_ERR(priv->bus_clk)) { - dev_err(&pdev->dev, "bus clock not found\n"); + if (PTR_ERR(priv->bus_clk) != -EPROBE_DEFER) + dev_err(&pdev->dev, "bus clock not found\n"); ret = PTR_ERR(priv->bus_clk); goto err_free; } From patchwork Wed Nov 20 12:11:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Neeli X-Patchwork-Id: 11253735 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5745314E5 for ; Wed, 20 Nov 2019 12:12:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B8E7224C4 for ; Wed, 20 Nov 2019 12:12:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fjksaQu4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="Si6hVoPE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B8E7224C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JyAboutT+ZEX7EJWtwYnbsWiZQekwCtzF42YUFYfjqY=; b=fjksaQu4+3cHgk 0n4ZqHZ52QKBpeeMLKHZkH5G7h4RlLmbdkKILNnFytIn6DcrevbUmDItldubFwMGFfMsAwXm/LojJ 0Qnz/f96eWDUgrqPlNfvpwFJaLsvTBhcF80CgRWCkJofkcExlfe6QYJe0tpgWzkF6PPHxuzIwxtPQ fFO7lVowCwpFpMXDJanYrPvPCLNq+BXkxSAl/rGVczilQFkB/L78qhKzpPc9QRHKODC2gvwLp+t4X JhZw8sOIQ7uOrDSLXK06evjWKaCvpHU9HaZ/Sh2FcNZmsGEje5nDHg/2Plot0yAwM1ZbcqynNxHSC L2+R2cVAozK8bfUeLDYg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXOqM-00019T-CU; Wed, 20 Nov 2019 12:12:22 +0000 Received: from mail-eopbgr790050.outbound.protection.outlook.com ([40.107.79.50] helo=NAM03-CO1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXOpz-0000lQ-SW for linux-arm-kernel@lists.infradead.org; Wed, 20 Nov 2019 12:12:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mPY3LAofNWs7+BVxP8qfvQQriTXfVBls5u0Y7iBwWrc6fcYYztwkyCFeauzy9zwxM8uPJf3Z0btuqJmrd+B6lnT+GSbjkTA0fF5bGndqoRhLlKko9opY+PznYtDgqS7zm9g6C7nM03aj+3v/M3HXymPDMm3+Im8P3y+h87qTSGWxJ+JYjhcXrYsSi/roIhNxsFskFmWDM1TH64vON0m4cyEfKNjfL51OUH1j3ryw7Cm+MVbXcDhn+55w95i2RgXh361YbKGC6xBH+zaPmFKQQFOLT2bYG9hs6sEoeMDGwQr90CZDvLj2eFMCTwXdaOj1bvit9GehzazHcQYQleDcmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NV0+L/clYw+7icfp7edhnVTXuRkGNbhl90CiS8Eqxao=; b=IoO2AHO9EUqHKJBgqxSFuj94XvzvyUvbwidtFSFHcrWULQRVwegMOoTZHH3+v5h+9GCdAFz5YlX/7UwW0UGZ6wV/pgj/otVmcoes5CXf6clcAg4DWzeuP3oWhwkRrCWmqY6BpP061JF1NrxVgBrzaB7O8gLjLqYPRwnw23wCQdPZQ9CYvXq5OECvZ1WCC7Oj85WU0S1EKMWSake21S+oTx+hNIEO5i15NjCv1TGTuSichF1y0ru76fcKeYPUr5iH6rHHONBc01TQuyoAt6yUJbHABBCx3wY3Tn/QjH6bzyppQ6o0HNBm/63w4ZapMQ0M/1JnYO94d2Y5NxfdW4Zbkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.60.83) smtp.rcpttodomain=grandegger.com smtp.mailfrom=xilinx.com; dmarc=bestguesspass action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NV0+L/clYw+7icfp7edhnVTXuRkGNbhl90CiS8Eqxao=; b=Si6hVoPEY6qq0HtsdmRN4zBVv48LEzB9fgskEkdUTjlJ602+qwfy17TCh/TSi/govZtvXgdKrAOcnC7bmtfus9Y7S25cboYKVVgF+jfiBHwkuAqME0Dx+3LbzkHF3oqgfrNtbvC36ffCKc8MTKkasnQL4bQET6Xa5/t8OVOvqLE= Received: from MWHPR0201CA0103.namprd02.prod.outlook.com (2603:10b6:301:75::44) by BYAPR02MB5944.namprd02.prod.outlook.com (2603:10b6:a03:124::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2451.30; Wed, 20 Nov 2019 12:11:56 +0000 Received: from BL2NAM02FT021.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e46::200) by MWHPR0201CA0103.outlook.office365.com (2603:10b6:301:75::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.17 via Frontend Transport; Wed, 20 Nov 2019 12:11:55 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; grandegger.com; dkim=none (message not signed) header.d=none;grandegger.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by BL2NAM02FT021.mail.protection.outlook.com (10.152.77.158) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.2474.17 via Frontend Transport; Wed, 20 Nov 2019 12:11:55 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1iXOpu-0000gy-IO; Wed, 20 Nov 2019 04:11:54 -0800 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1iXOpp-0002hM-Ev; Wed, 20 Nov 2019 04:11:49 -0800 Received: from [10.140.6.6] (helo=xhdappanad40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1iXOpe-0002fi-Nh; Wed, 20 Nov 2019 04:11:39 -0800 From: Srinivas Neeli To: wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net, michal.simek@xilinx.com, appanad@xilinx.com Subject: [PATCH 2/2] can: xilinx_can: Fix usage of skb memory Date: Wed, 20 Nov 2019 17:41:05 +0530 Message-Id: <1574251865-19592-3-git-send-email-srinivas.neeli@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1574251865-19592-1-git-send-email-srinivas.neeli@xilinx.com> References: <1574251865-19592-1-git-send-email-srinivas.neeli@xilinx.com> X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(136003)(376002)(39860400002)(189003)(199004)(70586007)(81166006)(106002)(6666004)(4326008)(81156014)(36386004)(36756003)(50226002)(6636002)(16586007)(8676002)(70206006)(48376002)(966005)(305945005)(5660300002)(2616005)(478600001)(6306002)(8936002)(316002)(107886003)(50466002)(9786002)(7696005)(51416003)(76176011)(486006)(44832011)(336012)(11346002)(446003)(426003)(186003)(26005)(476003)(356004)(126002)(2906002)(47776003); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR02MB5944; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; LANG:en; PTR:unknown-60-83.xilinx.com; MX:1; A:1; MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f67bdc69-b2ca-4351-2c71-08d76db2d5c6 X-MS-TrafficTypeDiagnostic: BYAPR02MB5944: X-MS-Exchange-PUrlCount: 1 X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-Forefront-PRVS: 02272225C5 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dclRN9gZ0qYUmtOZcQYzkes7QVJEAHDgw8DOFnbDTZCIE/SiJhI4St5OsGJhYqEuItJn4TQBoNNSgcV9HFdNG5vQhu9zrvDe7pdE4c1R8H3VhUJB46O+dDtc/dYev2FwRhF9kaX+uXkWvsFKhJznabCFazkL1wVPte7LVd+4OUkZ6c4lch8lUWevynBnPmO4ZFXtCYLbVo3eC+adlYidnE/CDkQi3VVDOve+YJK7dvWDm6k8HvdnXSmymsqncVGVH4BVxbx6xeoFrKz7mZ1R8QD8qGWCx7ASmOarULkCr3z3g17GjSyey5T0idNppClqCQRTvCmpwAyum878l4bGWhxK3qRlQDbQANf8d4YR7zjeoDF/MCa/XqUPT0ZZMlyWeLy2abv7++DOIE6fBQ0dSPbPAMaj0cDeUUylmlP+d19yow1bUs7WKWSALEGeasjsQKLi5/qgJ2fAQzpI/NYx21GKCc973n8L7QWd9jAZZsY= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2019 12:11:55.1963 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f67bdc69-b2ca-4351-2c71-08d76db2d5c6 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB5944 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191120_041159_970732_B11E59B9 X-CRM114-Status: GOOD ( 13.16 ) X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [40.107.79.50 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Srinivas Neeli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, nagasure@xilinx.com, git@xilinx.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org As per linux can framework, driver not allowed to touch the skb memory after can_put_echo_skb() call. This patch fixes the same. https://www.spinics.net/lists/linux-can/msg02199.html Signed-off-by: Srinivas Neeli Signed-off-by: Michal Simek --- drivers/net/can/xilinx_can.c | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index c5f05b994435..536b0f8272f6 100644 --- a/drivers/net/can/xilinx_can.c +++ b/drivers/net/can/xilinx_can.c @@ -191,6 +191,8 @@ struct xcan_devtype_data { * @bus_clk: Pointer to struct clk * @can_clk: Pointer to struct clk * @devtype: Device type specific constants + * @cfd: Variable to struct canfd_frame + * @is_canfd: For checking canfd or not */ struct xcan_priv { struct can_priv can; @@ -208,6 +210,8 @@ struct xcan_priv { struct clk *bus_clk; struct clk *can_clk; struct xcan_devtype_data devtype; + struct canfd_frame cfd; + bool is_canfd; }; /* CAN Bittiming constants as per Xilinx CAN specs */ @@ -543,14 +547,13 @@ static int xcan_do_set_mode(struct net_device *ndev, enum can_mode mode) /** * xcan_write_frame - Write a frame to HW * @priv: Driver private data structure - * @skb: sk_buff pointer that contains data to be Txed + * @cf: canfd_frame pointer that contains data to be Txed * @frame_offset: Register offset to write the frame to */ -static void xcan_write_frame(struct xcan_priv *priv, struct sk_buff *skb, +static void xcan_write_frame(struct xcan_priv *priv, struct canfd_frame *cf, int frame_offset) { u32 id, dlc, data[2] = {0, 0}; - struct canfd_frame *cf = (struct canfd_frame *)skb->data; u32 ramoff, dwindex = 0, i; /* Watch carefully on the bit sequence */ @@ -581,7 +584,7 @@ static void xcan_write_frame(struct xcan_priv *priv, struct sk_buff *skb, } dlc = can_len2dlc(cf->len) << XCAN_DLCR_DLC_SHIFT; - if (can_is_canfd_skb(skb)) { + if (priv->is_canfd) { if (cf->flags & CANFD_BRS) dlc |= XCAN_DLCR_BRS_MASK; dlc |= XCAN_DLCR_EDL_MASK; @@ -633,6 +636,9 @@ static int xcan_start_xmit_fifo(struct sk_buff *skb, struct net_device *ndev) struct xcan_priv *priv = netdev_priv(ndev); unsigned long flags; + priv->cfd = *((struct canfd_frame *)skb->data); + priv->is_canfd = can_is_canfd_skb(skb); + /* Check if the TX buffer is full */ if (unlikely(priv->read_reg(priv, XCAN_SR_OFFSET) & XCAN_SR_TXFLL_MASK)) @@ -644,7 +650,7 @@ static int xcan_start_xmit_fifo(struct sk_buff *skb, struct net_device *ndev) priv->tx_head++; - xcan_write_frame(priv, skb, XCAN_TXFIFO_OFFSET); + xcan_write_frame(priv, &priv->cfd, XCAN_TXFIFO_OFFSET); /* Clear TX-FIFO-empty interrupt for xcan_tx_interrupt() */ if (priv->tx_max > 1) @@ -671,6 +677,9 @@ static int xcan_start_xmit_mailbox(struct sk_buff *skb, struct net_device *ndev) struct xcan_priv *priv = netdev_priv(ndev); unsigned long flags; + priv->cfd = *((struct canfd_frame *)skb->data); + priv->is_canfd = can_is_canfd_skb(skb); + if (unlikely(priv->read_reg(priv, XCAN_TRR_OFFSET) & BIT(XCAN_TX_MAILBOX_IDX))) return -ENOSPC; @@ -681,7 +690,7 @@ static int xcan_start_xmit_mailbox(struct sk_buff *skb, struct net_device *ndev) priv->tx_head++; - xcan_write_frame(priv, skb, + xcan_write_frame(priv, &priv->cfd, XCAN_TXMSG_FRAME_OFFSET(XCAN_TX_MAILBOX_IDX)); /* Mark buffer as ready for transmit */